From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kurt Manucredo <fuzzybritches@protonmail.com>
Cc: gregkh@linuxfoundation.org, ross.schm.dev@gmail.com,
straube.linux@gmail.com, d.straghkov@ispras.ru, tiwai@suse.de,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8723bs: code-style fix
Date: Fri, 19 Feb 2021 09:57:17 +0300 [thread overview]
Message-ID: <20210219065717.GO2222@kadam> (raw)
In-Reply-To: <20210218163204.7-1-fuzzybritches@protonmail.com>
The subject is too vague.
On Thu, Feb 18, 2021 at 04:33:10PM +0000, Kurt Manucredo wrote:
> Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com>
> ---
>
> Checkpatch complains the constant needs to be on the right side of the
> comparison. The preferred way is:
>
The commit message isn't complete and it has to go above the Signed-off-by
line.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kurt Manucredo <fuzzybritches@protonmail.com>
Cc: devel@driverdev.osuosl.org, tiwai@suse.de,
gregkh@linuxfoundation.org, d.straghkov@ispras.ru,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8723bs: code-style fix
Date: Fri, 19 Feb 2021 09:57:17 +0300 [thread overview]
Message-ID: <20210219065717.GO2222@kadam> (raw)
In-Reply-To: <20210218163204.7-1-fuzzybritches@protonmail.com>
The subject is too vague.
On Thu, Feb 18, 2021 at 04:33:10PM +0000, Kurt Manucredo wrote:
> Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com>
> ---
>
> Checkpatch complains the constant needs to be on the right side of the
> comparison. The preferred way is:
>
The commit message isn't complete and it has to go above the Signed-off-by
line.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2021-02-19 6:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 16:33 [PATCH] Staging: rtl8723bs: code-style fix Kurt Manucredo
2021-02-18 16:33 ` Kurt Manucredo
2021-02-18 17:46 ` Greg KH
2021-02-18 17:46 ` Greg KH
2021-02-19 6:57 ` Dan Carpenter [this message]
2021-02-19 6:57 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219065717.GO2222@kadam \
--to=dan.carpenter@oracle.com \
--cc=d.straghkov@ispras.ru \
--cc=devel@driverdev.osuosl.org \
--cc=fuzzybritches@protonmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ross.schm.dev@gmail.com \
--cc=straube.linux@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.