* [PATCH] Staging: rtl8723bs: code-style fix @ 2021-02-18 16:33 ` Kurt Manucredo 0 siblings, 0 replies; 6+ messages in thread From: Kurt Manucredo @ 2021-02-18 16:33 UTC (permalink / raw) To: gregkh, ross.schm.dev, straube.linux, dan.carpenter, d.straghkov, tiwai Cc: devel, linux-kernel, Kurt Manucredo Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com> --- Checkpatch complains the constant needs to be on the right side of the comparison. The preferred way is: drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index 089c6ec19373..96feced698ac 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8 *pcur_dot11txpn, u8 *StaAddr) struct security_priv *psecpriv = &padapter->securitypriv; memset(pcur_dot11txpn, 0, 8); - if (StaAddr == NULL) + if (!StaAddr) return; psta = rtw_get_stainfo(&padapter->stapriv, StaAddr); DBG_871X("%s(): StaAddr: %02x %02x %02x %02x %02x %02x\n", -- 2.20.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] Staging: rtl8723bs: code-style fix @ 2021-02-18 16:33 ` Kurt Manucredo 0 siblings, 0 replies; 6+ messages in thread From: Kurt Manucredo @ 2021-02-18 16:33 UTC (permalink / raw) To: gregkh, ross.schm.dev, straube.linux, dan.carpenter, d.straghkov, tiwai Cc: devel, linux-kernel, Kurt Manucredo Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com> --- Checkpatch complains the constant needs to be on the right side of the comparison. The preferred way is: drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index 089c6ec19373..96feced698ac 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8 *pcur_dot11txpn, u8 *StaAddr) struct security_priv *psecpriv = &padapter->securitypriv; memset(pcur_dot11txpn, 0, 8); - if (StaAddr == NULL) + if (!StaAddr) return; psta = rtw_get_stainfo(&padapter->stapriv, StaAddr); DBG_871X("%s(): StaAddr: %02x %02x %02x %02x %02x %02x\n", -- 2.20.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: rtl8723bs: code-style fix 2021-02-18 16:33 ` Kurt Manucredo @ 2021-02-18 17:46 ` Greg KH -1 siblings, 0 replies; 6+ messages in thread From: Greg KH @ 2021-02-18 17:46 UTC (permalink / raw) To: Kurt Manucredo Cc: ross.schm.dev, straube.linux, dan.carpenter, d.straghkov, tiwai, devel, linux-kernel On Thu, Feb 18, 2021 at 04:33:10PM +0000, Kurt Manucredo wrote: > Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com> > --- > > Checkpatch complains the constant needs to be on the right side of the > comparison. The preferred way is: > > drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > index 089c6ec19373..96feced698ac 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > @@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8 *pcur_dot11txpn, u8 *StaAddr) > struct security_priv *psecpriv = &padapter->securitypriv; > > memset(pcur_dot11txpn, 0, 8); > - if (StaAddr == NULL) > + if (!StaAddr) > return; > psta = rtw_get_stainfo(&padapter->stapriv, StaAddr); > DBG_871X("%s(): StaAddr: %02x %02x %02x %02x %02x %02x\n", > -- > 2.20.1 > > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: rtl8723bs: code-style fix @ 2021-02-18 17:46 ` Greg KH 0 siblings, 0 replies; 6+ messages in thread From: Greg KH @ 2021-02-18 17:46 UTC (permalink / raw) To: Kurt Manucredo; +Cc: devel, tiwai, d.straghkov, linux-kernel, dan.carpenter On Thu, Feb 18, 2021 at 04:33:10PM +0000, Kurt Manucredo wrote: > Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com> > --- > > Checkpatch complains the constant needs to be on the right side of the > comparison. The preferred way is: > > drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > index 089c6ec19373..96feced698ac 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > @@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8 *pcur_dot11txpn, u8 *StaAddr) > struct security_priv *psecpriv = &padapter->securitypriv; > > memset(pcur_dot11txpn, 0, 8); > - if (StaAddr == NULL) > + if (!StaAddr) > return; > psta = rtw_get_stainfo(&padapter->stapriv, StaAddr); > DBG_871X("%s(): StaAddr: %02x %02x %02x %02x %02x %02x\n", > -- > 2.20.1 > > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: rtl8723bs: code-style fix 2021-02-18 16:33 ` Kurt Manucredo @ 2021-02-19 6:57 ` Dan Carpenter -1 siblings, 0 replies; 6+ messages in thread From: Dan Carpenter @ 2021-02-19 6:57 UTC (permalink / raw) To: Kurt Manucredo Cc: gregkh, ross.schm.dev, straube.linux, d.straghkov, tiwai, devel, linux-kernel The subject is too vague. On Thu, Feb 18, 2021 at 04:33:10PM +0000, Kurt Manucredo wrote: > Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com> > --- > > Checkpatch complains the constant needs to be on the right side of the > comparison. The preferred way is: > The commit message isn't complete and it has to go above the Signed-off-by line. regards, dan carpenter ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: rtl8723bs: code-style fix @ 2021-02-19 6:57 ` Dan Carpenter 0 siblings, 0 replies; 6+ messages in thread From: Dan Carpenter @ 2021-02-19 6:57 UTC (permalink / raw) To: Kurt Manucredo; +Cc: devel, tiwai, gregkh, d.straghkov, linux-kernel The subject is too vague. On Thu, Feb 18, 2021 at 04:33:10PM +0000, Kurt Manucredo wrote: > Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com> > --- > > Checkpatch complains the constant needs to be on the right side of the > comparison. The preferred way is: > The commit message isn't complete and it has to go above the Signed-off-by line. regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-19 6:58 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-02-18 16:33 [PATCH] Staging: rtl8723bs: code-style fix Kurt Manucredo 2021-02-18 16:33 ` Kurt Manucredo 2021-02-18 17:46 ` Greg KH 2021-02-18 17:46 ` Greg KH 2021-02-19 6:57 ` Dan Carpenter 2021-02-19 6:57 ` Dan Carpenter
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.