All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Valentin Caron <valentin.caron@foss.st.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Erwan Le Ray <erwan.leray@foss.st.com>,
	linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: serial: stm32: add examples
Date: Fri, 5 Mar 2021 12:53:47 -0600	[thread overview]
Message-ID: <20210305185347.GA466473@robh.at.kernel.org> (raw)
In-Reply-To: <20210209095948.15889-1-valentin.caron@foss.st.com>

On Tue, Feb 09, 2021 at 10:59:48AM +0100, Valentin Caron wrote:
> From: Valentin Caron <valentin.caron@st.com>
> 
> Add examples to show more use cases :
>  - uart2 with hardware flow control
>  - uart4 without flow control

Why do I need these? I can go read your dts files if I need more 
examples.

> 
> Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
> ---
>  .../bindings/serial/st,stm32-uart.yaml        | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> index 06d5f251ec88..3a4aab5d1862 100644
> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> @@ -82,6 +82,26 @@ additionalProperties: false
>  examples:
>    - |
>      #include <dt-bindings/clock/stm32mp1-clks.h>
> +
> +    usart4: serial@40004c00 {
> +      compatible = "st,stm32-uart";
> +      reg = <0x40004c00 0x400>;
> +      interrupts = <52>;
> +      clocks = <&clk_pclk1>;
> +      pinctrl-names = "default";
> +      pinctrl-0 = <&pinctrl_usart4>;
> +    };
> +
> +    usart2: serial@40004400 {
> +      compatible = "st,stm32-uart";
> +      reg = <0x40004400 0x400>;
> +      interrupts = <38>;
> +      clocks = <&clk_pclk1>;
> +      st,hw-flow-ctrl;
> +      pinctrl-names = "default";
> +      pinctrl-0 = <&pinctrl_usart2 &pinctrl_usart2_rtscts>;
> +    };
> +
>      usart1: serial@40011000 {
>        compatible = "st,stm32-uart";
>        reg = <0x40011000 0x400>;
> -- 
> 2.17.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Valentin Caron <valentin.caron@foss.st.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Erwan Le Ray <erwan.leray@foss.st.com>,
	linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: serial: stm32: add examples
Date: Fri, 5 Mar 2021 12:53:47 -0600	[thread overview]
Message-ID: <20210305185347.GA466473@robh.at.kernel.org> (raw)
In-Reply-To: <20210209095948.15889-1-valentin.caron@foss.st.com>

On Tue, Feb 09, 2021 at 10:59:48AM +0100, Valentin Caron wrote:
> From: Valentin Caron <valentin.caron@st.com>
> 
> Add examples to show more use cases :
>  - uart2 with hardware flow control
>  - uart4 without flow control

Why do I need these? I can go read your dts files if I need more 
examples.

> 
> Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
> ---
>  .../bindings/serial/st,stm32-uart.yaml        | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> index 06d5f251ec88..3a4aab5d1862 100644
> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> @@ -82,6 +82,26 @@ additionalProperties: false
>  examples:
>    - |
>      #include <dt-bindings/clock/stm32mp1-clks.h>
> +
> +    usart4: serial@40004c00 {
> +      compatible = "st,stm32-uart";
> +      reg = <0x40004c00 0x400>;
> +      interrupts = <52>;
> +      clocks = <&clk_pclk1>;
> +      pinctrl-names = "default";
> +      pinctrl-0 = <&pinctrl_usart4>;
> +    };
> +
> +    usart2: serial@40004400 {
> +      compatible = "st,stm32-uart";
> +      reg = <0x40004400 0x400>;
> +      interrupts = <38>;
> +      clocks = <&clk_pclk1>;
> +      st,hw-flow-ctrl;
> +      pinctrl-names = "default";
> +      pinctrl-0 = <&pinctrl_usart2 &pinctrl_usart2_rtscts>;
> +    };
> +
>      usart1: serial@40011000 {
>        compatible = "st,stm32-uart";
>        reg = <0x40011000 0x400>;
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-03-05 18:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-09  9:59 [PATCH] dt-bindings: serial: stm32: add examples Valentin Caron
2021-02-09  9:59 ` Valentin Caron
2021-03-05 18:53 ` Rob Herring [this message]
2021-03-05 18:53   ` Rob Herring
2021-03-10  8:41   ` Valentin CARON - foss
2021-03-10  8:41     ` Valentin CARON - foss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210305185347.GA466473@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=erwan.leray@foss.st.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=valentin.caron@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.