* [PATCH] dt-bindings: serial: stm32: add examples
@ 2021-02-09 9:59 ` Valentin Caron
0 siblings, 0 replies; 6+ messages in thread
From: Valentin Caron @ 2021-02-09 9:59 UTC (permalink / raw)
To: Rob Herring, Alexandre Torgue
Cc: Greg Kroah-Hartman, Maxime Coquelin, Erwan Le Ray, linux-serial,
devicetree, linux-stm32, linux-arm-kernel, linux-kernel
From: Valentin Caron <valentin.caron@st.com>
Add examples to show more use cases :
- uart2 with hardware flow control
- uart4 without flow control
Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
---
.../bindings/serial/st,stm32-uart.yaml | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
index 06d5f251ec88..3a4aab5d1862 100644
--- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
@@ -82,6 +82,26 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/clock/stm32mp1-clks.h>
+
+ usart4: serial@40004c00 {
+ compatible = "st,stm32-uart";
+ reg = <0x40004c00 0x400>;
+ interrupts = <52>;
+ clocks = <&clk_pclk1>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usart4>;
+ };
+
+ usart2: serial@40004400 {
+ compatible = "st,stm32-uart";
+ reg = <0x40004400 0x400>;
+ interrupts = <38>;
+ clocks = <&clk_pclk1>;
+ st,hw-flow-ctrl;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usart2 &pinctrl_usart2_rtscts>;
+ };
+
usart1: serial@40011000 {
compatible = "st,stm32-uart";
reg = <0x40011000 0x400>;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] dt-bindings: serial: stm32: add examples
@ 2021-02-09 9:59 ` Valentin Caron
0 siblings, 0 replies; 6+ messages in thread
From: Valentin Caron @ 2021-02-09 9:59 UTC (permalink / raw)
To: Rob Herring, Alexandre Torgue
Cc: devicetree, Erwan Le Ray, Maxime Coquelin, Greg Kroah-Hartman,
linux-kernel, linux-serial, linux-stm32, linux-arm-kernel
From: Valentin Caron <valentin.caron@st.com>
Add examples to show more use cases :
- uart2 with hardware flow control
- uart4 without flow control
Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
---
.../bindings/serial/st,stm32-uart.yaml | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
index 06d5f251ec88..3a4aab5d1862 100644
--- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
@@ -82,6 +82,26 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/clock/stm32mp1-clks.h>
+
+ usart4: serial@40004c00 {
+ compatible = "st,stm32-uart";
+ reg = <0x40004c00 0x400>;
+ interrupts = <52>;
+ clocks = <&clk_pclk1>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usart4>;
+ };
+
+ usart2: serial@40004400 {
+ compatible = "st,stm32-uart";
+ reg = <0x40004400 0x400>;
+ interrupts = <38>;
+ clocks = <&clk_pclk1>;
+ st,hw-flow-ctrl;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usart2 &pinctrl_usart2_rtscts>;
+ };
+
usart1: serial@40011000 {
compatible = "st,stm32-uart";
reg = <0x40011000 0x400>;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: serial: stm32: add examples
2021-02-09 9:59 ` Valentin Caron
@ 2021-03-05 18:53 ` Rob Herring
-1 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-03-05 18:53 UTC (permalink / raw)
To: Valentin Caron
Cc: Alexandre Torgue, Greg Kroah-Hartman, Maxime Coquelin,
Erwan Le Ray, linux-serial, devicetree, linux-stm32,
linux-arm-kernel, linux-kernel
On Tue, Feb 09, 2021 at 10:59:48AM +0100, Valentin Caron wrote:
> From: Valentin Caron <valentin.caron@st.com>
>
> Add examples to show more use cases :
> - uart2 with hardware flow control
> - uart4 without flow control
Why do I need these? I can go read your dts files if I need more
examples.
>
> Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
> ---
> .../bindings/serial/st,stm32-uart.yaml | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> index 06d5f251ec88..3a4aab5d1862 100644
> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> @@ -82,6 +82,26 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/clock/stm32mp1-clks.h>
> +
> + usart4: serial@40004c00 {
> + compatible = "st,stm32-uart";
> + reg = <0x40004c00 0x400>;
> + interrupts = <52>;
> + clocks = <&clk_pclk1>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usart4>;
> + };
> +
> + usart2: serial@40004400 {
> + compatible = "st,stm32-uart";
> + reg = <0x40004400 0x400>;
> + interrupts = <38>;
> + clocks = <&clk_pclk1>;
> + st,hw-flow-ctrl;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usart2 &pinctrl_usart2_rtscts>;
> + };
> +
> usart1: serial@40011000 {
> compatible = "st,stm32-uart";
> reg = <0x40011000 0x400>;
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: serial: stm32: add examples
@ 2021-03-05 18:53 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-03-05 18:53 UTC (permalink / raw)
To: Valentin Caron
Cc: Alexandre Torgue, Greg Kroah-Hartman, Maxime Coquelin,
Erwan Le Ray, linux-serial, devicetree, linux-stm32,
linux-arm-kernel, linux-kernel
On Tue, Feb 09, 2021 at 10:59:48AM +0100, Valentin Caron wrote:
> From: Valentin Caron <valentin.caron@st.com>
>
> Add examples to show more use cases :
> - uart2 with hardware flow control
> - uart4 without flow control
Why do I need these? I can go read your dts files if I need more
examples.
>
> Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
> ---
> .../bindings/serial/st,stm32-uart.yaml | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> index 06d5f251ec88..3a4aab5d1862 100644
> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> @@ -82,6 +82,26 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/clock/stm32mp1-clks.h>
> +
> + usart4: serial@40004c00 {
> + compatible = "st,stm32-uart";
> + reg = <0x40004c00 0x400>;
> + interrupts = <52>;
> + clocks = <&clk_pclk1>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usart4>;
> + };
> +
> + usart2: serial@40004400 {
> + compatible = "st,stm32-uart";
> + reg = <0x40004400 0x400>;
> + interrupts = <38>;
> + clocks = <&clk_pclk1>;
> + st,hw-flow-ctrl;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usart2 &pinctrl_usart2_rtscts>;
> + };
> +
> usart1: serial@40011000 {
> compatible = "st,stm32-uart";
> reg = <0x40011000 0x400>;
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: serial: stm32: add examples
2021-03-05 18:53 ` Rob Herring
@ 2021-03-10 8:41 ` Valentin CARON - foss
-1 siblings, 0 replies; 6+ messages in thread
From: Valentin CARON - foss @ 2021-03-10 8:41 UTC (permalink / raw)
To: Rob Herring
Cc: Alexandre TORGUE - foss, Greg Kroah-Hartman, Maxime Coquelin,
Erwan LE-RAY - foss, linux-serial, devicetree, linux-stm32,
linux-arm-kernel, linux-kernel
On 3/5/21 7:53 PM, Rob Herring wrote:
> On Tue, Feb 09, 2021 at 10:59:48AM +0100, Valentin Caron wrote:
>> From: Valentin Caron <valentin.caron@st.com>
>>
>> Add examples to show more use cases :
>> - uart2 with hardware flow control
>> - uart4 without flow control
> Why do I need these? I can go read your dts files if I need more
> examples.
Hi,
These examples were present in the dt-binding before the convertion to
json :
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20200122095558.22553-3-benjamin.gaignard@st.com/
Would you like a v2 with this precision ?
However this is not an essential patch, we can just drop it.
>
>> Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
>> ---
>> .../bindings/serial/st,stm32-uart.yaml | 20 +++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
>> index 06d5f251ec88..3a4aab5d1862 100644
>> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
>> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
>> @@ -82,6 +82,26 @@ additionalProperties: false
>> examples:
>> - |
>> #include <dt-bindings/clock/stm32mp1-clks.h>
>> +
>> + usart4: serial@40004c00 {
>> + compatible = "st,stm32-uart";
>> + reg = <0x40004c00 0x400>;
>> + interrupts = <52>;
>> + clocks = <&clk_pclk1>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_usart4>;
>> + };
>> +
>> + usart2: serial@40004400 {
>> + compatible = "st,stm32-uart";
>> + reg = <0x40004400 0x400>;
>> + interrupts = <38>;
>> + clocks = <&clk_pclk1>;
>> + st,hw-flow-ctrl;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_usart2 &pinctrl_usart2_rtscts>;
>> + };
>> +
>> usart1: serial@40011000 {
>> compatible = "st,stm32-uart";
>> reg = <0x40011000 0x400>;
>> --
>> 2.17.1
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: serial: stm32: add examples
@ 2021-03-10 8:41 ` Valentin CARON - foss
0 siblings, 0 replies; 6+ messages in thread
From: Valentin CARON - foss @ 2021-03-10 8:41 UTC (permalink / raw)
To: Rob Herring
Cc: Alexandre TORGUE - foss, Greg Kroah-Hartman, Maxime Coquelin,
Erwan LE-RAY - foss, linux-serial, devicetree, linux-stm32,
linux-arm-kernel, linux-kernel
On 3/5/21 7:53 PM, Rob Herring wrote:
> On Tue, Feb 09, 2021 at 10:59:48AM +0100, Valentin Caron wrote:
>> From: Valentin Caron <valentin.caron@st.com>
>>
>> Add examples to show more use cases :
>> - uart2 with hardware flow control
>> - uart4 without flow control
> Why do I need these? I can go read your dts files if I need more
> examples.
Hi,
These examples were present in the dt-binding before the convertion to
json :
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20200122095558.22553-3-benjamin.gaignard@st.com/
Would you like a v2 with this precision ?
However this is not an essential patch, we can just drop it.
>
>> Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
>> ---
>> .../bindings/serial/st,stm32-uart.yaml | 20 +++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
>> index 06d5f251ec88..3a4aab5d1862 100644
>> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
>> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
>> @@ -82,6 +82,26 @@ additionalProperties: false
>> examples:
>> - |
>> #include <dt-bindings/clock/stm32mp1-clks.h>
>> +
>> + usart4: serial@40004c00 {
>> + compatible = "st,stm32-uart";
>> + reg = <0x40004c00 0x400>;
>> + interrupts = <52>;
>> + clocks = <&clk_pclk1>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_usart4>;
>> + };
>> +
>> + usart2: serial@40004400 {
>> + compatible = "st,stm32-uart";
>> + reg = <0x40004400 0x400>;
>> + interrupts = <38>;
>> + clocks = <&clk_pclk1>;
>> + st,hw-flow-ctrl;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_usart2 &pinctrl_usart2_rtscts>;
>> + };
>> +
>> usart1: serial@40011000 {
>> compatible = "st,stm32-uart";
>> reg = <0x40011000 0x400>;
>> --
>> 2.17.1
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-10 8:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-09 9:59 [PATCH] dt-bindings: serial: stm32: add examples Valentin Caron
2021-02-09 9:59 ` Valentin Caron
2021-03-05 18:53 ` Rob Herring
2021-03-05 18:53 ` Rob Herring
2021-03-10 8:41 ` Valentin CARON - foss
2021-03-10 8:41 ` Valentin CARON - foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.