All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	intel-gfx <intel-gfx@lists.freedesktop.org>,
	dri-devel@lists.freedesktop.org,
	platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [PATCH 0/9] drm + usb-type-c: Add support for out-of-band hotplug notification (v2)
Date: Mon,  3 May 2021 17:46:38 +0200	[thread overview]
Message-ID: <20210503154647.142551-1-hdegoede@redhat.com> (raw)

Hi All,

Here is v2 of my work on making DP over Type-C work on devices where the
Type-C controller does not drive the HPD pin on the GPU, but instead
we need to forward HPD events from the Type-C controller to the DRM driver.

Changes in v2:
- Replace the bogus "drm/connector: Make the drm_sysfs connector->kdev
  device hold a reference to the connector" patch with:
  "drm/connector: Give connector sysfs devices there own device_type"
  the new patch is a dep for patch 2/9 see the patches

- Stop using a class-dev-iter, instead at a global connector list
  to drm_connector.c and use that to find the connector by the fwnode,
  similar to how we already do this in drm_panel.c and drm_bridge.c

- Make drm_connector_oob_hotplug_event() take a fwnode pointer as
  argument, rather then a drm_connector pointer and let it do the
  lookup itself. This allows making drm_connector_find_by_fwnode() a
  drm-internal function and avoids code outside the drm subsystem
  potentially holding on the a drm_connector reference for a longer
  period.

This series not only touches drm subsys files but it also touches
drivers/usb/typec/altmodes/typec_displayport.c, that file usually
does not see a whole lot of changes. So I believe it would be best
to just merge the entire series through drm-misc, Assuming we can
get an ack from Greg for merging the typec_displayport.c changes
this way.

### 

As already mentioned in the v1 cover-letter this series replaces
a previous attempt from quite some time ago. 
For anyone interested here are the old (2019!) patches for this:

https://patchwork.freedesktop.org/patch/288491/
https://patchwork.freedesktop.org/patch/288493/
https://patchwork.freedesktop.org/patch/288495/

Last time I posted this the biggest change requested was for more info to
be included in the event send to the DRM-subsystem, specifically sending
the following info was requested:

1. Which DP connector on the GPU the event is for
2. How many lanes are available
3. Connector orientation

This series is basically an entirely new approach, which no longer
uses the notifier framework at all. Instead the Type-C code looksup
a connector based on a fwnode (this was suggested by Heikki Krogerus)
and then calls a new oob_hotplug_event drm_connector_func directly
on the connector, passing the requested info as argument.

Info such as the orientation and the number of dp-lanes is now passed
to the drm_connector_oob_hotplug_event() function as requested in the
review of the old code, but nothing is done with it for now.
Using this info falls well outside of my knowledge of the i915 driver
so this is left to a follow-up patch (I will be available to test
patches for this).

Regards,

Hans


Hans de Goede (8):
  drm/connector: Give connector sysfs devices there own device_type
  drm/connector: Add a fwnode pointer to drm_connector and register with
    ACPI
  drm/connector: Add drm_connector_find_by_fwnode() function (v2)
  drm/connector: Add support for out-of-band hotplug notification (v2)
  drm/i915/dp: Add support for out-of-bound hotplug events
  usb: typec: altmodes/displayport: Make dp_altmode_notify() more
    generic
  usb: typec: altmodes/displayport: Notify drm subsys of hotplug events
  platform/x86/intel_cht_int33fe: Correct "displayport" fwnode reference

Heikki Krogerus (1):
  drm/i915: Associate ACPI connector nodes with connector entries

 drivers/gpu/drm/drm_connector.c               | 79 +++++++++++++++++
 drivers/gpu/drm/drm_crtc_internal.h           |  1 +
 drivers/gpu/drm/drm_sysfs.c                   | 87 ++++++++++++++++---
 drivers/gpu/drm/i915/display/intel_acpi.c     | 40 +++++++++
 drivers/gpu/drm/i915/display/intel_acpi.h     |  3 +
 drivers/gpu/drm/i915/display/intel_display.c  |  1 +
 drivers/gpu/drm/i915/display/intel_dp.c       | 13 +++
 .../platform/x86/intel_cht_int33fe_typec.c    |  4 +-
 drivers/usb/typec/altmodes/Kconfig            |  1 +
 drivers/usb/typec/altmodes/displayport.c      | 73 +++++++++++-----
 include/drm/drm_connector.h                   | 43 +++++++++
 11 files changed, 308 insertions(+), 37 deletions(-)

-- 
2.31.1


WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	intel-gfx <intel-gfx@lists.freedesktop.org>,
	linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org,
	platform-driver-x86@vger.kernel.org
Subject: [PATCH 0/9] drm + usb-type-c: Add support for out-of-band hotplug notification (v2)
Date: Mon,  3 May 2021 17:46:38 +0200	[thread overview]
Message-ID: <20210503154647.142551-1-hdegoede@redhat.com> (raw)

Hi All,

Here is v2 of my work on making DP over Type-C work on devices where the
Type-C controller does not drive the HPD pin on the GPU, but instead
we need to forward HPD events from the Type-C controller to the DRM driver.

Changes in v2:
- Replace the bogus "drm/connector: Make the drm_sysfs connector->kdev
  device hold a reference to the connector" patch with:
  "drm/connector: Give connector sysfs devices there own device_type"
  the new patch is a dep for patch 2/9 see the patches

- Stop using a class-dev-iter, instead at a global connector list
  to drm_connector.c and use that to find the connector by the fwnode,
  similar to how we already do this in drm_panel.c and drm_bridge.c

- Make drm_connector_oob_hotplug_event() take a fwnode pointer as
  argument, rather then a drm_connector pointer and let it do the
  lookup itself. This allows making drm_connector_find_by_fwnode() a
  drm-internal function and avoids code outside the drm subsystem
  potentially holding on the a drm_connector reference for a longer
  period.

This series not only touches drm subsys files but it also touches
drivers/usb/typec/altmodes/typec_displayport.c, that file usually
does not see a whole lot of changes. So I believe it would be best
to just merge the entire series through drm-misc, Assuming we can
get an ack from Greg for merging the typec_displayport.c changes
this way.

### 

As already mentioned in the v1 cover-letter this series replaces
a previous attempt from quite some time ago. 
For anyone interested here are the old (2019!) patches for this:

https://patchwork.freedesktop.org/patch/288491/
https://patchwork.freedesktop.org/patch/288493/
https://patchwork.freedesktop.org/patch/288495/

Last time I posted this the biggest change requested was for more info to
be included in the event send to the DRM-subsystem, specifically sending
the following info was requested:

1. Which DP connector on the GPU the event is for
2. How many lanes are available
3. Connector orientation

This series is basically an entirely new approach, which no longer
uses the notifier framework at all. Instead the Type-C code looksup
a connector based on a fwnode (this was suggested by Heikki Krogerus)
and then calls a new oob_hotplug_event drm_connector_func directly
on the connector, passing the requested info as argument.

Info such as the orientation and the number of dp-lanes is now passed
to the drm_connector_oob_hotplug_event() function as requested in the
review of the old code, but nothing is done with it for now.
Using this info falls well outside of my knowledge of the i915 driver
so this is left to a follow-up patch (I will be available to test
patches for this).

Regards,

Hans


Hans de Goede (8):
  drm/connector: Give connector sysfs devices there own device_type
  drm/connector: Add a fwnode pointer to drm_connector and register with
    ACPI
  drm/connector: Add drm_connector_find_by_fwnode() function (v2)
  drm/connector: Add support for out-of-band hotplug notification (v2)
  drm/i915/dp: Add support for out-of-bound hotplug events
  usb: typec: altmodes/displayport: Make dp_altmode_notify() more
    generic
  usb: typec: altmodes/displayport: Notify drm subsys of hotplug events
  platform/x86/intel_cht_int33fe: Correct "displayport" fwnode reference

Heikki Krogerus (1):
  drm/i915: Associate ACPI connector nodes with connector entries

 drivers/gpu/drm/drm_connector.c               | 79 +++++++++++++++++
 drivers/gpu/drm/drm_crtc_internal.h           |  1 +
 drivers/gpu/drm/drm_sysfs.c                   | 87 ++++++++++++++++---
 drivers/gpu/drm/i915/display/intel_acpi.c     | 40 +++++++++
 drivers/gpu/drm/i915/display/intel_acpi.h     |  3 +
 drivers/gpu/drm/i915/display/intel_display.c  |  1 +
 drivers/gpu/drm/i915/display/intel_dp.c       | 13 +++
 .../platform/x86/intel_cht_int33fe_typec.c    |  4 +-
 drivers/usb/typec/altmodes/Kconfig            |  1 +
 drivers/usb/typec/altmodes/displayport.c      | 73 +++++++++++-----
 include/drm/drm_connector.h                   | 43 +++++++++
 11 files changed, 308 insertions(+), 37 deletions(-)

-- 
2.31.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
	linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org,
	platform-driver-x86@vger.kernel.org
Subject: [Intel-gfx] [PATCH 0/9] drm + usb-type-c: Add support for out-of-band hotplug notification (v2)
Date: Mon,  3 May 2021 17:46:38 +0200	[thread overview]
Message-ID: <20210503154647.142551-1-hdegoede@redhat.com> (raw)

Hi All,

Here is v2 of my work on making DP over Type-C work on devices where the
Type-C controller does not drive the HPD pin on the GPU, but instead
we need to forward HPD events from the Type-C controller to the DRM driver.

Changes in v2:
- Replace the bogus "drm/connector: Make the drm_sysfs connector->kdev
  device hold a reference to the connector" patch with:
  "drm/connector: Give connector sysfs devices there own device_type"
  the new patch is a dep for patch 2/9 see the patches

- Stop using a class-dev-iter, instead at a global connector list
  to drm_connector.c and use that to find the connector by the fwnode,
  similar to how we already do this in drm_panel.c and drm_bridge.c

- Make drm_connector_oob_hotplug_event() take a fwnode pointer as
  argument, rather then a drm_connector pointer and let it do the
  lookup itself. This allows making drm_connector_find_by_fwnode() a
  drm-internal function and avoids code outside the drm subsystem
  potentially holding on the a drm_connector reference for a longer
  period.

This series not only touches drm subsys files but it also touches
drivers/usb/typec/altmodes/typec_displayport.c, that file usually
does not see a whole lot of changes. So I believe it would be best
to just merge the entire series through drm-misc, Assuming we can
get an ack from Greg for merging the typec_displayport.c changes
this way.

### 

As already mentioned in the v1 cover-letter this series replaces
a previous attempt from quite some time ago. 
For anyone interested here are the old (2019!) patches for this:

https://patchwork.freedesktop.org/patch/288491/
https://patchwork.freedesktop.org/patch/288493/
https://patchwork.freedesktop.org/patch/288495/

Last time I posted this the biggest change requested was for more info to
be included in the event send to the DRM-subsystem, specifically sending
the following info was requested:

1. Which DP connector on the GPU the event is for
2. How many lanes are available
3. Connector orientation

This series is basically an entirely new approach, which no longer
uses the notifier framework at all. Instead the Type-C code looksup
a connector based on a fwnode (this was suggested by Heikki Krogerus)
and then calls a new oob_hotplug_event drm_connector_func directly
on the connector, passing the requested info as argument.

Info such as the orientation and the number of dp-lanes is now passed
to the drm_connector_oob_hotplug_event() function as requested in the
review of the old code, but nothing is done with it for now.
Using this info falls well outside of my knowledge of the i915 driver
so this is left to a follow-up patch (I will be available to test
patches for this).

Regards,

Hans


Hans de Goede (8):
  drm/connector: Give connector sysfs devices there own device_type
  drm/connector: Add a fwnode pointer to drm_connector and register with
    ACPI
  drm/connector: Add drm_connector_find_by_fwnode() function (v2)
  drm/connector: Add support for out-of-band hotplug notification (v2)
  drm/i915/dp: Add support for out-of-bound hotplug events
  usb: typec: altmodes/displayport: Make dp_altmode_notify() more
    generic
  usb: typec: altmodes/displayport: Notify drm subsys of hotplug events
  platform/x86/intel_cht_int33fe: Correct "displayport" fwnode reference

Heikki Krogerus (1):
  drm/i915: Associate ACPI connector nodes with connector entries

 drivers/gpu/drm/drm_connector.c               | 79 +++++++++++++++++
 drivers/gpu/drm/drm_crtc_internal.h           |  1 +
 drivers/gpu/drm/drm_sysfs.c                   | 87 ++++++++++++++++---
 drivers/gpu/drm/i915/display/intel_acpi.c     | 40 +++++++++
 drivers/gpu/drm/i915/display/intel_acpi.h     |  3 +
 drivers/gpu/drm/i915/display/intel_display.c  |  1 +
 drivers/gpu/drm/i915/display/intel_dp.c       | 13 +++
 .../platform/x86/intel_cht_int33fe_typec.c    |  4 +-
 drivers/usb/typec/altmodes/Kconfig            |  1 +
 drivers/usb/typec/altmodes/displayport.c      | 73 +++++++++++-----
 include/drm/drm_connector.h                   | 43 +++++++++
 11 files changed, 308 insertions(+), 37 deletions(-)

-- 
2.31.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2021-05-03 15:47 UTC|newest]

Thread overview: 91+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03 15:46 Hans de Goede [this message]
2021-05-03 15:46 ` [Intel-gfx] [PATCH 0/9] drm + usb-type-c: Add support for out-of-band hotplug notification (v2) Hans de Goede
2021-05-03 15:46 ` Hans de Goede
2021-05-03 15:46 ` [PATCH 1/9] drm/connector: Give connector sysfs devices there own device_type Hans de Goede
2021-05-03 15:46   ` [Intel-gfx] " Hans de Goede
2021-05-03 15:46   ` Hans de Goede
2021-05-03 15:46 ` [PATCH 2/9] drm/connector: Add a fwnode pointer to drm_connector and register with ACPI Hans de Goede
2021-05-03 15:46   ` [Intel-gfx] " Hans de Goede
2021-05-03 15:46   ` Hans de Goede
2021-05-04  7:57   ` Andy Shevchenko
2021-05-04  7:57     ` [Intel-gfx] " Andy Shevchenko
2021-05-03 15:46 ` [PATCH 3/9] drm/connector: Add drm_connector_find_by_fwnode() function (v2) Hans de Goede
2021-05-03 15:46   ` [Intel-gfx] " Hans de Goede
2021-05-03 15:46   ` Hans de Goede
2021-05-04  8:00   ` Andy Shevchenko
2021-05-04  8:00     ` [Intel-gfx] " Andy Shevchenko
2021-05-04 11:53     ` Hans de Goede
2021-05-04 11:53       ` [Intel-gfx] " Hans de Goede
2021-05-04 11:53       ` Hans de Goede
2021-05-04 12:35       ` Andy Shevchenko
2021-05-04 12:35         ` [Intel-gfx] " Andy Shevchenko
2021-05-04 12:35         ` Andy Shevchenko
2021-05-03 15:46 ` [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification (v2) Hans de Goede
2021-05-03 15:46   ` [Intel-gfx] " Hans de Goede
2021-05-03 15:46   ` Hans de Goede
2021-05-04 15:10   ` Heikki Krogerus
2021-05-04 15:10     ` [Intel-gfx] " Heikki Krogerus
2021-05-04 15:10     ` Heikki Krogerus
2021-05-04 15:35     ` Hans de Goede
2021-05-04 15:35       ` [Intel-gfx] " Hans de Goede
2021-05-04 15:35       ` Hans de Goede
2021-05-05  9:50       ` Heikki Krogerus
2021-05-05  9:50         ` [Intel-gfx] " Heikki Krogerus
2021-05-05  9:50         ` Heikki Krogerus
2021-05-05 10:42         ` Hans de Goede
2021-05-05 10:42           ` [Intel-gfx] " Hans de Goede
2021-05-05 10:42           ` Hans de Goede
2021-05-03 15:46 ` [PATCH 5/9] drm/i915: Associate ACPI connector nodes with connector entries Hans de Goede
2021-05-03 15:46   ` [Intel-gfx] " Hans de Goede
2021-05-03 15:46   ` Hans de Goede
2021-05-04  7:52   ` Andy Shevchenko
2021-05-04  7:52     ` [Intel-gfx] " Andy Shevchenko
2021-05-04 14:56     ` Heikki Krogerus
2021-05-04 14:56       ` [Intel-gfx] " Heikki Krogerus
2021-05-04 14:56       ` Heikki Krogerus
2021-05-05  9:07     ` Hans de Goede
2021-05-05  9:07       ` [Intel-gfx] " Hans de Goede
2021-05-05  9:07       ` Hans de Goede
2021-05-05  9:17       ` Andy Shevchenko
2021-05-05  9:17         ` [Intel-gfx] " Andy Shevchenko
2021-05-05  9:17         ` Andy Shevchenko
2021-05-05  9:28         ` Hans de Goede
2021-05-05  9:28           ` [Intel-gfx] " Hans de Goede
2021-05-05  9:28           ` Hans de Goede
2021-05-05 10:02           ` Andy Shevchenko
2021-05-05 10:02             ` [Intel-gfx] " Andy Shevchenko
2021-05-05 10:02             ` Andy Shevchenko
2021-05-05 10:30             ` Hans de Goede
2021-05-05 10:30               ` [Intel-gfx] " Hans de Goede
2021-05-05 10:30               ` Hans de Goede
2021-05-05 12:55               ` Andy Shevchenko
2021-05-05 12:55                 ` [Intel-gfx] " Andy Shevchenko
2021-05-05 12:55                 ` Andy Shevchenko
2021-05-05 10:28         ` Sakari Ailus
2021-05-05 10:28           ` [Intel-gfx] " Sakari Ailus
2021-05-05 10:28           ` Sakari Ailus
2021-05-03 15:46 ` [PATCH 6/9] drm/i915/dp: Add support for out-of-bound hotplug events Hans de Goede
2021-05-03 15:46   ` [Intel-gfx] " Hans de Goede
2021-05-03 15:46   ` Hans de Goede
2021-05-03 15:46 ` [PATCH 7/9] usb: typec: altmodes/displayport: Make dp_altmode_notify() more generic Hans de Goede
2021-05-03 15:46   ` [Intel-gfx] " Hans de Goede
2021-05-03 15:46   ` Hans de Goede
2021-05-03 15:46 ` [PATCH 8/9] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events Hans de Goede
2021-05-03 15:46   ` [Intel-gfx] " Hans de Goede
2021-05-03 15:46   ` Hans de Goede
2021-05-05 10:17   ` Heikki Krogerus
2021-05-05 10:17     ` [Intel-gfx] " Heikki Krogerus
2021-05-05 10:17     ` Heikki Krogerus
2021-05-05 10:44     ` Hans de Goede
2021-05-05 10:44       ` [Intel-gfx] " Hans de Goede
2021-05-05 10:44       ` Hans de Goede
2021-05-03 15:46 ` [PATCH 9/9] platform/x86/intel_cht_int33fe: Correct "displayport" fwnode reference Hans de Goede
2021-05-03 15:46   ` [Intel-gfx] " Hans de Goede
2021-05-03 15:46   ` Hans de Goede
2021-05-19 13:37   ` Hans de Goede
2021-05-19 13:37     ` [Intel-gfx] " Hans de Goede
2021-05-19 13:37     ` Hans de Goede
2021-05-03 20:25 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm + usb-type-c: Add support for out-of-band hotplug notification (rev2) Patchwork
2021-05-04 15:22 ` [PATCH 0/9] drm + usb-type-c: Add support for out-of-band hotplug notification (v2) Heikki Krogerus
2021-05-04 15:22   ` [Intel-gfx] " Heikki Krogerus
2021-05-04 15:22   ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210503154647.142551-1-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.