All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
	dri-devel@lists.freedesktop.org,
	platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 9/9] platform/x86/intel_cht_int33fe: Correct "displayport" fwnode reference
Date: Wed, 19 May 2021 15:37:23 +0200	[thread overview]
Message-ID: <2d02c9ba-1385-41cf-6150-ca8ed5e835ba@redhat.com> (raw)
In-Reply-To: <20210503154647.142551-10-hdegoede@redhat.com>

Hi,

On 5/3/21 5:46 PM, Hans de Goede wrote:
> The Type-C connector on these devices is connected to DP-2 not DP-1,
> so the reference must be to the DD04 child-node of the GPU, rather
> then the DD02 child-node.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Since this is pretty much independent from the rest of the series,
I'll take this upstream through the pdx86 tree.

I've added this to my review-hans branch now, and it will get added
to for-next from there.

Regards,

Hans



> ---
>  drivers/platform/x86/intel_cht_int33fe_typec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel_cht_int33fe_typec.c b/drivers/platform/x86/intel_cht_int33fe_typec.c
> index b61bad9cc8d2..d59544167430 100644
> --- a/drivers/platform/x86/intel_cht_int33fe_typec.c
> +++ b/drivers/platform/x86/intel_cht_int33fe_typec.c
> @@ -168,8 +168,8 @@ static int cht_int33fe_setup_dp(struct cht_int33fe_data *data)
>  		return -ENODEV;
>  	}
>  
> -	/* Then the DP child device node */
> -	data->dp = device_get_named_child_node(&pdev->dev, "DD02");
> +	/* Then the DP-2 child device node */
> +	data->dp = device_get_named_child_node(&pdev->dev, "DD04");
>  	pci_dev_put(pdev);
>  	if (!data->dp)
>  		return -ENODEV;
> 


WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
	linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org,
	platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 9/9] platform/x86/intel_cht_int33fe: Correct "displayport" fwnode reference
Date: Wed, 19 May 2021 15:37:23 +0200	[thread overview]
Message-ID: <2d02c9ba-1385-41cf-6150-ca8ed5e835ba@redhat.com> (raw)
In-Reply-To: <20210503154647.142551-10-hdegoede@redhat.com>

Hi,

On 5/3/21 5:46 PM, Hans de Goede wrote:
> The Type-C connector on these devices is connected to DP-2 not DP-1,
> so the reference must be to the DD04 child-node of the GPU, rather
> then the DD02 child-node.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Since this is pretty much independent from the rest of the series,
I'll take this upstream through the pdx86 tree.

I've added this to my review-hans branch now, and it will get added
to for-next from there.

Regards,

Hans



> ---
>  drivers/platform/x86/intel_cht_int33fe_typec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel_cht_int33fe_typec.c b/drivers/platform/x86/intel_cht_int33fe_typec.c
> index b61bad9cc8d2..d59544167430 100644
> --- a/drivers/platform/x86/intel_cht_int33fe_typec.c
> +++ b/drivers/platform/x86/intel_cht_int33fe_typec.c
> @@ -168,8 +168,8 @@ static int cht_int33fe_setup_dp(struct cht_int33fe_data *data)
>  		return -ENODEV;
>  	}
>  
> -	/* Then the DP child device node */
> -	data->dp = device_get_named_child_node(&pdev->dev, "DD02");
> +	/* Then the DP-2 child device node */
> +	data->dp = device_get_named_child_node(&pdev->dev, "DD04");
>  	pci_dev_put(pdev);
>  	if (!data->dp)
>  		return -ENODEV;
> 


WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
	linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org,
	platform-driver-x86@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH 9/9] platform/x86/intel_cht_int33fe: Correct "displayport" fwnode reference
Date: Wed, 19 May 2021 15:37:23 +0200	[thread overview]
Message-ID: <2d02c9ba-1385-41cf-6150-ca8ed5e835ba@redhat.com> (raw)
In-Reply-To: <20210503154647.142551-10-hdegoede@redhat.com>

Hi,

On 5/3/21 5:46 PM, Hans de Goede wrote:
> The Type-C connector on these devices is connected to DP-2 not DP-1,
> so the reference must be to the DD04 child-node of the GPU, rather
> then the DD02 child-node.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Since this is pretty much independent from the rest of the series,
I'll take this upstream through the pdx86 tree.

I've added this to my review-hans branch now, and it will get added
to for-next from there.

Regards,

Hans



> ---
>  drivers/platform/x86/intel_cht_int33fe_typec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel_cht_int33fe_typec.c b/drivers/platform/x86/intel_cht_int33fe_typec.c
> index b61bad9cc8d2..d59544167430 100644
> --- a/drivers/platform/x86/intel_cht_int33fe_typec.c
> +++ b/drivers/platform/x86/intel_cht_int33fe_typec.c
> @@ -168,8 +168,8 @@ static int cht_int33fe_setup_dp(struct cht_int33fe_data *data)
>  		return -ENODEV;
>  	}
>  
> -	/* Then the DP child device node */
> -	data->dp = device_get_named_child_node(&pdev->dev, "DD02");
> +	/* Then the DP-2 child device node */
> +	data->dp = device_get_named_child_node(&pdev->dev, "DD04");
>  	pci_dev_put(pdev);
>  	if (!data->dp)
>  		return -ENODEV;
> 

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-05-19 13:37 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03 15:46 [PATCH 0/9] drm + usb-type-c: Add support for out-of-band hotplug notification (v2) Hans de Goede
2021-05-03 15:46 ` [Intel-gfx] " Hans de Goede
2021-05-03 15:46 ` Hans de Goede
2021-05-03 15:46 ` [PATCH 1/9] drm/connector: Give connector sysfs devices there own device_type Hans de Goede
2021-05-03 15:46   ` [Intel-gfx] " Hans de Goede
2021-05-03 15:46   ` Hans de Goede
2021-05-03 15:46 ` [PATCH 2/9] drm/connector: Add a fwnode pointer to drm_connector and register with ACPI Hans de Goede
2021-05-03 15:46   ` [Intel-gfx] " Hans de Goede
2021-05-03 15:46   ` Hans de Goede
2021-05-04  7:57   ` Andy Shevchenko
2021-05-04  7:57     ` [Intel-gfx] " Andy Shevchenko
2021-05-03 15:46 ` [PATCH 3/9] drm/connector: Add drm_connector_find_by_fwnode() function (v2) Hans de Goede
2021-05-03 15:46   ` [Intel-gfx] " Hans de Goede
2021-05-03 15:46   ` Hans de Goede
2021-05-04  8:00   ` Andy Shevchenko
2021-05-04  8:00     ` [Intel-gfx] " Andy Shevchenko
2021-05-04 11:53     ` Hans de Goede
2021-05-04 11:53       ` [Intel-gfx] " Hans de Goede
2021-05-04 11:53       ` Hans de Goede
2021-05-04 12:35       ` Andy Shevchenko
2021-05-04 12:35         ` [Intel-gfx] " Andy Shevchenko
2021-05-04 12:35         ` Andy Shevchenko
2021-05-03 15:46 ` [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification (v2) Hans de Goede
2021-05-03 15:46   ` [Intel-gfx] " Hans de Goede
2021-05-03 15:46   ` Hans de Goede
2021-05-04 15:10   ` Heikki Krogerus
2021-05-04 15:10     ` [Intel-gfx] " Heikki Krogerus
2021-05-04 15:10     ` Heikki Krogerus
2021-05-04 15:35     ` Hans de Goede
2021-05-04 15:35       ` [Intel-gfx] " Hans de Goede
2021-05-04 15:35       ` Hans de Goede
2021-05-05  9:50       ` Heikki Krogerus
2021-05-05  9:50         ` [Intel-gfx] " Heikki Krogerus
2021-05-05  9:50         ` Heikki Krogerus
2021-05-05 10:42         ` Hans de Goede
2021-05-05 10:42           ` [Intel-gfx] " Hans de Goede
2021-05-05 10:42           ` Hans de Goede
2021-05-03 15:46 ` [PATCH 5/9] drm/i915: Associate ACPI connector nodes with connector entries Hans de Goede
2021-05-03 15:46   ` [Intel-gfx] " Hans de Goede
2021-05-03 15:46   ` Hans de Goede
2021-05-04  7:52   ` Andy Shevchenko
2021-05-04  7:52     ` [Intel-gfx] " Andy Shevchenko
2021-05-04 14:56     ` Heikki Krogerus
2021-05-04 14:56       ` [Intel-gfx] " Heikki Krogerus
2021-05-04 14:56       ` Heikki Krogerus
2021-05-05  9:07     ` Hans de Goede
2021-05-05  9:07       ` [Intel-gfx] " Hans de Goede
2021-05-05  9:07       ` Hans de Goede
2021-05-05  9:17       ` Andy Shevchenko
2021-05-05  9:17         ` [Intel-gfx] " Andy Shevchenko
2021-05-05  9:17         ` Andy Shevchenko
2021-05-05  9:28         ` Hans de Goede
2021-05-05  9:28           ` [Intel-gfx] " Hans de Goede
2021-05-05  9:28           ` Hans de Goede
2021-05-05 10:02           ` Andy Shevchenko
2021-05-05 10:02             ` [Intel-gfx] " Andy Shevchenko
2021-05-05 10:02             ` Andy Shevchenko
2021-05-05 10:30             ` Hans de Goede
2021-05-05 10:30               ` [Intel-gfx] " Hans de Goede
2021-05-05 10:30               ` Hans de Goede
2021-05-05 12:55               ` Andy Shevchenko
2021-05-05 12:55                 ` [Intel-gfx] " Andy Shevchenko
2021-05-05 12:55                 ` Andy Shevchenko
2021-05-05 10:28         ` Sakari Ailus
2021-05-05 10:28           ` [Intel-gfx] " Sakari Ailus
2021-05-05 10:28           ` Sakari Ailus
2021-05-03 15:46 ` [PATCH 6/9] drm/i915/dp: Add support for out-of-bound hotplug events Hans de Goede
2021-05-03 15:46   ` [Intel-gfx] " Hans de Goede
2021-05-03 15:46   ` Hans de Goede
2021-05-03 15:46 ` [PATCH 7/9] usb: typec: altmodes/displayport: Make dp_altmode_notify() more generic Hans de Goede
2021-05-03 15:46   ` [Intel-gfx] " Hans de Goede
2021-05-03 15:46   ` Hans de Goede
2021-05-03 15:46 ` [PATCH 8/9] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events Hans de Goede
2021-05-03 15:46   ` [Intel-gfx] " Hans de Goede
2021-05-03 15:46   ` Hans de Goede
2021-05-05 10:17   ` Heikki Krogerus
2021-05-05 10:17     ` [Intel-gfx] " Heikki Krogerus
2021-05-05 10:17     ` Heikki Krogerus
2021-05-05 10:44     ` Hans de Goede
2021-05-05 10:44       ` [Intel-gfx] " Hans de Goede
2021-05-05 10:44       ` Hans de Goede
2021-05-03 15:46 ` [PATCH 9/9] platform/x86/intel_cht_int33fe: Correct "displayport" fwnode reference Hans de Goede
2021-05-03 15:46   ` [Intel-gfx] " Hans de Goede
2021-05-03 15:46   ` Hans de Goede
2021-05-19 13:37   ` Hans de Goede [this message]
2021-05-19 13:37     ` [Intel-gfx] " Hans de Goede
2021-05-19 13:37     ` Hans de Goede
2021-05-03 20:25 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm + usb-type-c: Add support for out-of-band hotplug notification (rev2) Patchwork
2021-05-04 15:22 ` [PATCH 0/9] drm + usb-type-c: Add support for out-of-band hotplug notification (v2) Heikki Krogerus
2021-05-04 15:22   ` [Intel-gfx] " Heikki Krogerus
2021-05-04 15:22   ` Heikki Krogerus
  -- strict thread matches above, loose matches on Subject: below --
2021-04-28 21:52 [PATCH 0/9] drm + usb-type-c: Add support for out-of-band hotplug notification Hans de Goede
2021-04-28 21:52 ` [PATCH 9/9] platform/x86/intel_cht_int33fe: Correct "displayport" fwnode reference Hans de Goede
2021-04-28 21:52   ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d02c9ba-1385-41cf-6150-ca8ed5e835ba@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.