From: Javier Martinez Canillas <javierm@redhat.com> To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas <javierm@redhat.com>, Peter Robinson <pbrobinson@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, dri-devel@lists.freedesktop.org Subject: [PATCH] drm/fb-helper: improve DRM fbdev emulation device names Date: Fri, 21 May 2021 15:19:10 +0200 [thread overview] Message-ID: <20210521131910.3000689-1-javierm@redhat.com> (raw) Framebuffer devices that are registered by DRM drivers for fbdev emulation have a "drmfb" suffix in their name. But makes them to be quite confusing if a driver already has "drm" in its name: $ cat /proc/fb 0 rockchipdrmdrmfb $ cat /proc/fb 0 simpledrmdrmfb Instead, let's just add a "-fb" suffix to denote that are DRM drivers FB: $ cat /proc/fb 0 rockchipdrm-fb $ cat /proc/fb 0 simpledrm-fb Suggested-by: Peter Robinson <pbrobinson@gmail.com> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> --- drivers/gpu/drm/drm_fb_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index f6baa204612..bbaff92c509 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -1737,7 +1737,7 @@ void drm_fb_helper_fill_info(struct fb_info *info, sizes->fb_width, sizes->fb_height); info->par = fb_helper; - snprintf(info->fix.id, sizeof(info->fix.id), "%sdrmfb", + snprintf(info->fix.id, sizeof(info->fix.id), "%s-fb", fb_helper->dev->driver->name); } -- 2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javierm@redhat.com> To: linux-kernel@vger.kernel.org Cc: Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org, Javier Martinez Canillas <javierm@redhat.com>, Peter Robinson <pbrobinson@gmail.com> Subject: [PATCH] drm/fb-helper: improve DRM fbdev emulation device names Date: Fri, 21 May 2021 15:19:10 +0200 [thread overview] Message-ID: <20210521131910.3000689-1-javierm@redhat.com> (raw) Framebuffer devices that are registered by DRM drivers for fbdev emulation have a "drmfb" suffix in their name. But makes them to be quite confusing if a driver already has "drm" in its name: $ cat /proc/fb 0 rockchipdrmdrmfb $ cat /proc/fb 0 simpledrmdrmfb Instead, let's just add a "-fb" suffix to denote that are DRM drivers FB: $ cat /proc/fb 0 rockchipdrm-fb $ cat /proc/fb 0 simpledrm-fb Suggested-by: Peter Robinson <pbrobinson@gmail.com> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> --- drivers/gpu/drm/drm_fb_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index f6baa204612..bbaff92c509 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -1737,7 +1737,7 @@ void drm_fb_helper_fill_info(struct fb_info *info, sizes->fb_width, sizes->fb_height); info->par = fb_helper; - snprintf(info->fix.id, sizeof(info->fix.id), "%sdrmfb", + snprintf(info->fix.id, sizeof(info->fix.id), "%s-fb", fb_helper->dev->driver->name); } -- 2.31.1
next reply other threads:[~2021-05-21 13:19 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-21 13:19 Javier Martinez Canillas [this message] 2021-05-21 13:19 ` [PATCH] drm/fb-helper: improve DRM fbdev emulation device names Javier Martinez Canillas 2021-05-21 15:33 ` Daniel Vetter 2021-05-21 15:33 ` Daniel Vetter 2021-05-21 16:53 ` Thomas Zimmermann 2021-05-21 17:18 ` Javier Martinez Canillas 2021-05-21 18:53 ` Thomas Zimmermann 2021-05-25 13:08 ` Daniel Vetter 2021-05-25 13:08 ` Daniel Vetter 2021-05-25 13:34 ` Thomas Zimmermann 2021-05-25 13:52 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210521131910.3000689-1-javierm@redhat.com \ --to=javierm@redhat.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=pbrobinson@gmail.com \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.