All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kurz <groug@kaod.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-kernel@vger.kernel.org, Max Reitz <mreitz@redhat.com>,
	linux-fsdevel@vger.kernel.org, virtio-fs@redhat.com,
	Vivek Goyal <vgoyal@redhat.com>, Greg Kurz <groug@kaod.org>
Subject: [PATCH v2 7/7] fuse: Make fuse_fill_super_submount() static
Date: Fri,  4 Jun 2021 18:11:56 +0200	[thread overview]
Message-ID: <20210604161156.408496-8-groug@kaod.org> (raw)
In-Reply-To: <20210604161156.408496-1-groug@kaod.org>

This function used to be called from fuse_dentry_automount(). This code
was moved to fuse_get_tree_submount() in the same file since then. It
is unlikely there will ever be another user. No need to be extern in
this case.

Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
 fs/fuse/fuse_i.h | 9 ---------
 fs/fuse/inode.c  | 4 ++--
 2 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/fs/fuse/fuse_i.h b/fs/fuse/fuse_i.h
index 862ad317bc89..1d32251a439a 100644
--- a/fs/fuse/fuse_i.h
+++ b/fs/fuse/fuse_i.h
@@ -1081,15 +1081,6 @@ void fuse_send_init(struct fuse_mount *fm);
  */
 int fuse_fill_super_common(struct super_block *sb, struct fuse_fs_context *ctx);
 
-/*
- * Fill in superblock for submounts
- * @sb: partially-initialized superblock to fill in
- * @parent_fi: The fuse_inode of the parent filesystem where this submount is
- * 	       mounted
- */
-int fuse_fill_super_submount(struct super_block *sb,
-			     struct fuse_inode *parent_fi);
-
 /*
  * Remove the mount from the connection
  *
diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
index bec1676811d4..72d44121ea38 100644
--- a/fs/fuse/inode.c
+++ b/fs/fuse/inode.c
@@ -1275,8 +1275,8 @@ static void fuse_sb_defaults(struct super_block *sb)
 		sb->s_xattr = fuse_no_acl_xattr_handlers;
 }
 
-int fuse_fill_super_submount(struct super_block *sb,
-			     struct fuse_inode *parent_fi)
+static int fuse_fill_super_submount(struct super_block *sb,
+				    struct fuse_inode *parent_fi)
 {
 	struct fuse_mount *fm = get_fuse_mount_super(sb);
 	struct super_block *parent_sb = parent_fi->inode.i_sb;
-- 
2.31.1


WARNING: multiple messages have this Message-ID (diff)
From: Greg Kurz <groug@kaod.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-kernel@vger.kernel.org, virtio-fs@redhat.com,
	linux-fsdevel@vger.kernel.org, Max Reitz <mreitz@redhat.com>,
	Vivek Goyal <vgoyal@redhat.com>
Subject: [Virtio-fs] [PATCH v2 7/7] fuse: Make fuse_fill_super_submount() static
Date: Fri,  4 Jun 2021 18:11:56 +0200	[thread overview]
Message-ID: <20210604161156.408496-8-groug@kaod.org> (raw)
In-Reply-To: <20210604161156.408496-1-groug@kaod.org>

This function used to be called from fuse_dentry_automount(). This code
was moved to fuse_get_tree_submount() in the same file since then. It
is unlikely there will ever be another user. No need to be extern in
this case.

Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
 fs/fuse/fuse_i.h | 9 ---------
 fs/fuse/inode.c  | 4 ++--
 2 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/fs/fuse/fuse_i.h b/fs/fuse/fuse_i.h
index 862ad317bc89..1d32251a439a 100644
--- a/fs/fuse/fuse_i.h
+++ b/fs/fuse/fuse_i.h
@@ -1081,15 +1081,6 @@ void fuse_send_init(struct fuse_mount *fm);
  */
 int fuse_fill_super_common(struct super_block *sb, struct fuse_fs_context *ctx);
 
-/*
- * Fill in superblock for submounts
- * @sb: partially-initialized superblock to fill in
- * @parent_fi: The fuse_inode of the parent filesystem where this submount is
- * 	       mounted
- */
-int fuse_fill_super_submount(struct super_block *sb,
-			     struct fuse_inode *parent_fi);
-
 /*
  * Remove the mount from the connection
  *
diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
index bec1676811d4..72d44121ea38 100644
--- a/fs/fuse/inode.c
+++ b/fs/fuse/inode.c
@@ -1275,8 +1275,8 @@ static void fuse_sb_defaults(struct super_block *sb)
 		sb->s_xattr = fuse_no_acl_xattr_handlers;
 }
 
-int fuse_fill_super_submount(struct super_block *sb,
-			     struct fuse_inode *parent_fi)
+static int fuse_fill_super_submount(struct super_block *sb,
+				    struct fuse_inode *parent_fi)
 {
 	struct fuse_mount *fm = get_fuse_mount_super(sb);
 	struct super_block *parent_sb = parent_fi->inode.i_sb;
-- 
2.31.1


  parent reply	other threads:[~2021-06-04 16:12 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-04 16:11 [PATCH v2 0/7] fuse: Some fixes for submounts Greg Kurz
2021-06-04 16:11 ` [Virtio-fs] " Greg Kurz
2021-06-04 16:11 ` [PATCH v2 1/7] fuse: Fix crash in fuse_dentry_automount() error path Greg Kurz
2021-06-04 16:11   ` [Virtio-fs] " Greg Kurz
2021-06-04 16:11 ` [PATCH v2 2/7] fuse: Fix crash if superblock of submount gets killed early Greg Kurz
2021-06-04 16:11   ` [Virtio-fs] " Greg Kurz
2021-06-08 15:08   ` Max Reitz
2021-06-08 15:08     ` [Virtio-fs] " Max Reitz
2021-06-04 16:11 ` [PATCH v2 3/7] fuse: Fix infinite loop in sget_fc() Greg Kurz
2021-06-04 16:11   ` [Virtio-fs] " Greg Kurz
2021-06-08 15:12   ` Max Reitz
2021-06-08 15:12     ` [Virtio-fs] " Max Reitz
2021-06-04 16:11 ` [PATCH v2 4/7] fuse: Add dedicated filesystem context ops for submounts Greg Kurz
2021-06-04 16:11   ` [Virtio-fs] " Greg Kurz
2021-06-08 15:25   ` Max Reitz
2021-06-08 15:25     ` [Virtio-fs] " Max Reitz
2021-06-04 16:11 ` [PATCH v2 5/7] fuse: Call vfs_get_tree() " Greg Kurz
2021-06-04 16:11   ` [Virtio-fs] " Greg Kurz
2021-06-08 15:40   ` Max Reitz
2021-06-08 15:40     ` [Virtio-fs] " Max Reitz
2021-06-04 16:11 ` [PATCH v2 6/7] fuse: Switch to fc_mount() " Greg Kurz
2021-06-04 16:11   ` [Virtio-fs] " Greg Kurz
2021-06-08 15:51   ` Max Reitz
2021-06-08 15:51     ` [Virtio-fs] " Max Reitz
2021-06-09  7:45     ` Greg Kurz
2021-06-09  7:45       ` [Virtio-fs] " Greg Kurz
2021-06-11 14:44       ` Miklos Szeredi
2021-06-11 14:44         ` [Virtio-fs] " Miklos Szeredi
2021-06-04 16:11 ` Greg Kurz [this message]
2021-06-04 16:11   ` [Virtio-fs] [PATCH v2 7/7] fuse: Make fuse_fill_super_submount() static Greg Kurz
2021-06-08 15:52 ` [PATCH v2 0/7] fuse: Some fixes for submounts Max Reitz
2021-06-08 15:52   ` [Virtio-fs] " Max Reitz
2021-06-09  7:46   ` Greg Kurz
2021-06-09  7:46     ` [Virtio-fs] " Greg Kurz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210604161156.408496-8-groug@kaod.org \
    --to=groug@kaod.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=mreitz@redhat.com \
    --cc=vgoyal@redhat.com \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.