All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: Greg Kurz <groug@kaod.org>, Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	virtio-fs@redhat.com, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH v2 5/7] fuse: Call vfs_get_tree() for submounts
Date: Tue, 8 Jun 2021 17:40:37 +0200	[thread overview]
Message-ID: <f4161490-f7ed-78f0-bf05-96040cbb31e9@redhat.com> (raw)
In-Reply-To: <20210604161156.408496-6-groug@kaod.org>

On 04.06.21 18:11, Greg Kurz wrote:
> We recently fixed an infinite loop by setting the SB_BORN flag on
> submounts along with the write barrier needed by super_cache_count().
> This is the job of vfs_get_tree() and FUSE shouldn't have to care
> about the barrier at all.
>
> Split out some code from fuse_dentry_automount() to the dedicated
> fuse_get_tree_submount() handler for submounts and call vfs_get_tree().
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
>   fs/fuse/dir.c   | 53 +++++--------------------------------------------
>   fs/fuse/inode.c | 36 +++++++++++++++++++++++++++++++++
>   2 files changed, 41 insertions(+), 48 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>


WARNING: multiple messages have this Message-ID (diff)
From: Max Reitz <mreitz@redhat.com>
To: Greg Kurz <groug@kaod.org>, Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org, virtio-fs@redhat.com,
	linux-kernel@vger.kernel.org, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [Virtio-fs] [PATCH v2 5/7] fuse: Call vfs_get_tree() for submounts
Date: Tue, 8 Jun 2021 17:40:37 +0200	[thread overview]
Message-ID: <f4161490-f7ed-78f0-bf05-96040cbb31e9@redhat.com> (raw)
In-Reply-To: <20210604161156.408496-6-groug@kaod.org>

On 04.06.21 18:11, Greg Kurz wrote:
> We recently fixed an infinite loop by setting the SB_BORN flag on
> submounts along with the write barrier needed by super_cache_count().
> This is the job of vfs_get_tree() and FUSE shouldn't have to care
> about the barrier at all.
>
> Split out some code from fuse_dentry_automount() to the dedicated
> fuse_get_tree_submount() handler for submounts and call vfs_get_tree().
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
>   fs/fuse/dir.c   | 53 +++++--------------------------------------------
>   fs/fuse/inode.c | 36 +++++++++++++++++++++++++++++++++
>   2 files changed, 41 insertions(+), 48 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>


  reply	other threads:[~2021-06-08 15:41 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-04 16:11 [PATCH v2 0/7] fuse: Some fixes for submounts Greg Kurz
2021-06-04 16:11 ` [Virtio-fs] " Greg Kurz
2021-06-04 16:11 ` [PATCH v2 1/7] fuse: Fix crash in fuse_dentry_automount() error path Greg Kurz
2021-06-04 16:11   ` [Virtio-fs] " Greg Kurz
2021-06-04 16:11 ` [PATCH v2 2/7] fuse: Fix crash if superblock of submount gets killed early Greg Kurz
2021-06-04 16:11   ` [Virtio-fs] " Greg Kurz
2021-06-08 15:08   ` Max Reitz
2021-06-08 15:08     ` [Virtio-fs] " Max Reitz
2021-06-04 16:11 ` [PATCH v2 3/7] fuse: Fix infinite loop in sget_fc() Greg Kurz
2021-06-04 16:11   ` [Virtio-fs] " Greg Kurz
2021-06-08 15:12   ` Max Reitz
2021-06-08 15:12     ` [Virtio-fs] " Max Reitz
2021-06-04 16:11 ` [PATCH v2 4/7] fuse: Add dedicated filesystem context ops for submounts Greg Kurz
2021-06-04 16:11   ` [Virtio-fs] " Greg Kurz
2021-06-08 15:25   ` Max Reitz
2021-06-08 15:25     ` [Virtio-fs] " Max Reitz
2021-06-04 16:11 ` [PATCH v2 5/7] fuse: Call vfs_get_tree() " Greg Kurz
2021-06-04 16:11   ` [Virtio-fs] " Greg Kurz
2021-06-08 15:40   ` Max Reitz [this message]
2021-06-08 15:40     ` Max Reitz
2021-06-04 16:11 ` [PATCH v2 6/7] fuse: Switch to fc_mount() " Greg Kurz
2021-06-04 16:11   ` [Virtio-fs] " Greg Kurz
2021-06-08 15:51   ` Max Reitz
2021-06-08 15:51     ` [Virtio-fs] " Max Reitz
2021-06-09  7:45     ` Greg Kurz
2021-06-09  7:45       ` [Virtio-fs] " Greg Kurz
2021-06-11 14:44       ` Miklos Szeredi
2021-06-11 14:44         ` [Virtio-fs] " Miklos Szeredi
2021-06-04 16:11 ` [PATCH v2 7/7] fuse: Make fuse_fill_super_submount() static Greg Kurz
2021-06-04 16:11   ` [Virtio-fs] " Greg Kurz
2021-06-08 15:52 ` [PATCH v2 0/7] fuse: Some fixes for submounts Max Reitz
2021-06-08 15:52   ` [Virtio-fs] " Max Reitz
2021-06-09  7:46   ` Greg Kurz
2021-06-09  7:46     ` [Virtio-fs] " Greg Kurz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4161490-f7ed-78f0-bf05-96040cbb31e9@redhat.com \
    --to=mreitz@redhat.com \
    --cc=groug@kaod.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=vgoyal@redhat.com \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.