* [PATCH] Fix libpmem configuration option
@ 2021-07-07 7:51 Miroslav Rezanina
2021-07-07 8:14 ` Philippe Mathieu-Daudé
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Miroslav Rezanina @ 2021-07-07 7:51 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, Miroslav Rezanina
For some reason, libpmem option setting was set to work in an opposite
way (--enable-libpmem disabled it and vice versa). Fixing this so
configuration works properly.
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
---
configure | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 7994bdee92..ffa93cc5fd 100755
--- a/configure
+++ b/configure
@@ -1501,9 +1501,9 @@ for opt do
;;
--disable-debug-mutex) debug_mutex=no
;;
- --enable-libpmem) libpmem=disabled
+ --enable-libpmem) libpmem="enabled"
;;
- --disable-libpmem) libpmem=enabled
+ --disable-libpmem) libpmem="disabled"
;;
--enable-xkbcommon) xkbcommon="enabled"
;;
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix libpmem configuration option
2021-07-07 7:51 [PATCH] Fix libpmem configuration option Miroslav Rezanina
@ 2021-07-07 8:14 ` Philippe Mathieu-Daudé
2021-07-08 0:22 ` Connor Kuehl
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-07-07 8:14 UTC (permalink / raw)
To: Miroslav Rezanina, qemu-devel; +Cc: pbonzini
On 7/7/21 9:51 AM, Miroslav Rezanina wrote:
> For some reason, libpmem option setting was set to work in an opposite
> way (--enable-libpmem disabled it and vice versa). Fixing this so
> configuration works properly.
>
> Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
> ---
> configure | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 7994bdee92..ffa93cc5fd 100755
> --- a/configure
> +++ b/configure
> @@ -1501,9 +1501,9 @@ for opt do
> ;;
> --disable-debug-mutex) debug_mutex=no
> ;;
> - --enable-libpmem) libpmem=disabled
> + --enable-libpmem) libpmem="enabled"
> ;;
> - --disable-libpmem) libpmem=enabled
> + --disable-libpmem) libpmem="disabled"
> ;;
> --enable-xkbcommon) xkbcommon="enabled"
> ;;
>
Fixes: e36e8c70f6d ("configure, meson: convert libpmem detection to meson")
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix libpmem configuration option
2021-07-07 7:51 [PATCH] Fix libpmem configuration option Miroslav Rezanina
2021-07-07 8:14 ` Philippe Mathieu-Daudé
@ 2021-07-08 0:22 ` Connor Kuehl
2021-07-08 4:48 ` Pankaj Gupta
2021-07-08 9:54 ` Li, Zhijian/李 智坚
3 siblings, 0 replies; 5+ messages in thread
From: Connor Kuehl @ 2021-07-08 0:22 UTC (permalink / raw)
To: Miroslav Rezanina, qemu-devel; +Cc: pbonzini
On Wed Jul 7, 2021 at 12:51 AM PDT, Miroslav Rezanina wrote:
> For some reason, libpmem option setting was set to work in an opposite
> way (--enable-libpmem disabled it and vice versa). Fixing this so
> configuration works properly.
>
> Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
> ---
> configure | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 7994bdee92..ffa93cc5fd 100755
> --- a/configure
> +++ b/configure
> @@ -1501,9 +1501,9 @@ for opt do
> ;;
> --disable-debug-mutex) debug_mutex=no
> ;;
> - --enable-libpmem) libpmem=disabled
> + --enable-libpmem) libpmem="enabled"
> ;;
> - --disable-libpmem) libpmem=enabled
> + --disable-libpmem) libpmem="disabled"
> ;;
> --enable-xkbcommon) xkbcommon="enabled"
> ;;
> --
> 2.27.0
Good catch.
Reviewed-by: Connor Kuehl <ckuehl@redhat.com>
or
Tested-by: Connor Kuehl <ckuehl@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix libpmem configuration option
2021-07-07 7:51 [PATCH] Fix libpmem configuration option Miroslav Rezanina
2021-07-07 8:14 ` Philippe Mathieu-Daudé
2021-07-08 0:22 ` Connor Kuehl
@ 2021-07-08 4:48 ` Pankaj Gupta
2021-07-08 9:54 ` Li, Zhijian/李 智坚
3 siblings, 0 replies; 5+ messages in thread
From: Pankaj Gupta @ 2021-07-08 4:48 UTC (permalink / raw)
To: Miroslav Rezanina; +Cc: Paolo Bonzini, Qemu Developers
> For some reason, libpmem option setting was set to work in an opposite
> way (--enable-libpmem disabled it and vice versa). Fixing this so
> configuration works properly.
>
> Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
> ---
> configure | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 7994bdee92..ffa93cc5fd 100755
> --- a/configure
> +++ b/configure
> @@ -1501,9 +1501,9 @@ for opt do
> ;;
> --disable-debug-mutex) debug_mutex=no
> ;;
> - --enable-libpmem) libpmem=disabled
> + --enable-libpmem) libpmem="enabled"
> ;;
> - --disable-libpmem) libpmem=enabled
> + --disable-libpmem) libpmem="disabled"
> ;;
> --enable-xkbcommon) xkbcommon="enabled"
> ;;
Reviewed-by: Pankaj Gupta <pankaj.gupta@ionos.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix libpmem configuration option
2021-07-07 7:51 [PATCH] Fix libpmem configuration option Miroslav Rezanina
` (2 preceding siblings ...)
2021-07-08 4:48 ` Pankaj Gupta
@ 2021-07-08 9:54 ` Li, Zhijian/李 智坚
3 siblings, 0 replies; 5+ messages in thread
From: Li, Zhijian/李 智坚 @ 2021-07-08 9:54 UTC (permalink / raw)
To: Miroslav Rezanina, qemu-devel; +Cc: pbonzini
[-- Attachment #1: Type: text/plain, Size: 1675 bytes --]
i have to apply below extra changes
From a8d027d3dfe70fb33363ad5934e163999fc29eec Mon Sep 17 00:00:00 2001
From: Li Zhijian <lizhijian@cn.fujitsu.com>
Date: Thu, 8 Jul 2021 17:52:40 +0800
Subject: [PATCH] fix libpmem configuration
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index a172c83e150..0a3a4610f27 100755
--- a/configure
+++ b/configure
@@ -4818,7 +4818,7 @@ elif test "$pthread_setname_np_wo_tid" = "yes" ; then
echo "CONFIG_PTHREAD_SETNAME_NP_WO_TID=y" >> $config_host_mak
fi
-if test "$libpmem" = "yes" ; then
+if test "$libpmem" = "enabled" ; then
echo "CONFIG_LIBPMEM=y" >> $config_host_mak
echo "LIBPMEM_LIBS=$libpmem_libs" >> $config_host_mak
echo "LIBPMEM_CFLAGS=$libpmem_cflags" >> $config_host_mak
--
2.31.1
On 2021/7/7 15:51, Miroslav Rezanina wrote:
> For some reason, libpmem option setting was set to work in an opposite
> way (--enable-libpmem disabled it and vice versa). Fixing this so
> configuration works properly.
>
> Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
> ---
> configure | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 7994bdee92..ffa93cc5fd 100755
> --- a/configure
> +++ b/configure
> @@ -1501,9 +1501,9 @@ for opt do
> ;;
> --disable-debug-mutex) debug_mutex=no
> ;;
> - --enable-libpmem) libpmem=disabled
> + --enable-libpmem) libpmem="enabled"
> ;;
> - --disable-libpmem) libpmem=enabled
> + --disable-libpmem) libpmem="disabled"
> ;;
> --enable-xkbcommon) xkbcommon="enabled"
> ;;
[-- Attachment #2: Type: text/html, Size: 2261 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-07-08 9:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-07 7:51 [PATCH] Fix libpmem configuration option Miroslav Rezanina
2021-07-07 8:14 ` Philippe Mathieu-Daudé
2021-07-08 0:22 ` Connor Kuehl
2021-07-08 4:48 ` Pankaj Gupta
2021-07-08 9:54 ` Li, Zhijian/李 智坚
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.