From: Jonathan Cameron <jic23@kernel.org> To: David Lechner <david@lechnology.com> Cc: William Breathitt Gray <vilhelm.gray@gmail.com>, linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de, jarkko.nikula@linux.intel.com, Dan Carpenter <dan.carpenter@oracle.com> Subject: Re: [PATCH v12 14/17] counter: Implement *_component_id sysfs attributes Date: Sun, 11 Jul 2021 14:28:00 +0100 [thread overview] Message-ID: <20210711142800.60e94cc7@jic23-huawei> (raw) In-Reply-To: <bd0313ce-22fa-0516-93a1-ff3a5cb1fdd1@lechnology.com> On Sat, 10 Jul 2021 12:06:53 -0500 David Lechner <david@lechnology.com> wrote: > On 7/5/21 3:19 AM, William Breathitt Gray wrote: > > The Generic Counter chrdev interface expects users to supply component > > IDs in order to select extensions for requests. In order for users to > > know what component ID belongs to which extension this information must > > be exposed. The *_component_id attribute provides a way for users to > > discover what component ID belongs to which respective extension. > > > > Cc: David Lechner <david@lechnology.com> > > Cc: Gwendal Grignou <gwendal@chromium.org> > > Cc: Dan Carpenter <dan.carpenter@oracle.com> > > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > > --- > > Documentation/ABI/testing/sysfs-bus-counter | 16 ++++++++++- > > drivers/counter/counter-sysfs.c | 30 ++++++++++++++++----- > > 2 files changed, 39 insertions(+), 7 deletions(-) > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-counter b/Documentation/ABI/testing/sysfs-bus-counter > > index 9809d8a47431..e0e99adb0ecc 100644 > > --- a/Documentation/ABI/testing/sysfs-bus-counter > > +++ b/Documentation/ABI/testing/sysfs-bus-counter > > @@ -203,12 +203,26 @@ Description: > > both edges: > > Any state transition. > > > > +What: /sys/bus/counter/devices/counterX/countY/ceiling_component_id > > +What: /sys/bus/counter/devices/counterX/countY/floor_component_id > > +What: /sys/bus/counter/devices/counterX/countY/count_mode_component_id > > +What: /sys/bus/counter/devices/counterX/countY/direction_component_id > > +What: /sys/bus/counter/devices/counterX/countY/enable_component_id > > +What: /sys/bus/counter/devices/counterX/countY/error_noise_component_id > > +What: /sys/bus/counter/devices/counterX/countY/prescaler_component_id > > +What: /sys/bus/counter/devices/counterX/countY/preset_component_id > > +What: /sys/bus/counter/devices/counterX/countY/preset_enable_component_id > > What: /sys/bus/counter/devices/counterX/countY/signalZ_action_component_id > > +What: /sys/bus/counter/devices/counterX/signalY/cable_fault_component_id > > +What: /sys/bus/counter/devices/counterX/signalY/cable_fault_enable_component_id > > +What: /sys/bus/counter/devices/counterX/signalY/filter_clock_prescaler_component_id > > +What: /sys/bus/counter/devices/counterX/signalY/index_polarity_component_id > > +What: /sys/bus/counter/devices/counterX/signalY/synchronous_mode_component_id > > Could we just write a single line? > > What: /sys/bus/counter/devices/counterX/signalY/<component>_component_id Not nice for grepping so I think it's better to call them out explicitly. There has been a proposal to check this ABI doc against running kernels, and if we have too many wild cards that becomes very difficult to do. Jonathan > > > KernelVersion: 5.15 > > Contact: linux-iio@vger.kernel.org > > Description: > > Read-only attribute that indicates the component ID of the > > - respective Synapse of Count Y for Signal Z. > > + respective extension or Synapse. > > > > What: /sys/bus/counter/devices/counterX/countY/spike_filter_ns > > KernelVersion: 5.14 > > diff --git a/drivers/counter/counter-sysfs.c b/drivers/counter/counter-sysfs.c > > index bb49a10f160b..eb1505bfbd89 100644 > > --- a/drivers/counter/counter-sysfs.c > > +++ b/drivers/counter/counter-sysfs.c > > @@ -587,6 +587,7 @@ static int counter_signal_attrs_create(struct counter_device *const counter, > > int err; > > struct counter_comp comp; > > size_t i; > > + struct counter_comp *ext; > > > > /* Create main Signal attribute */ > > comp = counter_signal_comp; > > @@ -602,8 +603,13 @@ static int counter_signal_attrs_create(struct counter_device *const counter, > > > > /* Create an attribute for each extension */ > > for (i = 0; i < signal->num_ext; i++) { > > - err = counter_attr_create(dev, group, signal->ext + i, scope, > > - signal); > > + ext = signal->ext + i; > > + > > + err = counter_attr_create(dev, group, ext, scope, signal); > > + if (err < 0) > > + return err; > > + > > + err = counter_comp_id_attr_create(dev, group, ext->name, i); > > if (err < 0) > > return err; > > } > > @@ -694,6 +700,7 @@ static int counter_count_attrs_create(struct counter_device *const counter, > > int err; > > struct counter_comp comp; > > size_t i; > > + struct counter_comp *ext; > > > > /* Create main Count attribute */ > > comp = counter_count_comp; > > @@ -718,8 +725,13 @@ static int counter_count_attrs_create(struct counter_device *const counter, > > > > /* Create an attribute for each extension */ > > for (i = 0; i < count->num_ext; i++) { > > - err = counter_attr_create(dev, group, count->ext + i, scope, > > - count); > > + ext = count->ext + i; > > ext = &count->ext[i]; > > Could make it more clear we are dealing with pointers rather than integers. > > > + > > + err = counter_attr_create(dev, group, ext, scope, count); > > + if (err < 0) > > + return err; > > + > > + err = counter_comp_id_attr_create(dev, group, ext->name, i); > > if (err < 0) > > return err; > > } > > @@ -783,6 +795,7 @@ static int counter_sysfs_attr_add(struct counter_device *const counter, > > struct device *const dev = &counter->dev; > > int err; > > size_t i; > > + struct counter_comp *ext; > > > > /* Add Signals sysfs attributes */ > > err = counter_sysfs_signals_add(counter, group); > > @@ -815,8 +828,13 @@ static int counter_sysfs_attr_add(struct counter_device *const counter, > > > > /* Create an attribute for each extension */ > > for (i = 0; i < counter->num_ext; i++) { > > - err = counter_attr_create(dev, group, counter->ext + i, scope, > > - NULL); > > + ext = counter->ext + i; > > ditto > > > + > > + err = counter_attr_create(dev, group, ext, scope, NULL); > > + if (err < 0) > > + return err; > > + > > + err = counter_comp_id_attr_create(dev, group, ext->name, i); > > if (err < 0) > > return err; > > } > > >
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org> To: David Lechner <david@lechnology.com> Cc: William Breathitt Gray <vilhelm.gray@gmail.com>, linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de, jarkko.nikula@linux.intel.com, Dan Carpenter <dan.carpenter@oracle.com> Subject: Re: [PATCH v12 14/17] counter: Implement *_component_id sysfs attributes Date: Sun, 11 Jul 2021 14:28:00 +0100 [thread overview] Message-ID: <20210711142800.60e94cc7@jic23-huawei> (raw) In-Reply-To: <bd0313ce-22fa-0516-93a1-ff3a5cb1fdd1@lechnology.com> On Sat, 10 Jul 2021 12:06:53 -0500 David Lechner <david@lechnology.com> wrote: > On 7/5/21 3:19 AM, William Breathitt Gray wrote: > > The Generic Counter chrdev interface expects users to supply component > > IDs in order to select extensions for requests. In order for users to > > know what component ID belongs to which extension this information must > > be exposed. The *_component_id attribute provides a way for users to > > discover what component ID belongs to which respective extension. > > > > Cc: David Lechner <david@lechnology.com> > > Cc: Gwendal Grignou <gwendal@chromium.org> > > Cc: Dan Carpenter <dan.carpenter@oracle.com> > > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > > --- > > Documentation/ABI/testing/sysfs-bus-counter | 16 ++++++++++- > > drivers/counter/counter-sysfs.c | 30 ++++++++++++++++----- > > 2 files changed, 39 insertions(+), 7 deletions(-) > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-counter b/Documentation/ABI/testing/sysfs-bus-counter > > index 9809d8a47431..e0e99adb0ecc 100644 > > --- a/Documentation/ABI/testing/sysfs-bus-counter > > +++ b/Documentation/ABI/testing/sysfs-bus-counter > > @@ -203,12 +203,26 @@ Description: > > both edges: > > Any state transition. > > > > +What: /sys/bus/counter/devices/counterX/countY/ceiling_component_id > > +What: /sys/bus/counter/devices/counterX/countY/floor_component_id > > +What: /sys/bus/counter/devices/counterX/countY/count_mode_component_id > > +What: /sys/bus/counter/devices/counterX/countY/direction_component_id > > +What: /sys/bus/counter/devices/counterX/countY/enable_component_id > > +What: /sys/bus/counter/devices/counterX/countY/error_noise_component_id > > +What: /sys/bus/counter/devices/counterX/countY/prescaler_component_id > > +What: /sys/bus/counter/devices/counterX/countY/preset_component_id > > +What: /sys/bus/counter/devices/counterX/countY/preset_enable_component_id > > What: /sys/bus/counter/devices/counterX/countY/signalZ_action_component_id > > +What: /sys/bus/counter/devices/counterX/signalY/cable_fault_component_id > > +What: /sys/bus/counter/devices/counterX/signalY/cable_fault_enable_component_id > > +What: /sys/bus/counter/devices/counterX/signalY/filter_clock_prescaler_component_id > > +What: /sys/bus/counter/devices/counterX/signalY/index_polarity_component_id > > +What: /sys/bus/counter/devices/counterX/signalY/synchronous_mode_component_id > > Could we just write a single line? > > What: /sys/bus/counter/devices/counterX/signalY/<component>_component_id Not nice for grepping so I think it's better to call them out explicitly. There has been a proposal to check this ABI doc against running kernels, and if we have too many wild cards that becomes very difficult to do. Jonathan > > > KernelVersion: 5.15 > > Contact: linux-iio@vger.kernel.org > > Description: > > Read-only attribute that indicates the component ID of the > > - respective Synapse of Count Y for Signal Z. > > + respective extension or Synapse. > > > > What: /sys/bus/counter/devices/counterX/countY/spike_filter_ns > > KernelVersion: 5.14 > > diff --git a/drivers/counter/counter-sysfs.c b/drivers/counter/counter-sysfs.c > > index bb49a10f160b..eb1505bfbd89 100644 > > --- a/drivers/counter/counter-sysfs.c > > +++ b/drivers/counter/counter-sysfs.c > > @@ -587,6 +587,7 @@ static int counter_signal_attrs_create(struct counter_device *const counter, > > int err; > > struct counter_comp comp; > > size_t i; > > + struct counter_comp *ext; > > > > /* Create main Signal attribute */ > > comp = counter_signal_comp; > > @@ -602,8 +603,13 @@ static int counter_signal_attrs_create(struct counter_device *const counter, > > > > /* Create an attribute for each extension */ > > for (i = 0; i < signal->num_ext; i++) { > > - err = counter_attr_create(dev, group, signal->ext + i, scope, > > - signal); > > + ext = signal->ext + i; > > + > > + err = counter_attr_create(dev, group, ext, scope, signal); > > + if (err < 0) > > + return err; > > + > > + err = counter_comp_id_attr_create(dev, group, ext->name, i); > > if (err < 0) > > return err; > > } > > @@ -694,6 +700,7 @@ static int counter_count_attrs_create(struct counter_device *const counter, > > int err; > > struct counter_comp comp; > > size_t i; > > + struct counter_comp *ext; > > > > /* Create main Count attribute */ > > comp = counter_count_comp; > > @@ -718,8 +725,13 @@ static int counter_count_attrs_create(struct counter_device *const counter, > > > > /* Create an attribute for each extension */ > > for (i = 0; i < count->num_ext; i++) { > > - err = counter_attr_create(dev, group, count->ext + i, scope, > > - count); > > + ext = count->ext + i; > > ext = &count->ext[i]; > > Could make it more clear we are dealing with pointers rather than integers. > > > + > > + err = counter_attr_create(dev, group, ext, scope, count); > > + if (err < 0) > > + return err; > > + > > + err = counter_comp_id_attr_create(dev, group, ext->name, i); > > if (err < 0) > > return err; > > } > > @@ -783,6 +795,7 @@ static int counter_sysfs_attr_add(struct counter_device *const counter, > > struct device *const dev = &counter->dev; > > int err; > > size_t i; > > + struct counter_comp *ext; > > > > /* Add Signals sysfs attributes */ > > err = counter_sysfs_signals_add(counter, group); > > @@ -815,8 +828,13 @@ static int counter_sysfs_attr_add(struct counter_device *const counter, > > > > /* Create an attribute for each extension */ > > for (i = 0; i < counter->num_ext; i++) { > > - err = counter_attr_create(dev, group, counter->ext + i, scope, > > - NULL); > > + ext = counter->ext + i; > > ditto > > > + > > + err = counter_attr_create(dev, group, ext, scope, NULL); > > + if (err < 0) > > + return err; > > + > > + err = counter_comp_id_attr_create(dev, group, ext->name, i); > > if (err < 0) > > return err; > > } > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-11 13:25 UTC|newest] Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-05 8:18 [PATCH v12 00/17] Introduce the Counter character device interface William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-05 8:18 ` [PATCH v12 01/17] counter: 104-quad-8: Return error when invalid mode during ceiling_write William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-05 8:18 ` [PATCH v12 02/17] counter: Return error code on invalid modes William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-09 17:40 ` David Lechner 2021-07-09 17:40 ` David Lechner 2021-07-05 8:18 ` [PATCH v12 03/17] counter: Standardize to ERANGE for limit exceeded errors William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-05 8:18 ` [PATCH v12 04/17] counter: Rename counter_signal_value to counter_signal_level William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-05 8:18 ` [PATCH v12 05/17] counter: Rename counter_count_function to counter_function William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-05 8:18 ` [PATCH v12 06/17] counter: Internalize sysfs interface code William Breathitt Gray 2021-07-11 9:49 ` Syed Nayyar Waris 2021-07-11 11:42 ` Jonathan Cameron 2021-07-11 11:42 ` Jonathan Cameron 2021-07-05 8:18 ` [PATCH v12 07/17] counter: Update counter.h comments to reflect sysfs internalization William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-09 17:49 ` David Lechner 2021-07-09 17:49 ` David Lechner 2021-07-10 9:41 ` William Breathitt Gray 2021-07-10 9:41 ` William Breathitt Gray 2021-07-05 8:18 ` [PATCH v12 08/17] docs: counter: Update " William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-09 17:56 ` David Lechner 2021-07-09 17:56 ` David Lechner 2021-07-05 8:18 ` [PATCH v12 09/17] counter: Move counter enums to uapi header William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-05 8:18 ` [PATCH v12 10/17] counter: Add character device interface William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-10 19:37 ` David Lechner 2021-07-10 19:37 ` David Lechner 2021-07-11 12:20 ` Jonathan Cameron 2021-07-11 12:20 ` Jonathan Cameron 2021-07-12 10:28 ` William Breathitt Gray 2021-07-12 10:28 ` William Breathitt Gray 2021-07-05 8:18 ` [PATCH v12 11/17] docs: counter: Document " William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-10 20:15 ` David Lechner 2021-07-10 20:15 ` David Lechner 2021-07-11 10:41 ` William Breathitt Gray 2021-07-11 10:41 ` William Breathitt Gray 2021-07-05 8:19 ` [PATCH v12 12/17] tools/counter: Create Counter tools William Breathitt Gray 2021-07-05 8:19 ` William Breathitt Gray 2021-07-10 16:53 ` David Lechner 2021-07-10 16:53 ` David Lechner 2021-07-11 11:28 ` William Breathitt Gray 2021-07-11 11:28 ` William Breathitt Gray 2021-07-11 14:05 ` David Lechner 2021-07-11 14:05 ` David Lechner 2021-07-11 13:22 ` Jonathan Cameron 2021-07-11 13:22 ` Jonathan Cameron 2021-07-05 8:19 ` [PATCH v12 13/17] counter: Implement signalZ_action_component_id sysfs attribute William Breathitt Gray 2021-07-05 8:19 ` William Breathitt Gray 2021-07-10 16:20 ` David Lechner 2021-07-10 16:20 ` David Lechner 2021-07-05 8:19 ` [PATCH v12 14/17] counter: Implement *_component_id sysfs attributes William Breathitt Gray 2021-07-05 8:19 ` William Breathitt Gray 2021-07-10 17:06 ` David Lechner 2021-07-10 17:06 ` David Lechner 2021-07-11 13:28 ` Jonathan Cameron [this message] 2021-07-11 13:28 ` Jonathan Cameron 2021-07-11 14:08 ` David Lechner 2021-07-11 14:08 ` David Lechner 2021-07-12 10:19 ` Jonathan Cameron 2021-07-12 10:19 ` Jonathan Cameron 2021-07-05 8:19 ` [PATCH v12 15/17] counter: Implement events_queue_size sysfs attribute William Breathitt Gray 2021-07-05 8:19 ` William Breathitt Gray 2021-07-06 11:40 ` Jarkko Nikula 2021-07-06 11:40 ` Jarkko Nikula 2021-07-10 10:25 ` William Breathitt Gray 2021-07-10 10:25 ` William Breathitt Gray 2021-07-10 15:43 ` David Lechner 2021-07-10 15:43 ` David Lechner 2021-07-10 16:08 ` David Lechner 2021-07-10 16:08 ` David Lechner 2021-07-10 17:53 ` David Lechner 2021-07-10 17:53 ` David Lechner 2021-07-11 9:12 ` William Breathitt Gray 2021-07-11 9:12 ` William Breathitt Gray 2021-07-05 8:19 ` [PATCH v12 16/17] counter: 104-quad-8: Replace mutex with spinlock William Breathitt Gray 2021-07-05 8:19 ` William Breathitt Gray 2021-07-05 8:19 ` [PATCH v12 17/17] counter: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8 William Breathitt Gray 2021-07-05 8:19 ` William Breathitt Gray 2021-07-11 13:44 ` Jonathan Cameron 2021-07-11 13:44 ` Jonathan Cameron 2021-07-12 10:59 ` William Breathitt Gray 2021-07-12 10:59 ` William Breathitt Gray 2021-07-06 11:40 ` [PATCH v12 00/17] Introduce the Counter character device interface Jarkko Nikula 2021-07-06 11:40 ` Jarkko Nikula 2021-07-07 0:28 ` William Breathitt Gray 2021-07-07 0:28 ` William Breathitt Gray 2021-07-11 13:48 ` Jonathan Cameron 2021-07-11 13:48 ` Jonathan Cameron 2021-07-12 10:48 ` William Breathitt Gray 2021-07-12 10:48 ` William Breathitt Gray 2021-07-05 16:36 [PATCH v12 15/17] counter: Implement events_queue_size sysfs attribute kernel test robot 2021-07-06 7:48 ` Dan Carpenter 2021-07-06 7:48 ` Dan Carpenter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210711142800.60e94cc7@jic23-huawei \ --to=jic23@kernel.org \ --cc=a.fatoum@pengutronix.de \ --cc=alexandre.belloni@bootlin.com \ --cc=alexandre.torgue@st.com \ --cc=dan.carpenter@oracle.com \ --cc=david@lechnology.com \ --cc=fabrice.gasnier@st.com \ --cc=gwendal@chromium.org \ --cc=jarkko.nikula@linux.intel.com \ --cc=kamel.bouhara@bootlin.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=o.rempel@pengutronix.de \ --cc=patrick.havelange@essensium.com \ --cc=syednwaris@gmail.com \ --cc=vilhelm.gray@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.