From: William Breathitt Gray <vilhelm.gray@gmail.com> To: Jarkko Nikula <jarkko.nikula@linux.intel.com> Cc: jic23@kernel.org, linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, david@lechnology.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de Subject: Re: [PATCH v12 15/17] counter: Implement events_queue_size sysfs attribute Date: Sat, 10 Jul 2021 19:25:02 +0900 [thread overview] Message-ID: <YOl1frCrophjhk7y@shinobu> (raw) In-Reply-To: <1a624011-0b43-ac42-be53-a42f81923e5a@linux.intel.com> [-- Attachment #1: Type: text/plain, Size: 3171 bytes --] On Tue, Jul 06, 2021 at 02:40:13PM +0300, Jarkko Nikula wrote: > Hi > > On 7/5/21 11:19 AM, William Breathitt Gray wrote: > > The events_queue_size sysfs attribute provides a way for users to > > dynamically configure the Counter events queue size for the Counter > > character device interface. The size is in number of struct > > counter_event data structures. The number of elements will be rounded-up > > to a power of 2 due to a requirement of the kfifo_alloc function called > > during reallocation of the queue. > > > ... > > diff --git a/drivers/counter/counter-chrdev.c b/drivers/counter/counter-chrdev.c > > index 92805b1f65b8..13644c87d02a 100644 > > --- a/drivers/counter/counter-chrdev.c > > +++ b/drivers/counter/counter-chrdev.c > > @@ -323,6 +323,9 @@ static int counter_chrdev_open(struct inode *inode, struct file *filp) > > typeof(*counter), > > chrdev); > > > > + if (!mutex_trylock(&counter->chrdev_lock)) > > + return -EBUSY; > > + > > get_device(&counter->dev); > > filp->private_data = counter; > > > > @@ -339,6 +342,7 @@ static int counter_chrdev_release(struct inode *inode, struct file *filp) > > return err; > > > > put_device(&counter->dev); > > + mutex_unlock(&counter->chrdev_lock); > > > > return 0; > > } > > I got two separate mutex warnings from counter_chrdev_open() by doing > blind "cat /dev/counter0". First one due mutex being uninitialized: > > [ 441.057342] DEBUG_LOCKS_WARN_ON(lock->magic != lock) > [ 441.057355] WARNING: CPU: 2 PID: 366 at kernel/locking/mutex.c:1416 > mutex_trylock+0xf2/0x130 > ... > [ 441.217331] Call Trace: > [ 441.220062] counter_chrdev_open+0x21/0x60 [counter] > ... > > which I fixed trivially by (please be free to use it) > > --- a/drivers/counter/counter-chrdev.c > +++ b/drivers/counter/counter-chrdev.c > @@ -364,6 +364,7 @@ int counter_chrdev_add(struct counter_device *const > counter) > spin_lock_init(&counter->events_list_lock); > init_waitqueue_head(&counter->events_wait); > mutex_init(&counter->events_lock); > + mutex_init(&counter->chrdev_lock); > > /* Initialize character device */ > cdev_init(&counter->chrdev, &counter_fops); Thanks, I'll add this line in. > and after that > > [ 16.564403] ================================================ > [ 16.570725] WARNING: lock held when returning to user space! > [ 16.577044] 5.13.0-next-20210706+ #4 Not tainted > [ 16.582198] ------------------------------------------------ > [ 16.588507] cat/331 is leaving the kernel with locks still held! > [ 16.595214] 1 lock held by cat/331: > [ 16.599103] #0: ffff888102bb3630 > (&counter->chrdev_lock){+.+.}-{3:3}, at: counter_chrdev_open+0x21/0x60 > [counter] > > Jarkko I'm not sure how to resolve this warning. The purpose of this lock is to limit chrdev to a single open at a time. To accomplish this I grab this lock in counter_chrdev_open() and hold it until counter_chrdev_release() is called. Is there a better way to accomplish this? William Breathitt Gray [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: William Breathitt Gray <vilhelm.gray@gmail.com> To: Jarkko Nikula <jarkko.nikula@linux.intel.com> Cc: jic23@kernel.org, linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, david@lechnology.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de Subject: Re: [PATCH v12 15/17] counter: Implement events_queue_size sysfs attribute Date: Sat, 10 Jul 2021 19:25:02 +0900 [thread overview] Message-ID: <YOl1frCrophjhk7y@shinobu> (raw) In-Reply-To: <1a624011-0b43-ac42-be53-a42f81923e5a@linux.intel.com> [-- Attachment #1.1: Type: text/plain, Size: 3171 bytes --] On Tue, Jul 06, 2021 at 02:40:13PM +0300, Jarkko Nikula wrote: > Hi > > On 7/5/21 11:19 AM, William Breathitt Gray wrote: > > The events_queue_size sysfs attribute provides a way for users to > > dynamically configure the Counter events queue size for the Counter > > character device interface. The size is in number of struct > > counter_event data structures. The number of elements will be rounded-up > > to a power of 2 due to a requirement of the kfifo_alloc function called > > during reallocation of the queue. > > > ... > > diff --git a/drivers/counter/counter-chrdev.c b/drivers/counter/counter-chrdev.c > > index 92805b1f65b8..13644c87d02a 100644 > > --- a/drivers/counter/counter-chrdev.c > > +++ b/drivers/counter/counter-chrdev.c > > @@ -323,6 +323,9 @@ static int counter_chrdev_open(struct inode *inode, struct file *filp) > > typeof(*counter), > > chrdev); > > > > + if (!mutex_trylock(&counter->chrdev_lock)) > > + return -EBUSY; > > + > > get_device(&counter->dev); > > filp->private_data = counter; > > > > @@ -339,6 +342,7 @@ static int counter_chrdev_release(struct inode *inode, struct file *filp) > > return err; > > > > put_device(&counter->dev); > > + mutex_unlock(&counter->chrdev_lock); > > > > return 0; > > } > > I got two separate mutex warnings from counter_chrdev_open() by doing > blind "cat /dev/counter0". First one due mutex being uninitialized: > > [ 441.057342] DEBUG_LOCKS_WARN_ON(lock->magic != lock) > [ 441.057355] WARNING: CPU: 2 PID: 366 at kernel/locking/mutex.c:1416 > mutex_trylock+0xf2/0x130 > ... > [ 441.217331] Call Trace: > [ 441.220062] counter_chrdev_open+0x21/0x60 [counter] > ... > > which I fixed trivially by (please be free to use it) > > --- a/drivers/counter/counter-chrdev.c > +++ b/drivers/counter/counter-chrdev.c > @@ -364,6 +364,7 @@ int counter_chrdev_add(struct counter_device *const > counter) > spin_lock_init(&counter->events_list_lock); > init_waitqueue_head(&counter->events_wait); > mutex_init(&counter->events_lock); > + mutex_init(&counter->chrdev_lock); > > /* Initialize character device */ > cdev_init(&counter->chrdev, &counter_fops); Thanks, I'll add this line in. > and after that > > [ 16.564403] ================================================ > [ 16.570725] WARNING: lock held when returning to user space! > [ 16.577044] 5.13.0-next-20210706+ #4 Not tainted > [ 16.582198] ------------------------------------------------ > [ 16.588507] cat/331 is leaving the kernel with locks still held! > [ 16.595214] 1 lock held by cat/331: > [ 16.599103] #0: ffff888102bb3630 > (&counter->chrdev_lock){+.+.}-{3:3}, at: counter_chrdev_open+0x21/0x60 > [counter] > > Jarkko I'm not sure how to resolve this warning. The purpose of this lock is to limit chrdev to a single open at a time. To accomplish this I grab this lock in counter_chrdev_open() and hold it until counter_chrdev_release() is called. Is there a better way to accomplish this? William Breathitt Gray [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-10 10:25 UTC|newest] Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-05 8:18 [PATCH v12 00/17] Introduce the Counter character device interface William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-05 8:18 ` [PATCH v12 01/17] counter: 104-quad-8: Return error when invalid mode during ceiling_write William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-05 8:18 ` [PATCH v12 02/17] counter: Return error code on invalid modes William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-09 17:40 ` David Lechner 2021-07-09 17:40 ` David Lechner 2021-07-05 8:18 ` [PATCH v12 03/17] counter: Standardize to ERANGE for limit exceeded errors William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-05 8:18 ` [PATCH v12 04/17] counter: Rename counter_signal_value to counter_signal_level William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-05 8:18 ` [PATCH v12 05/17] counter: Rename counter_count_function to counter_function William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-05 8:18 ` [PATCH v12 06/17] counter: Internalize sysfs interface code William Breathitt Gray 2021-07-11 9:49 ` Syed Nayyar Waris 2021-07-11 11:42 ` Jonathan Cameron 2021-07-11 11:42 ` Jonathan Cameron 2021-07-05 8:18 ` [PATCH v12 07/17] counter: Update counter.h comments to reflect sysfs internalization William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-09 17:49 ` David Lechner 2021-07-09 17:49 ` David Lechner 2021-07-10 9:41 ` William Breathitt Gray 2021-07-10 9:41 ` William Breathitt Gray 2021-07-05 8:18 ` [PATCH v12 08/17] docs: counter: Update " William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-09 17:56 ` David Lechner 2021-07-09 17:56 ` David Lechner 2021-07-05 8:18 ` [PATCH v12 09/17] counter: Move counter enums to uapi header William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-05 8:18 ` [PATCH v12 10/17] counter: Add character device interface William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-10 19:37 ` David Lechner 2021-07-10 19:37 ` David Lechner 2021-07-11 12:20 ` Jonathan Cameron 2021-07-11 12:20 ` Jonathan Cameron 2021-07-12 10:28 ` William Breathitt Gray 2021-07-12 10:28 ` William Breathitt Gray 2021-07-05 8:18 ` [PATCH v12 11/17] docs: counter: Document " William Breathitt Gray 2021-07-05 8:18 ` William Breathitt Gray 2021-07-10 20:15 ` David Lechner 2021-07-10 20:15 ` David Lechner 2021-07-11 10:41 ` William Breathitt Gray 2021-07-11 10:41 ` William Breathitt Gray 2021-07-05 8:19 ` [PATCH v12 12/17] tools/counter: Create Counter tools William Breathitt Gray 2021-07-05 8:19 ` William Breathitt Gray 2021-07-10 16:53 ` David Lechner 2021-07-10 16:53 ` David Lechner 2021-07-11 11:28 ` William Breathitt Gray 2021-07-11 11:28 ` William Breathitt Gray 2021-07-11 14:05 ` David Lechner 2021-07-11 14:05 ` David Lechner 2021-07-11 13:22 ` Jonathan Cameron 2021-07-11 13:22 ` Jonathan Cameron 2021-07-05 8:19 ` [PATCH v12 13/17] counter: Implement signalZ_action_component_id sysfs attribute William Breathitt Gray 2021-07-05 8:19 ` William Breathitt Gray 2021-07-10 16:20 ` David Lechner 2021-07-10 16:20 ` David Lechner 2021-07-05 8:19 ` [PATCH v12 14/17] counter: Implement *_component_id sysfs attributes William Breathitt Gray 2021-07-05 8:19 ` William Breathitt Gray 2021-07-10 17:06 ` David Lechner 2021-07-10 17:06 ` David Lechner 2021-07-11 13:28 ` Jonathan Cameron 2021-07-11 13:28 ` Jonathan Cameron 2021-07-11 14:08 ` David Lechner 2021-07-11 14:08 ` David Lechner 2021-07-12 10:19 ` Jonathan Cameron 2021-07-12 10:19 ` Jonathan Cameron 2021-07-05 8:19 ` [PATCH v12 15/17] counter: Implement events_queue_size sysfs attribute William Breathitt Gray 2021-07-05 8:19 ` William Breathitt Gray 2021-07-06 11:40 ` Jarkko Nikula 2021-07-06 11:40 ` Jarkko Nikula 2021-07-10 10:25 ` William Breathitt Gray [this message] 2021-07-10 10:25 ` William Breathitt Gray 2021-07-10 15:43 ` David Lechner 2021-07-10 15:43 ` David Lechner 2021-07-10 16:08 ` David Lechner 2021-07-10 16:08 ` David Lechner 2021-07-10 17:53 ` David Lechner 2021-07-10 17:53 ` David Lechner 2021-07-11 9:12 ` William Breathitt Gray 2021-07-11 9:12 ` William Breathitt Gray 2021-07-05 8:19 ` [PATCH v12 16/17] counter: 104-quad-8: Replace mutex with spinlock William Breathitt Gray 2021-07-05 8:19 ` William Breathitt Gray 2021-07-05 8:19 ` [PATCH v12 17/17] counter: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8 William Breathitt Gray 2021-07-05 8:19 ` William Breathitt Gray 2021-07-11 13:44 ` Jonathan Cameron 2021-07-11 13:44 ` Jonathan Cameron 2021-07-12 10:59 ` William Breathitt Gray 2021-07-12 10:59 ` William Breathitt Gray 2021-07-06 11:40 ` [PATCH v12 00/17] Introduce the Counter character device interface Jarkko Nikula 2021-07-06 11:40 ` Jarkko Nikula 2021-07-07 0:28 ` William Breathitt Gray 2021-07-07 0:28 ` William Breathitt Gray 2021-07-11 13:48 ` Jonathan Cameron 2021-07-11 13:48 ` Jonathan Cameron 2021-07-12 10:48 ` William Breathitt Gray 2021-07-12 10:48 ` William Breathitt Gray 2021-07-05 16:36 [PATCH v12 15/17] counter: Implement events_queue_size sysfs attribute kernel test robot 2021-07-06 7:48 ` Dan Carpenter 2021-07-06 7:48 ` Dan Carpenter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YOl1frCrophjhk7y@shinobu \ --to=vilhelm.gray@gmail.com \ --cc=a.fatoum@pengutronix.de \ --cc=alexandre.belloni@bootlin.com \ --cc=alexandre.torgue@st.com \ --cc=david@lechnology.com \ --cc=fabrice.gasnier@st.com \ --cc=gwendal@chromium.org \ --cc=jarkko.nikula@linux.intel.com \ --cc=jic23@kernel.org \ --cc=kamel.bouhara@bootlin.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=o.rempel@pengutronix.de \ --cc=patrick.havelange@essensium.com \ --cc=syednwaris@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.