From: Yong Wu <yong.wu@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Tomasz Figa <tfiga@chromium.org>,
<linux-mediatek@lists.infradead.org>,
<srv_heupstream@mediatek.com>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<iommu@lists.linux-foundation.org>, <yong.wu@mediatek.com>,
<youlin.pei@mediatek.com>, <anan.sun@mediatek.com>,
<ming-fan.chen@mediatek.com>, <yi.kuo@mediatek.com>,
<anthony.huang@mediatek.com>
Subject: [PATCH v2 06/11] memory: mtk-smi: Add error handle for smi_probe
Date: Thu, 15 Jul 2021 20:12:04 +0800 [thread overview]
Message-ID: <20210715121209.31024-7-yong.wu@mediatek.com> (raw)
In-Reply-To: <20210715121209.31024-1-yong.wu@mediatek.com>
Add error handle while component_add fail.
Signed-off-by: Yong Wu <yong.wu@mediatek.com>
---
It don't have the error handle when v1. it is not a fatal error.
thus don't add fix tags.
---
drivers/memory/mtk-smi.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
index 6f8e582bace5..e68cbb51dd12 100644
--- a/drivers/memory/mtk-smi.c
+++ b/drivers/memory/mtk-smi.c
@@ -330,7 +330,15 @@ static int mtk_smi_larb_probe(struct platform_device *pdev)
pm_runtime_enable(dev);
platform_set_drvdata(pdev, larb);
- return component_add(dev, &mtk_smi_larb_component_ops);
+ ret = component_add(dev, &mtk_smi_larb_component_ops);
+ if (ret)
+ goto err_pm_disable;
+ return 0;
+
+err_pm_disable:
+ pm_runtime_disable(dev);
+ device_link_remove(dev, larb->smi_common_dev);
+ return ret;
}
static int mtk_smi_larb_remove(struct platform_device *pdev)
--
2.18.0
WARNING: multiple messages have this Message-ID (diff)
From: Yong Wu <yong.wu@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org,
yi.kuo@mediatek.com, srv_heupstream@mediatek.com,
Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
iommu@lists.linux-foundation.org,
linux-mediatek@lists.infradead.org, anthony.huang@mediatek.com,
ming-fan.chen@mediatek.com, anan.sun@mediatek.com,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 06/11] memory: mtk-smi: Add error handle for smi_probe
Date: Thu, 15 Jul 2021 20:12:04 +0800 [thread overview]
Message-ID: <20210715121209.31024-7-yong.wu@mediatek.com> (raw)
In-Reply-To: <20210715121209.31024-1-yong.wu@mediatek.com>
Add error handle while component_add fail.
Signed-off-by: Yong Wu <yong.wu@mediatek.com>
---
It don't have the error handle when v1. it is not a fatal error.
thus don't add fix tags.
---
drivers/memory/mtk-smi.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
index 6f8e582bace5..e68cbb51dd12 100644
--- a/drivers/memory/mtk-smi.c
+++ b/drivers/memory/mtk-smi.c
@@ -330,7 +330,15 @@ static int mtk_smi_larb_probe(struct platform_device *pdev)
pm_runtime_enable(dev);
platform_set_drvdata(pdev, larb);
- return component_add(dev, &mtk_smi_larb_component_ops);
+ ret = component_add(dev, &mtk_smi_larb_component_ops);
+ if (ret)
+ goto err_pm_disable;
+ return 0;
+
+err_pm_disable:
+ pm_runtime_disable(dev);
+ device_link_remove(dev, larb->smi_common_dev);
+ return ret;
}
static int mtk_smi_larb_remove(struct platform_device *pdev)
--
2.18.0
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Yong Wu <yong.wu@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
"Tomasz Figa" <tfiga@chromium.org>,
<linux-mediatek@lists.infradead.org>,
<srv_heupstream@mediatek.com>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<iommu@lists.linux-foundation.org>, <yong.wu@mediatek.com>,
<youlin.pei@mediatek.com>, <anan.sun@mediatek.com>,
<ming-fan.chen@mediatek.com>, <yi.kuo@mediatek.com>,
<anthony.huang@mediatek.com>
Subject: [PATCH v2 06/11] memory: mtk-smi: Add error handle for smi_probe
Date: Thu, 15 Jul 2021 20:12:04 +0800 [thread overview]
Message-ID: <20210715121209.31024-7-yong.wu@mediatek.com> (raw)
In-Reply-To: <20210715121209.31024-1-yong.wu@mediatek.com>
Add error handle while component_add fail.
Signed-off-by: Yong Wu <yong.wu@mediatek.com>
---
It don't have the error handle when v1. it is not a fatal error.
thus don't add fix tags.
---
drivers/memory/mtk-smi.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
index 6f8e582bace5..e68cbb51dd12 100644
--- a/drivers/memory/mtk-smi.c
+++ b/drivers/memory/mtk-smi.c
@@ -330,7 +330,15 @@ static int mtk_smi_larb_probe(struct platform_device *pdev)
pm_runtime_enable(dev);
platform_set_drvdata(pdev, larb);
- return component_add(dev, &mtk_smi_larb_component_ops);
+ ret = component_add(dev, &mtk_smi_larb_component_ops);
+ if (ret)
+ goto err_pm_disable;
+ return 0;
+
+err_pm_disable:
+ pm_runtime_disable(dev);
+ device_link_remove(dev, larb->smi_common_dev);
+ return ret;
}
static int mtk_smi_larb_remove(struct platform_device *pdev)
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Yong Wu <yong.wu@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
"Tomasz Figa" <tfiga@chromium.org>,
<linux-mediatek@lists.infradead.org>,
<srv_heupstream@mediatek.com>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<iommu@lists.linux-foundation.org>, <yong.wu@mediatek.com>,
<youlin.pei@mediatek.com>, <anan.sun@mediatek.com>,
<ming-fan.chen@mediatek.com>, <yi.kuo@mediatek.com>,
<anthony.huang@mediatek.com>
Subject: [PATCH v2 06/11] memory: mtk-smi: Add error handle for smi_probe
Date: Thu, 15 Jul 2021 20:12:04 +0800 [thread overview]
Message-ID: <20210715121209.31024-7-yong.wu@mediatek.com> (raw)
In-Reply-To: <20210715121209.31024-1-yong.wu@mediatek.com>
Add error handle while component_add fail.
Signed-off-by: Yong Wu <yong.wu@mediatek.com>
---
It don't have the error handle when v1. it is not a fatal error.
thus don't add fix tags.
---
drivers/memory/mtk-smi.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
index 6f8e582bace5..e68cbb51dd12 100644
--- a/drivers/memory/mtk-smi.c
+++ b/drivers/memory/mtk-smi.c
@@ -330,7 +330,15 @@ static int mtk_smi_larb_probe(struct platform_device *pdev)
pm_runtime_enable(dev);
platform_set_drvdata(pdev, larb);
- return component_add(dev, &mtk_smi_larb_component_ops);
+ ret = component_add(dev, &mtk_smi_larb_component_ops);
+ if (ret)
+ goto err_pm_disable;
+ return 0;
+
+err_pm_disable:
+ pm_runtime_disable(dev);
+ device_link_remove(dev, larb->smi_common_dev);
+ return ret;
}
static int mtk_smi_larb_remove(struct platform_device *pdev)
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-15 12:13 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 12:11 [PATCH v2 00/11] MT8195 SMI support Yong Wu
2021-07-15 12:11 ` Yong Wu
2021-07-15 12:11 ` Yong Wu
2021-07-15 12:11 ` Yong Wu
2021-07-15 12:11 ` [PATCH v2 01/11] dt-bindings: memory: mediatek: Add mt8195 smi binding Yong Wu
2021-07-15 12:11 ` Yong Wu
2021-07-15 12:11 ` Yong Wu
2021-07-15 12:11 ` Yong Wu
2021-07-22 2:51 ` Rob Herring
2021-07-22 2:51 ` Rob Herring
2021-07-22 2:51 ` Rob Herring
2021-07-22 2:51 ` Rob Herring
2021-07-15 12:12 ` [PATCH v2 02/11] dt-bindings: memory: mediatek: Add mt8195 smi sub common Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-22 2:53 ` Rob Herring
2021-07-22 2:53 ` Rob Herring
2021-07-22 2:53 ` Rob Herring
2021-07-22 2:53 ` Rob Herring
2021-07-15 12:12 ` [PATCH v2 03/11] memory: mtk-smi: Use clk_bulk clock ops Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-21 10:43 ` Ikjoon Jang
2021-07-21 10:43 ` Ikjoon Jang
2021-07-21 10:43 ` Ikjoon Jang
2021-07-21 10:43 ` Ikjoon Jang
2021-07-15 12:12 ` [PATCH v2 04/11] memory: mtk-smi: Rename smi_gen to smi_type Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-21 10:44 ` Ikjoon Jang
2021-07-21 10:44 ` Ikjoon Jang
2021-07-21 10:44 ` Ikjoon Jang
2021-07-21 10:44 ` Ikjoon Jang
2021-07-15 12:12 ` [PATCH v2 05/11] memory: mtk-smi: Adjust some code position Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-21 10:44 ` Ikjoon Jang
2021-07-21 10:44 ` Ikjoon Jang
2021-07-21 10:44 ` Ikjoon Jang
2021-07-21 10:44 ` Ikjoon Jang
2021-07-15 12:12 ` Yong Wu [this message]
2021-07-15 12:12 ` [PATCH v2 06/11] memory: mtk-smi: Add error handle for smi_probe Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-21 10:45 ` Ikjoon Jang
2021-07-21 10:45 ` Ikjoon Jang
2021-07-21 10:45 ` Ikjoon Jang
2021-07-21 10:45 ` Ikjoon Jang
2021-07-15 12:12 ` [PATCH v2 07/11] memory: mtk-smi: Add smi sub common support Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-21 11:43 ` Ikjoon Jang
2021-07-21 11:43 ` Ikjoon Jang
2021-07-21 11:43 ` Ikjoon Jang
2021-07-21 11:43 ` Ikjoon Jang
2021-07-22 6:38 ` Yong Wu
2021-07-22 6:38 ` Yong Wu
2021-07-22 6:38 ` Yong Wu
2021-07-22 6:38 ` Yong Wu
2021-07-15 12:12 ` [PATCH v2 08/11] memory: mtk-smi: Use devm_platform_ioremap_resource Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-21 11:44 ` Ikjoon Jang
2021-07-21 11:44 ` Ikjoon Jang
2021-07-21 11:44 ` Ikjoon Jang
2021-07-21 11:44 ` Ikjoon Jang
2021-07-15 12:12 ` [PATCH v2 09/11] memory: mtk-smi: mt8195: Add smi support Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-21 12:39 ` Ikjoon Jang
2021-07-21 12:39 ` Ikjoon Jang
2021-07-21 12:39 ` Ikjoon Jang
2021-07-21 12:39 ` Ikjoon Jang
2021-07-15 12:12 ` [PATCH v2 10/11] memory: mtk-smi: mt8195: Add initial setting for smi-common Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-21 12:54 ` Ikjoon Jang
2021-07-21 12:54 ` Ikjoon Jang
2021-07-21 12:54 ` Ikjoon Jang
2021-07-21 12:54 ` Ikjoon Jang
2021-07-22 6:38 ` Yong Wu
2021-07-22 6:38 ` Yong Wu
2021-07-22 6:38 ` Yong Wu
2021-07-22 6:38 ` Yong Wu
2021-07-15 12:12 ` [PATCH v2 11/11] memory: mtk-smi: mt8195: Add initial setting for smi-larb Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-15 12:12 ` Yong Wu
2021-07-21 13:40 ` Ikjoon Jang
2021-07-21 13:40 ` Ikjoon Jang
2021-07-21 13:40 ` Ikjoon Jang
2021-07-21 13:40 ` Ikjoon Jang
2021-07-22 6:38 ` Yong Wu
2021-07-22 6:38 ` Yong Wu
2021-07-22 6:38 ` Yong Wu
2021-07-22 6:38 ` Yong Wu
2021-07-29 6:41 ` Yong Wu
2021-07-29 6:41 ` Yong Wu
2021-07-29 6:41 ` Yong Wu
2021-07-29 6:41 ` Yong Wu
2021-08-03 5:37 ` Ikjoon Jang
2021-08-03 5:37 ` Ikjoon Jang
2021-08-03 5:37 ` Ikjoon Jang
2021-08-03 5:37 ` Ikjoon Jang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210715121209.31024-7-yong.wu@mediatek.com \
--to=yong.wu@mediatek.com \
--cc=anan.sun@mediatek.com \
--cc=anthony.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=ming-fan.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=will@kernel.org \
--cc=yi.kuo@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.