All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Nicolas Pitre <nico@fluxnic.net>,
	"Keller, Jacob E" <jacob.e.keller@intel.com>,
	"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
	"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Kurt Kanzenbach <kurt@linutronix.de>,
	"Saleem, Shiraz" <shiraz.saleem@intel.com>,
	"Ertman, David M" <david.m.ertman@intel.com>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies
Date: Tue, 3 Aug 2021 09:14:34 -0700	[thread overview]
Message-ID: <20210803161434.GE32663@hoboy.vegasvil.org> (raw)
In-Reply-To: <20210803155556.GD32663@hoboy.vegasvil.org>

On Tue, Aug 03, 2021 at 08:55:56AM -0700, Richard Cochran wrote:
> On Tue, Aug 03, 2021 at 08:59:02AM +0200, Arnd Bergmann wrote:
> > It may well be a lost cause, but a build fix is not the time to nail down
> > that decision. The fix I proposed (with the added MAY_USE_PTP_1588_CLOCK
> > symbol) is only two extra lines and leaves everything else working for the
> > moment.
> 
> Well, then we'll have TWO ugly and incomprehensible Kconfig hacks,
> imply and MAY_USE.
> 
> Can't we fix this once and for all?
> 
> Seriously, "imply" has been nothing but a major PITA since day one,
> and all to save 22 kb.  I can't think of another subsystem which
> tolerates so much pain for so little gain.

Here is what I want to have, in accordance with the KISS principle:

config PTP_1588_CLOCK
	bool "PTP clock support"
	select NET
	select POSIX_TIMERS
	select PPS
	select NET_PTP_CLASSIFY

# driver variant 1:

config ACME_MAC
	select PTP_1588_CLOCK

# driver variant 2:

config ACME_MAC

config ACME_MAC_PTP
	depends on ACME_MAC
	select PTP_1588_CLOCK

Hm?	

Thanks,
Richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Cochran <richardcochran@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies
Date: Tue, 3 Aug 2021 09:14:34 -0700	[thread overview]
Message-ID: <20210803161434.GE32663@hoboy.vegasvil.org> (raw)
In-Reply-To: <20210803155556.GD32663@hoboy.vegasvil.org>

On Tue, Aug 03, 2021 at 08:55:56AM -0700, Richard Cochran wrote:
> On Tue, Aug 03, 2021 at 08:59:02AM +0200, Arnd Bergmann wrote:
> > It may well be a lost cause, but a build fix is not the time to nail down
> > that decision. The fix I proposed (with the added MAY_USE_PTP_1588_CLOCK
> > symbol) is only two extra lines and leaves everything else working for the
> > moment.
> 
> Well, then we'll have TWO ugly and incomprehensible Kconfig hacks,
> imply and MAY_USE.
> 
> Can't we fix this once and for all?
> 
> Seriously, "imply" has been nothing but a major PITA since day one,
> and all to save 22 kb.  I can't think of another subsystem which
> tolerates so much pain for so little gain.

Here is what I want to have, in accordance with the KISS principle:

config PTP_1588_CLOCK
	bool "PTP clock support"
	select NET
	select POSIX_TIMERS
	select PPS
	select NET_PTP_CLASSIFY

# driver variant 1:

config ACME_MAC
	select PTP_1588_CLOCK

# driver variant 2:

config ACME_MAC

config ACME_MAC_PTP
	depends on ACME_MAC
	select PTP_1588_CLOCK

Hm?	

Thanks,
Richard

  reply	other threads:[~2021-08-03 16:15 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 14:59 [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies Arnd Bergmann
2021-08-02 14:59 ` [Intel-wired-lan] " Arnd Bergmann
2021-08-02 16:49 ` Richard Cochran
2021-08-02 16:49   ` [Intel-wired-lan] " Richard Cochran
2021-08-02 19:54   ` Keller, Jacob E
2021-08-02 19:54     ` [Intel-wired-lan] " Keller, Jacob E
2021-08-02 20:32     ` Arnd Bergmann
2021-08-02 20:32       ` [Intel-wired-lan] " Arnd Bergmann
2021-08-02 20:46       ` Keller, Jacob E
2021-08-02 20:46         ` [Intel-wired-lan] " Keller, Jacob E
2021-08-02 20:59         ` Arnd Bergmann
2021-08-02 20:59           ` [Intel-wired-lan] " Arnd Bergmann
2021-08-02 21:09           ` Keller, Jacob E
2021-08-02 21:09             ` [Intel-wired-lan] " Keller, Jacob E
2021-08-02 21:10           ` Keller, Jacob E
2021-08-02 21:10             ` [Intel-wired-lan] " Keller, Jacob E
2021-08-02 21:22           ` Nicolas Pitre
2021-08-02 21:22             ` [Intel-wired-lan] " Nicolas Pitre
2021-08-03 20:29       ` Arnd Bergmann
2021-08-03 20:29         ` [Intel-wired-lan] " Arnd Bergmann
2021-08-02 23:09     ` Richard Cochran
2021-08-02 23:09       ` [Intel-wired-lan] " Richard Cochran
2021-08-02 23:45       ` Keller, Jacob E
2021-08-02 23:45         ` [Intel-wired-lan] " Keller, Jacob E
2021-08-03  0:03         ` Richard Cochran
2021-08-03  0:03           ` [Intel-wired-lan] " Richard Cochran
2021-08-03  6:59       ` Arnd Bergmann
2021-08-03  6:59         ` [Intel-wired-lan] " Arnd Bergmann
2021-08-03 15:55         ` Richard Cochran
2021-08-03 15:55           ` [Intel-wired-lan] " Richard Cochran
2021-08-03 16:14           ` Richard Cochran [this message]
2021-08-03 16:14             ` Richard Cochran
2021-08-03 17:00             ` Arnd Bergmann
2021-08-03 17:00               ` [Intel-wired-lan] " Arnd Bergmann
2021-08-03 17:18               ` Keller, Jacob E
2021-08-03 17:18                 ` [Intel-wired-lan] " Keller, Jacob E
2021-08-03 18:27                 ` Arnd Bergmann
2021-08-03 18:27                   ` [Intel-wired-lan] " Arnd Bergmann
2021-08-03 23:25                   ` Keller, Jacob E
2021-08-03 23:25                     ` [Intel-wired-lan] " Keller, Jacob E
2021-08-04 11:18                   ` Arnd Bergmann
2021-08-04 11:18                     ` [Intel-wired-lan] " Arnd Bergmann
2021-08-03 20:54               ` Richard Cochran
2021-08-03 20:54                 ` [Intel-wired-lan] " Richard Cochran
2021-08-04 20:53                 ` Keller, Jacob E
2021-08-04 20:53                   ` [Intel-wired-lan] " Keller, Jacob E

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210803161434.GE32663@hoboy.vegasvil.org \
    --to=richardcochran@gmail.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=davem@davemloft.net \
    --cc=david.m.ertman@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=kuba@kernel.org \
    --cc=kurt@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nico@fluxnic.net \
    --cc=shiraz.saleem@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.