Re: [RFC net-next 2/2] ice: add support for reading SyncE DPLL state

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3555 bytes --]

Hi Maciej,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Maciej-Machnikowski/Add-RTNL-interface-for-SyncE/20210829-052844
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git c77225119daa0ca0a9c6c007945c0a87b3e4a2e8
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/33c0c8824cc9dc9a42e2e71435e530a759843ac0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Maciej-Machnikowski/Add-RTNL-interface-for-SyncE/20210829-052844
        git checkout 33c0c8824cc9dc9a42e2e71435e530a759843ac0
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/intel/ice/ice_main.c: In function 'ice_get_synce_state':
>> drivers/net/ethernet/intel/ice/ice_main.c:5998:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
    5998 |         if (src)
         |         ^~
   drivers/net/ethernet/intel/ice/ice_main.c:6023:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
    6023 |                 if (pf->synce_dpll_state != IF_SYNCE_STATE_LOCKED)
         |                 ^~


vim +/if +5998 drivers/net/ethernet/intel/ice/ice_main.c

  5975	
  5976	/**
  5977	 * ice_get_synce_state - get state of SyncE DPLL
  5978	 * @netdev: network interface device structure
  5979	 * @state: state of SyncE DPLL
  5980	 * @src: source type driving SyncE DPLL
  5981	 * @pin_idx: index of pin driving SyncE DPLL
  5982	 */
  5983	static int
  5984	ice_get_synce_state(struct net_device *netdev, enum if_synce_state *state,
  5985			    enum if_synce_src *src, u8 *pin_idx)
  5986	{
  5987		struct ice_netdev_priv *np = netdev_priv(netdev);
  5988		struct ice_vsi *vsi = np->vsi;
  5989		struct ice_pf *pf = vsi->back;
  5990	
  5991		if (!ice_is_e810t(&pf->hw))
  5992			return -EOPNOTSUPP;
  5993	
  5994		if (state)
  5995			*state = pf->synce_dpll_state;
  5996		if (pin_idx) {
  5997			*pin_idx = pf->synce_dpll_pin;
> 5998		if (src)
  5999			switch (pf->synce_dpll_pin) {
  6000			case REF0P:
  6001			case REF0N:
  6002				*src = IF_SYNCE_SRC_PTP;
  6003				break;
  6004			case REF1P:
  6005			case REF1N:
  6006			case REF2P:
  6007			case REF2N:
  6008				*src = IF_SYNCE_SRC_SYNCE;
  6009				break;
  6010			case REF3P:
  6011			case REF3N:
  6012				*src = IF_SYNCE_SRC_EXT;
  6013				break;
  6014			case REF4P:
  6015				*src = IF_SYNCE_SRC_GNSS;
  6016				break;
  6017			default:
  6018				*src = IF_SYNCE_SRC_INVALID;
  6019				break;
  6020			}
  6021	
  6022			/* Always report invalid source if state is not Locked */
  6023			if (pf->synce_dpll_state != IF_SYNCE_STATE_LOCKED)
  6024				*src = IF_SYNCE_SRC_INVALID;
  6025		}
  6026	
  6027		return 0;
  6028	}
  6029	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 68269 bytes --]