From: Andrew Lunn <andrew@lunn.ch>
To: Maciej Machnikowski <maciej.machnikowski@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
richardcochran@gmail.com, abyagowi@fb.com,
anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [RFC net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message to get SyncE status
Date: Sat, 28 Aug 2021 23:55:53 +0200 [thread overview]
Message-ID: <YSqw6aJRrWbxRaas@lunn.ch> (raw)
In-Reply-To: <20210828211248.3337476-2-maciej.machnikowski@intel.com>
On Sat, Aug 28, 2021 at 11:12:47PM +0200, Maciej Machnikowski wrote:
> This patch adds the new RTM_GETSYNCESTATE message to query the status
> of SyncE syntonization on the device.
Hi Maciej
You use syntonization a few times. Is this a miss spelling for
synchronisation, or a SyncE terms?
> @@ -193,7 +196,7 @@ enum {
> #define RTM_NR_FAMILIES (RTM_NR_MSGTYPES >> 2)
> #define RTM_FAM(cmd) (((cmd) - RTM_BASE) >> 2)
>
> -/*
> +/*
> Generic structure for encapsulation of optional route information.
> It is reminiscent of sockaddr, but with sa_family replaced
> with attribute type.
> @@ -233,7 +236,7 @@ struct rtmsg {
>
> unsigned char rtm_table; /* Routing table id */
> unsigned char rtm_protocol; /* Routing protocol; see below */
> - unsigned char rtm_scope; /* See below */
> + unsigned char rtm_scope; /* See below */
> unsigned char rtm_type; /* See below */
>
> unsigned rtm_flags;
> @@ -555,7 +558,7 @@ struct ifinfomsg {
> };
>
> /********************************************************************
> - * prefix information
> + * prefix information
> ****/
>
> struct prefixmsg {
> @@ -569,7 +572,7 @@ struct prefixmsg {
> unsigned char prefix_pad3;
> };
>
> -enum
> +enum
> {
> PREFIX_UNSPEC,
> PREFIX_ADDRESS,
You appear to have a number of white space changes here. Please put
them into a separate patch, or drop them.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [RFC net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message to get SyncE status
Date: Sat, 28 Aug 2021 23:55:53 +0200 [thread overview]
Message-ID: <YSqw6aJRrWbxRaas@lunn.ch> (raw)
In-Reply-To: <20210828211248.3337476-2-maciej.machnikowski@intel.com>
On Sat, Aug 28, 2021 at 11:12:47PM +0200, Maciej Machnikowski wrote:
> This patch adds the new RTM_GETSYNCESTATE message to query the status
> of SyncE syntonization on the device.
Hi Maciej
You use syntonization a few times. Is this a miss spelling for
synchronisation, or a SyncE terms?
> @@ -193,7 +196,7 @@ enum {
> #define RTM_NR_FAMILIES (RTM_NR_MSGTYPES >> 2)
> #define RTM_FAM(cmd) (((cmd) - RTM_BASE) >> 2)
>
> -/*
> +/*
> Generic structure for encapsulation of optional route information.
> It is reminiscent of sockaddr, but with sa_family replaced
> with attribute type.
> @@ -233,7 +236,7 @@ struct rtmsg {
>
> unsigned char rtm_table; /* Routing table id */
> unsigned char rtm_protocol; /* Routing protocol; see below */
> - unsigned char rtm_scope; /* See below */
> + unsigned char rtm_scope; /* See below */
> unsigned char rtm_type; /* See below */
>
> unsigned rtm_flags;
> @@ -555,7 +558,7 @@ struct ifinfomsg {
> };
>
> /********************************************************************
> - * prefix information
> + * prefix information
> ****/
>
> struct prefixmsg {
> @@ -569,7 +572,7 @@ struct prefixmsg {
> unsigned char prefix_pad3;
> };
>
> -enum
> +enum
> {
> PREFIX_UNSPEC,
> PREFIX_ADDRESS,
You appear to have a number of white space changes here. Please put
them into a separate patch, or drop them.
Andrew
next prev parent reply other threads:[~2021-08-28 21:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 21:12 [RFC net-next 0/2] Add RTNL interface for SyncE Maciej Machnikowski
2021-08-28 21:12 ` [Intel-wired-lan] " Maciej Machnikowski
2021-08-28 21:12 ` [RFC net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message to get SyncE status Maciej Machnikowski
2021-08-28 21:12 ` [Intel-wired-lan] " Maciej Machnikowski
2021-08-28 21:55 ` Andrew Lunn [this message]
2021-08-28 21:55 ` Andrew Lunn
2021-08-29 8:19 ` Machnikowski, Maciej
2021-08-29 8:19 ` [Intel-wired-lan] " Machnikowski, Maciej
2021-08-28 23:34 ` kernel test robot
2021-08-28 23:34 ` kernel test robot
2021-08-28 21:12 ` [RFC net-next 2/2] ice: add support for reading SyncE DPLL state Maciej Machnikowski
2021-08-28 21:12 ` [Intel-wired-lan] " Maciej Machnikowski
2021-08-28 23:49 ` kernel test robot
2021-08-29 2:22 ` kernel test robot
2021-08-29 2:22 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSqw6aJRrWbxRaas@lunn.ch \
--to=andrew@lunn.ch \
--cc=abyagowi@fb.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.machnikowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.