All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Maciej Machnikowski <maciej.machnikowski@intel.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org
Subject: Re: [RFC net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message to get SyncE status
Date: Sun, 29 Aug 2021 07:34:20 +0800	[thread overview]
Message-ID: <202108290738.ardgtD2L-lkp@intel.com> (raw)
In-Reply-To: <20210828211248.3337476-2-maciej.machnikowski@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2894 bytes --]

Hi Maciej,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Maciej-Machnikowski/Add-RTNL-interface-for-SyncE/20210829-052844
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git c77225119daa0ca0a9c6c007945c0a87b3e4a2e8
config: hexagon-randconfig-r041-20210829 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4e1a164d7bd53653f79decc121afe784d2fde0a7)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/ff940b657759b1ab4cc875cb16b9de3c60cc7ae7
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Maciej-Machnikowski/Add-RTNL-interface-for-SyncE/20210829-052844
        git checkout ff940b657759b1ab4cc875cb16b9de3c60cc7ae7
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> net/core/rtnetlink.c:5537:15: warning: variable 'filter_mask' is uninitialized when used here [-Wuninitialized]
                                       NULL, filter_mask);
                                             ^~~~~~~~~~~
   net/core/rtnetlink.c:5519:17: note: initialize the variable 'filter_mask' to silence this warning
           u32 filter_mask;
                          ^
                           = 0
   1 warning generated.


vim +/filter_mask +5537 net/core/rtnetlink.c

  5511	
  5512	static int rtnl_synce_state_get(struct sk_buff *skb, struct nlmsghdr *nlh,
  5513					struct netlink_ext_ack *extack)
  5514	{
  5515		struct net *net = sock_net(skb->sk);
  5516		struct if_synce_state_msg *state;
  5517		struct net_device *dev = NULL;
  5518		struct sk_buff *nskb;
  5519		u32 filter_mask;
  5520		int err;
  5521	
  5522		state = nlmsg_data(nlh);
  5523		if (state->ifindex > 0)
  5524			dev = __dev_get_by_index(net, state->ifindex);
  5525		else
  5526			return -EINVAL;
  5527	
  5528		nskb = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
  5529		if (!nskb)
  5530			return -ENOBUFS;
  5531	
  5532		if (!dev)
  5533			return -ENODEV;
  5534	
  5535		err = rtnl_fill_synce_state(nskb, dev,
  5536					    NETLINK_CB(skb).portid, nlh->nlmsg_seq,
> 5537					    NULL, filter_mask);
  5538		if (err < 0)
  5539			kfree_skb(nskb);
  5540		else
  5541			err = rtnl_unicast(nskb, net, NETLINK_CB(skb).portid);
  5542	
  5543		return err;
  5544	}
  5545	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35465 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message to get SyncE status
Date: Sun, 29 Aug 2021 07:34:20 +0800	[thread overview]
Message-ID: <202108290738.ardgtD2L-lkp@intel.com> (raw)
In-Reply-To: <20210828211248.3337476-2-maciej.machnikowski@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2969 bytes --]

Hi Maciej,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Maciej-Machnikowski/Add-RTNL-interface-for-SyncE/20210829-052844
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git c77225119daa0ca0a9c6c007945c0a87b3e4a2e8
config: hexagon-randconfig-r041-20210829 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4e1a164d7bd53653f79decc121afe784d2fde0a7)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/ff940b657759b1ab4cc875cb16b9de3c60cc7ae7
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Maciej-Machnikowski/Add-RTNL-interface-for-SyncE/20210829-052844
        git checkout ff940b657759b1ab4cc875cb16b9de3c60cc7ae7
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> net/core/rtnetlink.c:5537:15: warning: variable 'filter_mask' is uninitialized when used here [-Wuninitialized]
                                       NULL, filter_mask);
                                             ^~~~~~~~~~~
   net/core/rtnetlink.c:5519:17: note: initialize the variable 'filter_mask' to silence this warning
           u32 filter_mask;
                          ^
                           = 0
   1 warning generated.


vim +/filter_mask +5537 net/core/rtnetlink.c

  5511	
  5512	static int rtnl_synce_state_get(struct sk_buff *skb, struct nlmsghdr *nlh,
  5513					struct netlink_ext_ack *extack)
  5514	{
  5515		struct net *net = sock_net(skb->sk);
  5516		struct if_synce_state_msg *state;
  5517		struct net_device *dev = NULL;
  5518		struct sk_buff *nskb;
  5519		u32 filter_mask;
  5520		int err;
  5521	
  5522		state = nlmsg_data(nlh);
  5523		if (state->ifindex > 0)
  5524			dev = __dev_get_by_index(net, state->ifindex);
  5525		else
  5526			return -EINVAL;
  5527	
  5528		nskb = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
  5529		if (!nskb)
  5530			return -ENOBUFS;
  5531	
  5532		if (!dev)
  5533			return -ENODEV;
  5534	
  5535		err = rtnl_fill_synce_state(nskb, dev,
  5536					    NETLINK_CB(skb).portid, nlh->nlmsg_seq,
> 5537					    NULL, filter_mask);
  5538		if (err < 0)
  5539			kfree_skb(nskb);
  5540		else
  5541			err = rtnl_unicast(nskb, net, NETLINK_CB(skb).portid);
  5542	
  5543		return err;
  5544	}
  5545	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35465 bytes --]

  parent reply	other threads:[~2021-08-28 23:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-28 21:12 [RFC net-next 0/2] Add RTNL interface for SyncE Maciej Machnikowski
2021-08-28 21:12 ` [Intel-wired-lan] " Maciej Machnikowski
2021-08-28 21:12 ` [RFC net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message to get SyncE status Maciej Machnikowski
2021-08-28 21:12   ` [Intel-wired-lan] " Maciej Machnikowski
2021-08-28 21:55   ` Andrew Lunn
2021-08-28 21:55     ` [Intel-wired-lan] " Andrew Lunn
2021-08-29  8:19     ` Machnikowski, Maciej
2021-08-29  8:19       ` [Intel-wired-lan] " Machnikowski, Maciej
2021-08-28 23:34   ` kernel test robot [this message]
2021-08-28 23:34     ` kernel test robot
2021-08-28 21:12 ` [RFC net-next 2/2] ice: add support for reading SyncE DPLL state Maciej Machnikowski
2021-08-28 21:12   ` [Intel-wired-lan] " Maciej Machnikowski
2021-08-28 23:49   ` kernel test robot
2021-08-29  2:22   ` kernel test robot
2021-08-29  2:22     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202108290738.ardgtD2L-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=llvm@lists.linux.dev \
    --cc=maciej.machnikowski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.