From: "Machnikowski, Maciej" <maciej.machnikowski@intel.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"richardcochran@gmail.com" <richardcochran@gmail.com>,
"abyagowi@fb.com" <abyagowi@fb.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>
Subject: RE: [RFC net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message to get SyncE status
Date: Sun, 29 Aug 2021 08:19:54 +0000 [thread overview]
Message-ID: <PH0PR11MB49514899CD7CE514E792CE40EACA9@PH0PR11MB4951.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YSqw6aJRrWbxRaas@lunn.ch>
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Saturday, August 28, 2021 11:56 PM
> To: Machnikowski, Maciej <maciej.machnikowski@intel.com>
> Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org;
> richardcochran@gmail.com; abyagowi@fb.com; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; davem@davemloft.net; kuba@kernel.org;
> linux-kselftest@vger.kernel.org
> Subject: Re: [RFC net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE
> message to get SyncE status
>
> On Sat, Aug 28, 2021 at 11:12:47PM +0200, Maciej Machnikowski wrote:
> > This patch adds the new RTM_GETSYNCESTATE message to query the
> status
> > of SyncE syntonization on the device.
>
> Hi Maciej
>
> You use syntonization a few times. Is this a miss spelling for synchronisation,
> or a SyncE terms?
Hi! Thanks for your comments!
Syntonization is a specific term for frequency synchronization.
> >
> > struct prefixmsg {
> > @@ -569,7 +572,7 @@ struct prefixmsg {
> > unsigned char prefix_pad3;
> > };
> >
> > -enum
> > +enum
> > {
> > PREFIX_UNSPEC,
> > PREFIX_ADDRESS,
>
> You appear to have a number of white space changes here. Please put them
> into a separate patch, or drop them.
Will fix and resubmit along with the fix for issues found by the robot
Thanks!
Maciek
>
> Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Machnikowski, Maciej <maciej.machnikowski@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [RFC net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message to get SyncE status
Date: Sun, 29 Aug 2021 08:19:54 +0000 [thread overview]
Message-ID: <PH0PR11MB49514899CD7CE514E792CE40EACA9@PH0PR11MB4951.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YSqw6aJRrWbxRaas@lunn.ch>
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Saturday, August 28, 2021 11:56 PM
> To: Machnikowski, Maciej <maciej.machnikowski@intel.com>
> Cc: netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org;
> richardcochran at gmail.com; abyagowi at fb.com; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; davem at davemloft.net; kuba at kernel.org;
> linux-kselftest at vger.kernel.org
> Subject: Re: [RFC net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE
> message to get SyncE status
>
> On Sat, Aug 28, 2021 at 11:12:47PM +0200, Maciej Machnikowski wrote:
> > This patch adds the new RTM_GETSYNCESTATE message to query the
> status
> > of SyncE syntonization on the device.
>
> Hi Maciej
>
> You use syntonization a few times. Is this a miss spelling for synchronisation,
> or a SyncE terms?
Hi! Thanks for your comments!
Syntonization is a specific term for frequency synchronization.
> >
> > struct prefixmsg {
> > @@ -569,7 +572,7 @@ struct prefixmsg {
> > unsigned char prefix_pad3;
> > };
> >
> > -enum
> > +enum
> > {
> > PREFIX_UNSPEC,
> > PREFIX_ADDRESS,
>
> You appear to have a number of white space changes here. Please put them
> into a separate patch, or drop them.
Will fix and resubmit along with the fix for issues found by the robot
Thanks!
Maciek
>
> Andrew
next prev parent reply other threads:[~2021-08-29 8:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 21:12 [RFC net-next 0/2] Add RTNL interface for SyncE Maciej Machnikowski
2021-08-28 21:12 ` [Intel-wired-lan] " Maciej Machnikowski
2021-08-28 21:12 ` [RFC net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message to get SyncE status Maciej Machnikowski
2021-08-28 21:12 ` [Intel-wired-lan] " Maciej Machnikowski
2021-08-28 21:55 ` Andrew Lunn
2021-08-28 21:55 ` [Intel-wired-lan] " Andrew Lunn
2021-08-29 8:19 ` Machnikowski, Maciej [this message]
2021-08-29 8:19 ` Machnikowski, Maciej
2021-08-28 23:34 ` kernel test robot
2021-08-28 23:34 ` kernel test robot
2021-08-28 21:12 ` [RFC net-next 2/2] ice: add support for reading SyncE DPLL state Maciej Machnikowski
2021-08-28 21:12 ` [Intel-wired-lan] " Maciej Machnikowski
2021-08-28 23:49 ` kernel test robot
2021-08-29 2:22 ` kernel test robot
2021-08-29 2:22 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB49514899CD7CE514E792CE40EACA9@PH0PR11MB4951.namprd11.prod.outlook.com \
--to=maciej.machnikowski@intel.com \
--cc=abyagowi@fb.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.