All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lyude Paul <lyude@redhat.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	nouveau@lists.freedesktop.org
Cc: Ben Skeggs <bskeggs@redhat.com>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v3 2/5] drm/nouveau/kms/nv50-: Explicitly check DPCD backlights for aux enable/brightness
Date: Tue,  5 Oct 2021 22:40:15 -0400	[thread overview]
Message-ID: <20211006024018.320394-3-lyude@redhat.com> (raw)
In-Reply-To: <20211006024018.320394-1-lyude@redhat.com>

Since we don't support hybrid AUX/PWM backlights in nouveau right now,
let's add some explicit checks so that we don't break nouveau once we
enable support for these backlights in other drivers.

Signed-off-by: Lyude Paul <lyude@redhat.com>
---
 drivers/gpu/drm/nouveau/nouveau_backlight.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/nouveau_backlight.c
index 1cbd71abc80a..ae2f2abc8f5a 100644
--- a/drivers/gpu/drm/nouveau/nouveau_backlight.c
+++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c
@@ -308,7 +308,10 @@ nv50_backlight_init(struct nouveau_backlight *bl,
 		if (ret < 0)
 			return ret;
 
-		if (drm_edp_backlight_supported(edp_dpcd)) {
+		/* TODO: Add support for hybrid PWM/DPCD panels */
+		if (drm_edp_backlight_supported(edp_dpcd) &&
+		    (edp_dpcd[1] & DP_EDP_BACKLIGHT_AUX_ENABLE_CAP) &&
+		    (edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP)) {
 			NV_DEBUG(drm, "DPCD backlight controls supported on %s\n",
 				 nv_conn->base.name);
 
-- 
2.31.1


WARNING: multiple messages have this Message-ID (diff)
From: Lyude Paul <lyude@redhat.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	nouveau@lists.freedesktop.org
Cc: Ben Skeggs <bskeggs@redhat.com>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	linux-kernel@vger.kernel.org (open list)
Subject: [Nouveau] [PATCH v3 2/5] drm/nouveau/kms/nv50-: Explicitly check DPCD backlights for aux enable/brightness
Date: Tue,  5 Oct 2021 22:40:15 -0400	[thread overview]
Message-ID: <20211006024018.320394-3-lyude@redhat.com> (raw)
In-Reply-To: <20211006024018.320394-1-lyude@redhat.com>

Since we don't support hybrid AUX/PWM backlights in nouveau right now,
let's add some explicit checks so that we don't break nouveau once we
enable support for these backlights in other drivers.

Signed-off-by: Lyude Paul <lyude@redhat.com>
---
 drivers/gpu/drm/nouveau/nouveau_backlight.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/nouveau_backlight.c
index 1cbd71abc80a..ae2f2abc8f5a 100644
--- a/drivers/gpu/drm/nouveau/nouveau_backlight.c
+++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c
@@ -308,7 +308,10 @@ nv50_backlight_init(struct nouveau_backlight *bl,
 		if (ret < 0)
 			return ret;
 
-		if (drm_edp_backlight_supported(edp_dpcd)) {
+		/* TODO: Add support for hybrid PWM/DPCD panels */
+		if (drm_edp_backlight_supported(edp_dpcd) &&
+		    (edp_dpcd[1] & DP_EDP_BACKLIGHT_AUX_ENABLE_CAP) &&
+		    (edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP)) {
 			NV_DEBUG(drm, "DPCD backlight controls supported on %s\n",
 				 nv_conn->base.name);
 
-- 
2.31.1


WARNING: multiple messages have this Message-ID (diff)
From: Lyude Paul <lyude@redhat.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	nouveau@lists.freedesktop.org
Cc: Ben Skeggs <bskeggs@redhat.com>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	linux-kernel@vger.kernel.org (open list)
Subject: [Intel-gfx] [PATCH v3 2/5] drm/nouveau/kms/nv50-: Explicitly check DPCD backlights for aux enable/brightness
Date: Tue,  5 Oct 2021 22:40:15 -0400	[thread overview]
Message-ID: <20211006024018.320394-3-lyude@redhat.com> (raw)
In-Reply-To: <20211006024018.320394-1-lyude@redhat.com>

Since we don't support hybrid AUX/PWM backlights in nouveau right now,
let's add some explicit checks so that we don't break nouveau once we
enable support for these backlights in other drivers.

Signed-off-by: Lyude Paul <lyude@redhat.com>
---
 drivers/gpu/drm/nouveau/nouveau_backlight.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/nouveau_backlight.c
index 1cbd71abc80a..ae2f2abc8f5a 100644
--- a/drivers/gpu/drm/nouveau/nouveau_backlight.c
+++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c
@@ -308,7 +308,10 @@ nv50_backlight_init(struct nouveau_backlight *bl,
 		if (ret < 0)
 			return ret;
 
-		if (drm_edp_backlight_supported(edp_dpcd)) {
+		/* TODO: Add support for hybrid PWM/DPCD panels */
+		if (drm_edp_backlight_supported(edp_dpcd) &&
+		    (edp_dpcd[1] & DP_EDP_BACKLIGHT_AUX_ENABLE_CAP) &&
+		    (edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP)) {
 			NV_DEBUG(drm, "DPCD backlight controls supported on %s\n",
 				 nv_conn->base.name);
 
-- 
2.31.1


  parent reply	other threads:[~2021-10-06  2:41 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06  2:40 [Nouveau] [PATCH v3 0/5] drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers Lyude Paul
2021-10-06  2:40 ` [Intel-gfx] " Lyude Paul
2021-10-06  2:40 ` Lyude Paul
2021-10-06  2:40 ` [PATCH v3 1/5] drm/i915: Add support for panels with VESA backlights with PWM enable/disable Lyude Paul
2021-10-06  2:40   ` [Nouveau] " Lyude Paul
2021-10-06  2:40   ` [Intel-gfx] " Lyude Paul
2021-10-19 18:09   ` Ville Syrjälä
2021-10-19 18:09     ` [Intel-gfx] " Ville Syrjälä
2021-10-19 18:09     ` [Nouveau] " Ville Syrjälä
2021-10-20 21:30     ` Lyude Paul
2021-10-20 21:30       ` [Intel-gfx] " Lyude Paul
2021-10-20 21:30       ` [Nouveau] " Lyude Paul
2021-10-06  2:40 ` Lyude Paul [this message]
2021-10-06  2:40   ` [Intel-gfx] [PATCH v3 2/5] drm/nouveau/kms/nv50-: Explicitly check DPCD backlights for aux enable/brightness Lyude Paul
2021-10-06  2:40   ` [Nouveau] " Lyude Paul
2021-10-06 16:30   ` Karol Herbst
2021-10-06 16:30     ` [Intel-gfx] " Karol Herbst
2021-10-06 20:14     ` Lyude Paul
2021-10-06 20:14       ` [Intel-gfx] " Lyude Paul
2021-10-06  2:40 ` [PATCH v3 3/5] drm/dp: Disable unsupported features in DP_EDP_BACKLIGHT_MODE_SET_REGISTER Lyude Paul
2021-10-06  2:40   ` [Intel-gfx] " Lyude Paul
2021-10-06  2:40   ` [Nouveau] " Lyude Paul
2021-10-06  2:40 ` [PATCH v3 4/5] drm/dp, drm/i915: Add support for VESA backlights using PWM for brightness control Lyude Paul
2021-10-06  2:40   ` [Intel-gfx] " Lyude Paul
2021-10-06  2:40   ` [Nouveau] " Lyude Paul
2021-10-12 20:45   ` Doug Anderson
2021-10-12 20:45     ` [Nouveau] " Doug Anderson
2021-10-12 20:45     ` [Intel-gfx] " Doug Anderson
2021-10-06  2:40 ` [PATCH v3 5/5] drm/i915: Clarify probing order in intel_dp_aux_init_backlight_funcs() Lyude Paul
2021-10-06  2:40   ` [Intel-gfx] " Lyude Paul
2021-10-06  2:40   ` [Nouveau] " Lyude Paul
2021-10-19 18:15   ` Ville Syrjälä
2021-10-19 18:15     ` [Intel-gfx] " Ville Syrjälä
2021-10-19 18:15     ` [Nouveau] " Ville Syrjälä
2021-10-06  3:27 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev4) Patchwork
2021-10-06  3:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-10-06  9:11 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-06 16:15 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev5) Patchwork
2021-10-06 16:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-10-06 19:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-06 21:36 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev6) Patchwork
2021-10-06 22:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-10-06 23:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-07 20:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev7) Patchwork
2021-10-07 20:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-10-07 23:13 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-08 21:55 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev8) Patchwork
2021-10-08 22:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-10-09  1:58 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-11 18:50   ` Lyude Paul
2021-10-11 21:37 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev9) Patchwork
2021-10-11 22:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-10-12  2:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211006024018.320394-3-lyude@redhat.com \
    --to=lyude@redhat.com \
    --cc=airlied@linux.ie \
    --cc=bskeggs@redhat.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.