From: Lyude Paul <lyude@redhat.com> To: Karol Herbst <kherbst@redhat.com> Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, dri-devel <dri-devel@lists.freedesktop.org>, nouveau <nouveau@lists.freedesktop.org>, Ben Skeggs <bskeggs@redhat.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, open list <linux-kernel@vger.kernel.org> Subject: Re: [Nouveau] [PATCH v3 2/5] drm/nouveau/kms/nv50-: Explicitly check DPCD backlights for aux enable/brightness Date: Wed, 06 Oct 2021 16:14:31 -0400 [thread overview] Message-ID: <f9c4bd7a1ac1a43a4cd2cde8e6d23a60a245b7e7.camel@redhat.com> (raw) In-Reply-To: <CACO55tuMWVgsd44s1sAvgrKDHFZT2Z3F+CSqAh34_XaekYWuHA@mail.gmail.com> On Wed, 2021-10-06 at 18:30 +0200, Karol Herbst wrote: > On Wed, Oct 6, 2021 at 4:41 AM Lyude Paul <lyude@redhat.com> wrote: > > > > Since we don't support hybrid AUX/PWM backlights in nouveau right now, > > let's add some explicit checks so that we don't break nouveau once we > > enable support for these backlights in other drivers. > > > > Signed-off-by: Lyude Paul <lyude@redhat.com> > > --- > > drivers/gpu/drm/nouveau/nouveau_backlight.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c > > b/drivers/gpu/drm/nouveau/nouveau_backlight.c > > index 1cbd71abc80a..ae2f2abc8f5a 100644 > > --- a/drivers/gpu/drm/nouveau/nouveau_backlight.c > > +++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c > > @@ -308,7 +308,10 @@ nv50_backlight_init(struct nouveau_backlight *bl, > > if (ret < 0) > > return ret; > > > > - if (drm_edp_backlight_supported(edp_dpcd)) { > > + /* TODO: Add support for hybrid PWM/DPCD panels */ > > + if (drm_edp_backlight_supported(edp_dpcd) && > > + (edp_dpcd[1] & DP_EDP_BACKLIGHT_AUX_ENABLE_CAP) && > > where does the DP_EDP_BACKLIGHT_AUX_ENABLE_CAP come from? afaik > drm_edp_backlight_supported checks for > DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP and > DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP so wondering if this was > intentional or a typo This is intentional - drm_edp_backlight_supported() does check for these, but in the patch after this we remove the BRIGHTNESS_AUX_SET_CAP from drm_edp_backlight_supported() in order to implement support for panels lacking BRIGHTNESS_AUX_SET_CAP in i915. Since we don't have support for this in nouveau yet but such backlights are likely to mostly work without the use of DPCD if we avoid trying to set it up, this patch is just here to make sure that the changes to drm_edp_backlight_supported() don't result in nouveau suddenly trying (and failing) to enable DPCD backlight controls on those backlights. > > > + (edp_dpcd[2] & > > DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP)) { > > NV_DEBUG(drm, "DPCD backlight controls supported > > on %s\n", > > nv_conn->base.name); > > > > -- > > 2.31.1 > > > -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat
WARNING: multiple messages have this Message-ID (diff)
From: Lyude Paul <lyude@redhat.com> To: Karol Herbst <kherbst@redhat.com> Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, dri-devel <dri-devel@lists.freedesktop.org>, nouveau <nouveau@lists.freedesktop.org>, Ben Skeggs <bskeggs@redhat.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, open list <linux-kernel@vger.kernel.org> Subject: Re: [Intel-gfx] [Nouveau] [PATCH v3 2/5] drm/nouveau/kms/nv50-: Explicitly check DPCD backlights for aux enable/brightness Date: Wed, 06 Oct 2021 16:14:31 -0400 [thread overview] Message-ID: <f9c4bd7a1ac1a43a4cd2cde8e6d23a60a245b7e7.camel@redhat.com> (raw) In-Reply-To: <CACO55tuMWVgsd44s1sAvgrKDHFZT2Z3F+CSqAh34_XaekYWuHA@mail.gmail.com> On Wed, 2021-10-06 at 18:30 +0200, Karol Herbst wrote: > On Wed, Oct 6, 2021 at 4:41 AM Lyude Paul <lyude@redhat.com> wrote: > > > > Since we don't support hybrid AUX/PWM backlights in nouveau right now, > > let's add some explicit checks so that we don't break nouveau once we > > enable support for these backlights in other drivers. > > > > Signed-off-by: Lyude Paul <lyude@redhat.com> > > --- > > drivers/gpu/drm/nouveau/nouveau_backlight.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c > > b/drivers/gpu/drm/nouveau/nouveau_backlight.c > > index 1cbd71abc80a..ae2f2abc8f5a 100644 > > --- a/drivers/gpu/drm/nouveau/nouveau_backlight.c > > +++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c > > @@ -308,7 +308,10 @@ nv50_backlight_init(struct nouveau_backlight *bl, > > if (ret < 0) > > return ret; > > > > - if (drm_edp_backlight_supported(edp_dpcd)) { > > + /* TODO: Add support for hybrid PWM/DPCD panels */ > > + if (drm_edp_backlight_supported(edp_dpcd) && > > + (edp_dpcd[1] & DP_EDP_BACKLIGHT_AUX_ENABLE_CAP) && > > where does the DP_EDP_BACKLIGHT_AUX_ENABLE_CAP come from? afaik > drm_edp_backlight_supported checks for > DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP and > DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP so wondering if this was > intentional or a typo This is intentional - drm_edp_backlight_supported() does check for these, but in the patch after this we remove the BRIGHTNESS_AUX_SET_CAP from drm_edp_backlight_supported() in order to implement support for panels lacking BRIGHTNESS_AUX_SET_CAP in i915. Since we don't have support for this in nouveau yet but such backlights are likely to mostly work without the use of DPCD if we avoid trying to set it up, this patch is just here to make sure that the changes to drm_edp_backlight_supported() don't result in nouveau suddenly trying (and failing) to enable DPCD backlight controls on those backlights. > > > + (edp_dpcd[2] & > > DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP)) { > > NV_DEBUG(drm, "DPCD backlight controls supported > > on %s\n", > > nv_conn->base.name); > > > > -- > > 2.31.1 > > > -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat
next prev parent reply other threads:[~2021-10-06 20:14 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-06 2:40 [Nouveau] [PATCH v3 0/5] drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers Lyude Paul 2021-10-06 2:40 ` [Intel-gfx] " Lyude Paul 2021-10-06 2:40 ` Lyude Paul 2021-10-06 2:40 ` [PATCH v3 1/5] drm/i915: Add support for panels with VESA backlights with PWM enable/disable Lyude Paul 2021-10-06 2:40 ` [Nouveau] " Lyude Paul 2021-10-06 2:40 ` [Intel-gfx] " Lyude Paul 2021-10-19 18:09 ` Ville Syrjälä 2021-10-19 18:09 ` [Intel-gfx] " Ville Syrjälä 2021-10-19 18:09 ` [Nouveau] " Ville Syrjälä 2021-10-20 21:30 ` Lyude Paul 2021-10-20 21:30 ` [Intel-gfx] " Lyude Paul 2021-10-20 21:30 ` [Nouveau] " Lyude Paul 2021-10-06 2:40 ` [PATCH v3 2/5] drm/nouveau/kms/nv50-: Explicitly check DPCD backlights for aux enable/brightness Lyude Paul 2021-10-06 2:40 ` [Intel-gfx] " Lyude Paul 2021-10-06 2:40 ` [Nouveau] " Lyude Paul 2021-10-06 16:30 ` Karol Herbst 2021-10-06 16:30 ` [Intel-gfx] " Karol Herbst 2021-10-06 20:14 ` Lyude Paul [this message] 2021-10-06 20:14 ` Lyude Paul 2021-10-06 2:40 ` [PATCH v3 3/5] drm/dp: Disable unsupported features in DP_EDP_BACKLIGHT_MODE_SET_REGISTER Lyude Paul 2021-10-06 2:40 ` [Intel-gfx] " Lyude Paul 2021-10-06 2:40 ` [Nouveau] " Lyude Paul 2021-10-06 2:40 ` [PATCH v3 4/5] drm/dp, drm/i915: Add support for VESA backlights using PWM for brightness control Lyude Paul 2021-10-06 2:40 ` [Intel-gfx] " Lyude Paul 2021-10-06 2:40 ` [Nouveau] " Lyude Paul 2021-10-12 20:45 ` Doug Anderson 2021-10-12 20:45 ` [Nouveau] " Doug Anderson 2021-10-12 20:45 ` [Intel-gfx] " Doug Anderson 2021-10-06 2:40 ` [PATCH v3 5/5] drm/i915: Clarify probing order in intel_dp_aux_init_backlight_funcs() Lyude Paul 2021-10-06 2:40 ` [Intel-gfx] " Lyude Paul 2021-10-06 2:40 ` [Nouveau] " Lyude Paul 2021-10-19 18:15 ` Ville Syrjälä 2021-10-19 18:15 ` [Intel-gfx] " Ville Syrjälä 2021-10-19 18:15 ` [Nouveau] " Ville Syrjälä 2021-10-06 3:27 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev4) Patchwork 2021-10-06 3:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-10-06 9:11 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-10-06 16:15 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev5) Patchwork 2021-10-06 16:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-10-06 19:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-10-06 21:36 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev6) Patchwork 2021-10-06 22:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-10-06 23:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-10-07 20:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev7) Patchwork 2021-10-07 20:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-10-07 23:13 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-10-08 21:55 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev8) Patchwork 2021-10-08 22:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-10-09 1:58 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-10-11 18:50 ` Lyude Paul 2021-10-11 21:37 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev9) Patchwork 2021-10-11 22:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-10-12 2:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f9c4bd7a1ac1a43a4cd2cde8e6d23a60a245b7e7.camel@redhat.com \ --to=lyude@redhat.com \ --cc=airlied@linux.ie \ --cc=bskeggs@redhat.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=kherbst@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=nouveau@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.