* [PATCH v2] arm64: dts: imx8mm-venice-gw7901.dts: disable pgc_gpumix
@ 2021-10-06 15:38 ` Tim Harvey
0 siblings, 0 replies; 6+ messages in thread
From: Tim Harvey @ 2021-10-06 15:38 UTC (permalink / raw)
To: Shawn Guo, Rob Herring, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, linux-arm-kernel, linux-kernel
Cc: Tim Harvey
Since commit b21269b12e48 ("arm64: dts: imx8mm: add GPC node") the
GW7901 will hang during kernel init because it does not power the unused
GPU voltage rails on the IMX8MM. Disable pgc_gpumix to work around this.
We also disable the GPU devices that depend on the gpumix power domain
and pgc_gpu to avoid them staying in a probe deferred state forever.
Additionally as the MIPI voltage rail is also not connected on this
board we disable pgc_mipi and disp_blk_ctrl.
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
v2:
- also disable pgc_gpu to keep gpu from getting in probe deferred state
- also disable pgc_mipi and disp_blk_ctrl as the MIPI power rails are
not connected
---
.../dts/freescale/imx8mm-venice-gw7901.dts | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
index bafd5c8ea4e2..21c546c4628d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
@@ -255,6 +255,10 @@
};
};
+&disp_blk_ctrl {
+ status = "disabled";
+};
+
&ecspi1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_spi1>;
@@ -282,6 +286,14 @@
};
};
+&gpu_2d {
+ status = "disabled";
+};
+
+&gpu_3d {
+ status = "disabled";
+};
+
&i2c1 {
clock-frequency = <100000>;
pinctrl-names = "default";
@@ -632,6 +644,18 @@
status = "okay";
};
+&pgc_gpu {
+ status = "disabled";
+};
+
+&pgc_gpumix {
+ status = "disabled";
+};
+
+&pgc_mipi {
+ status = "disabled";
+};
+
&uart1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart1>, <&pinctrl_uart1_gpio>;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2] arm64: dts: imx8mm-venice-gw7901.dts: disable pgc_gpumix
@ 2021-10-06 15:38 ` Tim Harvey
0 siblings, 0 replies; 6+ messages in thread
From: Tim Harvey @ 2021-10-06 15:38 UTC (permalink / raw)
To: Shawn Guo, Rob Herring, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, linux-arm-kernel, linux-kernel
Cc: Tim Harvey
Since commit b21269b12e48 ("arm64: dts: imx8mm: add GPC node") the
GW7901 will hang during kernel init because it does not power the unused
GPU voltage rails on the IMX8MM. Disable pgc_gpumix to work around this.
We also disable the GPU devices that depend on the gpumix power domain
and pgc_gpu to avoid them staying in a probe deferred state forever.
Additionally as the MIPI voltage rail is also not connected on this
board we disable pgc_mipi and disp_blk_ctrl.
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
v2:
- also disable pgc_gpu to keep gpu from getting in probe deferred state
- also disable pgc_mipi and disp_blk_ctrl as the MIPI power rails are
not connected
---
.../dts/freescale/imx8mm-venice-gw7901.dts | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
index bafd5c8ea4e2..21c546c4628d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
@@ -255,6 +255,10 @@
};
};
+&disp_blk_ctrl {
+ status = "disabled";
+};
+
&ecspi1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_spi1>;
@@ -282,6 +286,14 @@
};
};
+&gpu_2d {
+ status = "disabled";
+};
+
+&gpu_3d {
+ status = "disabled";
+};
+
&i2c1 {
clock-frequency = <100000>;
pinctrl-names = "default";
@@ -632,6 +644,18 @@
status = "okay";
};
+&pgc_gpu {
+ status = "disabled";
+};
+
+&pgc_gpumix {
+ status = "disabled";
+};
+
+&pgc_mipi {
+ status = "disabled";
+};
+
&uart1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart1>, <&pinctrl_uart1_gpio>;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] arm64: dts: imx8mm-venice-gw7901.dts: disable pgc_gpumix
2021-10-06 15:38 ` Tim Harvey
@ 2021-10-06 16:26 ` Lucas Stach
-1 siblings, 0 replies; 6+ messages in thread
From: Lucas Stach @ 2021-10-06 16:26 UTC (permalink / raw)
To: Tim Harvey, Shawn Guo, Rob Herring, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
linux-arm-kernel, linux-kernel
Am Mittwoch, dem 06.10.2021 um 08:38 -0700 schrieb Tim Harvey:
> Since commit b21269b12e48 ("arm64: dts: imx8mm: add GPC node") the
> GW7901 will hang during kernel init because it does not power the unused
> GPU voltage rails on the IMX8MM. Disable pgc_gpumix to work around this.
>
> We also disable the GPU devices that depend on the gpumix power domain
> and pgc_gpu to avoid them staying in a probe deferred state forever.
>
> Additionally as the MIPI voltage rail is also not connected on this
> board we disable pgc_mipi and disp_blk_ctrl.
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> v2:
> - also disable pgc_gpu to keep gpu from getting in probe deferred state
> - also disable pgc_mipi and disp_blk_ctrl as the MIPI power rails are
> not connected
> ---
> .../dts/freescale/imx8mm-venice-gw7901.dts | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> index bafd5c8ea4e2..21c546c4628d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> @@ -255,6 +255,10 @@
> };
> };
>
> +&disp_blk_ctrl {
> + status = "disabled";
> +};
> +
> &ecspi1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_spi1>;
> @@ -282,6 +286,14 @@
> };
> };
>
> +&gpu_2d {
> + status = "disabled";
> +};
> +
> +&gpu_3d {
> + status = "disabled";
> +};
> +
> &i2c1 {
> clock-frequency = <100000>;
> pinctrl-names = "default";
> @@ -632,6 +644,18 @@
> status = "okay";
> };
>
> +&pgc_gpu {
> + status = "disabled";
> +};
> +
> +&pgc_gpumix {
> + status = "disabled";
> +};
> +
> +&pgc_mipi {
> + status = "disabled";
> +};
> +
> &uart1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_uart1>, <&pinctrl_uart1_gpio>;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] arm64: dts: imx8mm-venice-gw7901.dts: disable pgc_gpumix
@ 2021-10-06 16:26 ` Lucas Stach
0 siblings, 0 replies; 6+ messages in thread
From: Lucas Stach @ 2021-10-06 16:26 UTC (permalink / raw)
To: Tim Harvey, Shawn Guo, Rob Herring, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
linux-arm-kernel, linux-kernel
Am Mittwoch, dem 06.10.2021 um 08:38 -0700 schrieb Tim Harvey:
> Since commit b21269b12e48 ("arm64: dts: imx8mm: add GPC node") the
> GW7901 will hang during kernel init because it does not power the unused
> GPU voltage rails on the IMX8MM. Disable pgc_gpumix to work around this.
>
> We also disable the GPU devices that depend on the gpumix power domain
> and pgc_gpu to avoid them staying in a probe deferred state forever.
>
> Additionally as the MIPI voltage rail is also not connected on this
> board we disable pgc_mipi and disp_blk_ctrl.
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> v2:
> - also disable pgc_gpu to keep gpu from getting in probe deferred state
> - also disable pgc_mipi and disp_blk_ctrl as the MIPI power rails are
> not connected
> ---
> .../dts/freescale/imx8mm-venice-gw7901.dts | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> index bafd5c8ea4e2..21c546c4628d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> @@ -255,6 +255,10 @@
> };
> };
>
> +&disp_blk_ctrl {
> + status = "disabled";
> +};
> +
> &ecspi1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_spi1>;
> @@ -282,6 +286,14 @@
> };
> };
>
> +&gpu_2d {
> + status = "disabled";
> +};
> +
> +&gpu_3d {
> + status = "disabled";
> +};
> +
> &i2c1 {
> clock-frequency = <100000>;
> pinctrl-names = "default";
> @@ -632,6 +644,18 @@
> status = "okay";
> };
>
> +&pgc_gpu {
> + status = "disabled";
> +};
> +
> +&pgc_gpumix {
> + status = "disabled";
> +};
> +
> +&pgc_mipi {
> + status = "disabled";
> +};
> +
> &uart1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_uart1>, <&pinctrl_uart1_gpio>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: imx8mm-venice-gw7901.dts: disable pgc_gpumix
2021-10-06 15:38 ` Tim Harvey
@ 2021-10-15 2:43 ` Shawn Guo
-1 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2021-10-15 2:43 UTC (permalink / raw)
To: Tim Harvey
Cc: Rob Herring, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, linux-arm-kernel, linux-kernel
On Wed, Oct 06, 2021 at 08:38:36AM -0700, Tim Harvey wrote:
> Since commit b21269b12e48 ("arm64: dts: imx8mm: add GPC node") the
> GW7901 will hang during kernel init because it does not power the unused
> GPU voltage rails on the IMX8MM. Disable pgc_gpumix to work around this.
>
> We also disable the GPU devices that depend on the gpumix power domain
> and pgc_gpu to avoid them staying in a probe deferred state forever.
>
> Additionally as the MIPI voltage rail is also not connected on this
> board we disable pgc_mipi and disp_blk_ctrl.
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] arm64: dts: imx8mm-venice-gw7901.dts: disable pgc_gpumix
@ 2021-10-15 2:43 ` Shawn Guo
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2021-10-15 2:43 UTC (permalink / raw)
To: Tim Harvey
Cc: Rob Herring, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, linux-arm-kernel, linux-kernel
On Wed, Oct 06, 2021 at 08:38:36AM -0700, Tim Harvey wrote:
> Since commit b21269b12e48 ("arm64: dts: imx8mm: add GPC node") the
> GW7901 will hang during kernel init because it does not power the unused
> GPU voltage rails on the IMX8MM. Disable pgc_gpumix to work around this.
>
> We also disable the GPU devices that depend on the gpumix power domain
> and pgc_gpu to avoid them staying in a probe deferred state forever.
>
> Additionally as the MIPI voltage rail is also not connected on this
> board we disable pgc_mipi and disp_blk_ctrl.
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-15 2:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-06 15:38 [PATCH v2] arm64: dts: imx8mm-venice-gw7901.dts: disable pgc_gpumix Tim Harvey
2021-10-06 15:38 ` Tim Harvey
2021-10-06 16:26 ` Lucas Stach
2021-10-06 16:26 ` Lucas Stach
2021-10-15 2:43 ` Shawn Guo
2021-10-15 2:43 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.