[PATCH] net/ipa: ipa_resource: Fix wrong for loop range

[PATCH] net/ipa: ipa_resource: Fix wrong for loop range

[Konrad Dybcio]

The destrination group count was mistakenly assigned to both dst and src loops.
Fix it to make IPA probe and work again.

Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
---
 drivers/net/ipa/ipa_resource.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ipa/ipa_resource.c b/drivers/net/ipa/ipa_resource.c
index e3da95d69409..06cec7199382 100644
--- a/drivers/net/ipa/ipa_resource.c
+++ b/drivers/net/ipa/ipa_resource.c
@@ -52,7 +52,7 @@ static bool ipa_resource_limits_valid(struct ipa *ipa,
 				return false;
 	}
 
-	group_count = data->rsrc_group_src_count;
+	group_count = data->rsrc_group_dst_count;
 	if (!group_count || group_count > IPA_RESOURCE_GROUP_MAX)
 		return false;
 
-- 
2.33.0

Re: [PATCH] net/ipa: ipa_resource: Fix wrong for loop range

[AngeloGioacchino Del Regno]

Il 11/11/21 18:34, Konrad Dybcio ha scritto:
> The destrination group count was mistakenly assigned to both dst and src loops.
> Fix it to make IPA probe and work again.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
>   drivers/net/ipa/ipa_resource.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>

Re: [PATCH] net/ipa: ipa_resource: Fix wrong for loop range

[Marijn Suijten]

On 2021-11-11 18:34:00, Konrad Dybcio wrote:
> The destrination group count was mistakenly assigned to both dst and src loops.

There's an unnecessary `r` in destRination...  Apart that I think you
meant to say "source" here since both assignments to group_count use(d)
rsrc_group_src_count, not the destination.

> Fix it to make IPA probe and work again.
> 

This is missing:

Fixes: 4fd704b3608a ("net: ipa: record number of groups in data")

For backporting to 5.13 and above. Before that commit src and dst were
correctly used.  Apart that, after fixing this all:

Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>

> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
>  drivers/net/ipa/ipa_resource.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ipa/ipa_resource.c b/drivers/net/ipa/ipa_resource.c
> index e3da95d69409..06cec7199382 100644
> --- a/drivers/net/ipa/ipa_resource.c
> +++ b/drivers/net/ipa/ipa_resource.c
> @@ -52,7 +52,7 @@ static bool ipa_resource_limits_valid(struct ipa *ipa,
>  				return false;
>  	}
>  
> -	group_count = data->rsrc_group_src_count;
> +	group_count = data->rsrc_group_dst_count;
>  	if (!group_count || group_count > IPA_RESOURCE_GROUP_MAX)
>  		return false;
>  
> -- 
> 2.33.0
>