* [PATCH] net/ipa: ipa_resource: Fix wrong for loop range
@ 2021-11-11 17:34 Konrad Dybcio
2021-11-11 17:54 ` AngeloGioacchino Del Regno
2021-11-11 18:33 ` Marijn Suijten
0 siblings, 2 replies; 3+ messages in thread
From: Konrad Dybcio @ 2021-11-11 17:34 UTC (permalink / raw)
To: ~postmarketos/upstreaming
Cc: martin.botka, angelogioacchino.delregno, marijn.suijten,
jamipkettunen, Konrad Dybcio, Alex Elder, David S. Miller,
Jakub Kicinski, netdev, linux-kernel
The destrination group count was mistakenly assigned to both dst and src loops.
Fix it to make IPA probe and work again.
Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
---
drivers/net/ipa/ipa_resource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ipa/ipa_resource.c b/drivers/net/ipa/ipa_resource.c
index e3da95d69409..06cec7199382 100644
--- a/drivers/net/ipa/ipa_resource.c
+++ b/drivers/net/ipa/ipa_resource.c
@@ -52,7 +52,7 @@ static bool ipa_resource_limits_valid(struct ipa *ipa,
return false;
}
- group_count = data->rsrc_group_src_count;
+ group_count = data->rsrc_group_dst_count;
if (!group_count || group_count > IPA_RESOURCE_GROUP_MAX)
return false;
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/ipa: ipa_resource: Fix wrong for loop range
2021-11-11 17:34 [PATCH] net/ipa: ipa_resource: Fix wrong for loop range Konrad Dybcio
@ 2021-11-11 17:54 ` AngeloGioacchino Del Regno
2021-11-11 18:33 ` Marijn Suijten
1 sibling, 0 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2021-11-11 17:54 UTC (permalink / raw)
To: Konrad Dybcio, ~postmarketos/upstreaming
Cc: martin.botka, marijn.suijten, jamipkettunen, Alex Elder,
David S. Miller, Jakub Kicinski, netdev, linux-kernel
Il 11/11/21 18:34, Konrad Dybcio ha scritto:
> The destrination group count was mistakenly assigned to both dst and src loops.
> Fix it to make IPA probe and work again.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
> drivers/net/ipa/ipa_resource.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/ipa: ipa_resource: Fix wrong for loop range
2021-11-11 17:34 [PATCH] net/ipa: ipa_resource: Fix wrong for loop range Konrad Dybcio
2021-11-11 17:54 ` AngeloGioacchino Del Regno
@ 2021-11-11 18:33 ` Marijn Suijten
1 sibling, 0 replies; 3+ messages in thread
From: Marijn Suijten @ 2021-11-11 18:33 UTC (permalink / raw)
To: Konrad Dybcio
Cc: ~postmarketos/upstreaming, martin.botka,
angelogioacchino.delregno, jamipkettunen, Alex Elder,
David S. Miller, Jakub Kicinski, netdev, linux-kernel
On 2021-11-11 18:34:00, Konrad Dybcio wrote:
> The destrination group count was mistakenly assigned to both dst and src loops.
There's an unnecessary `r` in destRination... Apart that I think you
meant to say "source" here since both assignments to group_count use(d)
rsrc_group_src_count, not the destination.
> Fix it to make IPA probe and work again.
>
This is missing:
Fixes: 4fd704b3608a ("net: ipa: record number of groups in data")
For backporting to 5.13 and above. Before that commit src and dst were
correctly used. Apart that, after fixing this all:
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
> drivers/net/ipa/ipa_resource.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ipa/ipa_resource.c b/drivers/net/ipa/ipa_resource.c
> index e3da95d69409..06cec7199382 100644
> --- a/drivers/net/ipa/ipa_resource.c
> +++ b/drivers/net/ipa/ipa_resource.c
> @@ -52,7 +52,7 @@ static bool ipa_resource_limits_valid(struct ipa *ipa,
> return false;
> }
>
> - group_count = data->rsrc_group_src_count;
> + group_count = data->rsrc_group_dst_count;
> if (!group_count || group_count > IPA_RESOURCE_GROUP_MAX)
> return false;
>
> --
> 2.33.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-11 18:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-11 17:34 [PATCH] net/ipa: ipa_resource: Fix wrong for loop range Konrad Dybcio
2021-11-11 17:54 ` AngeloGioacchino Del Regno
2021-11-11 18:33 ` Marijn Suijten
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.