All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miaoqian Lin <linmq006@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: linmq006@gmail.com, Gabriel Somlo <somlo@cmu.edu>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org, linux-kernel@vger.kernel.org
Subject: [PATCH] fw_cfg: Fix memory leak in fw_cfg_register_file
Date: Tue, 16 Nov 2021 11:42:33 +0000	[thread overview]
Message-ID: <20211116114233.29462-1-linmq006@gmail.com> (raw)

When kobject_init_and_add() fails, entry should be freed just like
when sysfs_create_bin_file() fails.

Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
 drivers/firmware/qemu_fw_cfg.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
index 172c751a4f6c..0f404777f016 100644
--- a/drivers/firmware/qemu_fw_cfg.c
+++ b/drivers/firmware/qemu_fw_cfg.c
@@ -608,6 +608,7 @@ static int fw_cfg_register_file(const struct fw_cfg_file *f)
 				   fw_cfg_sel_ko, "%d", entry->select);
 	if (err) {
 		kobject_put(&entry->kobj);
+		kfree(entry);
 		return err;
 	}
 
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: Miaoqian Lin <linmq006@gmail.com>
Cc: qemu-devel@nongnu.org, linux-kernel@vger.kernel.org,
	linmq006@gmail.com, Gabriel Somlo <somlo@cmu.edu>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: [PATCH] fw_cfg: Fix memory leak in fw_cfg_register_file
Date: Tue, 16 Nov 2021 11:42:33 +0000	[thread overview]
Message-ID: <20211116114233.29462-1-linmq006@gmail.com> (raw)

When kobject_init_and_add() fails, entry should be freed just like
when sysfs_create_bin_file() fails.

Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
 drivers/firmware/qemu_fw_cfg.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
index 172c751a4f6c..0f404777f016 100644
--- a/drivers/firmware/qemu_fw_cfg.c
+++ b/drivers/firmware/qemu_fw_cfg.c
@@ -608,6 +608,7 @@ static int fw_cfg_register_file(const struct fw_cfg_file *f)
 				   fw_cfg_sel_ko, "%d", entry->select);
 	if (err) {
 		kobject_put(&entry->kobj);
+		kfree(entry);
 		return err;
 	}
 
-- 
2.17.1



             reply	other threads:[~2021-11-16 11:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16 11:42 Miaoqian Lin [this message]
2021-11-16 11:42 ` [PATCH] fw_cfg: Fix memory leak in fw_cfg_register_file Miaoqian Lin
2021-11-16 15:28 ` Philippe Mathieu-Daudé
2021-11-16 15:28   ` Philippe Mathieu-Daudé
2021-11-30 17:18   ` Johan Hovold
2021-11-30 17:18     ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211116114233.29462-1-linmq006@gmail.com \
    --to=linmq006@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=somlo@cmu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.