* [PATCH] fw_cfg: Fix memory leak in fw_cfg_register_file
@ 2021-11-16 11:42 ` Miaoqian Lin
0 siblings, 0 replies; 6+ messages in thread
From: Miaoqian Lin @ 2021-11-16 11:42 UTC (permalink / raw)
Cc: linmq006, Gabriel Somlo, Michael S. Tsirkin, qemu-devel, linux-kernel
When kobject_init_and_add() fails, entry should be freed just like
when sysfs_create_bin_file() fails.
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/firmware/qemu_fw_cfg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
index 172c751a4f6c..0f404777f016 100644
--- a/drivers/firmware/qemu_fw_cfg.c
+++ b/drivers/firmware/qemu_fw_cfg.c
@@ -608,6 +608,7 @@ static int fw_cfg_register_file(const struct fw_cfg_file *f)
fw_cfg_sel_ko, "%d", entry->select);
if (err) {
kobject_put(&entry->kobj);
+ kfree(entry);
return err;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] fw_cfg: Fix memory leak in fw_cfg_register_file
@ 2021-11-16 11:42 ` Miaoqian Lin
0 siblings, 0 replies; 6+ messages in thread
From: Miaoqian Lin @ 2021-11-16 11:42 UTC (permalink / raw)
Cc: qemu-devel, linux-kernel, linmq006, Gabriel Somlo, Michael S. Tsirkin
When kobject_init_and_add() fails, entry should be freed just like
when sysfs_create_bin_file() fails.
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/firmware/qemu_fw_cfg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
index 172c751a4f6c..0f404777f016 100644
--- a/drivers/firmware/qemu_fw_cfg.c
+++ b/drivers/firmware/qemu_fw_cfg.c
@@ -608,6 +608,7 @@ static int fw_cfg_register_file(const struct fw_cfg_file *f)
fw_cfg_sel_ko, "%d", entry->select);
if (err) {
kobject_put(&entry->kobj);
+ kfree(entry);
return err;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] fw_cfg: Fix memory leak in fw_cfg_register_file
2021-11-16 11:42 ` Miaoqian Lin
@ 2021-11-16 15:28 ` Philippe Mathieu-Daudé
-1 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-11-16 15:28 UTC (permalink / raw)
To: Miaoqian Lin, Qiushi Wu
Cc: qemu-devel, linux-kernel, Gabriel Somlo, Michael S. Tsirkin
On 11/16/21 12:42, Miaoqian Lin wrote:
> When kobject_init_and_add() fails, entry should be freed just like
> when sysfs_create_bin_file() fails.
>
Fixes: fe3c60684377 ("firmware: Fix a reference count leak.")
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> drivers/firmware/qemu_fw_cfg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
> index 172c751a4f6c..0f404777f016 100644
> --- a/drivers/firmware/qemu_fw_cfg.c
> +++ b/drivers/firmware/qemu_fw_cfg.c
> @@ -608,6 +608,7 @@ static int fw_cfg_register_file(const struct fw_cfg_file *f)
> fw_cfg_sel_ko, "%d", entry->select);
> if (err) {
> kobject_put(&entry->kobj);
> + kfree(entry);
> return err;
> }
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] fw_cfg: Fix memory leak in fw_cfg_register_file
@ 2021-11-16 15:28 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-11-16 15:28 UTC (permalink / raw)
To: Miaoqian Lin, Qiushi Wu
Cc: Gabriel Somlo, Michael S. Tsirkin, qemu-devel, linux-kernel
On 11/16/21 12:42, Miaoqian Lin wrote:
> When kobject_init_and_add() fails, entry should be freed just like
> when sysfs_create_bin_file() fails.
>
Fixes: fe3c60684377 ("firmware: Fix a reference count leak.")
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> drivers/firmware/qemu_fw_cfg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
> index 172c751a4f6c..0f404777f016 100644
> --- a/drivers/firmware/qemu_fw_cfg.c
> +++ b/drivers/firmware/qemu_fw_cfg.c
> @@ -608,6 +608,7 @@ static int fw_cfg_register_file(const struct fw_cfg_file *f)
> fw_cfg_sel_ko, "%d", entry->select);
> if (err) {
> kobject_put(&entry->kobj);
> + kfree(entry);
> return err;
> }
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] fw_cfg: Fix memory leak in fw_cfg_register_file
2021-11-16 15:28 ` Philippe Mathieu-Daudé
@ 2021-11-30 17:18 ` Johan Hovold
-1 siblings, 0 replies; 6+ messages in thread
From: Johan Hovold @ 2021-11-30 17:18 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Miaoqian Lin, Qiushi Wu, qemu-devel, linux-kernel, Gabriel Somlo,
Michael S. Tsirkin
On Tue, Nov 16, 2021 at 04:28:34PM +0100, Philippe Mathieu-Daudé wrote:
> On 11/16/21 12:42, Miaoqian Lin wrote:
> > When kobject_init_and_add() fails, entry should be freed just like
> > when sysfs_create_bin_file() fails.
> >
>
> Fixes: fe3c60684377 ("firmware: Fix a reference count leak.")
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
No, no. This patch is completely bogus and would introduce a double
free.
> > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> > ---
> > drivers/firmware/qemu_fw_cfg.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
> > index 172c751a4f6c..0f404777f016 100644
> > --- a/drivers/firmware/qemu_fw_cfg.c
> > +++ b/drivers/firmware/qemu_fw_cfg.c
> > @@ -608,6 +608,7 @@ static int fw_cfg_register_file(const struct fw_cfg_file *f)
> > fw_cfg_sel_ko, "%d", entry->select);
> > if (err) {
> > kobject_put(&entry->kobj);
> > + kfree(entry);
entry would already have been freed by kobject_put() and
fw_cfg_sysfs_release_entry() here.
> > return err;
> > }
> >
> >
Doesn't look like this patch has been picked up yet, so:
NAK.
Johan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] fw_cfg: Fix memory leak in fw_cfg_register_file
@ 2021-11-30 17:18 ` Johan Hovold
0 siblings, 0 replies; 6+ messages in thread
From: Johan Hovold @ 2021-11-30 17:18 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Miaoqian Lin, Michael S. Tsirkin, Gabriel Somlo, qemu-devel,
linux-kernel, Qiushi Wu
On Tue, Nov 16, 2021 at 04:28:34PM +0100, Philippe Mathieu-Daudé wrote:
> On 11/16/21 12:42, Miaoqian Lin wrote:
> > When kobject_init_and_add() fails, entry should be freed just like
> > when sysfs_create_bin_file() fails.
> >
>
> Fixes: fe3c60684377 ("firmware: Fix a reference count leak.")
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
No, no. This patch is completely bogus and would introduce a double
free.
> > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> > ---
> > drivers/firmware/qemu_fw_cfg.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
> > index 172c751a4f6c..0f404777f016 100644
> > --- a/drivers/firmware/qemu_fw_cfg.c
> > +++ b/drivers/firmware/qemu_fw_cfg.c
> > @@ -608,6 +608,7 @@ static int fw_cfg_register_file(const struct fw_cfg_file *f)
> > fw_cfg_sel_ko, "%d", entry->select);
> > if (err) {
> > kobject_put(&entry->kobj);
> > + kfree(entry);
entry would already have been freed by kobject_put() and
fw_cfg_sysfs_release_entry() here.
> > return err;
> > }
> >
> >
Doesn't look like this patch has been picked up yet, so:
NAK.
Johan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-12-01 2:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-16 11:42 [PATCH] fw_cfg: Fix memory leak in fw_cfg_register_file Miaoqian Lin
2021-11-16 11:42 ` Miaoqian Lin
2021-11-16 15:28 ` Philippe Mathieu-Daudé
2021-11-16 15:28 ` Philippe Mathieu-Daudé
2021-11-30 17:18 ` Johan Hovold
2021-11-30 17:18 ` Johan Hovold
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.