From: Nicolin Chen <nicolinc@nvidia.com> To: <thierry.reding@gmail.com>, <joro@8bytes.org>, <will@kernel.org> Cc: <digetx@gmail.com>, <vdumpa@nvidia.com>, <jonathanh@nvidia.com>, <linux-tegra@vger.kernel.org>, <iommu@lists.linux-foundation.org>, <linux-kernel@vger.kernel.org> Subject: [PATCH v8 0/6] iommu/tegra-smmu: Add pagetable mappings to debugfs Date: Wed, 8 Dec 2021 23:38:16 -0800 [thread overview] Message-ID: <20211209073822.26728-1-nicolinc@nvidia.com> (raw) This series of patches adds a new mappings node to debugfs for tegra-smmu driver. The first five patches are all preparational changes for PATCH-6, based on Thierry's review feedback against v5. Changelog v8: * No changes for PATCH 1-4 * PATCH-5: * * bypassed "group->as == as" to fix KMSG bug reported by Dmitry * PATCH-6: * * changed to use u32 casting for IOVA outputs * * squashed Dmitry's change to list all swgroup names in the same group_soc since they share the same as pointer v7: https://lore.kernel.org/linux-iommu/20211208084732.23363-1-nicolinc@nvidia.com/T/ * Added "Acked-by" from Thierry to PATCH1,4,5 * No other changes for PATCH1,3,4,5 * PATCH-2: dropped "s/soc/group_soc" change * PATCH-6: * * avoided forward declaration * * dropped castings in pd_pt_index_iova() * * used "'-' : 'S'" for non-secure attribute * * changed multi-line outputs to single-line format v6: https://lore.kernel.org/linux-iommu/20210915043806.GA19185@Asurada-Nvidia/t/ * Added PATCH1-3 for better naming conventions * Added PATCH4-5 to embed previous struct tegra_smmu_group_debug into struct tegra_smmu_group * Dropped parentheses at SMMU_PTE_ATTR_SHIFT * Dropped swgrp->reg print * Replaced ptb_reg contents with as->attr and as->pd_dma * Added "index" and "count" in the PD entries for readability * Removed Dmitry's Tested-by and Reviewed-by for the big change from v5 to v6. v5: https://lore.kernel.org/linux-iommu/20210315203631.24990-1-nicoleotsuka@gmail.com/ * Fixed a typo in commit message * Split a long line into two lines * Rearranged variable defines by length * Added Tested-by and Reviewed-by from Dmitry v4: https://lore.kernel.org/lkml/20210315033504.23937-1-nicoleotsuka@gmail.com/ * Changed %d to %u for unsigned variables * Fixed print format mismatch warnings on ARM32 v3: https://lore.kernel.org/linux-iommu/20210315031530.GA15245@Asurada-Nvidia/T/ * Fixed PHYS and IOVA print formats * Changed variables to unsigned int type * Changed the table outputs to be compact v2: https://lore.kernel.org/linux-iommu/20210312010932.GB29926@Asurada-Nvidia/T/ * Expanded mutex range to the entire function * Added as->lock to protect pagetable walkthrough * Replaced devm_kzalloc with devm_kcalloc for group_debug * Added "PTE RANGE" and "SIZE" columns to group contiguous mappings * Dropped as->count check * Added WARN_ON when as->count mismatches pd[pd_index] v1: https://lkml.org/lkml/2020/9/26/70 Nicolin Chen (6): iommu/tegra-smmu: Rename struct iommu_group *group to *grp iommu/tegra-smmu: Rename tegra_smmu_find_group to tegra_smmu_find_group_soc iommu/tegra-smmu: Rename struct tegra_smmu_swgroup *group to *swgrp iommu/tegra-smmu: Use swgrp pointer instead of swgroup id iommu/tegra-smmu: Attach as pointer to tegra_smmu_group iommu/tegra-smmu: Add pagetable mappings to debugfs drivers/iommu/tegra-smmu.c | 345 ++++++++++++++++++++++++++++++++----- 1 file changed, 299 insertions(+), 46 deletions(-) -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen via iommu <iommu@lists.linux-foundation.org> To: <thierry.reding@gmail.com>, <joro@8bytes.org>, <will@kernel.org> Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, jonathanh@nvidia.com, linux-tegra@vger.kernel.org, digetx@gmail.com Subject: [PATCH v8 0/6] iommu/tegra-smmu: Add pagetable mappings to debugfs Date: Wed, 8 Dec 2021 23:38:16 -0800 [thread overview] Message-ID: <20211209073822.26728-1-nicolinc@nvidia.com> (raw) This series of patches adds a new mappings node to debugfs for tegra-smmu driver. The first five patches are all preparational changes for PATCH-6, based on Thierry's review feedback against v5. Changelog v8: * No changes for PATCH 1-4 * PATCH-5: * * bypassed "group->as == as" to fix KMSG bug reported by Dmitry * PATCH-6: * * changed to use u32 casting for IOVA outputs * * squashed Dmitry's change to list all swgroup names in the same group_soc since they share the same as pointer v7: https://lore.kernel.org/linux-iommu/20211208084732.23363-1-nicolinc@nvidia.com/T/ * Added "Acked-by" from Thierry to PATCH1,4,5 * No other changes for PATCH1,3,4,5 * PATCH-2: dropped "s/soc/group_soc" change * PATCH-6: * * avoided forward declaration * * dropped castings in pd_pt_index_iova() * * used "'-' : 'S'" for non-secure attribute * * changed multi-line outputs to single-line format v6: https://lore.kernel.org/linux-iommu/20210915043806.GA19185@Asurada-Nvidia/t/ * Added PATCH1-3 for better naming conventions * Added PATCH4-5 to embed previous struct tegra_smmu_group_debug into struct tegra_smmu_group * Dropped parentheses at SMMU_PTE_ATTR_SHIFT * Dropped swgrp->reg print * Replaced ptb_reg contents with as->attr and as->pd_dma * Added "index" and "count" in the PD entries for readability * Removed Dmitry's Tested-by and Reviewed-by for the big change from v5 to v6. v5: https://lore.kernel.org/linux-iommu/20210315203631.24990-1-nicoleotsuka@gmail.com/ * Fixed a typo in commit message * Split a long line into two lines * Rearranged variable defines by length * Added Tested-by and Reviewed-by from Dmitry v4: https://lore.kernel.org/lkml/20210315033504.23937-1-nicoleotsuka@gmail.com/ * Changed %d to %u for unsigned variables * Fixed print format mismatch warnings on ARM32 v3: https://lore.kernel.org/linux-iommu/20210315031530.GA15245@Asurada-Nvidia/T/ * Fixed PHYS and IOVA print formats * Changed variables to unsigned int type * Changed the table outputs to be compact v2: https://lore.kernel.org/linux-iommu/20210312010932.GB29926@Asurada-Nvidia/T/ * Expanded mutex range to the entire function * Added as->lock to protect pagetable walkthrough * Replaced devm_kzalloc with devm_kcalloc for group_debug * Added "PTE RANGE" and "SIZE" columns to group contiguous mappings * Dropped as->count check * Added WARN_ON when as->count mismatches pd[pd_index] v1: https://lkml.org/lkml/2020/9/26/70 Nicolin Chen (6): iommu/tegra-smmu: Rename struct iommu_group *group to *grp iommu/tegra-smmu: Rename tegra_smmu_find_group to tegra_smmu_find_group_soc iommu/tegra-smmu: Rename struct tegra_smmu_swgroup *group to *swgrp iommu/tegra-smmu: Use swgrp pointer instead of swgroup id iommu/tegra-smmu: Attach as pointer to tegra_smmu_group iommu/tegra-smmu: Add pagetable mappings to debugfs drivers/iommu/tegra-smmu.c | 345 ++++++++++++++++++++++++++++++++----- 1 file changed, 299 insertions(+), 46 deletions(-) -- 2.17.1 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next reply other threads:[~2021-12-09 7:38 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-09 7:38 Nicolin Chen [this message] 2021-12-09 7:38 ` [PATCH v8 0/6] iommu/tegra-smmu: Add pagetable mappings to debugfs Nicolin Chen via iommu 2021-12-09 7:38 ` [PATCH v8 1/6] iommu/tegra-smmu: Rename struct iommu_group *group to *grp Nicolin Chen 2021-12-09 7:38 ` Nicolin Chen via iommu 2021-12-09 7:38 ` [PATCH v8 2/6] iommu/tegra-smmu: Rename tegra_smmu_find_group to tegra_smmu_find_group_soc Nicolin Chen 2021-12-09 7:38 ` Nicolin Chen via iommu 2021-12-09 7:38 ` [PATCH v8 3/6] iommu/tegra-smmu: Rename struct tegra_smmu_swgroup *group to *swgrp Nicolin Chen 2021-12-09 7:38 ` Nicolin Chen via iommu 2021-12-09 7:38 ` [PATCH v8 4/6] iommu/tegra-smmu: Use swgrp pointer instead of swgroup id Nicolin Chen 2021-12-09 7:38 ` Nicolin Chen via iommu 2021-12-09 7:38 ` [PATCH v8 5/6] iommu/tegra-smmu: Attach as pointer to tegra_smmu_group Nicolin Chen 2021-12-09 7:38 ` Nicolin Chen via iommu 2021-12-09 7:38 ` [PATCH v8 6/6] iommu/tegra-smmu: Add pagetable mappings to debugfs Nicolin Chen 2021-12-09 7:38 ` Nicolin Chen via iommu 2021-12-09 14:47 ` Dmitry Osipenko 2021-12-09 14:47 ` Dmitry Osipenko 2021-12-09 19:32 ` Nicolin Chen 2021-12-09 19:32 ` Nicolin Chen via iommu 2021-12-09 19:40 ` Dmitry Osipenko 2021-12-09 19:40 ` Dmitry Osipenko 2021-12-09 19:51 ` Nicolin Chen 2021-12-09 19:51 ` Nicolin Chen via iommu 2021-12-09 19:58 ` Dmitry Osipenko 2021-12-09 19:58 ` Dmitry Osipenko 2021-12-09 20:06 ` Nicolin Chen 2021-12-09 20:06 ` Nicolin Chen via iommu 2021-12-09 14:49 ` Dmitry Osipenko 2021-12-09 14:49 ` Dmitry Osipenko 2021-12-09 19:24 ` Nicolin Chen 2021-12-09 19:24 ` Nicolin Chen via iommu 2021-12-09 19:44 ` Dmitry Osipenko 2021-12-09 19:44 ` Dmitry Osipenko 2021-12-09 19:54 ` Nicolin Chen 2021-12-09 19:54 ` Nicolin Chen via iommu 2021-12-09 19:58 ` Dmitry Osipenko 2021-12-09 19:58 ` Dmitry Osipenko 2021-12-09 20:01 ` Nicolin Chen 2021-12-09 20:01 ` Nicolin Chen via iommu 2021-12-09 20:03 ` Dmitry Osipenko 2021-12-09 20:03 ` Dmitry Osipenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211209073822.26728-1-nicolinc@nvidia.com \ --to=nicolinc@nvidia.com \ --cc=digetx@gmail.com \ --cc=iommu@lists.linux-foundation.org \ --cc=jonathanh@nvidia.com \ --cc=joro@8bytes.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=thierry.reding@gmail.com \ --cc=vdumpa@nvidia.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.