From: Dmitry Osipenko <digetx@gmail.com>
To: Nicolin Chen <nicolinc@nvidia.com>,
thierry.reding@gmail.com, joro@8bytes.org, will@kernel.org
Cc: vdumpa@nvidia.com, jonathanh@nvidia.com,
linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 6/6] iommu/tegra-smmu: Add pagetable mappings to debugfs
Date: Thu, 9 Dec 2021 17:47:18 +0300 [thread overview]
Message-ID: <5713902d-823b-63ca-00c9-aa6c64c1af41@gmail.com> (raw)
In-Reply-To: <20211209073822.26728-7-nicolinc@nvidia.com>
09.12.2021 10:38, Nicolin Chen пишет:
> @@ -545,6 +719,15 @@ static void tegra_smmu_detach_as(struct tegra_smmu *smmu,
> if (group->swgrp != swgrp)
> continue;
> group->as = NULL;
> +
> + if (smmu->debugfs_mappings) {
Do we really need this check?
Looks like all debugfs_create_dir() usages in this driver are incorrect,
that function never returns NULL. Please fix this.
> + struct dentry *d;
The file name is wrong here.
if (group->soc)
name = group->soc->name;
else
name = group->swgrp->name;
> + d = debugfs_lookup(group->swgrp->name,
> + smmu->debugfs_mappings);
> + debugfs_remove(d);
> + }
This now looks problematic to me. You created debugfs file when the
first member of the shared group was attached to AS, now you remove this
file when any device is detached. The shared debugfs file should be
refcounted or something.
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Nicolin Chen <nicolinc@nvidia.com>,
thierry.reding@gmail.com, joro@8bytes.org, will@kernel.org
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, jonathanh@nvidia.com
Subject: Re: [PATCH v8 6/6] iommu/tegra-smmu: Add pagetable mappings to debugfs
Date: Thu, 9 Dec 2021 17:47:18 +0300 [thread overview]
Message-ID: <5713902d-823b-63ca-00c9-aa6c64c1af41@gmail.com> (raw)
In-Reply-To: <20211209073822.26728-7-nicolinc@nvidia.com>
09.12.2021 10:38, Nicolin Chen пишет:
> @@ -545,6 +719,15 @@ static void tegra_smmu_detach_as(struct tegra_smmu *smmu,
> if (group->swgrp != swgrp)
> continue;
> group->as = NULL;
> +
> + if (smmu->debugfs_mappings) {
Do we really need this check?
Looks like all debugfs_create_dir() usages in this driver are incorrect,
that function never returns NULL. Please fix this.
> + struct dentry *d;
The file name is wrong here.
if (group->soc)
name = group->soc->name;
else
name = group->swgrp->name;
> + d = debugfs_lookup(group->swgrp->name,
> + smmu->debugfs_mappings);
> + debugfs_remove(d);
> + }
This now looks problematic to me. You created debugfs file when the
first member of the shared group was attached to AS, now you remove this
file when any device is detached. The shared debugfs file should be
refcounted or something.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-12-09 14:47 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 7:38 [PATCH v8 0/6] iommu/tegra-smmu: Add pagetable mappings to debugfs Nicolin Chen
2021-12-09 7:38 ` Nicolin Chen via iommu
2021-12-09 7:38 ` [PATCH v8 1/6] iommu/tegra-smmu: Rename struct iommu_group *group to *grp Nicolin Chen
2021-12-09 7:38 ` Nicolin Chen via iommu
2021-12-09 7:38 ` [PATCH v8 2/6] iommu/tegra-smmu: Rename tegra_smmu_find_group to tegra_smmu_find_group_soc Nicolin Chen
2021-12-09 7:38 ` Nicolin Chen via iommu
2021-12-09 7:38 ` [PATCH v8 3/6] iommu/tegra-smmu: Rename struct tegra_smmu_swgroup *group to *swgrp Nicolin Chen
2021-12-09 7:38 ` Nicolin Chen via iommu
2021-12-09 7:38 ` [PATCH v8 4/6] iommu/tegra-smmu: Use swgrp pointer instead of swgroup id Nicolin Chen
2021-12-09 7:38 ` Nicolin Chen via iommu
2021-12-09 7:38 ` [PATCH v8 5/6] iommu/tegra-smmu: Attach as pointer to tegra_smmu_group Nicolin Chen
2021-12-09 7:38 ` Nicolin Chen via iommu
2021-12-09 7:38 ` [PATCH v8 6/6] iommu/tegra-smmu: Add pagetable mappings to debugfs Nicolin Chen
2021-12-09 7:38 ` Nicolin Chen via iommu
2021-12-09 14:47 ` Dmitry Osipenko [this message]
2021-12-09 14:47 ` Dmitry Osipenko
2021-12-09 19:32 ` Nicolin Chen
2021-12-09 19:32 ` Nicolin Chen via iommu
2021-12-09 19:40 ` Dmitry Osipenko
2021-12-09 19:40 ` Dmitry Osipenko
2021-12-09 19:51 ` Nicolin Chen
2021-12-09 19:51 ` Nicolin Chen via iommu
2021-12-09 19:58 ` Dmitry Osipenko
2021-12-09 19:58 ` Dmitry Osipenko
2021-12-09 20:06 ` Nicolin Chen
2021-12-09 20:06 ` Nicolin Chen via iommu
2021-12-09 14:49 ` Dmitry Osipenko
2021-12-09 14:49 ` Dmitry Osipenko
2021-12-09 19:24 ` Nicolin Chen
2021-12-09 19:24 ` Nicolin Chen via iommu
2021-12-09 19:44 ` Dmitry Osipenko
2021-12-09 19:44 ` Dmitry Osipenko
2021-12-09 19:54 ` Nicolin Chen
2021-12-09 19:54 ` Nicolin Chen via iommu
2021-12-09 19:58 ` Dmitry Osipenko
2021-12-09 19:58 ` Dmitry Osipenko
2021-12-09 20:01 ` Nicolin Chen
2021-12-09 20:01 ` Nicolin Chen via iommu
2021-12-09 20:03 ` Dmitry Osipenko
2021-12-09 20:03 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5713902d-823b-63ca-00c9-aa6c64c1af41@gmail.com \
--to=digetx@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=vdumpa@nvidia.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.