From: Marc Zyngier <maz@kernel.org> To: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mark Rutland <mark.rutland@arm.com>, Will Deacon <will@kernel.org>, Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>, Alyssa Rosenzweig <alyssa@rosenzweig.io>, Rob Herring <robh+dt@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Dougall <dougallj@gmail.com>, kernel-team@android.com Subject: [PATCH v3 00/10] drivers/perf: CPU PMU driver for Apple M1 Date: Tue, 14 Dec 2021 18:26:24 +0000 [thread overview] Message-ID: <20211214182634.727330-1-maz@kernel.org> (raw) The M1 SoC embeds a per-CPU PMU that has a very different programming interface compared to the architected PMUv3 that is normally present on standard implementations. This small series adds a driver for this HW by leveraging the arm_pmu infrastructure, resulting in a rather simple driver. Of course, we know next to nothing about the actual events this PMU counts, aside from CPU cycles and instructions. Everything else is undocumented (though as Dougall pointed out, someone could extract the relevant information from a macOS install if they wanted -- I don't). My hope is that this driver will help people to explore the event space and propose possible interpretations for these events using reproducible test cases. * From v2 [2]: - Reworked the way the FIQ virtual affinity is exposed (now coming from the DT instead of being internal to the irqchip driver) - Dropped the locking from the PMU driver after Mark's review - Required the exclude_guest flag to be set, as the PMU doesn't seem to be able to count guest events, at least by default - Dropped the counter-stop on interrupt and instead stop the whole PMU on interrupt - Dropped the kernel taint, as I couldn't find a good way to do that on first use - Collected RBs from Hector * From v1 [1]: - Added a few comments clarifying the event mapping to counters - Spelling fixes - Collected Acks from Rob [1] https://lore.kernel.org/r/20211113115429.4027571-1-maz@kernel.org [2] https://lore.kernel.org/r/20211201134909.390490-1-maz@kernel.org Marc Zyngier (10): dt-bindings: arm-pmu: Document Apple PMU compatible strings dt-bindings: apple,aic: Add CPU PMU per-cpu pseudo-interrupts dt-bindings: apple,aic: Add affinity description for per-cpu pseudo-interrupts irqchip/apple-aic: Parse FIQ affinities from device-tree irqchip/apple-aic: Wire PMU interrupts arm64: dts: apple: Add t8103 PMU interrupt affinities arm64: dts: apple: Add t8301 PMU nodes irqchip/apple-aic: Move PMU-specific registers to their own include file drivers/perf: arm_pmu: Handle 47 bit counters drivers/perf: Add Apple icestorm/firestorm CPU PMU driver .../devicetree/bindings/arm/pmu.yaml | 2 + .../interrupt-controller/apple,aic.yaml | 28 + arch/arm64/boot/dts/apple/t8103.dtsi | 24 + arch/arm64/include/asm/apple_m1_pmu.h | 64 ++ drivers/irqchip/irq-apple-aic.c | 95 ++- drivers/perf/Kconfig | 7 + drivers/perf/Makefile | 1 + drivers/perf/apple_m1_cpu_pmu.c | 584 ++++++++++++++++++ drivers/perf/arm_pmu.c | 2 + .../interrupt-controller/apple-aic.h | 2 + include/linux/perf/arm_pmu.h | 2 + 11 files changed, 789 insertions(+), 22 deletions(-) create mode 100644 arch/arm64/include/asm/apple_m1_pmu.h create mode 100644 drivers/perf/apple_m1_cpu_pmu.c -- 2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org> To: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mark Rutland <mark.rutland@arm.com>, Will Deacon <will@kernel.org>, Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>, Alyssa Rosenzweig <alyssa@rosenzweig.io>, Rob Herring <robh+dt@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Dougall <dougallj@gmail.com>, kernel-team@android.com Subject: [PATCH v3 00/10] drivers/perf: CPU PMU driver for Apple M1 Date: Tue, 14 Dec 2021 18:26:24 +0000 [thread overview] Message-ID: <20211214182634.727330-1-maz@kernel.org> (raw) The M1 SoC embeds a per-CPU PMU that has a very different programming interface compared to the architected PMUv3 that is normally present on standard implementations. This small series adds a driver for this HW by leveraging the arm_pmu infrastructure, resulting in a rather simple driver. Of course, we know next to nothing about the actual events this PMU counts, aside from CPU cycles and instructions. Everything else is undocumented (though as Dougall pointed out, someone could extract the relevant information from a macOS install if they wanted -- I don't). My hope is that this driver will help people to explore the event space and propose possible interpretations for these events using reproducible test cases. * From v2 [2]: - Reworked the way the FIQ virtual affinity is exposed (now coming from the DT instead of being internal to the irqchip driver) - Dropped the locking from the PMU driver after Mark's review - Required the exclude_guest flag to be set, as the PMU doesn't seem to be able to count guest events, at least by default - Dropped the counter-stop on interrupt and instead stop the whole PMU on interrupt - Dropped the kernel taint, as I couldn't find a good way to do that on first use - Collected RBs from Hector * From v1 [1]: - Added a few comments clarifying the event mapping to counters - Spelling fixes - Collected Acks from Rob [1] https://lore.kernel.org/r/20211113115429.4027571-1-maz@kernel.org [2] https://lore.kernel.org/r/20211201134909.390490-1-maz@kernel.org Marc Zyngier (10): dt-bindings: arm-pmu: Document Apple PMU compatible strings dt-bindings: apple,aic: Add CPU PMU per-cpu pseudo-interrupts dt-bindings: apple,aic: Add affinity description for per-cpu pseudo-interrupts irqchip/apple-aic: Parse FIQ affinities from device-tree irqchip/apple-aic: Wire PMU interrupts arm64: dts: apple: Add t8103 PMU interrupt affinities arm64: dts: apple: Add t8301 PMU nodes irqchip/apple-aic: Move PMU-specific registers to their own include file drivers/perf: arm_pmu: Handle 47 bit counters drivers/perf: Add Apple icestorm/firestorm CPU PMU driver .../devicetree/bindings/arm/pmu.yaml | 2 + .../interrupt-controller/apple,aic.yaml | 28 + arch/arm64/boot/dts/apple/t8103.dtsi | 24 + arch/arm64/include/asm/apple_m1_pmu.h | 64 ++ drivers/irqchip/irq-apple-aic.c | 95 ++- drivers/perf/Kconfig | 7 + drivers/perf/Makefile | 1 + drivers/perf/apple_m1_cpu_pmu.c | 584 ++++++++++++++++++ drivers/perf/arm_pmu.c | 2 + .../interrupt-controller/apple-aic.h | 2 + include/linux/perf/arm_pmu.h | 2 + 11 files changed, 789 insertions(+), 22 deletions(-) create mode 100644 arch/arm64/include/asm/apple_m1_pmu.h create mode 100644 drivers/perf/apple_m1_cpu_pmu.c -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-12-14 18:27 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-14 18:26 Marc Zyngier [this message] 2021-12-14 18:26 ` [PATCH v3 00/10] drivers/perf: CPU PMU driver for Apple M1 Marc Zyngier 2021-12-14 18:26 ` [PATCH v3 01/10] dt-bindings: arm-pmu: Document Apple PMU compatible strings Marc Zyngier 2021-12-14 18:26 ` Marc Zyngier 2021-12-14 18:26 ` [PATCH v3 02/10] dt-bindings: apple,aic: Add CPU PMU per-cpu pseudo-interrupts Marc Zyngier 2021-12-14 18:26 ` [PATCH v3 02/10] dt-bindings: apple, aic: " Marc Zyngier 2021-12-14 18:26 ` [PATCH v3 03/10] dt-bindings: apple,aic: Add affinity description for " Marc Zyngier 2021-12-14 18:26 ` [PATCH v3 03/10] dt-bindings: apple, aic: " Marc Zyngier 2021-12-15 21:35 ` [PATCH v3 03/10] dt-bindings: apple,aic: " Rob Herring 2021-12-15 21:35 ` Rob Herring 2021-12-14 18:26 ` [PATCH v3 04/10] irqchip/apple-aic: Parse FIQ affinities from device-tree Marc Zyngier 2021-12-14 18:26 ` Marc Zyngier 2021-12-14 18:26 ` [PATCH v3 05/10] irqchip/apple-aic: Wire PMU interrupts Marc Zyngier 2021-12-14 18:26 ` Marc Zyngier 2021-12-14 18:26 ` [PATCH v3 06/10] arm64: dts: apple: Add t8103 PMU interrupt affinities Marc Zyngier 2021-12-14 18:26 ` Marc Zyngier 2021-12-14 18:26 ` [PATCH v3 07/10] arm64: dts: apple: Add t8301 PMU nodes Marc Zyngier 2021-12-14 18:26 ` Marc Zyngier 2021-12-14 18:48 ` Alyssa Rosenzweig 2021-12-14 18:48 ` Alyssa Rosenzweig 2021-12-14 18:26 ` [PATCH v3 08/10] irqchip/apple-aic: Move PMU-specific registers to their own include file Marc Zyngier 2021-12-14 18:26 ` Marc Zyngier 2021-12-14 18:26 ` [PATCH v3 09/10] drivers/perf: arm_pmu: Handle 47 bit counters Marc Zyngier 2021-12-14 18:26 ` Marc Zyngier 2021-12-14 18:26 ` [PATCH v3 10/10] drivers/perf: Add Apple icestorm/firestorm CPU PMU driver Marc Zyngier 2021-12-14 18:26 ` Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211214182634.727330-1-maz@kernel.org \ --to=maz@kernel.org \ --cc=alyssa@rosenzweig.io \ --cc=devicetree@vger.kernel.org \ --cc=dougallj@gmail.com \ --cc=kernel-team@android.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marcan@marcan.st \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=sven@svenpeter.dev \ --cc=tglx@linutronix.de \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.