From: Pratyush Yadav <p.yadav@ti.com> To: Vinod Koul <vkoul@kernel.org> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Paul Kocialkowski <paul.kocialkowski@bootlin.com>, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>, Vignesh Raghavendra <vigneshr@ti.com>, Kishon Vijay Abraham I <kishon@ti.com>, Pratyush Yadav <p.yadav@ti.com>, Rob Herring <robh+dt@kernel.org>, Swapnil Jakhade <sjakhade@cadence.com>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org> Subject: [PATCH v7 0/4] Rx mode support for Cadence DPHY Date: Mon, 27 Dec 2021 16:25:41 +0530 [thread overview] Message-ID: <20211227105545.4852-1-p.yadav@ti.com> (raw) Hi, This series adds support for Cadence DPHY Rx driver. It has been split off from [0] to facilitate easier merging. I have still kept the version number to maintain continuity with the previous patches. The earlier version used the same binding for Tx and Rx DPHY. With the separate driver, I have added a separate binding. But I am still keeping the old conversion patch in this series since I have already done the work in converting the binding to yaml, might as well get it merged. Tested on TI's J721E with OV5640 sensor. [0] https://patchwork.linuxtv.org/project/linux-media/list/?series=5526&state=%2A&archive=both Changes in v7: - Add spaces after { and before } in the bands table. - Drop the wrapping around the for loop on cdns_dphy_rx_get_band_ctrl(). - Make cdns_dphy_rx_wait_for_bit() inline. - Print an error message if registering PHY provider fails. Changes in v6: - Add a new binding for DPHY Rx. - Move the DPHY Rx part to a separate driver. - Drop Rx specific changes from the cdns,dphy.yaml binding. Keep those in cdns,dphy-rx.yaml Changes in v5: - Use the new cdns_dphy_info to specify PHY ops. - Re-order include in alphabetical order. - Make bands const. - Drop num_bands. - Make i, lanes unsigned. - Drop the maximum check in cdns_dphy_rx_get_band_ctrl(). Let the loop complete and return -EOPNOTSUPP when we reach the end. - Drop the "rate < bands[i].min_rate" check since the bands are in ascending order. - Move data_lane_ctrl to start of function and make it static const. Changes in v4: - Drop the submode parts. Use a different compatible for the Rx ops. - Make bands and num_bands static. - Drop the submode patches. Use a different compatible for Rx mode DPHY instead. Changes in v3: - Use a table to select the band. - Use a table to poll the data lane ready bits. - Multiply the DPHY HS clock rate by 2 to get the bit rate since the clock is DDR. - Add Rob's R-by. Changes in v2: - Drop reg description. - Add a description for each DPHY clock. - Rename dphy@... to phy@... in example. - Add Laurent's R-by. - Re-order subject prefixes. - Add power-domain to the example. - Add Laurent's R-by. - Re-order subject prefixes. Pratyush Yadav (4): phy: cadence: Add Cadence D-PHY Rx driver phy: dt-bindings: Convert Cadence DPHY binding to YAML phy: dt-bindings: cdns,dphy: add power-domains property phy: dt-bindings: Add Cadence D-PHY Rx bindings .../devicetree/bindings/phy/cdns,dphy-rx.yaml | 42 +++ .../devicetree/bindings/phy/cdns,dphy.txt | 20 -- .../devicetree/bindings/phy/cdns,dphy.yaml | 56 ++++ drivers/phy/cadence/Kconfig | 8 + drivers/phy/cadence/Makefile | 1 + drivers/phy/cadence/cdns-dphy-rx.c | 255 ++++++++++++++++++ 6 files changed, 362 insertions(+), 20 deletions(-) create mode 100644 Documentation/devicetree/bindings/phy/cdns,dphy-rx.yaml delete mode 100644 Documentation/devicetree/bindings/phy/cdns,dphy.txt create mode 100644 Documentation/devicetree/bindings/phy/cdns,dphy.yaml create mode 100644 drivers/phy/cadence/cdns-dphy-rx.c -- 2.33.1.835.ge9e5ba39a7
WARNING: multiple messages have this Message-ID (diff)
From: Pratyush Yadav <p.yadav@ti.com> To: Vinod Koul <vkoul@kernel.org> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Paul Kocialkowski <paul.kocialkowski@bootlin.com>, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>, Vignesh Raghavendra <vigneshr@ti.com>, Kishon Vijay Abraham I <kishon@ti.com>, Pratyush Yadav <p.yadav@ti.com>, Rob Herring <robh+dt@kernel.org>, Swapnil Jakhade <sjakhade@cadence.com>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org> Subject: [PATCH v7 0/4] Rx mode support for Cadence DPHY Date: Mon, 27 Dec 2021 16:25:41 +0530 [thread overview] Message-ID: <20211227105545.4852-1-p.yadav@ti.com> (raw) Hi, This series adds support for Cadence DPHY Rx driver. It has been split off from [0] to facilitate easier merging. I have still kept the version number to maintain continuity with the previous patches. The earlier version used the same binding for Tx and Rx DPHY. With the separate driver, I have added a separate binding. But I am still keeping the old conversion patch in this series since I have already done the work in converting the binding to yaml, might as well get it merged. Tested on TI's J721E with OV5640 sensor. [0] https://patchwork.linuxtv.org/project/linux-media/list/?series=5526&state=%2A&archive=both Changes in v7: - Add spaces after { and before } in the bands table. - Drop the wrapping around the for loop on cdns_dphy_rx_get_band_ctrl(). - Make cdns_dphy_rx_wait_for_bit() inline. - Print an error message if registering PHY provider fails. Changes in v6: - Add a new binding for DPHY Rx. - Move the DPHY Rx part to a separate driver. - Drop Rx specific changes from the cdns,dphy.yaml binding. Keep those in cdns,dphy-rx.yaml Changes in v5: - Use the new cdns_dphy_info to specify PHY ops. - Re-order include in alphabetical order. - Make bands const. - Drop num_bands. - Make i, lanes unsigned. - Drop the maximum check in cdns_dphy_rx_get_band_ctrl(). Let the loop complete and return -EOPNOTSUPP when we reach the end. - Drop the "rate < bands[i].min_rate" check since the bands are in ascending order. - Move data_lane_ctrl to start of function and make it static const. Changes in v4: - Drop the submode parts. Use a different compatible for the Rx ops. - Make bands and num_bands static. - Drop the submode patches. Use a different compatible for Rx mode DPHY instead. Changes in v3: - Use a table to select the band. - Use a table to poll the data lane ready bits. - Multiply the DPHY HS clock rate by 2 to get the bit rate since the clock is DDR. - Add Rob's R-by. Changes in v2: - Drop reg description. - Add a description for each DPHY clock. - Rename dphy@... to phy@... in example. - Add Laurent's R-by. - Re-order subject prefixes. - Add power-domain to the example. - Add Laurent's R-by. - Re-order subject prefixes. Pratyush Yadav (4): phy: cadence: Add Cadence D-PHY Rx driver phy: dt-bindings: Convert Cadence DPHY binding to YAML phy: dt-bindings: cdns,dphy: add power-domains property phy: dt-bindings: Add Cadence D-PHY Rx bindings .../devicetree/bindings/phy/cdns,dphy-rx.yaml | 42 +++ .../devicetree/bindings/phy/cdns,dphy.txt | 20 -- .../devicetree/bindings/phy/cdns,dphy.yaml | 56 ++++ drivers/phy/cadence/Kconfig | 8 + drivers/phy/cadence/Makefile | 1 + drivers/phy/cadence/cdns-dphy-rx.c | 255 ++++++++++++++++++ 6 files changed, 362 insertions(+), 20 deletions(-) create mode 100644 Documentation/devicetree/bindings/phy/cdns,dphy-rx.yaml delete mode 100644 Documentation/devicetree/bindings/phy/cdns,dphy.txt create mode 100644 Documentation/devicetree/bindings/phy/cdns,dphy.yaml create mode 100644 drivers/phy/cadence/cdns-dphy-rx.c -- 2.33.1.835.ge9e5ba39a7 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next reply other threads:[~2021-12-27 10:56 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-27 10:55 Pratyush Yadav [this message] 2021-12-27 10:55 ` [PATCH v7 0/4] Rx mode support for Cadence DPHY Pratyush Yadav 2021-12-27 10:55 ` [PATCH v7 1/4] phy: cadence: Add Cadence D-PHY Rx driver Pratyush Yadav 2021-12-27 10:55 ` Pratyush Yadav 2021-12-29 23:30 ` Laurent Pinchart 2021-12-29 23:30 ` Laurent Pinchart 2021-12-31 10:28 ` Pratyush Yadav 2021-12-31 10:28 ` Pratyush Yadav 2022-01-04 11:11 ` kernel test robot 2022-01-04 11:11 ` kernel test robot 2022-01-05 5:27 ` kernel test robot 2022-01-05 5:27 ` kernel test robot 2021-12-27 10:55 ` [PATCH v7 2/4] phy: dt-bindings: Convert Cadence DPHY binding to YAML Pratyush Yadav 2021-12-27 10:55 ` Pratyush Yadav 2021-12-27 10:55 ` [PATCH v7 3/4] phy: dt-bindings: cdns,dphy: add power-domains property Pratyush Yadav 2021-12-27 10:55 ` [PATCH v7 3/4] phy: dt-bindings: cdns, dphy: " Pratyush Yadav 2021-12-27 10:55 ` [PATCH v7 4/4] phy: dt-bindings: Add Cadence D-PHY Rx bindings Pratyush Yadav 2021-12-27 10:55 ` Pratyush Yadav 2021-12-27 16:57 ` Rob Herring 2021-12-27 16:57 ` Rob Herring 2021-12-27 20:48 ` Pratyush Yadav 2021-12-27 20:48 ` Pratyush Yadav 2021-12-29 23:14 ` Laurent Pinchart 2021-12-29 23:14 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211227105545.4852-1-p.yadav@ti.com \ --to=p.yadav@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=kishon@ti.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=paul.kocialkowski@bootlin.com \ --cc=robh+dt@kernel.org \ --cc=sjakhade@cadence.com \ --cc=tomi.valkeinen@ideasonboard.com \ --cc=vigneshr@ti.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.