From: kernel test robot <lkp@intel.com>
To: Pratyush Yadav <p.yadav@ti.com>, Vinod Koul <vkoul@kernel.org>
Cc: kbuild-all@lists.01.org, Pratyush Yadav <p.yadav@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Swapnil Jakhade <sjakhade@cadence.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v7 1/4] phy: cadence: Add Cadence D-PHY Rx driver
Date: Tue, 4 Jan 2022 19:11:14 +0800 [thread overview]
Message-ID: <202201041908.dB4f5BTe-lkp@intel.com> (raw)
In-Reply-To: <20211227105545.4852-2-p.yadav@ti.com>
Hi Pratyush,
I love your patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v5.16-rc8 next-20211224]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Pratyush-Yadav/Rx-mode-support-for-Cadence-DPHY/20211227-185749
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: csky-allyesconfig (https://download.01.org/0day-ci/archive/20220104/202201041908.dB4f5BTe-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/266027120669b8824f07fa9c2f7a59b7bc12648c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Pratyush-Yadav/Rx-mode-support-for-Cadence-DPHY/20211227-185749
git checkout 266027120669b8824f07fa9c2f7a59b7bc12648c
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=csky SHELL=/bin/bash drivers/phy/cadence/ drivers/thermal/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from include/linux/phy/phy.h:15,
from drivers/phy/cadence/cdns-dphy-rx.c:11:
drivers/phy/cadence/cdns-dphy-rx.c: In function 'cdns_dphy_rx_probe':
>> drivers/phy/cadence/cdns-dphy-rx.c:223:30: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat=]
223 | dev_err(dev, "Failed to create PHY: %d\n", PTR_ERR(dphy->phy));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/phy/cadence/cdns-dphy-rx.c:223:17: note: in expansion of macro 'dev_err'
223 | dev_err(dev, "Failed to create PHY: %d\n", PTR_ERR(dphy->phy));
| ^~~~~~~
drivers/phy/cadence/cdns-dphy-rx.c:223:54: note: format string is defined here
223 | dev_err(dev, "Failed to create PHY: %d\n", PTR_ERR(dphy->phy));
| ~^
| |
| int
| %ld
In file included from include/linux/device.h:15,
from include/linux/phy/phy.h:15,
from drivers/phy/cadence/cdns-dphy-rx.c:11:
drivers/phy/cadence/cdns-dphy-rx.c:230:30: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat=]
230 | dev_err(dev, "Failed to register PHY provider: %d\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/phy/cadence/cdns-dphy-rx.c:230:17: note: in expansion of macro 'dev_err'
230 | dev_err(dev, "Failed to register PHY provider: %d\n",
| ^~~~~~~
drivers/phy/cadence/cdns-dphy-rx.c:230:65: note: format string is defined here
230 | dev_err(dev, "Failed to register PHY provider: %d\n",
| ~^
| |
| int
| %ld
vim +223 drivers/phy/cadence/cdns-dphy-rx.c
203
204 static int cdns_dphy_rx_probe(struct platform_device *pdev)
205 {
206 struct device *dev = &pdev->dev;
207 struct phy_provider *provider;
208 struct cdns_dphy_rx *dphy;
209
210 dphy = devm_kzalloc(dev, sizeof(*dphy), GFP_KERNEL);
211 if (!dphy)
212 return -ENOMEM;
213
214 dev_set_drvdata(dev, dphy);
215 dphy->dev = dev;
216
217 dphy->regs = devm_platform_ioremap_resource(pdev, 0);
218 if (IS_ERR(dphy->regs))
219 return PTR_ERR(dphy->regs);
220
221 dphy->phy = devm_phy_create(dev, NULL, &cdns_dphy_rx_ops);
222 if (IS_ERR(dphy->phy)) {
> 223 dev_err(dev, "Failed to create PHY: %d\n", PTR_ERR(dphy->phy));
224 return PTR_ERR(dphy->phy);
225 }
226
227 phy_set_drvdata(dphy->phy, dphy);
228 provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
229 if (IS_ERR(provider)) {
230 dev_err(dev, "Failed to register PHY provider: %d\n",
231 PTR_ERR(provider));
232 return PTR_ERR(provider);
233 }
234
235 return 0;
236 }
237
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v7 1/4] phy: cadence: Add Cadence D-PHY Rx driver
Date: Tue, 04 Jan 2022 19:11:14 +0800 [thread overview]
Message-ID: <202201041908.dB4f5BTe-lkp@intel.com> (raw)
In-Reply-To: <20211227105545.4852-2-p.yadav@ti.com>
[-- Attachment #1: Type: text/plain, Size: 6229 bytes --]
Hi Pratyush,
I love your patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v5.16-rc8 next-20211224]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Pratyush-Yadav/Rx-mode-support-for-Cadence-DPHY/20211227-185749
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: csky-allyesconfig (https://download.01.org/0day-ci/archive/20220104/202201041908.dB4f5BTe-lkp(a)intel.com/config)
compiler: csky-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/266027120669b8824f07fa9c2f7a59b7bc12648c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Pratyush-Yadav/Rx-mode-support-for-Cadence-DPHY/20211227-185749
git checkout 266027120669b8824f07fa9c2f7a59b7bc12648c
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=csky SHELL=/bin/bash drivers/phy/cadence/ drivers/thermal/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from include/linux/phy/phy.h:15,
from drivers/phy/cadence/cdns-dphy-rx.c:11:
drivers/phy/cadence/cdns-dphy-rx.c: In function 'cdns_dphy_rx_probe':
>> drivers/phy/cadence/cdns-dphy-rx.c:223:30: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat=]
223 | dev_err(dev, "Failed to create PHY: %d\n", PTR_ERR(dphy->phy));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/phy/cadence/cdns-dphy-rx.c:223:17: note: in expansion of macro 'dev_err'
223 | dev_err(dev, "Failed to create PHY: %d\n", PTR_ERR(dphy->phy));
| ^~~~~~~
drivers/phy/cadence/cdns-dphy-rx.c:223:54: note: format string is defined here
223 | dev_err(dev, "Failed to create PHY: %d\n", PTR_ERR(dphy->phy));
| ~^
| |
| int
| %ld
In file included from include/linux/device.h:15,
from include/linux/phy/phy.h:15,
from drivers/phy/cadence/cdns-dphy-rx.c:11:
drivers/phy/cadence/cdns-dphy-rx.c:230:30: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat=]
230 | dev_err(dev, "Failed to register PHY provider: %d\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/phy/cadence/cdns-dphy-rx.c:230:17: note: in expansion of macro 'dev_err'
230 | dev_err(dev, "Failed to register PHY provider: %d\n",
| ^~~~~~~
drivers/phy/cadence/cdns-dphy-rx.c:230:65: note: format string is defined here
230 | dev_err(dev, "Failed to register PHY provider: %d\n",
| ~^
| |
| int
| %ld
vim +223 drivers/phy/cadence/cdns-dphy-rx.c
203
204 static int cdns_dphy_rx_probe(struct platform_device *pdev)
205 {
206 struct device *dev = &pdev->dev;
207 struct phy_provider *provider;
208 struct cdns_dphy_rx *dphy;
209
210 dphy = devm_kzalloc(dev, sizeof(*dphy), GFP_KERNEL);
211 if (!dphy)
212 return -ENOMEM;
213
214 dev_set_drvdata(dev, dphy);
215 dphy->dev = dev;
216
217 dphy->regs = devm_platform_ioremap_resource(pdev, 0);
218 if (IS_ERR(dphy->regs))
219 return PTR_ERR(dphy->regs);
220
221 dphy->phy = devm_phy_create(dev, NULL, &cdns_dphy_rx_ops);
222 if (IS_ERR(dphy->phy)) {
> 223 dev_err(dev, "Failed to create PHY: %d\n", PTR_ERR(dphy->phy));
224 return PTR_ERR(dphy->phy);
225 }
226
227 phy_set_drvdata(dphy->phy, dphy);
228 provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
229 if (IS_ERR(provider)) {
230 dev_err(dev, "Failed to register PHY provider: %d\n",
231 PTR_ERR(provider));
232 return PTR_ERR(provider);
233 }
234
235 return 0;
236 }
237
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2022-01-04 11:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 10:55 [PATCH v7 0/4] Rx mode support for Cadence DPHY Pratyush Yadav
2021-12-27 10:55 ` Pratyush Yadav
2021-12-27 10:55 ` [PATCH v7 1/4] phy: cadence: Add Cadence D-PHY Rx driver Pratyush Yadav
2021-12-27 10:55 ` Pratyush Yadav
2021-12-29 23:30 ` Laurent Pinchart
2021-12-29 23:30 ` Laurent Pinchart
2021-12-31 10:28 ` Pratyush Yadav
2021-12-31 10:28 ` Pratyush Yadav
2022-01-04 11:11 ` kernel test robot [this message]
2022-01-04 11:11 ` kernel test robot
2022-01-05 5:27 ` kernel test robot
2022-01-05 5:27 ` kernel test robot
2021-12-27 10:55 ` [PATCH v7 2/4] phy: dt-bindings: Convert Cadence DPHY binding to YAML Pratyush Yadav
2021-12-27 10:55 ` Pratyush Yadav
2021-12-27 10:55 ` [PATCH v7 3/4] phy: dt-bindings: cdns,dphy: add power-domains property Pratyush Yadav
2021-12-27 10:55 ` [PATCH v7 3/4] phy: dt-bindings: cdns, dphy: " Pratyush Yadav
2021-12-27 10:55 ` [PATCH v7 4/4] phy: dt-bindings: Add Cadence D-PHY Rx bindings Pratyush Yadav
2021-12-27 10:55 ` Pratyush Yadav
2021-12-27 16:57 ` Rob Herring
2021-12-27 16:57 ` Rob Herring
2021-12-27 20:48 ` Pratyush Yadav
2021-12-27 20:48 ` Pratyush Yadav
2021-12-29 23:14 ` Laurent Pinchart
2021-12-29 23:14 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202201041908.dB4f5BTe-lkp@intel.com \
--to=lkp@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=kishon@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=p.yadav@ti.com \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=sjakhade@cadence.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.