From: Tobias Waldekranz <tobias@waldekranz.com> To: davem@davemloft.net, kuba@kernel.org Cc: madalin.bucur@nxp.com, robh+dt@kernel.org, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH net 4/4] net/fsl: xgmac_mdio: Fix incorrect iounmap when removing module Date: Sun, 16 Jan 2022 22:15:29 +0100 [thread overview] Message-ID: <20220116211529.25604-5-tobias@waldekranz.com> (raw) In-Reply-To: <20220116211529.25604-1-tobias@waldekranz.com> As reported by sparse: In the remove path, the driver would attempt to unmap its own priv pointer - instead of the io memory that it mapped in probe. Fixes: 9f35a7342cff ("net/fsl: introduce Freescale 10G MDIO driver") Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com> --- drivers/net/ethernet/freescale/xgmac_mdio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c index bf566ac3195b..266e562bd67a 100644 --- a/drivers/net/ethernet/freescale/xgmac_mdio.c +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c @@ -331,9 +331,10 @@ static int xgmac_mdio_probe(struct platform_device *pdev) static int xgmac_mdio_remove(struct platform_device *pdev) { struct mii_bus *bus = platform_get_drvdata(pdev); + struct mdio_fsl_priv *priv = bus->priv; mdiobus_unregister(bus); - iounmap(bus->priv); + iounmap(priv->mdio_base); mdiobus_free(bus); return 0; -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Tobias Waldekranz <tobias@waldekranz.com> To: davem@davemloft.net, kuba@kernel.org Cc: devicetree@vger.kernel.org, madalin.bucur@nxp.com, robh+dt@kernel.org, paulus@samba.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org Subject: [PATCH net 4/4] net/fsl: xgmac_mdio: Fix incorrect iounmap when removing module Date: Sun, 16 Jan 2022 22:15:29 +0100 [thread overview] Message-ID: <20220116211529.25604-5-tobias@waldekranz.com> (raw) In-Reply-To: <20220116211529.25604-1-tobias@waldekranz.com> As reported by sparse: In the remove path, the driver would attempt to unmap its own priv pointer - instead of the io memory that it mapped in probe. Fixes: 9f35a7342cff ("net/fsl: introduce Freescale 10G MDIO driver") Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com> --- drivers/net/ethernet/freescale/xgmac_mdio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c index bf566ac3195b..266e562bd67a 100644 --- a/drivers/net/ethernet/freescale/xgmac_mdio.c +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c @@ -331,9 +331,10 @@ static int xgmac_mdio_probe(struct platform_device *pdev) static int xgmac_mdio_remove(struct platform_device *pdev) { struct mii_bus *bus = platform_get_drvdata(pdev); + struct mdio_fsl_priv *priv = bus->priv; mdiobus_unregister(bus); - iounmap(bus->priv); + iounmap(priv->mdio_base); mdiobus_free(bus); return 0; -- 2.25.1
next prev parent reply other threads:[~2022-01-16 21:16 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-16 21:15 [PATCH net 0/4] net/fsl: xgmac_mdio: Add workaround for erratum A-009885 Tobias Waldekranz 2022-01-16 21:15 ` Tobias Waldekranz 2022-01-16 21:15 ` [PATCH net 1/4] " Tobias Waldekranz 2022-01-16 21:15 ` Tobias Waldekranz 2022-01-16 22:02 ` Andrew Lunn 2022-01-16 22:02 ` Andrew Lunn 2022-01-17 7:24 ` Tobias Waldekranz 2022-01-17 7:24 ` Tobias Waldekranz 2022-01-17 14:00 ` Andrew Lunn 2022-01-17 14:00 ` Andrew Lunn 2022-01-18 20:34 ` Jakub Kicinski 2022-01-18 20:34 ` Jakub Kicinski 2022-01-18 8:40 ` Tobias Waldekranz 2022-01-18 8:40 ` Tobias Waldekranz 2022-01-16 21:15 ` [PATCH net 2/4] dt-bindings: net: Document fsl,erratum-a009885 Tobias Waldekranz 2022-01-16 21:15 ` Tobias Waldekranz 2022-01-16 21:56 ` Andrew Lunn 2022-01-16 21:56 ` Andrew Lunn 2022-01-16 21:15 ` [PATCH net 3/4] powerpc/fsl/dts: Enable WA for erratum A-009885 on fman3l MDIO buses Tobias Waldekranz 2022-01-16 21:15 ` Tobias Waldekranz 2022-01-18 8:41 ` Tobias Waldekranz 2022-01-18 8:41 ` Tobias Waldekranz 2022-01-16 21:15 ` Tobias Waldekranz [this message] 2022-01-16 21:15 ` [PATCH net 4/4] net/fsl: xgmac_mdio: Fix incorrect iounmap when removing module Tobias Waldekranz 2022-01-16 21:54 ` Andrew Lunn 2022-01-16 21:54 ` Andrew Lunn 2022-01-17 7:26 ` Tobias Waldekranz 2022-01-17 7:26 ` Tobias Waldekranz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220116211529.25604-5-tobias@waldekranz.com \ --to=tobias@waldekranz.com \ --cc=benh@kernel.crashing.org \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=kuba@kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=madalin.bucur@nxp.com \ --cc=mpe@ellerman.id.au \ --cc=netdev@vger.kernel.org \ --cc=paulus@samba.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.