From: Andrew Lunn <andrew@lunn.ch> To: Tobias Waldekranz <tobias@waldekranz.com> Cc: davem@davemloft.net, kuba@kernel.org, madalin.bucur@nxp.com, robh+dt@kernel.org, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH net 1/4] net/fsl: xgmac_mdio: Add workaround for erratum A-009885 Date: Mon, 17 Jan 2022 15:00:41 +0100 [thread overview] Message-ID: <YeV2idN2wPzrHI0n@lunn.ch> (raw) In-Reply-To: <87czkqdduh.fsf@waldekranz.com> On Mon, Jan 17, 2022 at 08:24:22AM +0100, Tobias Waldekranz wrote: > On Sun, Jan 16, 2022 at 23:02, Andrew Lunn <andrew@lunn.ch> wrote: > > On Sun, Jan 16, 2022 at 10:15:26PM +0100, Tobias Waldekranz wrote: > >> Once an MDIO read transaction is initiated, we must read back the data > >> register within 16 MDC cycles after the transaction completes. Outside > >> of this window, reads may return corrupt data. > >> > >> Therefore, disable local interrupts in the critical section, to > >> maximize the probability that we can satisfy this requirement. > > > > Since this is for net, a Fixes: tag would be nice. Maybe that would be > > for the commit which added this driver, or maybe when the DTSI files > > for the SOCs which have this errata we added? > > Alright, I wasn't sure how to tag WAs for errata since it is more about > the hardware than the driver. The tag gives the backporter an idea how far back to go. If support for this SoC has only recently been added, there is no need to backport a long way. If it is an old SoC, then maybe more effort should be put into the backport? > Should I send a v2 even if nothing else > pops up, or is this more of a if-you're-sending-a-v2-anyway type of > comment? If you reply with a Fixes: patchwork will automagically append it like it does Reviewed-by, Tested-by etc. Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch> To: Tobias Waldekranz <tobias@waldekranz.com> Cc: devicetree@vger.kernel.org, madalin.bucur@nxp.com, robh+dt@kernel.org, paulus@samba.org, kuba@kernel.org, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net Subject: Re: [PATCH net 1/4] net/fsl: xgmac_mdio: Add workaround for erratum A-009885 Date: Mon, 17 Jan 2022 15:00:41 +0100 [thread overview] Message-ID: <YeV2idN2wPzrHI0n@lunn.ch> (raw) In-Reply-To: <87czkqdduh.fsf@waldekranz.com> On Mon, Jan 17, 2022 at 08:24:22AM +0100, Tobias Waldekranz wrote: > On Sun, Jan 16, 2022 at 23:02, Andrew Lunn <andrew@lunn.ch> wrote: > > On Sun, Jan 16, 2022 at 10:15:26PM +0100, Tobias Waldekranz wrote: > >> Once an MDIO read transaction is initiated, we must read back the data > >> register within 16 MDC cycles after the transaction completes. Outside > >> of this window, reads may return corrupt data. > >> > >> Therefore, disable local interrupts in the critical section, to > >> maximize the probability that we can satisfy this requirement. > > > > Since this is for net, a Fixes: tag would be nice. Maybe that would be > > for the commit which added this driver, or maybe when the DTSI files > > for the SOCs which have this errata we added? > > Alright, I wasn't sure how to tag WAs for errata since it is more about > the hardware than the driver. The tag gives the backporter an idea how far back to go. If support for this SoC has only recently been added, there is no need to backport a long way. If it is an old SoC, then maybe more effort should be put into the backport? > Should I send a v2 even if nothing else > pops up, or is this more of a if-you're-sending-a-v2-anyway type of > comment? If you reply with a Fixes: patchwork will automagically append it like it does Reviewed-by, Tested-by etc. Andrew
next prev parent reply other threads:[~2022-01-17 14:01 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-16 21:15 [PATCH net 0/4] net/fsl: xgmac_mdio: Add workaround for erratum A-009885 Tobias Waldekranz 2022-01-16 21:15 ` Tobias Waldekranz 2022-01-16 21:15 ` [PATCH net 1/4] " Tobias Waldekranz 2022-01-16 21:15 ` Tobias Waldekranz 2022-01-16 22:02 ` Andrew Lunn 2022-01-16 22:02 ` Andrew Lunn 2022-01-17 7:24 ` Tobias Waldekranz 2022-01-17 7:24 ` Tobias Waldekranz 2022-01-17 14:00 ` Andrew Lunn [this message] 2022-01-17 14:00 ` Andrew Lunn 2022-01-18 20:34 ` Jakub Kicinski 2022-01-18 20:34 ` Jakub Kicinski 2022-01-18 8:40 ` Tobias Waldekranz 2022-01-18 8:40 ` Tobias Waldekranz 2022-01-16 21:15 ` [PATCH net 2/4] dt-bindings: net: Document fsl,erratum-a009885 Tobias Waldekranz 2022-01-16 21:15 ` Tobias Waldekranz 2022-01-16 21:56 ` Andrew Lunn 2022-01-16 21:56 ` Andrew Lunn 2022-01-16 21:15 ` [PATCH net 3/4] powerpc/fsl/dts: Enable WA for erratum A-009885 on fman3l MDIO buses Tobias Waldekranz 2022-01-16 21:15 ` Tobias Waldekranz 2022-01-18 8:41 ` Tobias Waldekranz 2022-01-18 8:41 ` Tobias Waldekranz 2022-01-16 21:15 ` [PATCH net 4/4] net/fsl: xgmac_mdio: Fix incorrect iounmap when removing module Tobias Waldekranz 2022-01-16 21:15 ` Tobias Waldekranz 2022-01-16 21:54 ` Andrew Lunn 2022-01-16 21:54 ` Andrew Lunn 2022-01-17 7:26 ` Tobias Waldekranz 2022-01-17 7:26 ` Tobias Waldekranz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YeV2idN2wPzrHI0n@lunn.ch \ --to=andrew@lunn.ch \ --cc=benh@kernel.crashing.org \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=kuba@kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=madalin.bucur@nxp.com \ --cc=mpe@ellerman.id.au \ --cc=netdev@vger.kernel.org \ --cc=paulus@samba.org \ --cc=robh+dt@kernel.org \ --cc=tobias@waldekranz.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.