[PATCH v2] local.conf.sample: use https instead of http for SSTATE_MIRRORS

[PATCH v2] local.conf.sample: use https instead of http for SSTATE_MIRRORS

[Michael Opdenacker]

Both http and https work, but we should get fewer questions
with https

Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
---
 meta-poky/conf/local.conf.sample | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta-poky/conf/local.conf.sample b/meta-poky/conf/local.conf.sample
index 7bdbba0..3100eb1 100644
--- a/meta-poky/conf/local.conf.sample
+++ b/meta-poky/conf/local.conf.sample
@@ -206,7 +206,7 @@ BB_DISKMON_DIRS ??= "\
 # used to accelerate build time. This variable can be used to configure the system
 # to search other mirror locations for these objects before it builds the data itself.
 #
-# This can be a filesystem directory, or a remote url such as http or ftp. These
+# This can be a filesystem directory, or a remote url such as https or ftp. These
 # would contain the sstate-cache results from previous builds (possibly from other
 # machines). This variable works like fetcher MIRRORS/PREMIRRORS and points to the
 # cache locations to check for the shared objects.
@@ -214,7 +214,7 @@ BB_DISKMON_DIRS ??= "\
 # at the end as shown in the examples below. This will be substituted with the
 # correct path within the directory structure.
 #SSTATE_MIRRORS ?= "\
-#file://.* http://someserver.tld/share/sstate/PATH;downloadfilename=PATH \n \
+#file://.* https://someserver.tld/share/sstate/PATH;downloadfilename=PATH \n \
 #file://.* file:///some/local/dir/sstate/PATH"
 
 #
@@ -229,7 +229,7 @@ BB_DISKMON_DIRS ??= "\
 # Note: For this to work you also need hash-equivalence passthrough to the matching server
 #
 #BB_HASHSERVE_UPSTREAM = "typhoon.yocto.io:8687"
-#SSTATE_MIRRORS ?= "file://.* http://sstate.yoctoproject.org/3.4/PATH;downloadfilename=PATH"
+#SSTATE_MIRRORS ?= "file://.* https://sstate.yoctoproject.org/3.4/PATH;downloadfilename=PATH"
 
 #
 # Qemu configuration
-- 
2.25.1

Re: [poky] [PATCH v2] local.conf.sample: use https instead of http for SSTATE_MIRRORS

[Peter Kjellerstedt]

> -----Original Message-----
> From: poky@lists.yoctoproject.org <poky@lists.yoctoproject.org> On Behalf Of Michael Opdenacker
> Sent: den 26 januari 2022 11:44
> To: poky@lists.yoctoproject.org
> Cc: Michael Opdenacker <michael.opdenacker@bootlin.com>
> Subject: [poky] [PATCH v2] local.conf.sample: use https instead of http for SSTATE_MIRRORS
> 
> Both http and https work, but we should get fewer questions
> with https
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> ---
>  meta-poky/conf/local.conf.sample | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta-poky/conf/local.conf.sample b/meta-poky/conf/local.conf.sample
> index 7bdbba0..3100eb1 100644
> --- a/meta-poky/conf/local.conf.sample
> +++ b/meta-poky/conf/local.conf.sample
> @@ -206,7 +206,7 @@ BB_DISKMON_DIRS ??= "\
>  # used to accelerate build time. This variable can be used to configure the system
>  # to search other mirror locations for these objects before it builds the data itself.
>  #
> -# This can be a filesystem directory, or a remote url such as http or ftp. These
> +# This can be a filesystem directory, or a remote url such as https or ftp. These
>  # would contain the sstate-cache results from previous builds (possibly from other
>  # machines). This variable works like fetcher MIRRORS/PREMIRRORS and points to the
>  # cache locations to check for the shared objects.
> @@ -214,7 +214,7 @@ BB_DISKMON_DIRS ??= "\
>  # at the end as shown in the examples below. This will be substituted with the
>  # correct path within the directory structure.
>  #SSTATE_MIRRORS ?= "\
> -#file://.* http://someserver.tld/share/sstate/PATH;downloadfilename=PATH \n \
> +#file://.* https://someserver.tld/share/sstate/PATH;downloadfilename=PATH \n \

While there, you may as well remove the "\n".

>  #file://.* file:///some/local/dir/sstate/PATH"
> 
>  #
> @@ -229,7 +229,7 @@ BB_DISKMON_DIRS ??= "\
>  # Note: For this to work you also need hash-equivalence passthrough to the matching server
>  #
>  #BB_HASHSERVE_UPSTREAM = "typhoon.yocto.io:8687"
> -#SSTATE_MIRRORS ?= "file://.* http://sstate.yoctoproject.org/3.4/PATH;downloadfilename=PATH"
> +#SSTATE_MIRRORS ?= "file://.* https://sstate.yoctoproject.org/3.4/PATH;downloadfilename=PATH"
> 
>  #
>  # Qemu configuration
> --
> 2.25.1

//Peter

Re: [poky] [PATCH v2] local.conf.sample: use https instead of http for SSTATE_MIRRORS

[Michael Opdenacker]

Hi Peter,

Thank you very much for the review!

On 1/26/22 12:24, Peter Kjellerstedt wrote:
>> -----Original Message-----
>> From: poky@lists.yoctoproject.org <poky@lists.yoctoproject.org> On Behalf Of Michael Opdenacker
>> Sent: den 26 januari 2022 11:44
>> To: poky@lists.yoctoproject.org
>> Cc: Michael Opdenacker <michael.opdenacker@bootlin.com>
>> Subject: [poky] [PATCH v2] local.conf.sample: use https instead of http for SSTATE_MIRRORS
>>
>> Both http and https work, but we should get fewer questions
>> with https
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
>> ---
>>  meta-poky/conf/local.conf.sample | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta-poky/conf/local.conf.sample b/meta-poky/conf/local.conf.sample
>> index 7bdbba0..3100eb1 100644
>> --- a/meta-poky/conf/local.conf.sample
>> +++ b/meta-poky/conf/local.conf.sample
>> @@ -206,7 +206,7 @@ BB_DISKMON_DIRS ??= "\
>>  # used to accelerate build time. This variable can be used to configure the system
>>  # to search other mirror locations for these objects before it builds the data itself.
>>  #
>> -# This can be a filesystem directory, or a remote url such as http or ftp. These
>> +# This can be a filesystem directory, or a remote url such as https or ftp. These
>>  # would contain the sstate-cache results from previous builds (possibly from other
>>  # machines). This variable works like fetcher MIRRORS/PREMIRRORS and points to the
>>  # cache locations to check for the shared objects.
>> @@ -214,7 +214,7 @@ BB_DISKMON_DIRS ??= "\
>>  # at the end as shown in the examples below. This will be substituted with the
>>  # correct path within the directory structure.
>>  #SSTATE_MIRRORS ?= "\
>> -#file://.* http://someserver.tld/share/sstate/PATH;downloadfilename=PATH \n \
>> +#file://.* https://someserver.tld/share/sstate/PATH;downloadfilename=PATH \n \
> While there, you may as well remove the "\n".


Good idea. We already did that in other places.
However, shouldn't it be a separate commit? I can read Quentin's lips ;-)
Cheers
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [poky] [PATCH v2] local.conf.sample: use https instead of http for SSTATE_MIRRORS

[Peter Kjellerstedt]

> -----Original Message-----
> From: Michael Opdenacker <michael.opdenacker@bootlin.com>
> Sent: den 27 januari 2022 17:11
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>;
> poky@lists.yoctoproject.org
> Subject: Re: [poky] [PATCH v2] local.conf.sample: use https instead of
> http for SSTATE_MIRRORS
> 
> Hi Peter,
> 
> Thank you very much for the review!
> 
> On 1/26/22 12:24, Peter Kjellerstedt wrote:
> >> -----Original Message-----
> >> From: poky@lists.yoctoproject.org <poky@lists.yoctoproject.org> On Behalf Of Michael Opdenacker
> >> Sent: den 26 januari 2022 11:44
> >> To: poky@lists.yoctoproject.org
> >> Cc: Michael Opdenacker <michael.opdenacker@bootlin.com>
> >> Subject: [poky] [PATCH v2] local.conf.sample: use https instead of http for SSTATE_MIRRORS
> >>
> >> Both http and https work, but we should get fewer questions
> >> with https
> >>
> >> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> >> ---
> >>  meta-poky/conf/local.conf.sample | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/meta-poky/conf/local.conf.sample b/meta-poky/conf/local.conf.sample
> >> index 7bdbba0..3100eb1 100644
> >> --- a/meta-poky/conf/local.conf.sample
> >> +++ b/meta-poky/conf/local.conf.sample
> >> @@ -206,7 +206,7 @@ BB_DISKMON_DIRS ??= "\
> >>  # used to accelerate build time. This variable can be used to configure the system
> >>  # to search other mirror locations for these objects before it builds the data itself.
> >>  #
> >> -# This can be a filesystem directory, or a remote url such as http or ftp. These
> >> +# This can be a filesystem directory, or a remote url such as https or ftp. These
> >>  # would contain the sstate-cache results from previous builds (possibly from other
> >>  # machines). This variable works like fetcher MIRRORS/PREMIRRORS and points to the
> >>  # cache locations to check for the shared objects.
> >> @@ -214,7 +214,7 @@ BB_DISKMON_DIRS ??= "\
> >>  # at the end as shown in the examples below. This will be substituted with the
> >>  # correct path within the directory structure.
> >>  #SSTATE_MIRRORS ?= "\
> >> -#file://.* http://someserver.tld/share/sstate/PATH;downloadfilename=PATH \n \
> >> +#file://.* https://someserver.tld/share/sstate/PATH;downloadfilename=PATH \n \
> >
> > While there, you may as well remove the "\n".
> 
> Good idea. We already did that in other places.
> However, shouldn't it be a separate commit? I can read Quentin's lips ;-)

True. There are a couple of other places that can be updated as well. 
I'll send a patch.

> Cheers
> Michael.
> 
> --
> Michael Opdenacker, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

//Peter