* Re: [PATCH 2/9] Remove bdi_congested() and wb_congested() and related functions
@ 2022-01-27 19:08 kernel test robot
0 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2022-01-27 19:08 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 20602 bytes --]
CC: llvm(a)lists.linux.dev
CC: kbuild-all(a)lists.01.org
In-Reply-To: <164325158955.29787.4769373293473421057.stgit@noble.brown>
References: <164325158955.29787.4769373293473421057.stgit@noble.brown>
TO: NeilBrown <neilb@suse.de>
TO: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Jaegeuk Kim <jaegeuk@kernel.org>
TO: Chao Yu <yuchao0@huawei.com>, Chao Yu <chao@kernel.org>
TO: Jeff Layton <jlayton@kernel.org>
TO: Ilya Dryomov <idryomov@gmail.com>
TO: Miklos Szeredi <miklos@szeredi.hu>
TO: Trond Myklebust <trond.myklebust@hammerspace.com>
TO: Anna Schumaker <anna.schumaker@netapp.com>
TO: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Hi NeilBrown,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on jaegeuk-f2fs/dev-test]
[also build test WARNING on trondmy-nfs/linux-next linus/master v5.17-rc1 next-20220127]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/NeilBrown/Remove-remaining-parts-of-congestions-tracking-code/20220127-105051
base: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
:::::: branch date: 16 hours ago
:::::: commit date: 16 hours ago
config: riscv-randconfig-c006-20220124 (https://download.01.org/0day-ci/archive/20220128/202201280341.M0HhrMlw-lkp(a)intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project f32dccb9a43b02ce4e540d6ba5dbbdb188f2dc7d)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/0day-ci/linux/commit/4e63f49027815bc4037227b6d091210c86009e7a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review NeilBrown/Remove-remaining-parts-of-congestions-tracking-code/20220127-105051
git checkout 4e63f49027815bc4037227b6d091210c86009e7a
# save the config file to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv clang-analyzer
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
clang-analyzer warnings: (new ones prefixed by >>)
drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:1073:2: note: Taking true branch
if (!dm_pp_get_clock_levels_by_type_with_latency(
^
drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:1084:27: note: Access to field 'high_sclk' results in a dereference of a null pointer (loaded from field 'bw_vbios')
dc->bw_vbios->high_sclk = bw_frc_to_fixed(
~~~~~~~~ ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:1120:26: warning: Access to field 'high_sclk' results in a dereference of a null pointer (loaded from field 'bw_vbios') [clang-analyzer-core.NullDereference]
dc->bw_vbios->high_sclk = bw_frc_to_fixed(
~~~~~~~~ ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:1067:6: note: Assuming field 'bw_vbios' is null
if (dc->bw_vbios && dc->bw_vbios->memory_type == bw_def_hbm)
^~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:1067:19: note: Left side of '&&' is false
if (dc->bw_vbios && dc->bw_vbios->memory_type == bw_def_hbm)
^
drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:1073:6: note: Assuming the condition is false
if (!dm_pp_get_clock_levels_by_type_with_latency(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:1073:2: note: Taking false branch
if (!dm_pp_get_clock_levels_by_type_with_latency(
^
drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:1120:26: note: Access to field 'high_sclk' results in a dereference of a null pointer (loaded from field 'bw_vbios')
dc->bw_vbios->high_sclk = bw_frc_to_fixed(
~~~~~~~~ ^
Suppressed 9 warnings (9 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
8 warnings generated.
Suppressed 8 warnings (8 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
5 warnings generated.
Suppressed 5 warnings (5 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
12 warnings generated.
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:898:5: warning: Value stored to 'bp_result' is never read [clang-analyzer-deadcode.DeadStores]
bp_result = ctx->dc_bios->funcs->enable_lvtma_control(ctx->dc_bios,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:898:5: note: Value stored to 'bp_result' is never read
bp_result = ctx->dc_bios->funcs->enable_lvtma_control(ctx->dc_bios,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:902:5: warning: Value stored to 'bp_result' is never read [clang-analyzer-deadcode.DeadStores]
bp_result = ctx->dc_bios->funcs->enable_lvtma_control(ctx->dc_bios,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:902:5: note: Value stored to 'bp_result' is never read
bp_result = ctx->dc_bios->funcs->enable_lvtma_control(ctx->dc_bios,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:1028:19: warning: Access to field 'inst' results in a dereference of a null pointer (loaded from field 'panel_cntl') [clang-analyzer-core.NullDereference]
panel_instance = link->panel_cntl->inst;
^ ~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:981:6: note: Assuming the condition is false
if (dal_graphics_object_id_get_connector_id(link->link_enc->connector)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:981:2: note: Taking false branch
if (dal_graphics_object_id_get_connector_id(link->link_enc->connector)
^
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:987:6: note: Assuming field 'panel_cntl' is null
if (link->panel_cntl) {
^~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:987:2: note: Taking false branch
if (link->panel_cntl) {
^
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:1002:15: note: Assuming 'enable' is false
__func__, (enable ? "On":"Off"));
^
drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:45:48: note: expanded from macro 'DC_LOG_HW_RESUME_S3'
#define DC_LOG_HW_RESUME_S3(...) DRM_DEBUG_KMS(__VA_ARGS__)
^~~~~~~~~~~
include/drm/drm_print.h:534:31: note: expanded from macro 'DRM_DEBUG_KMS'
__drm_dbg(DRM_UT_KMS, fmt, ##__VA_ARGS__)
^~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:1002:15: note: '?' condition is false
__func__, (enable ? "On":"Off"));
^
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:1004:16: note: 'enable' is false
cntl.action = enable ?
^~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:1004:16: note: '?' condition is false
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:1028:19: note: Access to field 'inst' results in a dereference of a null pointer (loaded from field 'panel_cntl')
panel_instance = link->panel_cntl->inst;
^ ~~~~~~~~~~
Suppressed 9 warnings (9 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
6 warnings generated.
Suppressed 6 warnings (6 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
5 warnings generated.
fs/ext2/dir.c:477:2: warning: Value stored to 'err' is never read [clang-analyzer-deadcode.DeadStores]
err = ext2_commit_chunk(page, pos, len);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fs/ext2/dir.c:477:2: note: Value stored to 'err' is never read
err = ext2_commit_chunk(page, pos, len);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
5 warnings generated.
Suppressed 5 warnings (5 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
>> fs/ext2/ialloc.c:175:2: warning: Value stored to 'bdi' is never read [clang-analyzer-deadcode.DeadStores]
bdi = inode_to_bdi(inode);
^ ~~~~~~~~~~~~~~~~~~~
fs/ext2/ialloc.c:175:2: note: Value stored to 'bdi' is never read
bdi = inode_to_bdi(inode);
^ ~~~~~~~~~~~~~~~~~~~
fs/ext2/ialloc.c:301:4: warning: Value stored to 'desc' is never read [clang-analyzer-deadcode.DeadStores]
desc = best_desc;
^ ~~~~~~~~~
fs/ext2/ialloc.c:301:4: note: Value stored to 'desc' is never read
desc = best_desc;
^ ~~~~~~~~~
Suppressed 5 warnings (4 in non-user code, 1 with check filters).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
6 warnings generated.
fs/ext2/inode.c:809:23: warning: Value stored to 'sbi' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
struct ext2_sb_info *sbi = EXT2_SB(inode->i_sb);
^~~ ~~~~~~~~~~~~~~~~~~~~
fs/ext2/inode.c:809:23: note: Value stored to 'sbi' during its initialization is never read
struct ext2_sb_info *sbi = EXT2_SB(inode->i_sb);
^~~ ~~~~~~~~~~~~~~~~~~~~
Suppressed 5 warnings (5 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
14 warnings generated.
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c:73:2: warning: Value stored to 'temp' is never read [clang-analyzer-deadcode.DeadStores]
temp = RREG32(rec->mask_clk_reg);
^
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c:73:2: note: Value stored to 'temp' is never read
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c:77:2: warning: Value stored to 'temp' is never read [clang-analyzer-deadcode.DeadStores]
temp = RREG32(rec->mask_data_reg);
^
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c:77:2: note: Value stored to 'temp' is never read
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c:92:2: warning: Value stored to 'temp' is never read [clang-analyzer-deadcode.DeadStores]
temp = RREG32(rec->mask_clk_reg);
^
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c:92:2: note: Value stored to 'temp' is never read
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c:96:2: warning: Value stored to 'temp' is never read [clang-analyzer-deadcode.DeadStores]
temp = RREG32(rec->mask_data_reg);
^
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c:96:2: note: Value stored to 'temp' is never read
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c:312:3: warning: 4th function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage]
DRM_DEBUG("i2c 0x%02x 0x%02x read failed\n",
^
include/drm/drm_print.h:526:2: note: expanded from macro 'DRM_DEBUG'
__drm_dbg(DRM_UT_CORE, fmt, ##__VA_ARGS__)
^
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c:371:2: note: 'val' declared without an initial value
u8 val;
^~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c:373:6: note: Assuming field 'cd_valid' is true
if (!amdgpu_connector->router.cd_valid)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c:373:2: note: Taking false branch
if (!amdgpu_connector->router.cd_valid)
^
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c:376:6: note: Assuming field 'router_bus' is non-null
if (!amdgpu_connector->router_bus)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c:376:2: note: Taking false branch
if (!amdgpu_connector->router_bus)
^
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c:379:2: note: Calling 'amdgpu_i2c_get_byte'
amdgpu_i2c_get_byte(amdgpu_connector->router_bus,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c:308:6: note: Assuming the condition is false
if (i2c_transfer(&i2c_bus->adapter, msgs, 2) == 2) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c:308:2: note: Taking false branch
if (i2c_transfer(&i2c_bus->adapter, msgs, 2) == 2) {
^
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c:312:3: note: 4th function call argument is an uninitialized value
DRM_DEBUG("i2c 0x%02x 0x%02x read failed\n",
^
include/drm/drm_print.h:526:2: note: expanded from macro 'DRM_DEBUG'
__drm_dbg(DRM_UT_CORE, fmt, ##__VA_ARGS__)
^ ~~~~~~~~~~~
Suppressed 9 warnings (9 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
3 warnings generated.
Suppressed 3 warnings (3 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
3 warnings generated.
Suppressed 3 warnings (3 in non-user code).
vim +/bdi +175 fs/ext2/ialloc.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 154
^1da177e4c3f41 Linus Torvalds 2005-04-16 155 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 156 * We perform asynchronous prereading of the new inode's inode block when
^1da177e4c3f41 Linus Torvalds 2005-04-16 157 * we create the inode, in the expectation that the inode will be written
^1da177e4c3f41 Linus Torvalds 2005-04-16 158 * back soon. There are two reasons:
^1da177e4c3f41 Linus Torvalds 2005-04-16 159 *
^1da177e4c3f41 Linus Torvalds 2005-04-16 160 * - When creating a large number of files, the async prereads will be
^1da177e4c3f41 Linus Torvalds 2005-04-16 161 * nicely merged into large reads
^1da177e4c3f41 Linus Torvalds 2005-04-16 162 * - When writing out a large number of inodes, we don't need to keep on
^1da177e4c3f41 Linus Torvalds 2005-04-16 163 * stalling the writes while we read the inode block.
^1da177e4c3f41 Linus Torvalds 2005-04-16 164 *
^1da177e4c3f41 Linus Torvalds 2005-04-16 165 * FIXME: ext2_get_group_desc() needs to be simplified.
^1da177e4c3f41 Linus Torvalds 2005-04-16 166 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 167 static void ext2_preread_inode(struct inode *inode)
^1da177e4c3f41 Linus Torvalds 2005-04-16 168 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 169 unsigned long block_group;
^1da177e4c3f41 Linus Torvalds 2005-04-16 170 unsigned long offset;
^1da177e4c3f41 Linus Torvalds 2005-04-16 171 unsigned long block;
^1da177e4c3f41 Linus Torvalds 2005-04-16 172 struct ext2_group_desc * gdp;
^1da177e4c3f41 Linus Torvalds 2005-04-16 173 struct backing_dev_info *bdi;
^1da177e4c3f41 Linus Torvalds 2005-04-16 174
de1414a654e66b Christoph Hellwig 2015-01-14 @175 bdi = inode_to_bdi(inode);
^1da177e4c3f41 Linus Torvalds 2005-04-16 176
^1da177e4c3f41 Linus Torvalds 2005-04-16 177 block_group = (inode->i_ino - 1) / EXT2_INODES_PER_GROUP(inode->i_sb);
ef2fb67989d30f Eric Sandeen 2007-10-16 178 gdp = ext2_get_group_desc(inode->i_sb, block_group, NULL);
^1da177e4c3f41 Linus Torvalds 2005-04-16 179 if (gdp == NULL)
^1da177e4c3f41 Linus Torvalds 2005-04-16 180 return;
^1da177e4c3f41 Linus Torvalds 2005-04-16 181
^1da177e4c3f41 Linus Torvalds 2005-04-16 182 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 183 * Figure out the offset within the block group inode table
^1da177e4c3f41 Linus Torvalds 2005-04-16 184 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 185 offset = ((inode->i_ino - 1) % EXT2_INODES_PER_GROUP(inode->i_sb)) *
^1da177e4c3f41 Linus Torvalds 2005-04-16 186 EXT2_INODE_SIZE(inode->i_sb);
^1da177e4c3f41 Linus Torvalds 2005-04-16 187 block = le32_to_cpu(gdp->bg_inode_table) +
^1da177e4c3f41 Linus Torvalds 2005-04-16 188 (offset >> EXT2_BLOCK_SIZE_BITS(inode->i_sb));
^1da177e4c3f41 Linus Torvalds 2005-04-16 189 sb_breadahead(inode->i_sb, block);
^1da177e4c3f41 Linus Torvalds 2005-04-16 190 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 191
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 2/9] Remove bdi_congested() and wb_congested() and related functions
@ 2022-01-27 14:00 kernel test robot
2022-01-28 6:48 ` kernel test robot
0 siblings, 1 reply; 8+ messages in thread
From: kernel test robot @ 2022-01-27 14:00 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 4583 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <164325158955.29787.4769373293473421057.stgit@noble.brown>
References: <164325158955.29787.4769373293473421057.stgit@noble.brown>
TO: NeilBrown <neilb@suse.de>
TO: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Jaegeuk Kim <jaegeuk@kernel.org>
TO: Chao Yu <yuchao0@huawei.com>, Chao Yu <chao@kernel.org>
TO: Jeff Layton <jlayton@kernel.org>
TO: Ilya Dryomov <idryomov@gmail.com>
TO: Miklos Szeredi <miklos@szeredi.hu>
TO: Trond Myklebust <trond.myklebust@hammerspace.com>
TO: Anna Schumaker <anna.schumaker@netapp.com>
TO: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Hi NeilBrown,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on jaegeuk-f2fs/dev-test]
[also build test WARNING on trondmy-nfs/linux-next linus/master hnaz-mm/master v5.17-rc1 next-20220127]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/NeilBrown/Remove-remaining-parts-of-congestions-tracking-code/20220127-105051
base: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago
config: alpha-randconfig-s031-20220125 (https://download.01.org/0day-ci/archive/20220127/202201272132.s3GTQRtU-lkp(a)intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/4e63f49027815bc4037227b6d091210c86009e7a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review NeilBrown/Remove-remaining-parts-of-congestions-tracking-code/20220127-105051
git checkout 4e63f49027815bc4037227b6d091210c86009e7a
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=alpha SHELL=/bin/bash fs/nilfs2/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> fs/nilfs2/segbuf.c:358:2: sparse: sparse: unused label 'failed'
vim +/failed +358 fs/nilfs2/segbuf.c
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 338
9284ad2a9016ad Ryusuke Konishi 2009-11-25 339 static int nilfs_segbuf_submit_bio(struct nilfs_segment_buffer *segbuf,
b2d4586627ad26 Mike Christie 2016-06-05 340 struct nilfs_write_info *wi, int mode,
b2d4586627ad26 Mike Christie 2016-06-05 341 int mode_flags)
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 342 {
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 343 struct bio *bio = wi->bio;
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 344 int err;
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 345
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 346 bio->bi_end_io = nilfs_end_bio_write;
9284ad2a9016ad Ryusuke Konishi 2009-11-25 347 bio->bi_private = segbuf;
b2d4586627ad26 Mike Christie 2016-06-05 348 bio_set_op_attrs(bio, mode, mode_flags);
4e49ea4a3d2763 Mike Christie 2016-06-05 349 submit_bio(bio);
4bf93b50fd0411 Vyacheslav Dubeyko 2013-08-22 350 segbuf->sb_nbio++;
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 351
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 352 wi->bio = NULL;
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 353 wi->rest_blocks -= wi->end - wi->start;
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 354 wi->nr_vecs = min(wi->max_pages, wi->rest_blocks);
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 355 wi->start = wi->end;
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 356 return 0;
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 357
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 @358 failed:
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 359 wi->bio = NULL;
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 360 return err;
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 361 }
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 362
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 2/9] Remove bdi_congested() and wb_congested() and related functions
2022-01-27 14:00 kernel test robot
@ 2022-01-28 6:48 ` kernel test robot
0 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2022-01-28 6:48 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3844 bytes --]
Hi NeilBrown,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on jaegeuk-f2fs/dev-test]
[also build test WARNING on trondmy-nfs/linux-next linus/master hnaz-mm/master v5.17-rc1 next-20220127]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/NeilBrown/Remove-remaining-parts-of-congestions-tracking-code/20220127-105051
base: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
config: alpha-randconfig-s031-20220125 (https://download.01.org/0day-ci/archive/20220127/202201272132.s3GTQRtU-lkp(a)intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/4e63f49027815bc4037227b6d091210c86009e7a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review NeilBrown/Remove-remaining-parts-of-congestions-tracking-code/20220127-105051
git checkout 4e63f49027815bc4037227b6d091210c86009e7a
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=alpha SHELL=/bin/bash fs/nilfs2/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <yujie.liu@intel.com>
sparse warnings: (new ones prefixed by >>)
>> fs/nilfs2/segbuf.c:358:2: sparse: sparse: unused label 'failed'
vim +/failed +358 fs/nilfs2/segbuf.c
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 338
9284ad2a9016ad Ryusuke Konishi 2009-11-25 339 static int nilfs_segbuf_submit_bio(struct nilfs_segment_buffer *segbuf,
b2d4586627ad26 Mike Christie 2016-06-05 340 struct nilfs_write_info *wi, int mode,
b2d4586627ad26 Mike Christie 2016-06-05 341 int mode_flags)
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 342 {
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 343 struct bio *bio = wi->bio;
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 344 int err;
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 345
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 346 bio->bi_end_io = nilfs_end_bio_write;
9284ad2a9016ad Ryusuke Konishi 2009-11-25 347 bio->bi_private = segbuf;
b2d4586627ad26 Mike Christie 2016-06-05 348 bio_set_op_attrs(bio, mode, mode_flags);
4e49ea4a3d2763 Mike Christie 2016-06-05 349 submit_bio(bio);
4bf93b50fd0411 Vyacheslav Dubeyko 2013-08-22 350 segbuf->sb_nbio++;
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 351
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 352 wi->bio = NULL;
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 353 wi->rest_blocks -= wi->end - wi->start;
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 354 wi->nr_vecs = min(wi->max_pages, wi->rest_blocks);
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 355 wi->start = wi->end;
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 356 return 0;
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 357
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 @358 failed:
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 359 wi->bio = NULL;
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 360 return err;
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 361 }
64b5a32e0b3680 Ryusuke Konishi 2009-04-06 362
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 0/9] Remove remaining parts of congestions tracking code.
@ 2022-01-27 2:46 NeilBrown
2022-01-27 2:46 ` [PATCH 2/9] Remove bdi_congested() and wb_congested() and related functions NeilBrown
0 siblings, 1 reply; 8+ messages in thread
From: NeilBrown @ 2022-01-27 2:46 UTC (permalink / raw)
To: Andrew Morton, Jaegeuk Kim, Chao Yu, Jeff Layton, Ilya Dryomov,
Miklos Szeredi, Trond Myklebust, Anna Schumaker, Ryusuke Konishi,
Darrick J. Wong, Philipp Reisner, Lars Ellenberg, Paolo Valente,
Jens Axboe
Cc: linux-mm, linux-nilfs, linux-nfs, linux-fsdevel,
linux-f2fs-devel, linux-ext4, ceph-devel, drbd-dev, linux-kernel,
linux-block
Congestion hasn't been reliably tracked for quite some time.
Most MM uses of it for guiding writeback decisions were removed in 5.16.
Some other uses were removed in 17-rc1.
This series removes the remaining places that test for congestion, and
the few places which still set it.
The second patch touches a few filesystems. I didn't think there was
much value in splitting this out by filesystems, but if maintainers
would rather I did that, I will.
The f2fs, cephfs, fuse, NFS, and block patches can go through the
respective trees proving the final patch doesn't land until after they
all do - so maybe it should be held for 5.18-rc2 if all the rest lands
by 5.18-rc1.
Thanks,
NeilBrown
---
NeilBrown (9):
Remove inode_congested()
Remove bdi_congested() and wb_congested() and related functions
f2fs: change retry waiting for f2fs_write_single_data_page()
f2f2: replace some congestion_wait() calls with io_schedule_timeout()
cephfs: don't set/clear bdi_congestion
fuse: don't set/clear bdi_congested
NFS: remove congestion control.
block/bfq-iosched.c: use "false" rather than "BLK_RW_ASYNC"
Remove congestion tracking framework.
block/bfq-iosched.c | 2 +-
drivers/block/drbd/drbd_int.h | 3 --
drivers/block/drbd/drbd_req.c | 3 +-
fs/ceph/addr.c | 27 ---------------
fs/ceph/super.c | 2 --
fs/ceph/super.h | 2 --
fs/ext2/ialloc.c | 2 --
fs/f2fs/compress.c | 6 ++--
fs/f2fs/data.c | 9 +++--
fs/f2fs/segment.c | 14 ++++----
fs/f2fs/super.c | 8 ++---
fs/fuse/control.c | 17 ----------
fs/fuse/dev.c | 8 -----
fs/nfs/sysctl.c | 7 ----
fs/nfs/write.c | 53 +----------------------------
fs/nilfs2/segbuf.c | 11 ------
fs/xfs/xfs_buf.c | 3 --
include/linux/backing-dev-defs.h | 8 -----
include/linux/backing-dev.h | 28 ----------------
include/linux/nfs_fs.h | 1 -
include/linux/nfs_fs_sb.h | 1 -
include/trace/events/writeback.h | 28 ----------------
mm/backing-dev.c | 57 --------------------------------
mm/vmscan.c | 4 +--
24 files changed, 25 insertions(+), 279 deletions(-)
--
Signature
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 2/9] Remove bdi_congested() and wb_congested() and related functions
2022-01-27 2:46 [PATCH 0/9] Remove remaining parts of congestions tracking code NeilBrown
@ 2022-01-27 2:46 ` NeilBrown
2022-01-27 9:54 ` kernel test robot
2022-01-27 22:10 ` Ryusuke Konishi
0 siblings, 2 replies; 8+ messages in thread
From: NeilBrown @ 2022-01-27 2:46 UTC (permalink / raw)
To: Andrew Morton, Jaegeuk Kim, Chao Yu, Jeff Layton, Ilya Dryomov,
Miklos Szeredi, Trond Myklebust, Anna Schumaker, Ryusuke Konishi,
Darrick J. Wong, Philipp Reisner, Lars Ellenberg, Paolo Valente,
Jens Axboe
Cc: linux-mm, linux-nilfs, linux-nfs, linux-fsdevel,
linux-f2fs-devel, linux-ext4, ceph-devel, drbd-dev, linux-kernel,
linux-block
These functions are no longer useful as the only bdis that report
congestion are in ceph, fuse, and nfs. None of those bdis can be the
target of the calls in drbd, ext2, nilfs2, or xfs.
Removing the test on bdi_write_contested() in current_may_throttle()
could cause a small change in behaviour, but only when PF_LOCAL_THROTTLE
is set.
So replace the calls by 'false' and simplify the code - and remove the
functions.
Signed-off-by: NeilBrown <neilb@suse.de>
---
drivers/block/drbd/drbd_int.h | 3 ---
drivers/block/drbd/drbd_req.c | 3 +--
fs/ext2/ialloc.c | 2 --
fs/nilfs2/segbuf.c | 11 -----------
fs/xfs/xfs_buf.c | 3 ---
include/linux/backing-dev.h | 26 --------------------------
mm/vmscan.c | 4 +---
7 files changed, 2 insertions(+), 50 deletions(-)
diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h
index f27d5b0f9a0b..f804b1bfb3e6 100644
--- a/drivers/block/drbd/drbd_int.h
+++ b/drivers/block/drbd/drbd_int.h
@@ -638,9 +638,6 @@ enum {
STATE_SENT, /* Do not change state/UUIDs while this is set */
CALLBACK_PENDING, /* Whether we have a call_usermodehelper(, UMH_WAIT_PROC)
* pending, from drbd worker context.
- * If set, bdi_write_congested() returns true,
- * so shrink_page_list() would not recurse into,
- * and potentially deadlock on, this drbd worker.
*/
DISCONNECT_SENT,
diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c
index 3235532ae077..2e5fb7e442e3 100644
--- a/drivers/block/drbd/drbd_req.c
+++ b/drivers/block/drbd/drbd_req.c
@@ -909,8 +909,7 @@ static bool remote_due_to_read_balancing(struct drbd_device *device, sector_t se
switch (rbm) {
case RB_CONGESTED_REMOTE:
- return bdi_read_congested(
- device->ldev->backing_bdev->bd_disk->bdi);
+ return 0;
case RB_LEAST_PENDING:
return atomic_read(&device->local_cnt) >
atomic_read(&device->ap_pending_cnt) + atomic_read(&device->rs_pending_cnt);
diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
index df14e750e9fe..d632764da240 100644
--- a/fs/ext2/ialloc.c
+++ b/fs/ext2/ialloc.c
@@ -173,8 +173,6 @@ static void ext2_preread_inode(struct inode *inode)
struct backing_dev_info *bdi;
bdi = inode_to_bdi(inode);
- if (bdi_rw_congested(bdi))
- return;
block_group = (inode->i_ino - 1) / EXT2_INODES_PER_GROUP(inode->i_sb);
gdp = ext2_get_group_desc(inode->i_sb, block_group, NULL);
diff --git a/fs/nilfs2/segbuf.c b/fs/nilfs2/segbuf.c
index 43287b0d3e9b..d1ebc9da7130 100644
--- a/fs/nilfs2/segbuf.c
+++ b/fs/nilfs2/segbuf.c
@@ -343,17 +343,6 @@ static int nilfs_segbuf_submit_bio(struct nilfs_segment_buffer *segbuf,
struct bio *bio = wi->bio;
int err;
- if (segbuf->sb_nbio > 0 &&
- bdi_write_congested(segbuf->sb_super->s_bdi)) {
- wait_for_completion(&segbuf->sb_bio_event);
- segbuf->sb_nbio--;
- if (unlikely(atomic_read(&segbuf->sb_err))) {
- bio_put(bio);
- err = -EIO;
- goto failed;
- }
- }
-
bio->bi_end_io = nilfs_end_bio_write;
bio->bi_private = segbuf;
bio_set_op_attrs(bio, mode, mode_flags);
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
index b45e0d50a405..b7ebcfe6b8d3 100644
--- a/fs/xfs/xfs_buf.c
+++ b/fs/xfs/xfs_buf.c
@@ -843,9 +843,6 @@ xfs_buf_readahead_map(
{
struct xfs_buf *bp;
- if (bdi_read_congested(target->bt_bdev->bd_disk->bdi))
- return;
-
xfs_buf_read_map(target, map, nmaps,
XBF_TRYLOCK | XBF_ASYNC | XBF_READ_AHEAD, &bp, ops,
__this_address);
diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index 860b675c2929..2d764566280c 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -135,11 +135,6 @@ static inline bool writeback_in_progress(struct bdi_writeback *wb)
struct backing_dev_info *inode_to_bdi(struct inode *inode);
-static inline int wb_congested(struct bdi_writeback *wb, int cong_bits)
-{
- return wb->congested & cong_bits;
-}
-
long congestion_wait(int sync, long timeout);
static inline bool mapping_can_writeback(struct address_space *mapping)
@@ -391,27 +386,6 @@ static inline void wb_blkcg_offline(struct blkcg *blkcg)
#endif /* CONFIG_CGROUP_WRITEBACK */
-static inline int bdi_congested(struct backing_dev_info *bdi, int cong_bits)
-{
- return wb_congested(&bdi->wb, cong_bits);
-}
-
-static inline int bdi_read_congested(struct backing_dev_info *bdi)
-{
- return bdi_congested(bdi, 1 << WB_sync_congested);
-}
-
-static inline int bdi_write_congested(struct backing_dev_info *bdi)
-{
- return bdi_congested(bdi, 1 << WB_async_congested);
-}
-
-static inline int bdi_rw_congested(struct backing_dev_info *bdi)
-{
- return bdi_congested(bdi, (1 << WB_sync_congested) |
- (1 << WB_async_congested));
-}
-
const char *bdi_dev_name(struct backing_dev_info *bdi);
#endif /* _LINUX_BACKING_DEV_H */
diff --git a/mm/vmscan.c b/mm/vmscan.c
index ce8492939bd3..0b930556c4f2 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2362,9 +2362,7 @@ static unsigned int move_pages_to_lru(struct lruvec *lruvec,
*/
static int current_may_throttle(void)
{
- return !(current->flags & PF_LOCAL_THROTTLE) ||
- current->backing_dev_info == NULL ||
- bdi_write_congested(current->backing_dev_info);
+ return !(current->flags & PF_LOCAL_THROTTLE);
}
/*
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/9] Remove bdi_congested() and wb_congested() and related functions
2022-01-27 2:46 ` [PATCH 2/9] Remove bdi_congested() and wb_congested() and related functions NeilBrown
@ 2022-01-27 9:54 ` kernel test robot
2022-01-27 22:10 ` Ryusuke Konishi
1 sibling, 0 replies; 8+ messages in thread
From: kernel test robot @ 2022-01-27 9:54 UTC (permalink / raw)
To: NeilBrown, Andrew Morton, Jaegeuk Kim, Chao Yu, Chao Yu,
Jeff Layton, Ilya Dryomov, Miklos Szeredi, Trond Myklebust,
Anna Schumaker, Ryusuke Konishi
Cc: kbuild-all, Linux Memory Management List
Hi NeilBrown,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on jaegeuk-f2fs/dev-test]
[also build test WARNING on trondmy-nfs/linux-next linus/master hnaz-mm/master v5.17-rc1 next-20220127]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/NeilBrown/Remove-remaining-parts-of-congestions-tracking-code/20220127-105051
base: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220127/202201271751.kYuN2eRv-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/4e63f49027815bc4037227b6d091210c86009e7a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review NeilBrown/Remove-remaining-parts-of-congestions-tracking-code/20220127-105051
git checkout 4e63f49027815bc4037227b6d091210c86009e7a
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/ext2/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
fs/ext2/ialloc.c: In function 'ext2_preread_inode':
>> fs/ext2/ialloc.c:173:27: warning: variable 'bdi' set but not used [-Wunused-but-set-variable]
173 | struct backing_dev_info *bdi;
| ^~~
vim +/bdi +173 fs/ext2/ialloc.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 154
^1da177e4c3f41 Linus Torvalds 2005-04-16 155 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 156 * We perform asynchronous prereading of the new inode's inode block when
^1da177e4c3f41 Linus Torvalds 2005-04-16 157 * we create the inode, in the expectation that the inode will be written
^1da177e4c3f41 Linus Torvalds 2005-04-16 158 * back soon. There are two reasons:
^1da177e4c3f41 Linus Torvalds 2005-04-16 159 *
^1da177e4c3f41 Linus Torvalds 2005-04-16 160 * - When creating a large number of files, the async prereads will be
^1da177e4c3f41 Linus Torvalds 2005-04-16 161 * nicely merged into large reads
^1da177e4c3f41 Linus Torvalds 2005-04-16 162 * - When writing out a large number of inodes, we don't need to keep on
^1da177e4c3f41 Linus Torvalds 2005-04-16 163 * stalling the writes while we read the inode block.
^1da177e4c3f41 Linus Torvalds 2005-04-16 164 *
^1da177e4c3f41 Linus Torvalds 2005-04-16 165 * FIXME: ext2_get_group_desc() needs to be simplified.
^1da177e4c3f41 Linus Torvalds 2005-04-16 166 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 167 static void ext2_preread_inode(struct inode *inode)
^1da177e4c3f41 Linus Torvalds 2005-04-16 168 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 169 unsigned long block_group;
^1da177e4c3f41 Linus Torvalds 2005-04-16 170 unsigned long offset;
^1da177e4c3f41 Linus Torvalds 2005-04-16 171 unsigned long block;
^1da177e4c3f41 Linus Torvalds 2005-04-16 172 struct ext2_group_desc * gdp;
^1da177e4c3f41 Linus Torvalds 2005-04-16 @173 struct backing_dev_info *bdi;
^1da177e4c3f41 Linus Torvalds 2005-04-16 174
de1414a654e66b Christoph Hellwig 2015-01-14 175 bdi = inode_to_bdi(inode);
^1da177e4c3f41 Linus Torvalds 2005-04-16 176
^1da177e4c3f41 Linus Torvalds 2005-04-16 177 block_group = (inode->i_ino - 1) / EXT2_INODES_PER_GROUP(inode->i_sb);
ef2fb67989d30f Eric Sandeen 2007-10-16 178 gdp = ext2_get_group_desc(inode->i_sb, block_group, NULL);
^1da177e4c3f41 Linus Torvalds 2005-04-16 179 if (gdp == NULL)
^1da177e4c3f41 Linus Torvalds 2005-04-16 180 return;
^1da177e4c3f41 Linus Torvalds 2005-04-16 181
^1da177e4c3f41 Linus Torvalds 2005-04-16 182 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 183 * Figure out the offset within the block group inode table
^1da177e4c3f41 Linus Torvalds 2005-04-16 184 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 185 offset = ((inode->i_ino - 1) % EXT2_INODES_PER_GROUP(inode->i_sb)) *
^1da177e4c3f41 Linus Torvalds 2005-04-16 186 EXT2_INODE_SIZE(inode->i_sb);
^1da177e4c3f41 Linus Torvalds 2005-04-16 187 block = le32_to_cpu(gdp->bg_inode_table) +
^1da177e4c3f41 Linus Torvalds 2005-04-16 188 (offset >> EXT2_BLOCK_SIZE_BITS(inode->i_sb));
^1da177e4c3f41 Linus Torvalds 2005-04-16 189 sb_breadahead(inode->i_sb, block);
^1da177e4c3f41 Linus Torvalds 2005-04-16 190 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 191
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 2/9] Remove bdi_congested() and wb_congested() and related functions
@ 2022-01-27 9:54 ` kernel test robot
0 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2022-01-27 9:54 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4995 bytes --]
Hi NeilBrown,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on jaegeuk-f2fs/dev-test]
[also build test WARNING on trondmy-nfs/linux-next linus/master hnaz-mm/master v5.17-rc1 next-20220127]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/NeilBrown/Remove-remaining-parts-of-congestions-tracking-code/20220127-105051
base: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220127/202201271751.kYuN2eRv-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/4e63f49027815bc4037227b6d091210c86009e7a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review NeilBrown/Remove-remaining-parts-of-congestions-tracking-code/20220127-105051
git checkout 4e63f49027815bc4037227b6d091210c86009e7a
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/ext2/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
fs/ext2/ialloc.c: In function 'ext2_preread_inode':
>> fs/ext2/ialloc.c:173:27: warning: variable 'bdi' set but not used [-Wunused-but-set-variable]
173 | struct backing_dev_info *bdi;
| ^~~
vim +/bdi +173 fs/ext2/ialloc.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 154
^1da177e4c3f41 Linus Torvalds 2005-04-16 155 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 156 * We perform asynchronous prereading of the new inode's inode block when
^1da177e4c3f41 Linus Torvalds 2005-04-16 157 * we create the inode, in the expectation that the inode will be written
^1da177e4c3f41 Linus Torvalds 2005-04-16 158 * back soon. There are two reasons:
^1da177e4c3f41 Linus Torvalds 2005-04-16 159 *
^1da177e4c3f41 Linus Torvalds 2005-04-16 160 * - When creating a large number of files, the async prereads will be
^1da177e4c3f41 Linus Torvalds 2005-04-16 161 * nicely merged into large reads
^1da177e4c3f41 Linus Torvalds 2005-04-16 162 * - When writing out a large number of inodes, we don't need to keep on
^1da177e4c3f41 Linus Torvalds 2005-04-16 163 * stalling the writes while we read the inode block.
^1da177e4c3f41 Linus Torvalds 2005-04-16 164 *
^1da177e4c3f41 Linus Torvalds 2005-04-16 165 * FIXME: ext2_get_group_desc() needs to be simplified.
^1da177e4c3f41 Linus Torvalds 2005-04-16 166 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 167 static void ext2_preread_inode(struct inode *inode)
^1da177e4c3f41 Linus Torvalds 2005-04-16 168 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 169 unsigned long block_group;
^1da177e4c3f41 Linus Torvalds 2005-04-16 170 unsigned long offset;
^1da177e4c3f41 Linus Torvalds 2005-04-16 171 unsigned long block;
^1da177e4c3f41 Linus Torvalds 2005-04-16 172 struct ext2_group_desc * gdp;
^1da177e4c3f41 Linus Torvalds 2005-04-16 @173 struct backing_dev_info *bdi;
^1da177e4c3f41 Linus Torvalds 2005-04-16 174
de1414a654e66b Christoph Hellwig 2015-01-14 175 bdi = inode_to_bdi(inode);
^1da177e4c3f41 Linus Torvalds 2005-04-16 176
^1da177e4c3f41 Linus Torvalds 2005-04-16 177 block_group = (inode->i_ino - 1) / EXT2_INODES_PER_GROUP(inode->i_sb);
ef2fb67989d30f Eric Sandeen 2007-10-16 178 gdp = ext2_get_group_desc(inode->i_sb, block_group, NULL);
^1da177e4c3f41 Linus Torvalds 2005-04-16 179 if (gdp == NULL)
^1da177e4c3f41 Linus Torvalds 2005-04-16 180 return;
^1da177e4c3f41 Linus Torvalds 2005-04-16 181
^1da177e4c3f41 Linus Torvalds 2005-04-16 182 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 183 * Figure out the offset within the block group inode table
^1da177e4c3f41 Linus Torvalds 2005-04-16 184 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 185 offset = ((inode->i_ino - 1) % EXT2_INODES_PER_GROUP(inode->i_sb)) *
^1da177e4c3f41 Linus Torvalds 2005-04-16 186 EXT2_INODE_SIZE(inode->i_sb);
^1da177e4c3f41 Linus Torvalds 2005-04-16 187 block = le32_to_cpu(gdp->bg_inode_table) +
^1da177e4c3f41 Linus Torvalds 2005-04-16 188 (offset >> EXT2_BLOCK_SIZE_BITS(inode->i_sb));
^1da177e4c3f41 Linus Torvalds 2005-04-16 189 sb_breadahead(inode->i_sb, block);
^1da177e4c3f41 Linus Torvalds 2005-04-16 190 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 191
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/9] Remove bdi_congested() and wb_congested() and related functions
@ 2022-01-27 22:10 ` Ryusuke Konishi
0 siblings, 0 replies; 8+ messages in thread
From: Ryusuke Konishi @ 2022-01-27 22:10 UTC (permalink / raw)
To: NeilBrown
Cc: Andrew Morton, Jaegeuk Kim, Chao Yu, Jeff Layton, Ilya Dryomov,
Miklos Szeredi, Trond Myklebust, Anna Schumaker, Darrick J. Wong,
Philipp Reisner, Lars Ellenberg, Paolo Valente, Jens Axboe,
Linux MM, linux-nilfs, linux-nfs, linux-fsdevel,
linux-f2fs-devel, linux-ext4, ceph-devel, drbd-dev, LKML,
linux-block
On Thu, Jan 27, 2022 at 11:47 AM NeilBrown <neilb@suse.de> wrote:
>
> These functions are no longer useful as the only bdis that report
> congestion are in ceph, fuse, and nfs. None of those bdis can be the
> target of the calls in drbd, ext2, nilfs2, or xfs.
>
> Removing the test on bdi_write_contested() in current_may_throttle()
> could cause a small change in behaviour, but only when PF_LOCAL_THROTTLE
> is set.
>
> So replace the calls by 'false' and simplify the code - and remove the
> functions.
>
> Signed-off-by: NeilBrown <neilb@suse.de>
> ---
> drivers/block/drbd/drbd_int.h | 3 ---
> drivers/block/drbd/drbd_req.c | 3 +--
> fs/ext2/ialloc.c | 2 --
> fs/nilfs2/segbuf.c | 11 -----------
> fs/xfs/xfs_buf.c | 3 ---
> include/linux/backing-dev.h | 26 --------------------------
> mm/vmscan.c | 4 +---
> 7 files changed, 2 insertions(+), 50 deletions(-)
for nilfs2 bits,
Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Thanks,
Ryusuke Konishi
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/9] Remove bdi_congested() and wb_congested() and related functions
@ 2022-01-27 22:10 ` Ryusuke Konishi
0 siblings, 0 replies; 8+ messages in thread
From: Ryusuke Konishi @ 2022-01-27 22:10 UTC (permalink / raw)
To: NeilBrown
Cc: Andrew Morton, Jaegeuk Kim, Chao Yu, Jeff Layton, Ilya Dryomov,
Miklos Szeredi, Trond Myklebust, Anna Schumaker, Darrick J. Wong,
Philipp Reisner, Lars Ellenberg, Paolo Valente, Jens Axboe,
Linux MM, linux-nilfs, linux-nfs-u79uwXL29TY76Z2rM5mHXA,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA,
linux-f2fs-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
linux-ext4-u79uwXL29TY76Z2rM5mHXA,
ceph-devel-u79uwXL29TY76Z2rM5mHXA,
drbd-dev-cunTk1MwBs8qoQakbn7OcQ, LKML
On Thu, Jan 27, 2022 at 11:47 AM NeilBrown <neilb-l3A5Bk7waGM@public.gmane.org> wrote:
>
> These functions are no longer useful as the only bdis that report
> congestion are in ceph, fuse, and nfs. None of those bdis can be the
> target of the calls in drbd, ext2, nilfs2, or xfs.
>
> Removing the test on bdi_write_contested() in current_may_throttle()
> could cause a small change in behaviour, but only when PF_LOCAL_THROTTLE
> is set.
>
> So replace the calls by 'false' and simplify the code - and remove the
> functions.
>
> Signed-off-by: NeilBrown <neilb-l3A5Bk7waGM@public.gmane.org>
> ---
> drivers/block/drbd/drbd_int.h | 3 ---
> drivers/block/drbd/drbd_req.c | 3 +--
> fs/ext2/ialloc.c | 2 --
> fs/nilfs2/segbuf.c | 11 -----------
> fs/xfs/xfs_buf.c | 3 ---
> include/linux/backing-dev.h | 26 --------------------------
> mm/vmscan.c | 4 +---
> 7 files changed, 2 insertions(+), 50 deletions(-)
for nilfs2 bits,
Acked-by: Ryusuke Konishi <konishi.ryusuke-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Thanks,
Ryusuke Konishi
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-01-28 6:48 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-27 19:08 [PATCH 2/9] Remove bdi_congested() and wb_congested() and related functions kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-01-27 14:00 kernel test robot
2022-01-28 6:48 ` kernel test robot
2022-01-27 2:46 [PATCH 0/9] Remove remaining parts of congestions tracking code NeilBrown
2022-01-27 2:46 ` [PATCH 2/9] Remove bdi_congested() and wb_congested() and related functions NeilBrown
2022-01-27 9:54 ` kernel test robot
2022-01-27 9:54 ` kernel test robot
2022-01-27 22:10 ` Ryusuke Konishi
2022-01-27 22:10 ` Ryusuke Konishi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.