* [Buildroot] [URGENT 0/1] This patch is needed for host-util-linux @ 2022-02-01 23:22 Giulio Benetti 2022-02-01 23:22 ` [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure Giulio Benetti 0 siblings, 1 reply; 14+ messages in thread From: Giulio Benetti @ 2022-02-01 23:22 UTC (permalink / raw) To: buildroot Cc: Peter Seiderer, Thomas Petazzoni, Giulio Benetti, Yann E . MORIN host-util-linux is very used, so please apply this asap, otherwise a lot of builds will fail. Giulio Benetti (1): package/util-linux: fix host build failure package/util-linux/util-linux.mk | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure 2022-02-01 23:22 [Buildroot] [URGENT 0/1] This patch is needed for host-util-linux Giulio Benetti @ 2022-02-01 23:22 ` Giulio Benetti 2022-02-01 23:25 ` Giulio Benetti 2022-02-02 7:41 ` Arnout Vandecappelle 0 siblings, 2 replies; 14+ messages in thread From: Giulio Benetti @ 2022-02-01 23:22 UTC (permalink / raw) To: buildroot Cc: Peter Seiderer, Thomas Petazzoni, Giulio Benetti, Yann E . MORIN The UTIL_LINUX_FIX_DISK_UTILS_COMPILE workaround is needed for host building too. So let's add it to HOST_UTIL_LINUX_POST_PATCH_HOOKS. host-util-linux is used a lot, so this patch fixes a lot of future builds. Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- package/util-linux/util-linux.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk index e59ef7dadc..5a4ff64d01 100644 --- a/package/util-linux/util-linux.mk +++ b/package/util-linux/util-linux.mk @@ -41,6 +41,7 @@ define UTIL_LINUX_FIX_DISK_UTILS_COMPILE touch $(@D)/disk-utils/raw.8 endef UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE +HOST_UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE HOST_UTIL_LINUX_DEPENDENCIES = host-pkgconf -- 2.25.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure 2022-02-01 23:22 ` [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure Giulio Benetti @ 2022-02-01 23:25 ` Giulio Benetti 2022-02-02 7:41 ` Arnout Vandecappelle 1 sibling, 0 replies; 14+ messages in thread From: Giulio Benetti @ 2022-02-01 23:25 UTC (permalink / raw) To: buildroot; +Cc: Peter Seiderer, Yann E . MORIN, Thomas Petazzoni On 02/02/22 00:22, Giulio Benetti wrote: > The UTIL_LINUX_FIX_DISK_UTILS_COMPILE workaround is needed for host > building too. So let's add it to HOST_UTIL_LINUX_POST_PATCH_HOOKS. > host-util-linux is used a lot, so this patch fixes a lot of future > builds. I was too fast... Fixes: http://autobuild.buildroot.net/results/b8c/b8cb40efc036a01802c914544cd4fc29dfd67af6// and others that are coming out. Best regards! -- Giulio Benetti Benetti Engineering sas > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > --- > package/util-linux/util-linux.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk > index e59ef7dadc..5a4ff64d01 100644 > --- a/package/util-linux/util-linux.mk > +++ b/package/util-linux/util-linux.mk > @@ -41,6 +41,7 @@ define UTIL_LINUX_FIX_DISK_UTILS_COMPILE > touch $(@D)/disk-utils/raw.8 > endef > UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE > +HOST_UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE > > HOST_UTIL_LINUX_DEPENDENCIES = host-pkgconf > _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure 2022-02-01 23:22 ` [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure Giulio Benetti 2022-02-01 23:25 ` Giulio Benetti @ 2022-02-02 7:41 ` Arnout Vandecappelle 2022-02-02 20:42 ` Peter Seiderer 1 sibling, 1 reply; 14+ messages in thread From: Arnout Vandecappelle @ 2022-02-02 7:41 UTC (permalink / raw) To: Giulio Benetti, buildroot Cc: Peter Seiderer, Yann E . MORIN, Thomas Petazzoni On 02/02/2022 00:22, Giulio Benetti wrote: > The UTIL_LINUX_FIX_DISK_UTILS_COMPILE workaround is needed for host > building too. So let's add it to HOST_UTIL_LINUX_POST_PATCH_HOOKS. > host-util-linux is used a lot, so this patch fixes a lot of future > builds. Darn, I tested that, both with and without BR2_PACKAGE_HOST_UTIL_LINUX set. I don't understand what went wrong in my test... Anyway, applied to master, thanks. Regards, Arnout > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > --- > package/util-linux/util-linux.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk > index e59ef7dadc..5a4ff64d01 100644 > --- a/package/util-linux/util-linux.mk > +++ b/package/util-linux/util-linux.mk > @@ -41,6 +41,7 @@ define UTIL_LINUX_FIX_DISK_UTILS_COMPILE > touch $(@D)/disk-utils/raw.8 > endef > UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE > +HOST_UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE > > HOST_UTIL_LINUX_DEPENDENCIES = host-pkgconf > _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure 2022-02-02 7:41 ` Arnout Vandecappelle @ 2022-02-02 20:42 ` Peter Seiderer 2022-02-02 21:09 ` Giulio Benetti 0 siblings, 1 reply; 14+ messages in thread From: Peter Seiderer @ 2022-02-02 20:42 UTC (permalink / raw) To: Arnout Vandecappelle Cc: Thomas Petazzoni, Giulio Benetti, Yann E . MORIN, buildroot Hello Arnout, Giulio, On Wed, 2 Feb 2022 08:41:34 +0100, Arnout Vandecappelle <arnout@mind.be> wrote: > On 02/02/2022 00:22, Giulio Benetti wrote: > > The UTIL_LINUX_FIX_DISK_UTILS_COMPILE workaround is needed for host > > building too. So let's add it to HOST_UTIL_LINUX_POST_PATCH_HOOKS. > > host-util-linux is used a lot, so this patch fixes a lot of future > > builds. > > Darn, I tested that, both with and without BR2_PACKAGE_HOST_UTIL_LINUX set. I > don't understand what went wrong in my test... The raw support depends on the available toolchain headers, see e.g. package/util-linux/Config.in: config BR2_PACKAGE_UTIL_LINUX_RAW bool "raw" depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_14 help Build a linux raw character device Or according to [1] '--disable-raw' for the host build should do the trick too... Regards, Peter [1] https://github.com/util-linux/util-linux/issues/1577 > > Anyway, applied to master, thanks. > > Regards, > Arnout > > > > > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > > --- > > package/util-linux/util-linux.mk | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk > > index e59ef7dadc..5a4ff64d01 100644 > > --- a/package/util-linux/util-linux.mk > > +++ b/package/util-linux/util-linux.mk > > @@ -41,6 +41,7 @@ define UTIL_LINUX_FIX_DISK_UTILS_COMPILE > > touch $(@D)/disk-utils/raw.8 > > endef > > UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE > > +HOST_UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE > > > > HOST_UTIL_LINUX_DEPENDENCIES = host-pkgconf > > _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure 2022-02-02 20:42 ` Peter Seiderer @ 2022-02-02 21:09 ` Giulio Benetti 2022-02-02 21:40 ` Peter Seiderer 0 siblings, 1 reply; 14+ messages in thread From: Giulio Benetti @ 2022-02-02 21:09 UTC (permalink / raw) To: Peter Seiderer, Arnout Vandecappelle Cc: Yann E . MORIN, Thomas Petazzoni, buildroot Hi Peter, On 02/02/22 21:42, Peter Seiderer wrote: > Hello Arnout, Giulio, > > On Wed, 2 Feb 2022 08:41:34 +0100, Arnout Vandecappelle <arnout@mind.be> wrote: > >> On 02/02/2022 00:22, Giulio Benetti wrote: >>> The UTIL_LINUX_FIX_DISK_UTILS_COMPILE workaround is needed for host >>> building too. So let's add it to HOST_UTIL_LINUX_POST_PATCH_HOOKS. >>> host-util-linux is used a lot, so this patch fixes a lot of future >>> builds. >> >> Darn, I tested that, both with and without BR2_PACKAGE_HOST_UTIL_LINUX set. I >> don't understand what went wrong in my test... > > The raw support depends on the available toolchain headers, see e.g. > package/util-linux/Config.in: > > config BR2_PACKAGE_UTIL_LINUX_RAW > bool "raw" > depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_14 > help > Build a linux raw character device > > Or according to [1] '--disable-raw' for the host build should do > the trick too... I was in hurry to produce the patch last night, so I went for the fastest way. Can you give a try with --disable-raw and eventually submit the patch? That would save some time while building. Also because host-util-linux is used a lot Thank you! Best regards -- Giulio Benetti Benetti Engineering sas > Regards, > Peter > > [1] https://github.com/util-linux/util-linux/issues/1577 > >> >> Anyway, applied to master, thanks. >> >> Regards, >> Arnout >> >> >>> >>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >>> --- >>> package/util-linux/util-linux.mk | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk >>> index e59ef7dadc..5a4ff64d01 100644 >>> --- a/package/util-linux/util-linux.mk >>> +++ b/package/util-linux/util-linux.mk >>> @@ -41,6 +41,7 @@ define UTIL_LINUX_FIX_DISK_UTILS_COMPILE >>> touch $(@D)/disk-utils/raw.8 >>> endef >>> UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE >>> +HOST_UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE >>> >>> HOST_UTIL_LINUX_DEPENDENCIES = host-pkgconf >>> > _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure 2022-02-02 21:09 ` Giulio Benetti @ 2022-02-02 21:40 ` Peter Seiderer 2022-02-02 21:54 ` Giulio Benetti 2022-02-02 22:10 ` [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure Giulio Benetti 0 siblings, 2 replies; 14+ messages in thread From: Peter Seiderer @ 2022-02-02 21:40 UTC (permalink / raw) To: Giulio Benetti; +Cc: Yann E . MORIN, Thomas Petazzoni, buildroot Hello Giulio, On Wed, 2 Feb 2022 22:09:22 +0100, Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > Hi Peter, > > On 02/02/22 21:42, Peter Seiderer wrote: > > Hello Arnout, Giulio, > > > > On Wed, 2 Feb 2022 08:41:34 +0100, Arnout Vandecappelle <arnout@mind.be> wrote: > > > >> On 02/02/2022 00:22, Giulio Benetti wrote: > >>> The UTIL_LINUX_FIX_DISK_UTILS_COMPILE workaround is needed for host > >>> building too. So let's add it to HOST_UTIL_LINUX_POST_PATCH_HOOKS. > >>> host-util-linux is used a lot, so this patch fixes a lot of future > >>> builds. > >> > >> Darn, I tested that, both with and without BR2_PACKAGE_HOST_UTIL_LINUX set. I > >> don't understand what went wrong in my test... > > > > The raw support depends on the available toolchain headers, see e.g. > > package/util-linux/Config.in: > > > > config BR2_PACKAGE_UTIL_LINUX_RAW > > bool "raw" > > depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_14 > > help > > Build a linux raw character device > > > > Or according to [1] '--disable-raw' for the host build should do > > the trick too... > > I was in hurry to produce the patch last night, so I went for the > fastest way. Can you give a try with --disable-raw and eventually submit Thanks for taking care! > the patch? That would save some time while building. Also because > host-util-linux is used a lot Sorry, could not reproduce the host-build failure on my system, seems the toolchain is too up-to-date (openSUSE Tumbleweed - gcc-11.2.1) ;-) But can provide an RFC patch for testing... Regards, Peter > > Thank you! > Best regards _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure 2022-02-02 21:40 ` Peter Seiderer @ 2022-02-02 21:54 ` Giulio Benetti 2022-02-02 22:05 ` [Buildroot] [PATCH] package/util-linux: improve host build failure fix Giulio Benetti 2022-02-02 22:10 ` [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure Giulio Benetti 1 sibling, 1 reply; 14+ messages in thread From: Giulio Benetti @ 2022-02-02 21:54 UTC (permalink / raw) To: Peter Seiderer; +Cc: Yann E . MORIN, Thomas Petazzoni, buildroot On 02/02/22 22:40, Peter Seiderer wrote: > Hello Giulio, > > On Wed, 2 Feb 2022 22:09:22 +0100, Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > >> Hi Peter, >> >> On 02/02/22 21:42, Peter Seiderer wrote: >>> Hello Arnout, Giulio, >>> >>> On Wed, 2 Feb 2022 08:41:34 +0100, Arnout Vandecappelle <arnout@mind.be> wrote: >>> >>>> On 02/02/2022 00:22, Giulio Benetti wrote: >>>>> The UTIL_LINUX_FIX_DISK_UTILS_COMPILE workaround is needed for host >>>>> building too. So let's add it to HOST_UTIL_LINUX_POST_PATCH_HOOKS. >>>>> host-util-linux is used a lot, so this patch fixes a lot of future >>>>> builds. >>>> >>>> Darn, I tested that, both with and without BR2_PACKAGE_HOST_UTIL_LINUX set. I >>>> don't understand what went wrong in my test... >>> >>> The raw support depends on the available toolchain headers, see e.g. >>> package/util-linux/Config.in: >>> >>> config BR2_PACKAGE_UTIL_LINUX_RAW >>> bool "raw" >>> depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_14 >>> help >>> Build a linux raw character device >>> >>> Or according to [1] '--disable-raw' for the host build should do >>> the trick too... >> >> I was in hurry to produce the patch last night, so I went for the >> fastest way. Can you give a try with --disable-raw and eventually submit > > Thanks for taking care! > >> the patch? That would save some time while building. Also because >> host-util-linux is used a lot > > Sorry, could not reproduce the host-build failure on my system, seems the > toolchain is too up-to-date (openSUSE Tumbleweed - gcc-11.2.1) ;-) > > But can provide an RFC patch for testing... I give a go on my pc and if it works I add Suggested-by: Peter Seiderer <ps.report@gmx.net> Are you on IRC? If yes my nick is benettig you can ping me there :-) Best regards -- Giulio Benetti Benetti Engineering sas _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH] package/util-linux: improve host build failure fix 2022-02-02 21:54 ` Giulio Benetti @ 2022-02-02 22:05 ` Giulio Benetti 2022-02-03 20:23 ` Peter Seiderer 0 siblings, 1 reply; 14+ messages in thread From: Giulio Benetti @ 2022-02-02 22:05 UTC (permalink / raw) To: buildroot Cc: Peter Seiderer, Thomas Petazzoni, Giulio Benetti, Yann E . MORIN As suggested by Peter Seiderer package util-linux doesn't need raw support when built for host, so let's remove: HOST_UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE in favor of: HOST_UTIL_LINUX_CONF_OPTS += --disable-raw This is a better approach than my commit: https://git.buildroot.net/buildroot/commit/?id=d895bd973b35fde10d3dd7db530d9e4782926497 Suggested-by: Peter Seiderer <ps.report@gmx.net> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- package/util-linux/util-linux.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk index 5a4ff64d01..f3297257cf 100644 --- a/package/util-linux/util-linux.mk +++ b/package/util-linux/util-linux.mk @@ -41,7 +41,6 @@ define UTIL_LINUX_FIX_DISK_UTILS_COMPILE touch $(@D)/disk-utils/raw.8 endef UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE -HOST_UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE HOST_UTIL_LINUX_DEPENDENCIES = host-pkgconf @@ -49,7 +48,8 @@ HOST_UTIL_LINUX_DEPENDENCIES = host-pkgconf HOST_UTIL_LINUX_CONF_OPTS = \ --without-systemd \ --with-systemdsystemunitdir=no \ - --without-python + --without-python \ + --disable-raw ifneq ($(BR2_PACKAGE_UTIL_LINUX_BINARIES)$(BR2_PACKAGE_UTIL_LINUX_CRAMFS)$(BR2_PACKAGE_UTIL_LINUX_FSCK)$(BR2_PACKAGE_UTIL_LINUX_LOSETUP),) UTIL_LINUX_SELINUX_MODULES = fstools -- 2.25.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH] package/util-linux: improve host build failure fix 2022-02-02 22:05 ` [Buildroot] [PATCH] package/util-linux: improve host build failure fix Giulio Benetti @ 2022-02-03 20:23 ` Peter Seiderer 2022-02-03 22:29 ` Giulio Benetti 2022-02-03 22:31 ` [Buildroot] [PATCH v2] " Giulio Benetti 0 siblings, 2 replies; 14+ messages in thread From: Peter Seiderer @ 2022-02-03 20:23 UTC (permalink / raw) To: Giulio Benetti; +Cc: Yann E . MORIN, Thomas Petazzoni, buildroot Hello Giulio, On Wed, 2 Feb 2022 23:05:38 +0100, Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > As suggested by Peter Seiderer package util-linux doesn't need raw support > when built for host, so let's remove: > HOST_UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE > in favor of: > HOST_UTIL_LINUX_CONF_OPTS += --disable-raw > This is a better approach than my commit: > https://git.buildroot.net/buildroot/commit/?id=d895bd973b35fde10d3dd7db530d9e4782926497 > > Suggested-by: Peter Seiderer <ps.report@gmx.net> > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Tested with registry.gitlab.com/buildroot.org/buildroot/base:20220105.2314: - reverted 'package/util-linux: fix host build failure' (d895bd973b35fde10d3dd7db530d9e4782926497) --> build fails with: No rule to make target 'disk-utils/raw.8' - build with 'package/util-linux: fix host build failure' (d895bd973b35fde10d3dd7db530d9e4782926497) --> build o.k. - build with this additional patch --> build o.k. Tested-by: Peter Seiderer <ps.report@gmx.net> > --- > package/util-linux/util-linux.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk > index 5a4ff64d01..f3297257cf 100644 > --- a/package/util-linux/util-linux.mk > +++ b/package/util-linux/util-linux.mk > @@ -41,7 +41,6 @@ define UTIL_LINUX_FIX_DISK_UTILS_COMPILE > touch $(@D)/disk-utils/raw.8 > endef > UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE > -HOST_UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE > > HOST_UTIL_LINUX_DEPENDENCIES = host-pkgconf > The line above reads: # We also don't want the host-python dependency > @@ -49,7 +48,8 @@ HOST_UTIL_LINUX_DEPENDENCIES = host-pkgconf > HOST_UTIL_LINUX_CONF_OPTS = \ > --without-systemd \ > --with-systemdsystemunitdir=no \ > - --without-python > + --without-python \ > + --disable-raw So I would move the 'disable-raw' down to line 196ff (or below to an extra 'HOST_UTIL_LINUX_CONF_OPTS +=' section with comment why... With this change you can add my: Reviewed-by: Peter Seiderer <ps.report@gmx.net> Regards, Peter > > ifneq ($(BR2_PACKAGE_UTIL_LINUX_BINARIES)$(BR2_PACKAGE_UTIL_LINUX_CRAMFS)$(BR2_PACKAGE_UTIL_LINUX_FSCK)$(BR2_PACKAGE_UTIL_LINUX_LOSETUP),) > UTIL_LINUX_SELINUX_MODULES = fstools _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH] package/util-linux: improve host build failure fix 2022-02-03 20:23 ` Peter Seiderer @ 2022-02-03 22:29 ` Giulio Benetti 2022-02-03 22:31 ` [Buildroot] [PATCH v2] " Giulio Benetti 1 sibling, 0 replies; 14+ messages in thread From: Giulio Benetti @ 2022-02-03 22:29 UTC (permalink / raw) To: Peter Seiderer; +Cc: Yann E . MORIN, Thomas Petazzoni, buildroot Hi Peter, On 03/02/22 21:23, Peter Seiderer wrote: > Hello Giulio, > > On Wed, 2 Feb 2022 23:05:38 +0100, Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > >> As suggested by Peter Seiderer package util-linux doesn't need raw support >> when built for host, so let's remove: >> HOST_UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE >> in favor of: >> HOST_UTIL_LINUX_CONF_OPTS += --disable-raw >> This is a better approach than my commit: >> https://git.buildroot.net/buildroot/commit/?id=d895bd973b35fde10d3dd7db530d9e4782926497 >> >> Suggested-by: Peter Seiderer <ps.report@gmx.net> >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > > Tested with registry.gitlab.com/buildroot.org/buildroot/base:20220105.2314: > > - reverted 'package/util-linux: fix host build failure' (d895bd973b35fde10d3dd7db530d9e4782926497) > --> build fails with: No rule to make target 'disk-utils/raw.8' > > - build with 'package/util-linux: fix host build failure' (d895bd973b35fde10d3dd7db530d9e4782926497) > --> build o.k. > > - build with this additional patch > --> build o.k. > > Tested-by: Peter Seiderer <ps.report@gmx.net> > > >> --- >> package/util-linux/util-linux.mk | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk >> index 5a4ff64d01..f3297257cf 100644 >> --- a/package/util-linux/util-linux.mk >> +++ b/package/util-linux/util-linux.mk >> @@ -41,7 +41,6 @@ define UTIL_LINUX_FIX_DISK_UTILS_COMPILE >> touch $(@D)/disk-utils/raw.8 >> endef >> UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE >> -HOST_UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE >> >> HOST_UTIL_LINUX_DEPENDENCIES = host-pkgconf >> > > The line above reads: > > # We also don't want the host-python dependency Oh, you're totally right >> @@ -49,7 +48,8 @@ HOST_UTIL_LINUX_DEPENDENCIES = host-pkgconf >> HOST_UTIL_LINUX_CONF_OPTS = \ >> --without-systemd \ >> --with-systemdsystemunitdir=no \ >> - --without-python >> + --without-python \ >> + --disable-raw > > So I would move the 'disable-raw' down to line 196ff (or below to an > extra 'HOST_UTIL_LINUX_CONF_OPTS +=' section with comment why... Yes > With this change you can add my: > > Reviewed-by: Peter Seiderer <ps.report@gmx.net> > > Regards, > Peter > >> >> ifneq ($(BR2_PACKAGE_UTIL_LINUX_BINARIES)$(BR2_PACKAGE_UTIL_LINUX_CRAMFS)$(BR2_PACKAGE_UTIL_LINUX_FSCK)$(BR2_PACKAGE_UTIL_LINUX_LOSETUP),) >> UTIL_LINUX_SELINUX_MODULES = fstools > Thank you! Going to reply with V2. Best regards -- Giulio Benetti Benetti Engineering sas _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH v2] package/util-linux: improve host build failure fix 2022-02-03 20:23 ` Peter Seiderer 2022-02-03 22:29 ` Giulio Benetti @ 2022-02-03 22:31 ` Giulio Benetti 2022-02-12 22:02 ` Arnout Vandecappelle 1 sibling, 1 reply; 14+ messages in thread From: Giulio Benetti @ 2022-02-03 22:31 UTC (permalink / raw) To: buildroot Cc: Giulio Benetti, Peter Seiderer, Yann E . MORIN, Thomas Petazzoni As suggested by Peter Seiderer package util-linux doesn't need raw support when built for host, so let's remove: HOST_UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE in favor of: HOST_UTIL_LINUX_CONF_OPTS += --disable-raw This is a better approach than my commit: https://git.buildroot.net/buildroot/commit/?id=d895bd973b35fde10d3dd7db530d9e4782926497 Suggested-by: Peter Seiderer <ps.report@gmx.net> Tested-by: Peter Seiderer <ps.report@gmx.net> Reviewed-by: Peter Seiderer <ps.report@gmx.net> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- V1->V2: * move --disable-raw to a dedicated HOST_UTIL_LINUX_CONF_OPTS as suggested by Peter Seiderer. This avoid ambiguity since previously it was under the comment "# We also don't want the host-python dependency". --- package/util-linux/util-linux.mk | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk index 5a4ff64d01..40fd518a58 100644 --- a/package/util-linux/util-linux.mk +++ b/package/util-linux/util-linux.mk @@ -41,7 +41,6 @@ define UTIL_LINUX_FIX_DISK_UTILS_COMPILE touch $(@D)/disk-utils/raw.8 endef UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE -HOST_UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE HOST_UTIL_LINUX_DEPENDENCIES = host-pkgconf @@ -202,6 +201,11 @@ HOST_UTIL_LINUX_CONF_OPTS += \ --without-ncursesw \ --without-tinfo +# Disable raw command since starting from version 2.37 needs a +# work-around to build but in the end we don't need at all. +HOST_UTIL_LINUX_CONF_OPTS += \ + --disable-raw + ifeq ($(BR2_PACKAGE_HOST_UTIL_LINUX),y) HOST_UTIL_LINUX_CONF_OPTS += --disable-makeinstall-chown # disable commands that have ncurses dependency, as well as -- 2.25.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH v2] package/util-linux: improve host build failure fix 2022-02-03 22:31 ` [Buildroot] [PATCH v2] " Giulio Benetti @ 2022-02-12 22:02 ` Arnout Vandecappelle 0 siblings, 0 replies; 14+ messages in thread From: Arnout Vandecappelle @ 2022-02-12 22:02 UTC (permalink / raw) To: Giulio Benetti, buildroot Cc: Peter Seiderer, Yann E . MORIN, Thomas Petazzoni On 03/02/2022 23:31, Giulio Benetti wrote: > As suggested by Peter Seiderer package util-linux doesn't need raw support > when built for host, so let's remove: > HOST_UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE > in favor of: > HOST_UTIL_LINUX_CONF_OPTS += --disable-raw > This is a better approach than my commit: > https://git.buildroot.net/buildroot/commit/?id=d895bd973b35fde10d3dd7db530d9e4782926497 > > Suggested-by: Peter Seiderer <ps.report@gmx.net> > Tested-by: Peter Seiderer <ps.report@gmx.net> > Reviewed-by: Peter Seiderer <ps.report@gmx.net> > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Applied to master, thanks. Regards, Arnout > --- > V1->V2: > * move --disable-raw to a dedicated HOST_UTIL_LINUX_CONF_OPTS as suggested > by Peter Seiderer. This avoid ambiguity since previously it was under the > comment "# We also don't want the host-python dependency". > --- > package/util-linux/util-linux.mk | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk > index 5a4ff64d01..40fd518a58 100644 > --- a/package/util-linux/util-linux.mk > +++ b/package/util-linux/util-linux.mk > @@ -41,7 +41,6 @@ define UTIL_LINUX_FIX_DISK_UTILS_COMPILE > touch $(@D)/disk-utils/raw.8 > endef > UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE > -HOST_UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE > > HOST_UTIL_LINUX_DEPENDENCIES = host-pkgconf > > @@ -202,6 +201,11 @@ HOST_UTIL_LINUX_CONF_OPTS += \ > --without-ncursesw \ > --without-tinfo > > +# Disable raw command since starting from version 2.37 needs a > +# work-around to build but in the end we don't need at all. > +HOST_UTIL_LINUX_CONF_OPTS += \ > + --disable-raw > + > ifeq ($(BR2_PACKAGE_HOST_UTIL_LINUX),y) > HOST_UTIL_LINUX_CONF_OPTS += --disable-makeinstall-chown > # disable commands that have ncurses dependency, as well as _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure 2022-02-02 21:40 ` Peter Seiderer 2022-02-02 21:54 ` Giulio Benetti @ 2022-02-02 22:10 ` Giulio Benetti 1 sibling, 0 replies; 14+ messages in thread From: Giulio Benetti @ 2022-02-02 22:10 UTC (permalink / raw) To: Peter Seiderer; +Cc: Yann E . MORIN, Thomas Petazzoni, buildroot Hi Peter, On 02/02/22 22:40, Peter Seiderer wrote: > Hello Giulio, > > On Wed, 2 Feb 2022 22:09:22 +0100, Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > >> Hi Peter, >> >> On 02/02/22 21:42, Peter Seiderer wrote: >>> Hello Arnout, Giulio, >>> >>> On Wed, 2 Feb 2022 08:41:34 +0100, Arnout Vandecappelle <arnout@mind.be> wrote: >>> >>>> On 02/02/2022 00:22, Giulio Benetti wrote: >>>>> The UTIL_LINUX_FIX_DISK_UTILS_COMPILE workaround is needed for host >>>>> building too. So let's add it to HOST_UTIL_LINUX_POST_PATCH_HOOKS. >>>>> host-util-linux is used a lot, so this patch fixes a lot of future >>>>> builds. >>>> >>>> Darn, I tested that, both with and without BR2_PACKAGE_HOST_UTIL_LINUX set. I >>>> don't understand what went wrong in my test... >>> >>> The raw support depends on the available toolchain headers, see e.g. >>> package/util-linux/Config.in: >>> >>> config BR2_PACKAGE_UTIL_LINUX_RAW >>> bool "raw" >>> depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_14 >>> help >>> Build a linux raw character device >>> >>> Or according to [1] '--disable-raw' for the host build should do >>> the trick too... >> >> I was in hurry to produce the patch last night, so I went for the >> fastest way. Can you give a try with --disable-raw and eventually submit > > Thanks for taking care! I've just sent a patch like you've suggested: https://patchwork.ozlabs.org/project/buildroot/patch/20220202220538.2858380-1-giulio.benetti@benettiengineering.com/ >> the patch? That would save some time while building. Also because >> host-util-linux is used a lot > > Sorry, could not reproduce the host-build failure on my system, seems the > toolchain is too up-to-date (openSUSE Tumbleweed - gcc-11.2.1) ;-) For this situation you can use this docker: docker pull registry.gitlab.com/buildroot.org/buildroot/base:20220105.2314 There gcc is version 10.2.1 and it's the official one used for build-testing buildroot defconfigs. You can find it also in buildroot/.gitlab-ci.yml Can you give a go with that docker by reproducing the failure and then applying the latest patch? That way you can give a Reviewed-by: or also a Tested-by: you Thank you! Kind regards -- Giulio Benetti Benetti Engineering sas _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2022-02-12 22:02 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-02-01 23:22 [Buildroot] [URGENT 0/1] This patch is needed for host-util-linux Giulio Benetti 2022-02-01 23:22 ` [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure Giulio Benetti 2022-02-01 23:25 ` Giulio Benetti 2022-02-02 7:41 ` Arnout Vandecappelle 2022-02-02 20:42 ` Peter Seiderer 2022-02-02 21:09 ` Giulio Benetti 2022-02-02 21:40 ` Peter Seiderer 2022-02-02 21:54 ` Giulio Benetti 2022-02-02 22:05 ` [Buildroot] [PATCH] package/util-linux: improve host build failure fix Giulio Benetti 2022-02-03 20:23 ` Peter Seiderer 2022-02-03 22:29 ` Giulio Benetti 2022-02-03 22:31 ` [Buildroot] [PATCH v2] " Giulio Benetti 2022-02-12 22:02 ` Arnout Vandecappelle 2022-02-02 22:10 ` [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure Giulio Benetti
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.