From: Marek Vasut <marex@denx.de>
To: dri-devel@lists.freedesktop.org
Cc: Marek Vasut <marex@denx.de>, Robert Foss <robert.foss@linaro.org>,
Jagan Teki <jagan@amarulasolutions.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Sam Ravnborg <sam@ravnborg.org>,
Maxime Ripard <maxime@cerno.tech>
Subject: [PATCH V3 00/13] drm: bridge: icn6211: Fix hard-coded panel settings and add I2C support
Date: Fri, 4 Mar 2022 01:24:55 +0100 [thread overview]
Message-ID: <20220304002508.75676-1-marex@denx.de> (raw)
This series fixes multiple problems with the ICN6211 driver and adds
support for configuration of the chip via I2C bus.
First, in the current state, the ICN6211 driver hard-codes DPI timing
and clock settings specific to some unknown panel. The settings provided
by panel driver are ignored. Using any other panel than the one for which
this driver is currently hard-coded can lead to permanent damage of the
panel (per display supplier warning, and it sure did in my case. The
damage looks like multiple rows of dead pixels at the bottom of the
panel, and this is not going away even after long power off time).
Much of this series thus fixes incorrect register layout, DPI timing
programming, clock generation by adding actual PLL configuration code.
This series also adds lane count decoding instead of using hard-coded
value, and fills in a couple of registers with likely correct default
values.
Second, this series adds support for I2C configuration of the ICN6211.
The device can be configured either via DSI command mode or via I2C,
the register layout is the same in both cases.
Since the datasheet for this device is very hard to come by, a lot of
information has been salvaged from [1] and [2].
[1] https://github.com/rockchip-linux/kernel/blob/develop-4.19/drivers/gpu/drm/bridge/icn6211.c
[2] https://github.com/tdjastrzebski/ICN6211-Configurator
Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: Maxime Ripard <maxime@cerno.tech>
Cc: Robert Foss <robert.foss@linaro.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
To: dri-devel@lists.freedesktop.org
Marek Vasut (13):
dt-bindings: display: bridge: icn6211: Document DSI data-lanes
property
drm: bridge: icn6211: Fix register layout
drm: bridge: icn6211: Fix HFP_HSW_HBP_HI and HFP_MIN handling
drm: bridge: icn6211: Add HS/VS/DE polarity handling
drm: bridge: icn6211: Add DSI lane count DT property parsing
drm: bridge: icn6211: Add generic DSI-to-DPI PLL configuration
drm: bridge: icn6211: Use DSI burst mode without EoT and with LP
command mode
drm: bridge: icn6211: Disable DPI color swap
drm: bridge: icn6211: Set SYS_CTRL_1 to value used in examples
drm: bridge: icn6211: Implement atomic_get_input_bus_fmts
drm: bridge: icn6211: Add I2C configuration support
drm: bridge: icn6211: Rework ICN6211_DSI to chipone_writeb()
drm: bridge: icn6211: Read and validate chip IDs before configuration
.../display/bridge/chipone,icn6211.yaml | 18 +-
drivers/gpu/drm/bridge/chipone-icn6211.c | 534 ++++++++++++++++--
2 files changed, 496 insertions(+), 56 deletions(-)
--
2.34.1
next reply other threads:[~2022-03-04 0:25 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 0:24 Marek Vasut [this message]
2022-03-04 0:24 ` [PATCH V3 01/13] dt-bindings: display: bridge: icn6211: Document DSI data-lanes property Marek Vasut
2022-03-04 0:24 ` Marek Vasut
2022-03-07 23:32 ` Rob Herring
2022-03-07 23:32 ` Rob Herring
2022-03-08 12:45 ` Maxime Ripard
2022-03-08 12:45 ` Maxime Ripard
2022-03-04 0:24 ` [PATCH V3 02/13] drm: bridge: icn6211: Fix register layout Marek Vasut
2022-03-04 0:24 ` [PATCH V3 03/13] drm: bridge: icn6211: Fix HFP_HSW_HBP_HI and HFP_MIN handling Marek Vasut
2022-03-04 0:24 ` [PATCH V3 04/13] drm: bridge: icn6211: Add HS/VS/DE polarity handling Marek Vasut
2022-03-08 12:46 ` Maxime Ripard
2022-03-04 0:25 ` [PATCH V3 05/13] drm: bridge: icn6211: Add DSI lane count DT property parsing Marek Vasut
2022-03-08 8:03 ` Jagan Teki
2022-03-08 9:49 ` Marek Vasut
2022-03-08 10:07 ` Jagan Teki
2022-03-08 10:29 ` Marek Vasut
2022-03-08 11:32 ` Jagan Teki
2022-03-08 12:51 ` Maxime Ripard
2022-03-08 13:27 ` Marek Vasut
2022-03-08 13:49 ` Maxime Ripard
2022-03-08 14:47 ` Marek Vasut
2022-03-08 16:21 ` Maxime Ripard
2022-03-08 21:41 ` Marek Vasut
2022-03-10 10:53 ` Maxime Ripard
2022-03-10 12:47 ` Marek Vasut
2022-03-10 14:18 ` Maxime Ripard
2022-03-11 10:36 ` Marek Vasut
2022-03-11 16:29 ` Maxime Ripard
2022-03-11 19:56 ` Marek Vasut
2022-03-11 20:35 ` Jagan Teki
2022-03-11 20:38 ` Jagan Teki
2022-03-11 21:11 ` Marek Vasut
2022-03-10 10:42 ` Laurent Pinchart
2022-03-10 10:57 ` Maxime Ripard
2022-03-10 11:16 ` Laurent Pinchart
2022-03-10 14:23 ` Maxime Ripard
2022-03-04 0:25 ` [PATCH V3 06/13] drm: bridge: icn6211: Add generic DSI-to-DPI PLL configuration Marek Vasut
2022-03-08 8:07 ` Jagan Teki
2022-03-08 10:11 ` Marek Vasut
2022-03-04 0:25 ` [PATCH V3 07/13] drm: bridge: icn6211: Use DSI burst mode without EoT and with LP command mode Marek Vasut
2022-03-04 0:25 ` [PATCH V3 08/13] drm: bridge: icn6211: Disable DPI color swap Marek Vasut
2022-03-04 0:25 ` [PATCH V3 09/13] drm: bridge: icn6211: Set SYS_CTRL_1 to value used in examples Marek Vasut
2022-03-04 0:25 ` [PATCH V3 10/13] drm: bridge: icn6211: Implement atomic_get_input_bus_fmts Marek Vasut
2022-03-04 0:25 ` [PATCH V3 11/13] drm: bridge: icn6211: Add I2C configuration support Marek Vasut
2022-03-04 0:25 ` [PATCH V3 12/13] drm: bridge: icn6211: Rework ICN6211_DSI to chipone_writeb() Marek Vasut
2022-03-04 0:25 ` [PATCH V3 13/13] drm: bridge: icn6211: Read and validate chip IDs before configuration Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220304002508.75676-1-marex@denx.de \
--to=marex@denx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagan@amarulasolutions.com \
--cc=maxime@cerno.tech \
--cc=robert.foss@linaro.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.