All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: dri-devel@lists.freedesktop.org
Cc: Marek Vasut <marex@denx.de>, Robert Foss <robert.foss@linaro.org>,
	Maxime Ripard <maxime@cerno.tech>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Sam Ravnborg <sam@ravnborg.org>,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: [PATCH V3 07/13] drm: bridge: icn6211: Use DSI burst mode without EoT and with LP command mode
Date: Fri,  4 Mar 2022 01:25:02 +0100	[thread overview]
Message-ID: <20220304002508.75676-8-marex@denx.de> (raw)
In-Reply-To: <20220304002508.75676-1-marex@denx.de>

The DSI burst mode is more energy efficient than the DSI sync pulse mode,
make use of the burst mode since the chip supports it as well. Disable the
generation of EoT packet, the chip ignores it, so no point in emitting it.
Enable transmission of data in LP mode, otherwise register read via DSI
does not work with this chip.

Acked-by: Maxime Ripard <maxime@cerno.tech>
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: Maxime Ripard <maxime@cerno.tech>
Cc: Robert Foss <robert.foss@linaro.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
To: dri-devel@lists.freedesktop.org
---
V2: Rebase on next-20220214
V3: Add AB from Maxime
---
 drivers/gpu/drm/bridge/chipone-icn6211.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
index 71c83a18984fa..b4e886c2b92a5 100644
--- a/drivers/gpu/drm/bridge/chipone-icn6211.c
+++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
@@ -503,7 +503,8 @@ static int chipone_probe(struct mipi_dsi_device *dsi)
 
 	dsi->lanes = icn->dsi_lanes;
 	dsi->format = MIPI_DSI_FMT_RGB888;
-	dsi->mode_flags = MIPI_DSI_MODE_VIDEO_SYNC_PULSE;
+	dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
+			  MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET;
 
 	ret = mipi_dsi_attach(dsi);
 	if (ret < 0) {
-- 
2.34.1


  parent reply	other threads:[~2022-03-04  0:25 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-04  0:24 [PATCH V3 00/13] drm: bridge: icn6211: Fix hard-coded panel settings and add I2C support Marek Vasut
2022-03-04  0:24 ` [PATCH V3 01/13] dt-bindings: display: bridge: icn6211: Document DSI data-lanes property Marek Vasut
2022-03-04  0:24   ` Marek Vasut
2022-03-07 23:32   ` Rob Herring
2022-03-07 23:32     ` Rob Herring
2022-03-08 12:45   ` Maxime Ripard
2022-03-08 12:45     ` Maxime Ripard
2022-03-04  0:24 ` [PATCH V3 02/13] drm: bridge: icn6211: Fix register layout Marek Vasut
2022-03-04  0:24 ` [PATCH V3 03/13] drm: bridge: icn6211: Fix HFP_HSW_HBP_HI and HFP_MIN handling Marek Vasut
2022-03-04  0:24 ` [PATCH V3 04/13] drm: bridge: icn6211: Add HS/VS/DE polarity handling Marek Vasut
2022-03-08 12:46   ` Maxime Ripard
2022-03-04  0:25 ` [PATCH V3 05/13] drm: bridge: icn6211: Add DSI lane count DT property parsing Marek Vasut
2022-03-08  8:03   ` Jagan Teki
2022-03-08  9:49     ` Marek Vasut
2022-03-08 10:07       ` Jagan Teki
2022-03-08 10:29         ` Marek Vasut
2022-03-08 11:32           ` Jagan Teki
2022-03-08 12:51           ` Maxime Ripard
2022-03-08 13:27             ` Marek Vasut
2022-03-08 13:49               ` Maxime Ripard
2022-03-08 14:47                 ` Marek Vasut
2022-03-08 16:21                   ` Maxime Ripard
2022-03-08 21:41                     ` Marek Vasut
2022-03-10 10:53                       ` Maxime Ripard
2022-03-10 12:47                         ` Marek Vasut
2022-03-10 14:18                           ` Maxime Ripard
2022-03-11 10:36                             ` Marek Vasut
2022-03-11 16:29                               ` Maxime Ripard
2022-03-11 19:56                                 ` Marek Vasut
2022-03-11 20:35                                   ` Jagan Teki
2022-03-11 20:38                                     ` Jagan Teki
2022-03-11 21:11                                       ` Marek Vasut
2022-03-10 10:42             ` Laurent Pinchart
2022-03-10 10:57               ` Maxime Ripard
2022-03-10 11:16                 ` Laurent Pinchart
2022-03-10 14:23                   ` Maxime Ripard
2022-03-04  0:25 ` [PATCH V3 06/13] drm: bridge: icn6211: Add generic DSI-to-DPI PLL configuration Marek Vasut
2022-03-08  8:07   ` Jagan Teki
2022-03-08 10:11     ` Marek Vasut
2022-03-04  0:25 ` Marek Vasut [this message]
2022-03-04  0:25 ` [PATCH V3 08/13] drm: bridge: icn6211: Disable DPI color swap Marek Vasut
2022-03-04  0:25 ` [PATCH V3 09/13] drm: bridge: icn6211: Set SYS_CTRL_1 to value used in examples Marek Vasut
2022-03-04  0:25 ` [PATCH V3 10/13] drm: bridge: icn6211: Implement atomic_get_input_bus_fmts Marek Vasut
2022-03-04  0:25 ` [PATCH V3 11/13] drm: bridge: icn6211: Add I2C configuration support Marek Vasut
2022-03-04  0:25 ` [PATCH V3 12/13] drm: bridge: icn6211: Rework ICN6211_DSI to chipone_writeb() Marek Vasut
2022-03-04  0:25 ` [PATCH V3 13/13] drm: bridge: icn6211: Read and validate chip IDs before configuration Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220304002508.75676-8-marex@denx.de \
    --to=marex@denx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jagan@amarulasolutions.com \
    --cc=maxime@cerno.tech \
    --cc=robert.foss@linaro.org \
    --cc=sam@ravnborg.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.