All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: dri-devel@lists.freedesktop.org
Cc: Marek Vasut <marex@denx.de>, Robert Foss <robert.foss@linaro.org>,
	Maxime Ripard <maxime@cerno.tech>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Sam Ravnborg <sam@ravnborg.org>,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: [PATCH V3 10/13] drm: bridge: icn6211: Implement atomic_get_input_bus_fmts
Date: Fri,  4 Mar 2022 01:25:05 +0100	[thread overview]
Message-ID: <20220304002508.75676-11-marex@denx.de> (raw)
In-Reply-To: <20220304002508.75676-1-marex@denx.de>

Implement .atomic_get_input_bus_fmts callback, which sets up the
input (DSI-end) format, and that format can then be used in pipeline
format negotiation between the DSI-end of this bridge and the other
component closer to the scanout engine.

Acked-by: Maxime Ripard <maxime@cerno.tech>
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: Maxime Ripard <maxime@cerno.tech>
Cc: Robert Foss <robert.foss@linaro.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
To: dri-devel@lists.freedesktop.org
---
V2: Rebase on next-20220214
V3: Add AB from Maxime
---
 drivers/gpu/drm/bridge/chipone-icn6211.c | 27 ++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
index 095002a40d0e8..afc619e215c3b 100644
--- a/drivers/gpu/drm/bridge/chipone-icn6211.c
+++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
@@ -389,6 +389,32 @@ static int chipone_attach(struct drm_bridge *bridge, enum drm_bridge_attach_flag
 	return drm_bridge_attach(bridge->encoder, icn->panel_bridge, bridge, flags);
 }
 
+#define MAX_INPUT_SEL_FORMATS	1
+
+static u32 *
+chipone_atomic_get_input_bus_fmts(struct drm_bridge *bridge,
+				  struct drm_bridge_state *bridge_state,
+				  struct drm_crtc_state *crtc_state,
+				  struct drm_connector_state *conn_state,
+				  u32 output_fmt,
+				  unsigned int *num_input_fmts)
+{
+	u32 *input_fmts;
+
+	*num_input_fmts = 0;
+
+	input_fmts = kcalloc(MAX_INPUT_SEL_FORMATS, sizeof(*input_fmts),
+			     GFP_KERNEL);
+	if (!input_fmts)
+		return NULL;
+
+	/* This is the DSI-end bus format */
+	input_fmts[0] = MEDIA_BUS_FMT_RGB888_1X24;
+	*num_input_fmts = 1;
+
+	return input_fmts;
+}
+
 static const struct drm_bridge_funcs chipone_bridge_funcs = {
 	.atomic_duplicate_state	= drm_atomic_helper_bridge_duplicate_state,
 	.atomic_destroy_state	= drm_atomic_helper_bridge_destroy_state,
@@ -398,6 +424,7 @@ static const struct drm_bridge_funcs chipone_bridge_funcs = {
 	.atomic_post_disable	= chipone_atomic_post_disable,
 	.mode_set		= chipone_mode_set,
 	.attach			= chipone_attach,
+	.atomic_get_input_bus_fmts = chipone_atomic_get_input_bus_fmts,
 };
 
 static int chipone_parse_dt(struct chipone *icn)
-- 
2.34.1


  parent reply	other threads:[~2022-03-04  0:25 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-04  0:24 [PATCH V3 00/13] drm: bridge: icn6211: Fix hard-coded panel settings and add I2C support Marek Vasut
2022-03-04  0:24 ` [PATCH V3 01/13] dt-bindings: display: bridge: icn6211: Document DSI data-lanes property Marek Vasut
2022-03-04  0:24   ` Marek Vasut
2022-03-07 23:32   ` Rob Herring
2022-03-07 23:32     ` Rob Herring
2022-03-08 12:45   ` Maxime Ripard
2022-03-08 12:45     ` Maxime Ripard
2022-03-04  0:24 ` [PATCH V3 02/13] drm: bridge: icn6211: Fix register layout Marek Vasut
2022-03-04  0:24 ` [PATCH V3 03/13] drm: bridge: icn6211: Fix HFP_HSW_HBP_HI and HFP_MIN handling Marek Vasut
2022-03-04  0:24 ` [PATCH V3 04/13] drm: bridge: icn6211: Add HS/VS/DE polarity handling Marek Vasut
2022-03-08 12:46   ` Maxime Ripard
2022-03-04  0:25 ` [PATCH V3 05/13] drm: bridge: icn6211: Add DSI lane count DT property parsing Marek Vasut
2022-03-08  8:03   ` Jagan Teki
2022-03-08  9:49     ` Marek Vasut
2022-03-08 10:07       ` Jagan Teki
2022-03-08 10:29         ` Marek Vasut
2022-03-08 11:32           ` Jagan Teki
2022-03-08 12:51           ` Maxime Ripard
2022-03-08 13:27             ` Marek Vasut
2022-03-08 13:49               ` Maxime Ripard
2022-03-08 14:47                 ` Marek Vasut
2022-03-08 16:21                   ` Maxime Ripard
2022-03-08 21:41                     ` Marek Vasut
2022-03-10 10:53                       ` Maxime Ripard
2022-03-10 12:47                         ` Marek Vasut
2022-03-10 14:18                           ` Maxime Ripard
2022-03-11 10:36                             ` Marek Vasut
2022-03-11 16:29                               ` Maxime Ripard
2022-03-11 19:56                                 ` Marek Vasut
2022-03-11 20:35                                   ` Jagan Teki
2022-03-11 20:38                                     ` Jagan Teki
2022-03-11 21:11                                       ` Marek Vasut
2022-03-10 10:42             ` Laurent Pinchart
2022-03-10 10:57               ` Maxime Ripard
2022-03-10 11:16                 ` Laurent Pinchart
2022-03-10 14:23                   ` Maxime Ripard
2022-03-04  0:25 ` [PATCH V3 06/13] drm: bridge: icn6211: Add generic DSI-to-DPI PLL configuration Marek Vasut
2022-03-08  8:07   ` Jagan Teki
2022-03-08 10:11     ` Marek Vasut
2022-03-04  0:25 ` [PATCH V3 07/13] drm: bridge: icn6211: Use DSI burst mode without EoT and with LP command mode Marek Vasut
2022-03-04  0:25 ` [PATCH V3 08/13] drm: bridge: icn6211: Disable DPI color swap Marek Vasut
2022-03-04  0:25 ` [PATCH V3 09/13] drm: bridge: icn6211: Set SYS_CTRL_1 to value used in examples Marek Vasut
2022-03-04  0:25 ` Marek Vasut [this message]
2022-03-04  0:25 ` [PATCH V3 11/13] drm: bridge: icn6211: Add I2C configuration support Marek Vasut
2022-03-04  0:25 ` [PATCH V3 12/13] drm: bridge: icn6211: Rework ICN6211_DSI to chipone_writeb() Marek Vasut
2022-03-04  0:25 ` [PATCH V3 13/13] drm: bridge: icn6211: Read and validate chip IDs before configuration Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220304002508.75676-11-marex@denx.de \
    --to=marex@denx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jagan@amarulasolutions.com \
    --cc=maxime@cerno.tech \
    --cc=robert.foss@linaro.org \
    --cc=sam@ravnborg.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.