From: "Petr Štetiar" <ynezz@true.cz> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: "Maxime Ripard" <mripard@kernel.org>, "Bastien Roucariès" <rouca@debian.org>, "Chen-Yu Tsai" <wens@csie.org>, "Jernej Skrabec" <jernej.skrabec@gmail.com>, "Rob Herring" <robh+dt@kernel.org>, stable@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode" Date: Tue, 15 Mar 2022 08:28:58 +0100 [thread overview] Message-ID: <20220315072846.GA9129@meh.true.cz> (raw) In-Reply-To: <20220308125531.27305-1-ynezz@true.cz> Petr Štetiar <ynezz@true.cz> [2022-03-08 13:55:30]: Hi Greg, one week has passed and as I didn't received any feedback, I'm providing more details in a hope to make it more clear, why I think, that this fix is wrong and should be reverted in LTS kernels 5.10 and 5.15. > This reverts commit 55dd7e059098ce4bd0a55c251cb78e74604abb57 as it breaks > network on my A20-olinuxino-lime2 hardware revision "K" which has Micrel > KSZ9031RNXCC-TR Gigabit PHY. Bastien has probably some previous hardware > revisions which were based on RTL8211E-VB-CG1 PHY and thus this fix was > working on his board. Disclaimer, I don't own A20-olinuxino-lime2 board with earlier HW revisions G/G1/G2 utilizing RTL8211E PHY. My understanding is, that up to kernel version 5.9 and specifically commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config") it was likely possible to use same DTS for A20-olinuxino-lime2 with KSZ9031 or RTL8211E PHYs (all HW revisions). At least I was using my A20-olinuxino-lime2 HW revision K with KSZ9031 PHY just fine with 4.19 kernel. After upgrade to 5.10 LTS kernel my network stopped working, reverting stable backport commit a90398438517 ("ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode") fixed it. From my POV proper fix for earlier HW revisions G/G1/G2 is introduction of sun7i-a20-olinuxino-lime2-revG.dts with a proper `phy-mode` for RTL8211E PHY. Cheers, Petr > Cc: stable@vger.kernel.org > Cc: Bastien Roucariès <rouca@debian.org> > References: https://github.com/openwrt/openwrt/issues/9153 > References: https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/A20-OLinuXino-LIME2/hardware_revision_changes_log.txt > Signed-off-by: Petr Štetiar <ynezz@true.cz> > --- > arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > index ecb91fb899ff..8077f1716fbc 100644 > --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > @@ -112,7 +112,7 @@ &gmac { > pinctrl-names = "default"; > pinctrl-0 = <&gmac_rgmii_pins>; > phy-handle = <&phy1>; > - phy-mode = "rgmii-id"; > + phy-mode = "rgmii"; > status = "okay"; > };
WARNING: multiple messages have this Message-ID (diff)
From: "Petr Štetiar" <ynezz@true.cz> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: "Maxime Ripard" <mripard@kernel.org>, "Bastien Roucariès" <rouca@debian.org>, "Chen-Yu Tsai" <wens@csie.org>, "Jernej Skrabec" <jernej.skrabec@gmail.com>, "Rob Herring" <robh+dt@kernel.org>, stable@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode" Date: Tue, 15 Mar 2022 08:28:58 +0100 [thread overview] Message-ID: <20220315072846.GA9129@meh.true.cz> (raw) In-Reply-To: <20220308125531.27305-1-ynezz@true.cz> Petr Štetiar <ynezz@true.cz> [2022-03-08 13:55:30]: Hi Greg, one week has passed and as I didn't received any feedback, I'm providing more details in a hope to make it more clear, why I think, that this fix is wrong and should be reverted in LTS kernels 5.10 and 5.15. > This reverts commit 55dd7e059098ce4bd0a55c251cb78e74604abb57 as it breaks > network on my A20-olinuxino-lime2 hardware revision "K" which has Micrel > KSZ9031RNXCC-TR Gigabit PHY. Bastien has probably some previous hardware > revisions which were based on RTL8211E-VB-CG1 PHY and thus this fix was > working on his board. Disclaimer, I don't own A20-olinuxino-lime2 board with earlier HW revisions G/G1/G2 utilizing RTL8211E PHY. My understanding is, that up to kernel version 5.9 and specifically commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config") it was likely possible to use same DTS for A20-olinuxino-lime2 with KSZ9031 or RTL8211E PHYs (all HW revisions). At least I was using my A20-olinuxino-lime2 HW revision K with KSZ9031 PHY just fine with 4.19 kernel. After upgrade to 5.10 LTS kernel my network stopped working, reverting stable backport commit a90398438517 ("ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode") fixed it. From my POV proper fix for earlier HW revisions G/G1/G2 is introduction of sun7i-a20-olinuxino-lime2-revG.dts with a proper `phy-mode` for RTL8211E PHY. Cheers, Petr > Cc: stable@vger.kernel.org > Cc: Bastien Roucariès <rouca@debian.org> > References: https://github.com/openwrt/openwrt/issues/9153 > References: https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/A20-OLinuXino-LIME2/hardware_revision_changes_log.txt > Signed-off-by: Petr Štetiar <ynezz@true.cz> > --- > arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > index ecb91fb899ff..8077f1716fbc 100644 > --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > @@ -112,7 +112,7 @@ &gmac { > pinctrl-names = "default"; > pinctrl-0 = <&gmac_rgmii_pins>; > phy-handle = <&phy1>; > - phy-mode = "rgmii-id"; > + phy-mode = "rgmii"; > status = "okay"; > }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-15 7:29 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-08 12:55 [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode" Petr Štetiar 2022-03-08 12:55 ` Petr Štetiar 2022-03-15 7:28 ` Petr Štetiar [this message] 2022-03-15 7:28 ` Petr Štetiar 2022-03-15 7:37 ` Corentin Labbe 2022-03-15 7:37 ` Corentin Labbe 2022-03-15 8:02 ` Petr Štetiar 2022-03-15 8:02 ` Petr Štetiar 2022-03-15 7:51 ` Greg Kroah-Hartman 2022-03-15 7:51 ` Greg Kroah-Hartman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220315072846.GA9129@meh.true.cz \ --to=ynezz@true.cz \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=jernej.skrabec@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=mripard@kernel.org \ --cc=robh+dt@kernel.org \ --cc=rouca@debian.org \ --cc=stable@vger.kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.