* [PATCH] boot: image: fixup zstd decompression buffer initialization typo
@ 2022-03-16 18:15 Jérôme Carretero
2022-03-16 19:23 ` Simon Glass
0 siblings, 1 reply; 2+ messages in thread
From: Jérôme Carretero @ 2022-03-16 18:15 UTC (permalink / raw)
To: U-Boot Mailing List; +Cc: Tom Rini, Jérôme Carretero, Simon Glass
Fixes: 458b30af66cd41ca8e6f8a52ea4c09cb50d3413d
Cc: Simon Glass <sjg@chromium.org>
---
boot/image.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/boot/image.c b/boot/image.c
index 07fa2d3160..121df0c838 100644
--- a/boot/image.c
+++ b/boot/image.c
@@ -500,7 +500,7 @@ int image_decomp(int comp, ulong load, ulong image_start, int type,
struct abuf in, out;
abuf_init_set(&in, image_buf, image_len);
- abuf_init_set(&in, load_buf, unc_len);
+ abuf_init_set(&out, load_buf, unc_len);
ret = zstd_decompress(&in, &out);
if (ret >= 0) {
image_len = ret;
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] boot: image: fixup zstd decompression buffer initialization typo
2022-03-16 18:15 [PATCH] boot: image: fixup zstd decompression buffer initialization typo Jérôme Carretero
@ 2022-03-16 19:23 ` Simon Glass
0 siblings, 0 replies; 2+ messages in thread
From: Simon Glass @ 2022-03-16 19:23 UTC (permalink / raw)
To: Jérôme Carretero; +Cc: U-Boot Mailing List, Tom Rini
Hi Jérôme,
On Wed, 16 Mar 2022 at 12:16, Jérôme Carretero <cJ-uboot@zougloub.eu> wrote:
>
Thanks for the fix! Please add a commit message.
> Fixes: 458b30af66cd41ca8e6f8a52ea4c09cb50d3413d
> Cc: Simon Glass <sjg@chromium.org>
> ---
> boot/image.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
Fixes: 458b30af66c image: Update image_decomp() to avoid ifdefs
>
> diff --git a/boot/image.c b/boot/image.c
> index 07fa2d3160..121df0c838 100644
> --- a/boot/image.c
> +++ b/boot/image.c
> @@ -500,7 +500,7 @@ int image_decomp(int comp, ulong load, ulong image_start, int type,
> struct abuf in, out;
>
> abuf_init_set(&in, image_buf, image_len);
> - abuf_init_set(&in, load_buf, unc_len);
> + abuf_init_set(&out, load_buf, unc_len);
> ret = zstd_decompress(&in, &out);
> if (ret >= 0) {
> image_len = ret;
> --
> 2.35.1
>
Regards,
Simon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-16 19:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-16 18:15 [PATCH] boot: image: fixup zstd decompression buffer initialization typo Jérôme Carretero
2022-03-16 19:23 ` Simon Glass
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.