[PATCH] boot: image: fixup zstd decompression buffer initialization typo

[PATCH] boot: image: fixup zstd decompression buffer initialization typo

[Jérôme Carretero]

Fixes: 458b30af66cd41ca8e6f8a52ea4c09cb50d3413d
Cc: Simon Glass <sjg@chromium.org>
---
 boot/image.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/boot/image.c b/boot/image.c
index 07fa2d3160..121df0c838 100644
--- a/boot/image.c
+++ b/boot/image.c
@@ -500,7 +500,7 @@ int image_decomp(int comp, ulong load, ulong image_start, int type,
 			struct abuf in, out;
 
 			abuf_init_set(&in, image_buf, image_len);
-			abuf_init_set(&in, load_buf, unc_len);
+			abuf_init_set(&out, load_buf, unc_len);
 			ret = zstd_decompress(&in, &out);
 			if (ret >= 0) {
 				image_len = ret;
-- 
2.35.1

Re: [PATCH] boot: image: fixup zstd decompression buffer initialization typo

[Simon Glass]

Hi Jérôme,

On Wed, 16 Mar 2022 at 12:16, Jérôme Carretero <cJ-uboot@zougloub.eu> wrote:
>

Thanks for the fix! Please add a commit message.

> Fixes: 458b30af66cd41ca8e6f8a52ea4c09cb50d3413d
> Cc: Simon Glass <sjg@chromium.org>
> ---
>  boot/image.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Fixes: 458b30af66c image: Update image_decomp() to avoid ifdefs

>
> diff --git a/boot/image.c b/boot/image.c
> index 07fa2d3160..121df0c838 100644
> --- a/boot/image.c
> +++ b/boot/image.c
> @@ -500,7 +500,7 @@ int image_decomp(int comp, ulong load, ulong image_start, int type,
>                         struct abuf in, out;
>
>                         abuf_init_set(&in, image_buf, image_len);
> -                       abuf_init_set(&in, load_buf, unc_len);
> +                       abuf_init_set(&out, load_buf, unc_len);
>                         ret = zstd_decompress(&in, &out);
>                         if (ret >= 0) {
>                                 image_len = ret;
> --
> 2.35.1
>

Regards,
Simon