* [PATCH v2 0/6] UFS support on SM6350 & FP4
@ 2022-03-21 13:33 ` Luca Weiss
0 siblings, 0 replies; 26+ messages in thread
From: Luca Weiss @ 2022-03-21 13:33 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Alim Akhtar,
Andy Gross, AngeloGioacchino Del Regno, Avri Altman,
Bjorn Andersson, devicetree, Konrad Dybcio, Linus Walleij,
linux-gpio, linux-kernel, linux-phy, linux-scsi, Vinod Koul
This series adds support for UFS on SM6350 which is used for internal
storage.
Changes in v2:
- see individual patches
Luca Weiss (6):
scsi: ufs: dt-bindings: Add SM6350 compatible string
dt-bindings: phy: qcom,qmp: Add SM6350 UFS PHY bindings
phy: qcom-qmp: Add SM6350 UFS PHY support
pinctrl: qcom: sm6350: fix order of UFS & SDC pins
arm64: dts: qcom: sm6350: Add UFS nodes
arm64: dts: qcom: sm7225-fairphone-fp4: Enable UFS
.../devicetree/bindings/phy/qcom,qmp-phy.yaml | 2 +
.../devicetree/bindings/ufs/qcom,ufs.yaml | 2 +
arch/arm64/boot/dts/qcom/sm6350.dtsi | 77 +++++++++++++++++++
.../boot/dts/qcom/sm7225-fairphone-fp4.dts | 18 +++++
drivers/phy/qualcomm/phy-qcom-qmp.c | 3 +
drivers/pinctrl/qcom/pinctrl-sm6350.c | 16 ++--
6 files changed, 110 insertions(+), 8 deletions(-)
--
2.35.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH v2 1/6] scsi: ufs: dt-bindings: Add SM6350 compatible string
2022-03-21 13:33 ` Luca Weiss
(?)
@ 2022-03-21 13:33 ` Luca Weiss
2022-03-21 13:40 ` Krzysztof Kozlowski
` (3 more replies)
-1 siblings, 4 replies; 26+ messages in thread
From: Luca Weiss @ 2022-03-21 13:33 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
Bjorn Andersson, Alim Akhtar, Avri Altman, Rob Herring,
Krzysztof Kozlowski, linux-scsi, devicetree, linux-kernel
Document the compatible for the UFS found on SM6350.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Changes in v2:
- add second hunk for clock validation
Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
index 5b3a2157f7e5..dcd32c10205a 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
@@ -27,6 +27,7 @@ properties:
- qcom,msm8996-ufshc
- qcom,msm8998-ufshc
- qcom,sdm845-ufshc
+ - qcom,sm6350-ufshc
- qcom,sm8150-ufshc
- qcom,sm8250-ufshc
- qcom,sm8350-ufshc
@@ -125,6 +126,7 @@ allOf:
contains:
enum:
- qcom,sdm845-ufshc
+ - qcom,sm6350-ufshc
- qcom,sm8150-ufshc
then:
properties:
--
2.35.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH v2 1/6] scsi: ufs: dt-bindings: Add SM6350 compatible string
2022-03-21 13:33 ` [PATCH v2 1/6] scsi: ufs: dt-bindings: Add SM6350 compatible string Luca Weiss
@ 2022-03-21 13:40 ` Krzysztof Kozlowski
2022-03-21 15:41 ` Alim Akhtar
` (2 subsequent siblings)
3 siblings, 0 replies; 26+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-21 13:40 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Alim Akhtar, Avri Altman, Rob Herring,
Krzysztof Kozlowski, linux-scsi, devicetree, linux-kernel
On 21/03/2022 14:33, Luca Weiss wrote:
> Document the compatible for the UFS found on SM6350.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Changes in v2:
> - add second hunk for clock validation
>
> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 26+ messages in thread
* RE: [PATCH v2 1/6] scsi: ufs: dt-bindings: Add SM6350 compatible string
2022-03-21 13:33 ` [PATCH v2 1/6] scsi: ufs: dt-bindings: Add SM6350 compatible string Luca Weiss
2022-03-21 13:40 ` Krzysztof Kozlowski
@ 2022-03-21 15:41 ` Alim Akhtar
2022-03-21 21:45 ` Rob Herring
2022-03-21 21:45 ` Rob Herring
3 siblings, 0 replies; 26+ messages in thread
From: Alim Akhtar @ 2022-03-21 15:41 UTC (permalink / raw)
To: 'Luca Weiss', linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, 'Andy Gross',
'Bjorn Andersson', 'Avri Altman',
'Rob Herring', 'Krzysztof Kozlowski',
linux-scsi, devicetree, linux-kernel
>-----Original Message-----
>From: Luca Weiss [mailto:luca.weiss@fairphone.com]
>Sent: Monday, March 21, 2022 7:03 PM
>To: linux-arm-msm@vger.kernel.org
>Cc: ~postmarketos/upstreaming@lists.sr.ht; phone-devel@vger.kernel.org;
>Luca Weiss <luca.weiss@fairphone.com>; Andy Gross <agross@kernel.org>;
>Bjorn Andersson <bjorn.andersson@linaro.org>; Alim Akhtar
><alim.akhtar@samsung.com>; Avri Altman <avri.altman@wdc.com>; Rob
>Herring <robh+dt@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>;
>linux-scsi@vger.kernel.org; devicetree@vger.kernel.org; linux-
>kernel@vger.kernel.org
>Subject: [PATCH v2 1/6] scsi: ufs: dt-bindings: Add SM6350 compatible
string
>
>Document the compatible for the UFS found on SM6350.
>
>Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
>Changes in v2:
>- add second hunk for clock validation
>
> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>index 5b3a2157f7e5..dcd32c10205a 100644
>--- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>+++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>@@ -27,6 +27,7 @@ properties:
> - qcom,msm8996-ufshc
> - qcom,msm8998-ufshc
> - qcom,sdm845-ufshc
>+ - qcom,sm6350-ufshc
> - qcom,sm8150-ufshc
> - qcom,sm8250-ufshc
> - qcom,sm8350-ufshc
>@@ -125,6 +126,7 @@ allOf:
> contains:
> enum:
> - qcom,sdm845-ufshc
>+ - qcom,sm6350-ufshc
> - qcom,sm8150-ufshc
> then:
> properties:
>--
>2.35.1
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 1/6] scsi: ufs: dt-bindings: Add SM6350 compatible string
2022-03-21 13:33 ` [PATCH v2 1/6] scsi: ufs: dt-bindings: Add SM6350 compatible string Luca Weiss
2022-03-21 13:40 ` Krzysztof Kozlowski
2022-03-21 15:41 ` Alim Akhtar
@ 2022-03-21 21:45 ` Rob Herring
2022-03-21 21:45 ` Rob Herring
3 siblings, 0 replies; 26+ messages in thread
From: Rob Herring @ 2022-03-21 21:45 UTC (permalink / raw)
To: Luca Weiss
Cc: linux-arm-msm, ~postmarketos/upstreaming, phone-devel,
Andy Gross, Bjorn Andersson, Alim Akhtar, Avri Altman,
Krzysztof Kozlowski, linux-scsi, devicetree, linux-kernel
On Mon, Mar 21, 2022 at 02:33:13PM +0100, Luca Weiss wrote:
> Document the compatible for the UFS found on SM6350.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Changes in v2:
> - add second hunk for clock validation
>
> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++
> 1 file changed, 2 insertions(+)
Are maintainers supposed to know that this is dependent on a patch in my
tree? After a week of vacation I don't even remember that without
checking.
Rob
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 1/6] scsi: ufs: dt-bindings: Add SM6350 compatible string
2022-03-21 13:33 ` [PATCH v2 1/6] scsi: ufs: dt-bindings: Add SM6350 compatible string Luca Weiss
` (2 preceding siblings ...)
2022-03-21 21:45 ` Rob Herring
@ 2022-03-21 21:45 ` Rob Herring
3 siblings, 0 replies; 26+ messages in thread
From: Rob Herring @ 2022-03-21 21:45 UTC (permalink / raw)
To: Luca Weiss
Cc: linux-scsi, devicetree, Andy Gross, phone-devel,
~postmarketos/upstreaming, linux-arm-msm, Avri Altman,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, linux-kernel,
Alim Akhtar
On Mon, 21 Mar 2022 14:33:13 +0100, Luca Weiss wrote:
> Document the compatible for the UFS found on SM6350.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Changes in v2:
> - add second hunk for clock validation
>
> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH v2 2/6] dt-bindings: phy: qcom,qmp: Add SM6350 UFS PHY bindings
2022-03-21 13:33 ` Luca Weiss
@ 2022-03-21 13:33 ` Luca Weiss
-1 siblings, 0 replies; 26+ messages in thread
From: Luca Weiss @ 2022-03-21 13:33 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
Bjorn Andersson, Kishon Vijay Abraham I, Vinod Koul, Rob Herring,
Krzysztof Kozlowski, linux-phy, devicetree, linux-kernel
Document the compatible string for the UFS PHY found in SM6350.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Changes in v2:
- add second hunk for clock validation
Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
index e20d9b087bb8..5d7417c34c87 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
@@ -39,6 +39,7 @@ properties:
- qcom,sdm845-qmp-usb3-phy
- qcom,sdm845-qmp-usb3-uni-phy
- qcom,sm6115-qmp-ufs-phy
+ - qcom,sm6350-qmp-ufs-phy
- qcom,sm8150-qmp-ufs-phy
- qcom,sm8150-qmp-usb3-phy
- qcom,sm8150-qmp-usb3-uni-phy
@@ -279,6 +280,7 @@ allOf:
enum:
- qcom,msm8998-qmp-ufs-phy
- qcom,sdm845-qmp-ufs-phy
+ - qcom,sm6350-qmp-ufs-phy
- qcom,sm8150-qmp-ufs-phy
- qcom,sm8250-qmp-ufs-phy
- qcom,sc8180x-qmp-ufs-phy
--
2.35.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH v2 2/6] dt-bindings: phy: qcom, qmp: Add SM6350 UFS PHY bindings
@ 2022-03-21 13:33 ` Luca Weiss
0 siblings, 0 replies; 26+ messages in thread
From: Luca Weiss @ 2022-03-21 13:33 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
Bjorn Andersson, Kishon Vijay Abraham I, Vinod Koul, Rob Herring,
Krzysztof Kozlowski, linux-phy, devicetree, linux-kernel
Document the compatible string for the UFS PHY found in SM6350.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Changes in v2:
- add second hunk for clock validation
Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
index e20d9b087bb8..5d7417c34c87 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
@@ -39,6 +39,7 @@ properties:
- qcom,sdm845-qmp-usb3-phy
- qcom,sdm845-qmp-usb3-uni-phy
- qcom,sm6115-qmp-ufs-phy
+ - qcom,sm6350-qmp-ufs-phy
- qcom,sm8150-qmp-ufs-phy
- qcom,sm8150-qmp-usb3-phy
- qcom,sm8150-qmp-usb3-uni-phy
@@ -279,6 +280,7 @@ allOf:
enum:
- qcom,msm8998-qmp-ufs-phy
- qcom,sdm845-qmp-ufs-phy
+ - qcom,sm6350-qmp-ufs-phy
- qcom,sm8150-qmp-ufs-phy
- qcom,sm8250-qmp-ufs-phy
- qcom,sc8180x-qmp-ufs-phy
--
2.35.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: phy: qcom,qmp: Add SM6350 UFS PHY bindings
2022-03-21 13:33 ` [PATCH v2 2/6] dt-bindings: phy: qcom, qmp: " Luca Weiss
@ 2022-03-21 13:41 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 26+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-21 13:41 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Kishon Vijay Abraham I, Vinod Koul, Rob Herring,
Krzysztof Kozlowski, linux-phy, devicetree, linux-kernel
On 21/03/2022 14:33, Luca Weiss wrote:
> Document the compatible string for the UFS PHY found in SM6350.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Changes in v2:
> - add second hunk for clock validation
>
> Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: phy: qcom,qmp: Add SM6350 UFS PHY bindings
@ 2022-03-21 13:41 ` Krzysztof Kozlowski
0 siblings, 0 replies; 26+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-21 13:41 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Kishon Vijay Abraham I, Vinod Koul, Rob Herring,
Krzysztof Kozlowski, linux-phy, devicetree, linux-kernel
On 21/03/2022 14:33, Luca Weiss wrote:
> Document the compatible string for the UFS PHY found in SM6350.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Changes in v2:
> - add second hunk for clock validation
>
> Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: phy: qcom,qmp: Add SM6350 UFS PHY bindings
2022-03-21 13:33 ` [PATCH v2 2/6] dt-bindings: phy: qcom, qmp: " Luca Weiss
@ 2022-03-21 21:46 ` Rob Herring
-1 siblings, 0 replies; 26+ messages in thread
From: Rob Herring @ 2022-03-21 21:46 UTC (permalink / raw)
To: Luca Weiss
Cc: Krzysztof Kozlowski, ~postmarketos/upstreaming, phone-devel,
linux-phy, Bjorn Andersson, Vinod Koul, devicetree, Andy Gross,
linux-kernel, Rob Herring, linux-arm-msm, Kishon Vijay Abraham I
On Mon, 21 Mar 2022 14:33:14 +0100, Luca Weiss wrote:
> Document the compatible string for the UFS PHY found in SM6350.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Changes in v2:
> - add second hunk for clock validation
>
> Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: phy: qcom,qmp: Add SM6350 UFS PHY bindings
@ 2022-03-21 21:46 ` Rob Herring
0 siblings, 0 replies; 26+ messages in thread
From: Rob Herring @ 2022-03-21 21:46 UTC (permalink / raw)
To: Luca Weiss
Cc: Krzysztof Kozlowski, ~postmarketos/upstreaming, phone-devel,
linux-phy, Bjorn Andersson, Vinod Koul, devicetree, Andy Gross,
linux-kernel, Rob Herring, linux-arm-msm, Kishon Vijay Abraham I
On Mon, 21 Mar 2022 14:33:14 +0100, Luca Weiss wrote:
> Document the compatible string for the UFS PHY found in SM6350.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Changes in v2:
> - add second hunk for clock validation
>
> Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: phy: qcom,qmp: Add SM6350 UFS PHY bindings
2022-03-21 13:33 ` [PATCH v2 2/6] dt-bindings: phy: qcom, qmp: " Luca Weiss
@ 2022-04-11 18:04 ` Vinod Koul
-1 siblings, 0 replies; 26+ messages in thread
From: Vinod Koul @ 2022-04-11 18:04 UTC (permalink / raw)
To: Luca Weiss
Cc: linux-arm-msm, ~postmarketos/upstreaming, phone-devel,
Andy Gross, Bjorn Andersson, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, linux-phy, devicetree, linux-kernel
On 21-03-22, 14:33, Luca Weiss wrote:
> Document the compatible string for the UFS PHY found in SM6350.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: phy: qcom,qmp: Add SM6350 UFS PHY bindings
@ 2022-04-11 18:04 ` Vinod Koul
0 siblings, 0 replies; 26+ messages in thread
From: Vinod Koul @ 2022-04-11 18:04 UTC (permalink / raw)
To: Luca Weiss
Cc: linux-arm-msm, ~postmarketos/upstreaming, phone-devel,
Andy Gross, Bjorn Andersson, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, linux-phy, devicetree, linux-kernel
On 21-03-22, 14:33, Luca Weiss wrote:
> Document the compatible string for the UFS PHY found in SM6350.
Applied, thanks
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH v2 3/6] phy: qcom-qmp: Add SM6350 UFS PHY support
2022-03-21 13:33 ` Luca Weiss
@ 2022-03-21 13:33 ` Luca Weiss
-1 siblings, 0 replies; 26+ messages in thread
From: Luca Weiss @ 2022-03-21 13:33 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
Bjorn Andersson, Kishon Vijay Abraham I, Vinod Koul, linux-phy,
linux-kernel
The SM6350 UFS PHY is compatible with the one from SDM845. Add a
compatible for that.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Changes in v2:
- nothing
drivers/phy/qualcomm/phy-qcom-qmp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
index b144ae1f729a..1628275265b5 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
@@ -6007,6 +6007,9 @@ static const struct of_device_id qcom_qmp_phy_of_match_table[] = {
}, {
.compatible = "qcom,sm6115-qmp-ufs-phy",
.data = &sm6115_ufsphy_cfg,
+ }, {
+ .compatible = "qcom,sm6350-qmp-ufs-phy",
+ .data = &sdm845_ufsphy_cfg,
}, {
.compatible = "qcom,sm8150-qmp-ufs-phy",
.data = &sm8150_ufsphy_cfg,
--
2.35.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH v2 3/6] phy: qcom-qmp: Add SM6350 UFS PHY support
@ 2022-03-21 13:33 ` Luca Weiss
0 siblings, 0 replies; 26+ messages in thread
From: Luca Weiss @ 2022-03-21 13:33 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
Bjorn Andersson, Kishon Vijay Abraham I, Vinod Koul, linux-phy,
linux-kernel
The SM6350 UFS PHY is compatible with the one from SDM845. Add a
compatible for that.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Changes in v2:
- nothing
drivers/phy/qualcomm/phy-qcom-qmp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
index b144ae1f729a..1628275265b5 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
@@ -6007,6 +6007,9 @@ static const struct of_device_id qcom_qmp_phy_of_match_table[] = {
}, {
.compatible = "qcom,sm6115-qmp-ufs-phy",
.data = &sm6115_ufsphy_cfg,
+ }, {
+ .compatible = "qcom,sm6350-qmp-ufs-phy",
+ .data = &sdm845_ufsphy_cfg,
}, {
.compatible = "qcom,sm8150-qmp-ufs-phy",
.data = &sm8150_ufsphy_cfg,
--
2.35.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH v2 3/6] phy: qcom-qmp: Add SM6350 UFS PHY support
2022-03-21 13:33 ` Luca Weiss
@ 2022-04-11 18:04 ` Vinod Koul
-1 siblings, 0 replies; 26+ messages in thread
From: Vinod Koul @ 2022-04-11 18:04 UTC (permalink / raw)
To: Luca Weiss
Cc: linux-arm-msm, ~postmarketos/upstreaming, phone-devel,
Andy Gross, Bjorn Andersson, Kishon Vijay Abraham I, linux-phy,
linux-kernel
On 21-03-22, 14:33, Luca Weiss wrote:
> The SM6350 UFS PHY is compatible with the one from SDM845. Add a
> compatible for that.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 3/6] phy: qcom-qmp: Add SM6350 UFS PHY support
@ 2022-04-11 18:04 ` Vinod Koul
0 siblings, 0 replies; 26+ messages in thread
From: Vinod Koul @ 2022-04-11 18:04 UTC (permalink / raw)
To: Luca Weiss
Cc: linux-arm-msm, ~postmarketos/upstreaming, phone-devel,
Andy Gross, Bjorn Andersson, Kishon Vijay Abraham I, linux-phy,
linux-kernel
On 21-03-22, 14:33, Luca Weiss wrote:
> The SM6350 UFS PHY is compatible with the one from SDM845. Add a
> compatible for that.
Applied, thanks
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH v2 4/6] pinctrl: qcom: sm6350: fix order of UFS & SDC pins
2022-03-21 13:33 ` Luca Weiss
` (3 preceding siblings ...)
(?)
@ 2022-03-21 13:33 ` Luca Weiss
2022-03-21 14:15 ` Bjorn Andersson
2022-04-17 23:42 ` Linus Walleij
-1 siblings, 2 replies; 26+ messages in thread
From: Luca Weiss @ 2022-03-21 13:33 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
Bjorn Andersson, Linus Walleij, AngeloGioacchino Del Regno,
Konrad Dybcio, linux-gpio, linux-kernel
In other places the SDC and UFS pins have been swapped but this was
missed in the PINCTRL_PIN definitions. Fix that.
Fixes: 7d74b55afd27 ("pinctrl: qcom: Add SM6350 pinctrl driver")
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Changes in v2:
- nothing
drivers/pinctrl/qcom/pinctrl-sm6350.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-sm6350.c b/drivers/pinctrl/qcom/pinctrl-sm6350.c
index 4d37b817b232..a91a86628f2f 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm6350.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm6350.c
@@ -264,14 +264,14 @@ static const struct pinctrl_pin_desc sm6350_pins[] = {
PINCTRL_PIN(153, "GPIO_153"),
PINCTRL_PIN(154, "GPIO_154"),
PINCTRL_PIN(155, "GPIO_155"),
- PINCTRL_PIN(156, "SDC1_RCLK"),
- PINCTRL_PIN(157, "SDC1_CLK"),
- PINCTRL_PIN(158, "SDC1_CMD"),
- PINCTRL_PIN(159, "SDC1_DATA"),
- PINCTRL_PIN(160, "SDC2_CLK"),
- PINCTRL_PIN(161, "SDC2_CMD"),
- PINCTRL_PIN(162, "SDC2_DATA"),
- PINCTRL_PIN(163, "UFS_RESET"),
+ PINCTRL_PIN(156, "UFS_RESET"),
+ PINCTRL_PIN(157, "SDC1_RCLK"),
+ PINCTRL_PIN(158, "SDC1_CLK"),
+ PINCTRL_PIN(159, "SDC1_CMD"),
+ PINCTRL_PIN(160, "SDC1_DATA"),
+ PINCTRL_PIN(161, "SDC2_CLK"),
+ PINCTRL_PIN(162, "SDC2_CMD"),
+ PINCTRL_PIN(163, "SDC2_DATA"),
};
#define DECLARE_MSM_GPIO_PINS(pin) \
--
2.35.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH v2 4/6] pinctrl: qcom: sm6350: fix order of UFS & SDC pins
2022-03-21 13:33 ` [PATCH v2 4/6] pinctrl: qcom: sm6350: fix order of UFS & SDC pins Luca Weiss
@ 2022-03-21 14:15 ` Bjorn Andersson
2022-03-21 14:21 ` Luca Weiss
2022-04-17 23:42 ` Linus Walleij
1 sibling, 1 reply; 26+ messages in thread
From: Bjorn Andersson @ 2022-03-21 14:15 UTC (permalink / raw)
To: Luca Weiss
Cc: linux-arm-msm, ~postmarketos/upstreaming, phone-devel,
Andy Gross, Linus Walleij, AngeloGioacchino Del Regno,
Konrad Dybcio, linux-gpio, linux-kernel
On Mon 21 Mar 08:33 CDT 2022, Luca Weiss wrote:
> In other places the SDC and UFS pins have been swapped but this was
> missed in the PINCTRL_PIN definitions. Fix that.
>
> Fixes: 7d74b55afd27 ("pinctrl: qcom: Add SM6350 pinctrl driver")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Your proposed change looks good, but when I look at 7d74b55afd27 it
already has these entries in the correct order.
Can you please confirm that this is still applicable. Or help me see
what I am missing.
Regards,
Bjorn
> ---
> Changes in v2:
> - nothing
>
> drivers/pinctrl/qcom/pinctrl-sm6350.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sm6350.c b/drivers/pinctrl/qcom/pinctrl-sm6350.c
> index 4d37b817b232..a91a86628f2f 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sm6350.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sm6350.c
> @@ -264,14 +264,14 @@ static const struct pinctrl_pin_desc sm6350_pins[] = {
> PINCTRL_PIN(153, "GPIO_153"),
> PINCTRL_PIN(154, "GPIO_154"),
> PINCTRL_PIN(155, "GPIO_155"),
> - PINCTRL_PIN(156, "SDC1_RCLK"),
> - PINCTRL_PIN(157, "SDC1_CLK"),
> - PINCTRL_PIN(158, "SDC1_CMD"),
> - PINCTRL_PIN(159, "SDC1_DATA"),
> - PINCTRL_PIN(160, "SDC2_CLK"),
> - PINCTRL_PIN(161, "SDC2_CMD"),
> - PINCTRL_PIN(162, "SDC2_DATA"),
> - PINCTRL_PIN(163, "UFS_RESET"),
> + PINCTRL_PIN(156, "UFS_RESET"),
> + PINCTRL_PIN(157, "SDC1_RCLK"),
> + PINCTRL_PIN(158, "SDC1_CLK"),
> + PINCTRL_PIN(159, "SDC1_CMD"),
> + PINCTRL_PIN(160, "SDC1_DATA"),
> + PINCTRL_PIN(161, "SDC2_CLK"),
> + PINCTRL_PIN(162, "SDC2_CMD"),
> + PINCTRL_PIN(163, "SDC2_DATA"),
> };
>
> #define DECLARE_MSM_GPIO_PINS(pin) \
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 4/6] pinctrl: qcom: sm6350: fix order of UFS & SDC pins
2022-03-21 14:15 ` Bjorn Andersson
@ 2022-03-21 14:21 ` Luca Weiss
0 siblings, 0 replies; 26+ messages in thread
From: Luca Weiss @ 2022-03-21 14:21 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, ~postmarketos/upstreaming, phone-devel,
Andy Gross, Linus Walleij, AngeloGioacchino Del Regno,
Konrad Dybcio, linux-gpio, linux-kernel
Hi Bjorn,
On Mon Mar 21, 2022 at 3:15 PM CET, Bjorn Andersson wrote:
> On Mon 21 Mar 08:33 CDT 2022, Luca Weiss wrote:
>
> > In other places the SDC and UFS pins have been swapped but this was
> > missed in the PINCTRL_PIN definitions. Fix that.
> >
> > Fixes: 7d74b55afd27 ("pinctrl: qcom: Add SM6350 pinctrl driver")
> > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>
> Your proposed change looks good, but when I look at 7d74b55afd27 it
> already has these entries in the correct order.
>
> Can you please confirm that this is still applicable. Or help me see
> what I am missing.
There are 3 times where number and description should match.
For this UFS pin on sm6350 only 2/3 match.
2x the number is 156, 1x it's 163
$ grep -i ufs_reset drivers/pinctrl/qcom/pinctrl-sm6350.c
PINCTRL_PIN(163, "UFS_RESET"),
static const unsigned int ufs_reset_pins[] = { 156 };
[156] = UFS_RESET(ufs_reset, 0xae000),
Does that help?
Regards
Luca
>
> Regards,
> Bjorn
>
> > ---
> > Changes in v2:
> > - nothing
> >
> > drivers/pinctrl/qcom/pinctrl-sm6350.c | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/pinctrl/qcom/pinctrl-sm6350.c b/drivers/pinctrl/qcom/pinctrl-sm6350.c
> > index 4d37b817b232..a91a86628f2f 100644
> > --- a/drivers/pinctrl/qcom/pinctrl-sm6350.c
> > +++ b/drivers/pinctrl/qcom/pinctrl-sm6350.c
> > @@ -264,14 +264,14 @@ static const struct pinctrl_pin_desc sm6350_pins[] = {
> > PINCTRL_PIN(153, "GPIO_153"),
> > PINCTRL_PIN(154, "GPIO_154"),
> > PINCTRL_PIN(155, "GPIO_155"),
> > - PINCTRL_PIN(156, "SDC1_RCLK"),
> > - PINCTRL_PIN(157, "SDC1_CLK"),
> > - PINCTRL_PIN(158, "SDC1_CMD"),
> > - PINCTRL_PIN(159, "SDC1_DATA"),
> > - PINCTRL_PIN(160, "SDC2_CLK"),
> > - PINCTRL_PIN(161, "SDC2_CMD"),
> > - PINCTRL_PIN(162, "SDC2_DATA"),
> > - PINCTRL_PIN(163, "UFS_RESET"),
> > + PINCTRL_PIN(156, "UFS_RESET"),
> > + PINCTRL_PIN(157, "SDC1_RCLK"),
> > + PINCTRL_PIN(158, "SDC1_CLK"),
> > + PINCTRL_PIN(159, "SDC1_CMD"),
> > + PINCTRL_PIN(160, "SDC1_DATA"),
> > + PINCTRL_PIN(161, "SDC2_CLK"),
> > + PINCTRL_PIN(162, "SDC2_CMD"),
> > + PINCTRL_PIN(163, "SDC2_DATA"),
> > };
> >
> > #define DECLARE_MSM_GPIO_PINS(pin) \
> > --
> > 2.35.1
> >
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 4/6] pinctrl: qcom: sm6350: fix order of UFS & SDC pins
2022-03-21 13:33 ` [PATCH v2 4/6] pinctrl: qcom: sm6350: fix order of UFS & SDC pins Luca Weiss
2022-03-21 14:15 ` Bjorn Andersson
@ 2022-04-17 23:42 ` Linus Walleij
1 sibling, 0 replies; 26+ messages in thread
From: Linus Walleij @ 2022-04-17 23:42 UTC (permalink / raw)
To: Luca Weiss
Cc: linux-arm-msm, ~postmarketos/upstreaming, phone-devel,
Andy Gross, Bjorn Andersson, AngeloGioacchino Del Regno,
Konrad Dybcio, linux-gpio, linux-kernel
On Mon, Mar 21, 2022 at 2:33 PM Luca Weiss <luca.weiss@fairphone.com> wrote:
> In other places the SDC and UFS pins have been swapped but this was
> missed in the PINCTRL_PIN definitions. Fix that.
>
> Fixes: 7d74b55afd27 ("pinctrl: qcom: Add SM6350 pinctrl driver")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Changes in v2:
> - nothing
Since no changes I assume it was OK I applied v1.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH v2 5/6] arm64: dts: qcom: sm6350: Add UFS nodes
2022-03-21 13:33 ` Luca Weiss
` (4 preceding siblings ...)
(?)
@ 2022-03-21 13:33 ` Luca Weiss
2022-03-21 13:42 ` Krzysztof Kozlowski
-1 siblings, 1 reply; 26+ messages in thread
From: Luca Weiss @ 2022-03-21 13:33 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-kernel
Add the necessary nodes for UFS and its PHY.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Changes in v2:
- rename node to ufs@ -> this makes this patch now (soft-)depend on
https://lore.kernel.org/linux-arm-msm/20220320110616.18355-1-krzk@kernel.org/
arch/arm64/boot/dts/qcom/sm6350.dtsi | 77 ++++++++++++++++++++++++++++
1 file changed, 77 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi
index d7c9edff19f7..75e4b2b4d3af 100644
--- a/arch/arm64/boot/dts/qcom/sm6350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi
@@ -541,6 +541,83 @@ uart2: serial@98c000 {
};
};
+ ufs_mem_hc: ufs@1d84000 {
+ compatible = "qcom,sm6350-ufshc", "qcom,ufshc",
+ "jedec,ufs-2.0";
+ reg = <0 0x01d84000 0 0x3000>,
+ <0 0x01d90000 0 0x8000>;
+ reg-names = "std", "ice";
+ interrupts = <GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH>;
+ phys = <&ufs_mem_phy_lanes>;
+ phy-names = "ufsphy";
+ lanes-per-direction = <2>;
+ #reset-cells = <1>;
+ resets = <&gcc GCC_UFS_PHY_BCR>;
+ reset-names = "rst";
+
+ power-domains = <&gcc UFS_PHY_GDSC>;
+
+ iommus = <&apps_smmu 0x80 0x0>;
+
+ clock-names = "core_clk",
+ "bus_aggr_clk",
+ "iface_clk",
+ "core_clk_unipro",
+ "ref_clk",
+ "tx_lane0_sync_clk",
+ "rx_lane0_sync_clk",
+ "rx_lane1_sync_clk",
+ "ice_core_clk";
+ clocks = <&gcc GCC_UFS_PHY_AXI_CLK>,
+ <&gcc GCC_AGGRE_UFS_PHY_AXI_CLK>,
+ <&gcc GCC_UFS_PHY_AHB_CLK>,
+ <&gcc GCC_UFS_PHY_UNIPRO_CORE_CLK>,
+ <&rpmhcc RPMH_QLINK_CLK>,
+ <&gcc GCC_UFS_PHY_TX_SYMBOL_0_CLK>,
+ <&gcc GCC_UFS_PHY_RX_SYMBOL_0_CLK>,
+ <&gcc GCC_UFS_PHY_RX_SYMBOL_1_CLK>,
+ <&gcc GCC_UFS_PHY_ICE_CORE_CLK>;
+ freq-table-hz =
+ <50000000 200000000>,
+ <0 0>,
+ <0 0>,
+ <37500000 150000000>,
+ <75000000 300000000>,
+ <0 0>,
+ <0 0>,
+ <0 0>,
+ <0 0>;
+
+ status = "disabled";
+ };
+
+ ufs_mem_phy: phy@1d87000 {
+ compatible = "qcom,sm6350-qmp-ufs-phy";
+ reg = <0 0x01d87000 0 0x18c>;
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ clock-names = "ref",
+ "ref_aux";
+ clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>,
+ <&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
+
+ resets = <&ufs_mem_hc 0>;
+ reset-names = "ufsphy";
+
+ status = "disabled";
+
+ ufs_mem_phy_lanes: phy@1d87400 {
+ reg = <0 0x01d87400 0 0x128>,
+ <0 0x01d87600 0 0x1fc>,
+ <0 0x01d87c00 0 0x1dc>,
+ <0 0x01d87800 0 0x128>,
+ <0 0x01d87a00 0 0x1fc>;
+ #phy-cells = <0>;
+ };
+ };
+
tcsr_mutex: hwlock@1f40000 {
compatible = "qcom,tcsr-mutex";
reg = <0x0 0x01f40000 0x0 0x40000>;
--
2.35.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH v2 5/6] arm64: dts: qcom: sm6350: Add UFS nodes
2022-03-21 13:33 ` [PATCH v2 5/6] arm64: dts: qcom: sm6350: Add UFS nodes Luca Weiss
@ 2022-03-21 13:42 ` Krzysztof Kozlowski
0 siblings, 0 replies; 26+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-21 13:42 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-kernel
On 21/03/2022 14:33, Luca Weiss wrote:
> Add the necessary nodes for UFS and its PHY.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Changes in v2:
> - rename node to ufs@ -> this makes this patch now (soft-)depend on
> https://lore.kernel.org/linux-arm-msm/20220320110616.18355-1-krzk@kernel.org/
>
> arch/arm64/boot/dts/qcom/sm6350.dtsi | 77 ++++++++++++++++++++++++++++
> 1 file changed, 77 insertions(+)
>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH v2 6/6] arm64: dts: qcom: sm7225-fairphone-fp4: Enable UFS
2022-03-21 13:33 ` Luca Weiss
` (5 preceding siblings ...)
(?)
@ 2022-03-21 13:33 ` Luca Weiss
-1 siblings, 0 replies; 26+ messages in thread
From: Luca Weiss @ 2022-03-21 13:33 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-kernel
Configure and enable the nodes for UFS that are used for internal
storage on FP4.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Changes in v2:
- nothing
.../boot/dts/qcom/sm7225-fairphone-fp4.dts | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
index adb6ca2be2a5..533a1c88040f 100644
--- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
+++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
@@ -336,6 +336,24 @@ &uart2 {
status = "okay";
};
+&ufs_mem_hc {
+ status = "okay";
+
+ reset-gpios = <&tlmm 156 GPIO_ACTIVE_LOW>;
+
+ vcc-supply = <&vreg_l7e>;
+ vcc-max-microamp = <800000>;
+ vccq2-supply = <&vreg_l12a>;
+ vccq2-max-microamp = <800000>;
+};
+
+&ufs_mem_phy {
+ status = "okay";
+
+ vdda-phy-supply = <&vreg_l18a>;
+ vdda-pll-supply = <&vreg_l22a>;
+};
+
&usb_1 {
status = "okay";
};
--
2.35.1
^ permalink raw reply related [flat|nested] 26+ messages in thread