* [PATCH V2] soc: imx: imx8m-blk-ctrl: Fix IMX8MN_DISPBLK_PD_ISI hang
@ 2022-03-20 20:52 ` Adam Ford
0 siblings, 0 replies; 6+ messages in thread
From: Adam Ford @ 2022-03-20 20:52 UTC (permalink / raw)
To: linux-arm-kernel
Cc: aford, Adam Ford, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Lucas Stach, linux-kernel
The imx8mn clock list for the ISI lists four clocks, but DOMAIN_MAX_CLKS
was set to 3. Because of this, attempts to enable the fourth clock failed,
threw some splat, and ultimately hung.
Fixes: 7f511d514e8c ("soc: imx: imx8m-blk-ctrl: add i.MX8MN DISP blk-ctrl")
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c
index a0a0d2d7ca4a..7109f0d508e2 100644
--- a/drivers/soc/imx/imx8m-blk-ctrl.c
+++ b/drivers/soc/imx/imx8m-blk-ctrl.c
@@ -50,7 +50,7 @@ struct imx8m_blk_ctrl_domain_data {
u32 mipi_phy_rst_mask;
};
-#define DOMAIN_MAX_CLKS 3
+#define DOMAIN_MAX_CLKS 4
struct imx8m_blk_ctrl_domain {
struct generic_pm_domain genpd;
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH V2] soc: imx: imx8m-blk-ctrl: Fix IMX8MN_DISPBLK_PD_ISI hang
@ 2022-03-20 20:52 ` Adam Ford
0 siblings, 0 replies; 6+ messages in thread
From: Adam Ford @ 2022-03-20 20:52 UTC (permalink / raw)
To: linux-arm-kernel
Cc: aford, Adam Ford, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Lucas Stach, linux-kernel
The imx8mn clock list for the ISI lists four clocks, but DOMAIN_MAX_CLKS
was set to 3. Because of this, attempts to enable the fourth clock failed,
threw some splat, and ultimately hung.
Fixes: 7f511d514e8c ("soc: imx: imx8m-blk-ctrl: add i.MX8MN DISP blk-ctrl")
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c
index a0a0d2d7ca4a..7109f0d508e2 100644
--- a/drivers/soc/imx/imx8m-blk-ctrl.c
+++ b/drivers/soc/imx/imx8m-blk-ctrl.c
@@ -50,7 +50,7 @@ struct imx8m_blk_ctrl_domain_data {
u32 mipi_phy_rst_mask;
};
-#define DOMAIN_MAX_CLKS 3
+#define DOMAIN_MAX_CLKS 4
struct imx8m_blk_ctrl_domain {
struct generic_pm_domain genpd;
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH V2] soc: imx: imx8m-blk-ctrl: Fix IMX8MN_DISPBLK_PD_ISI hang
2022-03-20 20:52 ` Adam Ford
@ 2022-03-21 10:58 ` Lucas Stach
-1 siblings, 0 replies; 6+ messages in thread
From: Lucas Stach @ 2022-03-21 10:58 UTC (permalink / raw)
To: Adam Ford, linux-arm-kernel
Cc: aford, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, linux-kernel
Am Sonntag, dem 20.03.2022 um 15:52 -0500 schrieb Adam Ford:
> The imx8mn clock list for the ISI lists four clocks, but DOMAIN_MAX_CLKS
> was set to 3. Because of this, attempts to enable the fourth clock failed,
> threw some splat, and ultimately hung.
>
> Fixes: 7f511d514e8c ("soc: imx: imx8m-blk-ctrl: add i.MX8MN DISP blk-ctrl")
> Signed-off-by: Adam Ford <aford173@gmail.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
>
> diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c
> index a0a0d2d7ca4a..7109f0d508e2 100644
> --- a/drivers/soc/imx/imx8m-blk-ctrl.c
> +++ b/drivers/soc/imx/imx8m-blk-ctrl.c
> @@ -50,7 +50,7 @@ struct imx8m_blk_ctrl_domain_data {
> u32 mipi_phy_rst_mask;
> };
>
> -#define DOMAIN_MAX_CLKS 3
> +#define DOMAIN_MAX_CLKS 4
>
> struct imx8m_blk_ctrl_domain {
> struct generic_pm_domain genpd;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH V2] soc: imx: imx8m-blk-ctrl: Fix IMX8MN_DISPBLK_PD_ISI hang
@ 2022-03-21 10:58 ` Lucas Stach
0 siblings, 0 replies; 6+ messages in thread
From: Lucas Stach @ 2022-03-21 10:58 UTC (permalink / raw)
To: Adam Ford, linux-arm-kernel
Cc: aford, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, linux-kernel
Am Sonntag, dem 20.03.2022 um 15:52 -0500 schrieb Adam Ford:
> The imx8mn clock list for the ISI lists four clocks, but DOMAIN_MAX_CLKS
> was set to 3. Because of this, attempts to enable the fourth clock failed,
> threw some splat, and ultimately hung.
>
> Fixes: 7f511d514e8c ("soc: imx: imx8m-blk-ctrl: add i.MX8MN DISP blk-ctrl")
> Signed-off-by: Adam Ford <aford173@gmail.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
>
> diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c
> index a0a0d2d7ca4a..7109f0d508e2 100644
> --- a/drivers/soc/imx/imx8m-blk-ctrl.c
> +++ b/drivers/soc/imx/imx8m-blk-ctrl.c
> @@ -50,7 +50,7 @@ struct imx8m_blk_ctrl_domain_data {
> u32 mipi_phy_rst_mask;
> };
>
> -#define DOMAIN_MAX_CLKS 3
> +#define DOMAIN_MAX_CLKS 4
>
> struct imx8m_blk_ctrl_domain {
> struct generic_pm_domain genpd;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] soc: imx: imx8m-blk-ctrl: Fix IMX8MN_DISPBLK_PD_ISI hang
2022-03-20 20:52 ` Adam Ford
@ 2022-04-10 1:32 ` Shawn Guo
-1 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2022-04-10 1:32 UTC (permalink / raw)
To: Adam Ford
Cc: linux-arm-kernel, aford, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Lucas Stach, linux-kernel
On Sun, Mar 20, 2022 at 03:52:12PM -0500, Adam Ford wrote:
> The imx8mn clock list for the ISI lists four clocks, but DOMAIN_MAX_CLKS
> was set to 3. Because of this, attempts to enable the fourth clock failed,
> threw some splat, and ultimately hung.
>
> Fixes: 7f511d514e8c ("soc: imx: imx8m-blk-ctrl: add i.MX8MN DISP blk-ctrl")
> Signed-off-by: Adam Ford <aford173@gmail.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH V2] soc: imx: imx8m-blk-ctrl: Fix IMX8MN_DISPBLK_PD_ISI hang
@ 2022-04-10 1:32 ` Shawn Guo
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2022-04-10 1:32 UTC (permalink / raw)
To: Adam Ford
Cc: linux-arm-kernel, aford, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Lucas Stach, linux-kernel
On Sun, Mar 20, 2022 at 03:52:12PM -0500, Adam Ford wrote:
> The imx8mn clock list for the ISI lists four clocks, but DOMAIN_MAX_CLKS
> was set to 3. Because of this, attempts to enable the fourth clock failed,
> threw some splat, and ultimately hung.
>
> Fixes: 7f511d514e8c ("soc: imx: imx8m-blk-ctrl: add i.MX8MN DISP blk-ctrl")
> Signed-off-by: Adam Ford <aford173@gmail.com>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-10 1:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-20 20:52 [PATCH V2] soc: imx: imx8m-blk-ctrl: Fix IMX8MN_DISPBLK_PD_ISI hang Adam Ford
2022-03-20 20:52 ` Adam Ford
2022-03-21 10:58 ` Lucas Stach
2022-03-21 10:58 ` Lucas Stach
2022-04-10 1:32 ` Shawn Guo
2022-04-10 1:32 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.