From: Nishanth Menon <nm@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>, <tony@atomide.com>
Cc: Devarsh Thakkar <devarsht@ti.com>, <linux-kernel@vger.kernel.org>,
<jyri.sarha@iki.fi>, <tomba@kernel.org>, <airlied@linux.ie>,
<daniel@ffwll.ch>, <dri-devel@lists.freedesktop.org>,
<a-bhatia1@ti.com>, <r-ravikumar@ti.com>, <nikhil.nd@ti.com>,
<linux-arm-kernel@lists.infradead.org>, <vigneshr@ti.com>,
<laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] drm/tidss: Soft Reset DISPC on startup
Date: Tue, 12 Apr 2022 16:20:49 -0500 [thread overview]
Message-ID: <20220412212049.gjnel7aubol56azk@earache> (raw)
In-Reply-To: <86a07099-1074-e8d1-6d0e-1ce68414b627@ideasonboard.com>
On 17:24-20220412, Tomi Valkeinen wrote:
> Hi,
>
> On 14/03/2022 13:37, Devarsh Thakkar wrote:
> > Soft reset the display subsystem controller on startup and wait for
> > the reset to complete. This helps the scenario where display was
> > already in use by some other core before the linux was booted.
>
> The reason the omapdrm doesn't do a reset is that the PM features on some of
> the DSS registers were set and controlled outside dss driver, so the dss
> driver could not do a reset just like that. That design was carried to the
> tidss driver, although I'm not sure if the reason is valid on AM6 and J7
> platforms.
>
> If that reasoning is not valid, this patch is ok and:
>
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
>
Tony - sysc control for older omap devices still control this directly?
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>, <tony@atomide.com>
Cc: Devarsh Thakkar <devarsht@ti.com>,
tomba@kernel.org, airlied@linux.ie, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, a-bhatia1@ti.com,
vigneshr@ti.com, laurent.pinchart@ideasonboard.com,
jyri.sarha@iki.fi, nikhil.nd@ti.com,
linux-arm-kernel@lists.infradead.org, r-ravikumar@ti.com
Subject: Re: [PATCH] drm/tidss: Soft Reset DISPC on startup
Date: Tue, 12 Apr 2022 16:20:49 -0500 [thread overview]
Message-ID: <20220412212049.gjnel7aubol56azk@earache> (raw)
In-Reply-To: <86a07099-1074-e8d1-6d0e-1ce68414b627@ideasonboard.com>
On 17:24-20220412, Tomi Valkeinen wrote:
> Hi,
>
> On 14/03/2022 13:37, Devarsh Thakkar wrote:
> > Soft reset the display subsystem controller on startup and wait for
> > the reset to complete. This helps the scenario where display was
> > already in use by some other core before the linux was booted.
>
> The reason the omapdrm doesn't do a reset is that the PM features on some of
> the DSS registers were set and controlled outside dss driver, so the dss
> driver could not do a reset just like that. That design was carried to the
> tidss driver, although I'm not sure if the reason is valid on AM6 and J7
> platforms.
>
> If that reasoning is not valid, this patch is ok and:
>
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
>
Tony - sysc control for older omap devices still control this directly?
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>, <tony@atomide.com>
Cc: Devarsh Thakkar <devarsht@ti.com>, <linux-kernel@vger.kernel.org>,
<jyri.sarha@iki.fi>, <tomba@kernel.org>, <airlied@linux.ie>,
<daniel@ffwll.ch>, <dri-devel@lists.freedesktop.org>,
<a-bhatia1@ti.com>, <r-ravikumar@ti.com>, <nikhil.nd@ti.com>,
<linux-arm-kernel@lists.infradead.org>, <vigneshr@ti.com>,
<laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] drm/tidss: Soft Reset DISPC on startup
Date: Tue, 12 Apr 2022 16:20:49 -0500 [thread overview]
Message-ID: <20220412212049.gjnel7aubol56azk@earache> (raw)
In-Reply-To: <86a07099-1074-e8d1-6d0e-1ce68414b627@ideasonboard.com>
On 17:24-20220412, Tomi Valkeinen wrote:
> Hi,
>
> On 14/03/2022 13:37, Devarsh Thakkar wrote:
> > Soft reset the display subsystem controller on startup and wait for
> > the reset to complete. This helps the scenario where display was
> > already in use by some other core before the linux was booted.
>
> The reason the omapdrm doesn't do a reset is that the PM features on some of
> the DSS registers were set and controlled outside dss driver, so the dss
> driver could not do a reset just like that. That design was carried to the
> tidss driver, although I'm not sure if the reason is valid on AM6 and J7
> platforms.
>
> If that reasoning is not valid, this patch is ok and:
>
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
>
Tony - sysc control for older omap devices still control this directly?
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2022-04-12 21:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 11:37 [PATCH] drm/tidss: Soft Reset DISPC on startup Devarsh Thakkar
2022-03-14 11:37 ` Devarsh Thakkar
2022-03-14 11:37 ` Devarsh Thakkar
2022-04-12 9:10 ` Devarsh Thakkar
2022-04-12 9:10 ` Devarsh Thakkar
2022-04-12 9:10 ` Devarsh Thakkar
2022-04-12 14:24 ` Tomi Valkeinen
2022-04-12 14:24 ` Tomi Valkeinen
2022-04-12 14:24 ` Tomi Valkeinen
2022-04-12 21:20 ` Nishanth Menon [this message]
2022-04-12 21:20 ` Nishanth Menon
2022-04-12 21:20 ` Nishanth Menon
2022-04-13 5:32 ` Tony Lindgren
2022-04-13 5:32 ` Tony Lindgren
2022-04-13 5:32 ` Tony Lindgren
2022-04-19 12:19 ` Tomi Valkeinen
2022-04-19 12:19 ` Tomi Valkeinen
2022-04-19 12:19 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220412212049.gjnel7aubol56azk@earache \
--to=nm@ti.com \
--cc=a-bhatia1@ti.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devarsht@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jyri.sarha@iki.fi \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikhil.nd@ti.com \
--cc=r-ravikumar@ti.com \
--cc=tomba@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.