All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	Devarsh Thakkar <devarsht@ti.com>,
	linux-kernel@vger.kernel.org, jyri.sarha@iki.fi,
	tomba@kernel.org, airlied@linux.ie, daniel@ffwll.ch,
	dri-devel@lists.freedesktop.org, a-bhatia1@ti.com,
	r-ravikumar@ti.com, nikhil.nd@ti.com,
	linux-arm-kernel@lists.infradead.org, vigneshr@ti.com,
	laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH] drm/tidss: Soft Reset DISPC on startup
Date: Wed, 13 Apr 2022 08:32:40 +0300	[thread overview]
Message-ID: <YlZgeGPoWv+Z0iYy@atomide.com> (raw)
In-Reply-To: <20220412212049.gjnel7aubol56azk@earache>

* Nishanth Menon <nm@ti.com> [220412 21:18]:
> On 17:24-20220412, Tomi Valkeinen wrote:
> > Hi,
> > 
> > On 14/03/2022 13:37, Devarsh Thakkar wrote:
> > > Soft reset the display subsystem controller on startup and wait for
> > > the reset to complete. This helps the scenario where display was
> > > already in use by some other core before the linux was booted.
> > 
> > The reason the omapdrm doesn't do a reset is that the PM features on some of
> > the DSS registers were set and controlled outside dss driver, so the dss
> > driver could not do a reset just like that. That design was carried to the
> > tidss driver, although I'm not sure if the reason is valid on AM6 and J7
> > platforms.
> > 
> > If that reasoning is not valid, this patch is ok and:
> > 
> > Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

Yeah seems OK to me for tidss, I don't think there's any other layer to
do this in a generic way for k3 devices currently.

The thing to check here is that the sysconfig register gets properly
initialized to the right state after reset. For PM, likely the syconfig
value after reset is not correct, but that can be reconfigured later on
as needed.

> Tony - sysc control for older omap devices still control this directly?

Yes, for a  reason. The reset affects the entire interconnect target
module, and disabling clockdomain autoidle needs to be considered for
enable. For omaps, the resets are handled in a generic way for all the
TI devices by ti-sysc.

With ti-sysc, the reset is done before probing dss devices on init in
sysc_init_module(). The dss related quirk handling is done in
sysc_pre_reset_quirk_dss(). If needed, we could add support for reset
framework to ti-sysc for omapdrm to call. But so far there has not been
much of a need for that, I think 8250_omap could use reset framework if
available though.

Anyways, sounds like there's no need to do a similar dss reset in
omapdrm.

Regards,

Tony


WARNING: multiple messages have this Message-ID
From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	Devarsh Thakkar <devarsht@ti.com>,
	linux-kernel@vger.kernel.org, jyri.sarha@iki.fi,
	tomba@kernel.org, airlied@linux.ie, daniel@ffwll.ch,
	dri-devel@lists.freedesktop.org, a-bhatia1@ti.com,
	r-ravikumar@ti.com, nikhil.nd@ti.com,
	linux-arm-kernel@lists.infradead.org, vigneshr@ti.com,
	laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH] drm/tidss: Soft Reset DISPC on startup
Date: Wed, 13 Apr 2022 08:32:40 +0300	[thread overview]
Message-ID: <YlZgeGPoWv+Z0iYy@atomide.com> (raw)
In-Reply-To: <20220412212049.gjnel7aubol56azk@earache>

* Nishanth Menon <nm@ti.com> [220412 21:18]:
> On 17:24-20220412, Tomi Valkeinen wrote:
> > Hi,
> > 
> > On 14/03/2022 13:37, Devarsh Thakkar wrote:
> > > Soft reset the display subsystem controller on startup and wait for
> > > the reset to complete. This helps the scenario where display was
> > > already in use by some other core before the linux was booted.
> > 
> > The reason the omapdrm doesn't do a reset is that the PM features on some of
> > the DSS registers were set and controlled outside dss driver, so the dss
> > driver could not do a reset just like that. That design was carried to the
> > tidss driver, although I'm not sure if the reason is valid on AM6 and J7
> > platforms.
> > 
> > If that reasoning is not valid, this patch is ok and:
> > 
> > Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

Yeah seems OK to me for tidss, I don't think there's any other layer to
do this in a generic way for k3 devices currently.

The thing to check here is that the sysconfig register gets properly
initialized to the right state after reset. For PM, likely the syconfig
value after reset is not correct, but that can be reconfigured later on
as needed.

> Tony - sysc control for older omap devices still control this directly?

Yes, for a  reason. The reset affects the entire interconnect target
module, and disabling clockdomain autoidle needs to be considered for
enable. For omaps, the resets are handled in a generic way for all the
TI devices by ti-sysc.

With ti-sysc, the reset is done before probing dss devices on init in
sysc_init_module(). The dss related quirk handling is done in
sysc_pre_reset_quirk_dss(). If needed, we could add support for reset
framework to ti-sysc for omapdrm to call. But so far there has not been
much of a need for that, I think 8250_omap could use reset framework if
available though.

Anyways, sounds like there's no need to do a similar dss reset in
omapdrm.

Regards,

Tony


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID
From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: Devarsh Thakkar <devarsht@ti.com>,
	tomba@kernel.org, airlied@linux.ie,
	Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	a-bhatia1@ti.com, vigneshr@ti.com,
	laurent.pinchart@ideasonboard.com, jyri.sarha@iki.fi,
	nikhil.nd@ti.com, linux-arm-kernel@lists.infradead.org,
	r-ravikumar@ti.com
Subject: Re: [PATCH] drm/tidss: Soft Reset DISPC on startup
Date: Wed, 13 Apr 2022 08:32:40 +0300	[thread overview]
Message-ID: <YlZgeGPoWv+Z0iYy@atomide.com> (raw)
In-Reply-To: <20220412212049.gjnel7aubol56azk@earache>

* Nishanth Menon <nm@ti.com> [220412 21:18]:
> On 17:24-20220412, Tomi Valkeinen wrote:
> > Hi,
> > 
> > On 14/03/2022 13:37, Devarsh Thakkar wrote:
> > > Soft reset the display subsystem controller on startup and wait for
> > > the reset to complete. This helps the scenario where display was
> > > already in use by some other core before the linux was booted.
> > 
> > The reason the omapdrm doesn't do a reset is that the PM features on some of
> > the DSS registers were set and controlled outside dss driver, so the dss
> > driver could not do a reset just like that. That design was carried to the
> > tidss driver, although I'm not sure if the reason is valid on AM6 and J7
> > platforms.
> > 
> > If that reasoning is not valid, this patch is ok and:
> > 
> > Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

Yeah seems OK to me for tidss, I don't think there's any other layer to
do this in a generic way for k3 devices currently.

The thing to check here is that the sysconfig register gets properly
initialized to the right state after reset. For PM, likely the syconfig
value after reset is not correct, but that can be reconfigured later on
as needed.

> Tony - sysc control for older omap devices still control this directly?

Yes, for a  reason. The reset affects the entire interconnect target
module, and disabling clockdomain autoidle needs to be considered for
enable. For omaps, the resets are handled in a generic way for all the
TI devices by ti-sysc.

With ti-sysc, the reset is done before probing dss devices on init in
sysc_init_module(). The dss related quirk handling is done in
sysc_pre_reset_quirk_dss(). If needed, we could add support for reset
framework to ti-sysc for omapdrm to call. But so far there has not been
much of a need for that, I think 8250_omap could use reset framework if
available though.

Anyways, sounds like there's no need to do a similar dss reset in
omapdrm.

Regards,

Tony


  reply	other threads:[~2022-04-13  5:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-14 11:37 [PATCH] drm/tidss: Soft Reset DISPC on startup Devarsh Thakkar
2022-03-14 11:37 ` Devarsh Thakkar
2022-03-14 11:37 ` Devarsh Thakkar
2022-04-12  9:10 ` Devarsh Thakkar
2022-04-12  9:10   ` Devarsh Thakkar
2022-04-12  9:10   ` Devarsh Thakkar
2022-04-12 14:24 ` Tomi Valkeinen
2022-04-12 14:24   ` Tomi Valkeinen
2022-04-12 14:24   ` Tomi Valkeinen
2022-04-12 21:20   ` Nishanth Menon
2022-04-12 21:20     ` Nishanth Menon
2022-04-12 21:20     ` Nishanth Menon
2022-04-13  5:32     ` Tony Lindgren [this message]
2022-04-13  5:32       ` Tony Lindgren
2022-04-13  5:32       ` Tony Lindgren
2022-04-19 12:19 ` Tomi Valkeinen
2022-04-19 12:19   ` Tomi Valkeinen
2022-04-19 12:19   ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YlZgeGPoWv+Z0iYy@atomide.com \
    --to=tony@atomide.com \
    --cc=a-bhatia1@ti.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=devarsht@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jyri.sarha@iki.fi \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikhil.nd@ti.com \
    --cc=nm@ti.com \
    --cc=r-ravikumar@ti.com \
    --cc=tomba@kernel.org \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.