All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Liang Yang <liang.yang@amlogic.com>
Cc: <linux-mtd@lists.infradead.org>, Rob Herring <robh+dt@kernel.org>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jianxin Pan <jianxin.pan@amlogic.com>,
	Victor Wan <victor.wan@amlogic.com>,
	XianWei Zhao <xianwei.zhao@amlogic.com>,
	Kelvin Zhang <kelvin.zhang@amlogic.com>,
	BiChao Zheng <bichao.zheng@amlogic.com>,
	YongHui Yu <yonghui.yu@amlogic.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-amlogic@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework
Date: Tue, 19 Apr 2022 10:26:29 +0200	[thread overview]
Message-ID: <20220419102629.1c77aa2a@xps13> (raw)
In-Reply-To: <d5a33645-fac1-9c69-afe6-654bfe93ca48@amlogic.com>

Hello,

liang.yang@amlogic.com wrote on Mon, 18 Apr 2022 11:40:10 +0800:

> Hi Miquel,
> 
> i have some confusion when i prepare the patches. for DT compatibility, it falls back to the old DT when failed to get resource by the new DT, but there is some points:
> a. old DT depends on MMC sub clock driver, but it never be merged, so it can't work.

I don't get what you mean here, sorry. I believe there is a new way to
describe this clock but grabbing the one from the MMC still works, does
not it?

> b. if it falls back to the old DT, beside the regmap lookup below, it seems that we have to preserve the code of the old clock setting in nfc_clk_init().

Yes, probably.

> do we still need to avoid break DT compatibility?

We should try our best to avoid breaking the DT, yes.

> 
> Thanks.
> 
> On 2022/4/11 10:40, Liang Yang wrote:
> >>>       nfc->dev = dev;
> >>> -    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> >>> -    nfc->reg_base = devm_ioremap_resource(dev, res);
> >>> +    nfc->reg_base = devm_platform_ioremap_resource_byname(pdev, "nfc");  
> >>
> >> This change seems unrelated.  
> > 
> > To be consistent with the following > devm_platform_ioremap_resource_byname(pdev, "emmc"). do you mean that we > don't need it?>  
> >>>       if (IS_ERR(nfc->reg_base))
> >>>           return PTR_ERR(nfc->reg_base);
> >>> -    nfc->reg_clk =
> >>> -        syscon_regmap_lookup_by_phandle(dev->of_node,
> >>> -                        "amlogic,mmc-syscon");
> >>> -    if (IS_ERR(nfc->reg_clk)) {
> >>> -        dev_err(dev, "Failed to lookup clock base\n");
> >>> -        return PTR_ERR(nfc->reg_clk);
> >>> -    }
> >>> +    nfc->sd_emmc_clock = devm_platform_ioremap_resource_byname(pdev, >>> "emmc");
> >>> +    if (IS_ERR(nfc->sd_emmc_clock))
> >>> +        return PTR_ERR(nfc->sd_emmc_clock);  
> >>
> >> While I agree this is much better than the previous solution, we cannot
> >> break DT compatibility, so you need to try getting the emmc clock, but
> >> if it fails you should fallback to the regmap lookup.  
> > 
> > ok, i will fix it next version. thanks.
> >   
> >>  
> >>>       irq = platform_get_irq(pdev, 0);  


Thanks,
Miquèl

WARNING: multiple messages have this Message-ID
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Liang Yang <liang.yang@amlogic.com>
Cc: <linux-mtd@lists.infradead.org>, Rob Herring <robh+dt@kernel.org>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jianxin Pan <jianxin.pan@amlogic.com>,
	Victor Wan <victor.wan@amlogic.com>,
	XianWei Zhao <xianwei.zhao@amlogic.com>,
	Kelvin Zhang <kelvin.zhang@amlogic.com>,
	BiChao Zheng <bichao.zheng@amlogic.com>,
	YongHui Yu <yonghui.yu@amlogic.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-amlogic@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework
Date: Tue, 19 Apr 2022 10:26:29 +0200	[thread overview]
Message-ID: <20220419102629.1c77aa2a@xps13> (raw)
In-Reply-To: <d5a33645-fac1-9c69-afe6-654bfe93ca48@amlogic.com>

Hello,

liang.yang@amlogic.com wrote on Mon, 18 Apr 2022 11:40:10 +0800:

> Hi Miquel,
> 
> i have some confusion when i prepare the patches. for DT compatibility, it falls back to the old DT when failed to get resource by the new DT, but there is some points:
> a. old DT depends on MMC sub clock driver, but it never be merged, so it can't work.

I don't get what you mean here, sorry. I believe there is a new way to
describe this clock but grabbing the one from the MMC still works, does
not it?

> b. if it falls back to the old DT, beside the regmap lookup below, it seems that we have to preserve the code of the old clock setting in nfc_clk_init().

Yes, probably.

> do we still need to avoid break DT compatibility?

We should try our best to avoid breaking the DT, yes.

> 
> Thanks.
> 
> On 2022/4/11 10:40, Liang Yang wrote:
> >>>       nfc->dev = dev;
> >>> -    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> >>> -    nfc->reg_base = devm_ioremap_resource(dev, res);
> >>> +    nfc->reg_base = devm_platform_ioremap_resource_byname(pdev, "nfc");  
> >>
> >> This change seems unrelated.  
> > 
> > To be consistent with the following > devm_platform_ioremap_resource_byname(pdev, "emmc"). do you mean that we > don't need it?>  
> >>>       if (IS_ERR(nfc->reg_base))
> >>>           return PTR_ERR(nfc->reg_base);
> >>> -    nfc->reg_clk =
> >>> -        syscon_regmap_lookup_by_phandle(dev->of_node,
> >>> -                        "amlogic,mmc-syscon");
> >>> -    if (IS_ERR(nfc->reg_clk)) {
> >>> -        dev_err(dev, "Failed to lookup clock base\n");
> >>> -        return PTR_ERR(nfc->reg_clk);
> >>> -    }
> >>> +    nfc->sd_emmc_clock = devm_platform_ioremap_resource_byname(pdev, >>> "emmc");
> >>> +    if (IS_ERR(nfc->sd_emmc_clock))
> >>> +        return PTR_ERR(nfc->sd_emmc_clock);  
> >>
> >> While I agree this is much better than the previous solution, we cannot
> >> break DT compatibility, so you need to try getting the emmc clock, but
> >> if it fails you should fallback to the regmap lookup.  
> > 
> > ok, i will fix it next version. thanks.
> >   
> >>  
> >>>       irq = platform_get_irq(pdev, 0);  


Thanks,
Miquèl

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Liang Yang <liang.yang@amlogic.com>
Cc: <linux-mtd@lists.infradead.org>, Rob Herring <robh+dt@kernel.org>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jianxin Pan <jianxin.pan@amlogic.com>,
	Victor Wan <victor.wan@amlogic.com>,
	XianWei Zhao <xianwei.zhao@amlogic.com>,
	Kelvin Zhang <kelvin.zhang@amlogic.com>,
	BiChao Zheng <bichao.zheng@amlogic.com>,
	YongHui Yu <yonghui.yu@amlogic.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-amlogic@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework
Date: Tue, 19 Apr 2022 10:26:29 +0200	[thread overview]
Message-ID: <20220419102629.1c77aa2a@xps13> (raw)
In-Reply-To: <d5a33645-fac1-9c69-afe6-654bfe93ca48@amlogic.com>

Hello,

liang.yang@amlogic.com wrote on Mon, 18 Apr 2022 11:40:10 +0800:

> Hi Miquel,
> 
> i have some confusion when i prepare the patches. for DT compatibility, it falls back to the old DT when failed to get resource by the new DT, but there is some points:
> a. old DT depends on MMC sub clock driver, but it never be merged, so it can't work.

I don't get what you mean here, sorry. I believe there is a new way to
describe this clock but grabbing the one from the MMC still works, does
not it?

> b. if it falls back to the old DT, beside the regmap lookup below, it seems that we have to preserve the code of the old clock setting in nfc_clk_init().

Yes, probably.

> do we still need to avoid break DT compatibility?

We should try our best to avoid breaking the DT, yes.

> 
> Thanks.
> 
> On 2022/4/11 10:40, Liang Yang wrote:
> >>>       nfc->dev = dev;
> >>> -    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> >>> -    nfc->reg_base = devm_ioremap_resource(dev, res);
> >>> +    nfc->reg_base = devm_platform_ioremap_resource_byname(pdev, "nfc");  
> >>
> >> This change seems unrelated.  
> > 
> > To be consistent with the following > devm_platform_ioremap_resource_byname(pdev, "emmc"). do you mean that we > don't need it?>  
> >>>       if (IS_ERR(nfc->reg_base))
> >>>           return PTR_ERR(nfc->reg_base);
> >>> -    nfc->reg_clk =
> >>> -        syscon_regmap_lookup_by_phandle(dev->of_node,
> >>> -                        "amlogic,mmc-syscon");
> >>> -    if (IS_ERR(nfc->reg_clk)) {
> >>> -        dev_err(dev, "Failed to lookup clock base\n");
> >>> -        return PTR_ERR(nfc->reg_clk);
> >>> -    }
> >>> +    nfc->sd_emmc_clock = devm_platform_ioremap_resource_byname(pdev, >>> "emmc");
> >>> +    if (IS_ERR(nfc->sd_emmc_clock))
> >>> +        return PTR_ERR(nfc->sd_emmc_clock);  
> >>
> >> While I agree this is much better than the previous solution, we cannot
> >> break DT compatibility, so you need to try getting the emmc clock, but
> >> if it fails you should fallback to the regmap lookup.  
> > 
> > ok, i will fix it next version. thanks.
> >   
> >>  
> >>>       irq = platform_get_irq(pdev, 0);  


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Liang Yang <liang.yang@amlogic.com>
Cc: <linux-mtd@lists.infradead.org>, Rob Herring <robh+dt@kernel.org>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jianxin Pan <jianxin.pan@amlogic.com>,
	Victor Wan <victor.wan@amlogic.com>,
	XianWei Zhao <xianwei.zhao@amlogic.com>,
	Kelvin Zhang <kelvin.zhang@amlogic.com>,
	BiChao Zheng <bichao.zheng@amlogic.com>,
	YongHui Yu <yonghui.yu@amlogic.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-amlogic@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework
Date: Tue, 19 Apr 2022 10:26:29 +0200	[thread overview]
Message-ID: <20220419102629.1c77aa2a@xps13> (raw)
In-Reply-To: <d5a33645-fac1-9c69-afe6-654bfe93ca48@amlogic.com>

Hello,

liang.yang@amlogic.com wrote on Mon, 18 Apr 2022 11:40:10 +0800:

> Hi Miquel,
> 
> i have some confusion when i prepare the patches. for DT compatibility, it falls back to the old DT when failed to get resource by the new DT, but there is some points:
> a. old DT depends on MMC sub clock driver, but it never be merged, so it can't work.

I don't get what you mean here, sorry. I believe there is a new way to
describe this clock but grabbing the one from the MMC still works, does
not it?

> b. if it falls back to the old DT, beside the regmap lookup below, it seems that we have to preserve the code of the old clock setting in nfc_clk_init().

Yes, probably.

> do we still need to avoid break DT compatibility?

We should try our best to avoid breaking the DT, yes.

> 
> Thanks.
> 
> On 2022/4/11 10:40, Liang Yang wrote:
> >>>       nfc->dev = dev;
> >>> -    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> >>> -    nfc->reg_base = devm_ioremap_resource(dev, res);
> >>> +    nfc->reg_base = devm_platform_ioremap_resource_byname(pdev, "nfc");  
> >>
> >> This change seems unrelated.  
> > 
> > To be consistent with the following > devm_platform_ioremap_resource_byname(pdev, "emmc"). do you mean that we > don't need it?>  
> >>>       if (IS_ERR(nfc->reg_base))
> >>>           return PTR_ERR(nfc->reg_base);
> >>> -    nfc->reg_clk =
> >>> -        syscon_regmap_lookup_by_phandle(dev->of_node,
> >>> -                        "amlogic,mmc-syscon");
> >>> -    if (IS_ERR(nfc->reg_clk)) {
> >>> -        dev_err(dev, "Failed to lookup clock base\n");
> >>> -        return PTR_ERR(nfc->reg_clk);
> >>> -    }
> >>> +    nfc->sd_emmc_clock = devm_platform_ioremap_resource_byname(pdev, >>> "emmc");
> >>> +    if (IS_ERR(nfc->sd_emmc_clock))
> >>> +        return PTR_ERR(nfc->sd_emmc_clock);  
> >>
> >> While I agree this is much better than the previous solution, we cannot
> >> break DT compatibility, so you need to try getting the emmc clock, but
> >> if it fails you should fallback to the regmap lookup.  
> > 
> > ok, i will fix it next version. thanks.
> >   
> >>  
> >>>       irq = platform_get_irq(pdev, 0);  


Thanks,
Miquèl

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-19  8:26 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-02  7:49 [PATCH v4 0/2] refine the NFC clock framework Liang Yang
2022-04-02  7:49 ` Liang Yang
2022-04-02  7:49 ` Liang Yang
2022-04-02  7:49 ` Liang Yang
2022-04-02  7:49 ` [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub " Liang Yang
2022-04-02  7:49   ` Liang Yang
2022-04-02  7:49   ` Liang Yang
2022-04-02  7:49   ` Liang Yang
2022-04-04  8:30   ` Miquel Raynal
2022-04-04  8:30     ` Miquel Raynal
2022-04-04  8:30     ` Miquel Raynal
2022-04-04  8:30     ` Miquel Raynal
2022-04-11  2:40     ` Liang Yang
2022-04-11  2:40       ` Liang Yang
2022-04-11  2:40       ` Liang Yang
2022-04-11  2:40       ` Liang Yang
2022-04-11  7:00       ` Miquel Raynal
2022-04-11  7:00         ` Miquel Raynal
2022-04-11  7:00         ` Miquel Raynal
2022-04-11  7:00         ` Miquel Raynal
2022-04-11  9:03         ` Liang Yang
2022-04-11  9:03           ` Liang Yang
2022-04-11  9:03           ` Liang Yang
2022-04-11  9:03           ` Liang Yang
2022-04-18  3:40       ` Liang Yang
2022-04-18  3:40         ` Liang Yang
2022-04-18  3:40         ` Liang Yang
2022-04-18  3:40         ` Liang Yang
2022-04-19  8:26         ` Miquel Raynal [this message]
2022-04-19  8:26           ` Miquel Raynal
2022-04-19  8:26           ` Miquel Raynal
2022-04-19  8:26           ` Miquel Raynal
2022-04-19  9:17           ` Liang Yang
2022-04-19  9:17             ` Liang Yang
2022-04-19  9:17             ` Liang Yang
2022-04-19  9:17             ` Liang Yang
2022-04-19 15:25             ` Miquel Raynal
2022-04-19 15:25               ` Miquel Raynal
2022-04-19 15:25               ` Miquel Raynal
2022-04-19 15:25               ` Miquel Raynal
2022-04-20  5:44               ` Liang Yang
2022-04-20  5:44                 ` Liang Yang
2022-04-20  5:44                 ` Liang Yang
2022-04-20  5:44                 ` Liang Yang
2022-04-20  7:29                 ` Miquel Raynal
2022-04-20  7:29                   ` Miquel Raynal
2022-04-20  7:29                   ` Miquel Raynal
2022-04-20  7:29                   ` Miquel Raynal
2022-04-20  8:19                   ` Liang Yang
2022-04-20  8:19                     ` Liang Yang
2022-04-20  8:19                     ` Liang Yang
2022-04-20  8:19                     ` Liang Yang
2022-04-04 12:40   ` Neil Armstrong
2022-04-04 12:40     ` Neil Armstrong
2022-04-04 12:40     ` Neil Armstrong
2022-04-04 12:40     ` Neil Armstrong
2022-04-11  2:44     ` Liang Yang
2022-04-11  2:44       ` Liang Yang
2022-04-11  2:44       ` Liang Yang
2022-04-11  2:44       ` Liang Yang
2022-04-04 14:26   ` kernel test robot
2022-04-04 14:26     ` kernel test robot
2022-04-04 14:26     ` kernel test robot
2022-04-04 14:26     ` kernel test robot
2022-04-05 11:48   ` kernel test robot
2022-04-05 11:48     ` kernel test robot
2022-04-05 11:48     ` kernel test robot
2022-04-05 11:48     ` kernel test robot
2022-04-02  7:49 ` [PATCH v4 2/2] dt-bindings: nand: meson: refine Amlogic NAND controller driver Liang Yang
2022-04-02  7:49   ` Liang Yang
2022-04-02  7:49   ` Liang Yang
2022-04-02  7:49   ` Liang Yang
2022-04-20  7:41   ` Miquel Raynal
2022-04-20  7:41     ` Miquel Raynal
2022-04-20  7:41     ` Miquel Raynal
2022-04-20  7:41     ` Miquel Raynal
2022-04-20 11:55     ` Liang Yang
2022-04-20 11:55       ` Liang Yang
2022-04-20 11:55       ` Liang Yang
2022-04-20 11:55       ` Liang Yang
2022-04-20 12:16       ` Miquel Raynal
2022-04-20 12:16         ` Miquel Raynal
2022-04-20 12:16         ` Miquel Raynal
2022-04-20 12:16         ` Miquel Raynal
2022-04-20 12:35         ` Liang Yang
2022-04-20 12:35           ` Liang Yang
2022-04-20 12:35           ` Liang Yang
2022-04-20 12:35           ` Liang Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220419102629.1c77aa2a@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=bichao.zheng@amlogic.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=jianxin.pan@amlogic.com \
    --cc=kelvin.zhang@amlogic.com \
    --cc=khilman@baylibre.com \
    --cc=liang.yang@amlogic.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=narmstrong@baylibre.com \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=victor.wan@amlogic.com \
    --cc=vigneshr@ti.com \
    --cc=xianwei.zhao@amlogic.com \
    --cc=yonghui.yu@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.