All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: jasowang@redhat.com, mst@redhat.com,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Cc: lulu@redhat.com, paulmck@kernel.org, peterz@infradead.org,
	maz@kernel.org, cohuck@redhat.com, pasic@linux.ibm.com,
	eperezma@redhat.com, tglx@linutronix.de
Subject: [PATCH V3 9/9] virtio: use WARN_ON() to warning illegal status value
Date: Mon, 25 Apr 2022 10:44:18 +0800	[thread overview]
Message-ID: <20220425024418.8415-10-jasowang@redhat.com> (raw)
In-Reply-To: <20220425024418.8415-1-jasowang@redhat.com>

We used to use BUG_ON() in virtio_device_ready() to detect illegal
status value, this seems sub-optimal since the value is under the
control of the device. Switch to use WARN_ON() instead.

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Halil Pasic <pasic@linux.ibm.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 include/linux/virtio_config.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
index 3e2bc8aff51e..b0010b2ca7c2 100644
--- a/include/linux/virtio_config.h
+++ b/include/linux/virtio_config.h
@@ -254,7 +254,7 @@ void virtio_device_ready(struct virtio_device *dev)
 {
 	unsigned status = dev->config->get_status(dev);
 
-	BUG_ON(status & VIRTIO_CONFIG_S_DRIVER_OK);
+	WARN_ON(status & VIRTIO_CONFIG_S_DRIVER_OK);
 
 	/*
 	 * The virtio_synchronize_cbs() makes sure vring_interrupt()
-- 
2.25.1

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com>
To: jasowang@redhat.com, mst@redhat.com,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Cc: sgarzare@redhat.com, eperezma@redhat.com, lulu@redhat.com,
	tglx@linutronix.de, peterz@infradead.org, paulmck@kernel.org,
	maz@kernel.org, pasic@linux.ibm.com, cohuck@redhat.com
Subject: [PATCH V3 9/9] virtio: use WARN_ON() to warning illegal status value
Date: Mon, 25 Apr 2022 10:44:18 +0800	[thread overview]
Message-ID: <20220425024418.8415-10-jasowang@redhat.com> (raw)
In-Reply-To: <20220425024418.8415-1-jasowang@redhat.com>

We used to use BUG_ON() in virtio_device_ready() to detect illegal
status value, this seems sub-optimal since the value is under the
control of the device. Switch to use WARN_ON() instead.

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Halil Pasic <pasic@linux.ibm.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 include/linux/virtio_config.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
index 3e2bc8aff51e..b0010b2ca7c2 100644
--- a/include/linux/virtio_config.h
+++ b/include/linux/virtio_config.h
@@ -254,7 +254,7 @@ void virtio_device_ready(struct virtio_device *dev)
 {
 	unsigned status = dev->config->get_status(dev);
 
-	BUG_ON(status & VIRTIO_CONFIG_S_DRIVER_OK);
+	WARN_ON(status & VIRTIO_CONFIG_S_DRIVER_OK);
 
 	/*
 	 * The virtio_synchronize_cbs() makes sure vring_interrupt()
-- 
2.25.1


  parent reply	other threads:[~2022-04-25  2:46 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25  2:44 [PATCH V3 0/9] rework on the IRQ hardening of virtio Jason Wang
2022-04-25  2:44 ` Jason Wang
2022-04-25  2:44 ` [PATCH V3 1/9] virtio: use virtio_device_ready() in virtio_device_restore() Jason Wang
2022-04-25  2:44   ` Jason Wang
2022-04-28  9:07   ` Cornelia Huck
2022-04-28  9:07     ` Cornelia Huck
2022-04-25  2:44 ` [PATCH V3 2/9] virtio: use virtio_reset_device() when possible Jason Wang
2022-04-25  2:44   ` Jason Wang
2022-04-28  9:07   ` Cornelia Huck
2022-04-28  9:07     ` Cornelia Huck
2022-04-25  2:44 ` [PATCH V3 3/9] virtio: introduce config op to synchronize vring callbacks Jason Wang
2022-04-25  2:44   ` Jason Wang
2022-04-28  9:13   ` Cornelia Huck
2022-04-28  9:13     ` Cornelia Huck
2022-04-29  2:08     ` Jason Wang
2022-04-29  2:08       ` Jason Wang
2022-04-29  7:25       ` Cornelia Huck
2022-04-29  7:25         ` Cornelia Huck
2022-05-05  8:15         ` Jason Wang
2022-05-05  8:15           ` Jason Wang
2022-04-25  2:44 ` [PATCH V3 4/9] virtio-pci: implement synchronize_cbs() Jason Wang
2022-04-25  2:44   ` Jason Wang
2022-04-25  2:44 ` [PATCH V3 5/9] virtio-mmio: " Jason Wang
2022-04-25  2:44   ` Jason Wang
2022-04-25  2:44 ` [PATCH V3 6/9] virtio-ccw: " Jason Wang
2022-04-25  2:44   ` Jason Wang
2022-04-25  8:08   ` Michael S. Tsirkin
2022-04-25  8:08     ` Michael S. Tsirkin
2022-04-25  8:54     ` Cornelia Huck
2022-04-25  8:54       ` Cornelia Huck
2022-04-25 13:59       ` Michael S. Tsirkin
2022-04-25 13:59         ` Michael S. Tsirkin
2022-04-26  2:29         ` Halil Pasic
2022-04-26  2:29           ` Halil Pasic
2022-04-26  3:35           ` Michael S. Tsirkin
2022-04-26  3:35             ` Michael S. Tsirkin
2022-04-26  3:38             ` Michael S. Tsirkin
2022-04-26  3:38               ` Michael S. Tsirkin
2022-04-26  3:42               ` Jason Wang
2022-04-26  3:42                 ` Jason Wang
2022-04-26  3:53                 ` Michael S. Tsirkin
2022-04-26  3:53                   ` Michael S. Tsirkin
2022-04-26  3:55                   ` Michael S. Tsirkin
2022-04-26  3:55                     ` Michael S. Tsirkin
2022-04-26  4:07                     ` Jason Wang
2022-04-26  4:07                       ` Jason Wang
2022-04-26  6:30                       ` Michael S. Tsirkin
2022-04-26  6:30                         ` Michael S. Tsirkin
2022-04-27  3:53                         ` Jason Wang
2022-04-27  3:53                           ` Jason Wang
2022-04-27  6:28                           ` Michael S. Tsirkin
2022-04-27  6:28                             ` Michael S. Tsirkin
2022-04-27  6:30                           ` Michael S. Tsirkin
2022-04-27  6:30                             ` Michael S. Tsirkin
2022-04-27  7:57                             ` Jason Wang
2022-04-27  7:57                               ` Jason Wang
2022-04-27 15:15                               ` Michael S. Tsirkin
2022-04-27 15:15                                 ` Michael S. Tsirkin
2022-04-26 15:47                     ` Cornelia Huck
2022-04-26 15:47                       ` Cornelia Huck
2022-04-26 16:43                       ` Michael S. Tsirkin
2022-04-26 16:43                         ` Michael S. Tsirkin
2022-04-27  9:27                         ` Cornelia Huck
2022-04-27  9:27                           ` Cornelia Huck
2022-04-28  2:43                           ` Halil Pasic
2022-04-28  2:43                             ` Halil Pasic
2022-04-28  3:04                             ` Jason Wang
2022-04-28  3:04                               ` Jason Wang
2022-04-28  5:24                               ` Michael S. Tsirkin
2022-04-28  5:24                                 ` Michael S. Tsirkin
2022-04-28  5:51                                 ` Jason Wang
2022-04-28  5:51                                   ` Jason Wang
2022-04-28  5:55                                   ` Michael S. Tsirkin
2022-04-28  5:55                                     ` Michael S. Tsirkin
2022-04-28  6:02                                     ` Jason Wang
2022-04-28  6:02                                       ` Jason Wang
2022-04-28  6:17                                       ` Michael S. Tsirkin
2022-04-28  6:17                                         ` Michael S. Tsirkin
2022-04-28  7:42                                       ` Cornelia Huck
2022-04-28  7:42                                         ` Cornelia Huck
2022-04-29  2:02                                         ` Jason Wang
2022-04-29  2:02                                           ` Jason Wang
2022-04-28  4:12                             ` Michael S. Tsirkin
2022-04-28  4:12                               ` Michael S. Tsirkin
2022-04-26  2:50       ` Halil Pasic
2022-04-26  2:50         ` Halil Pasic
2022-04-26  3:46         ` Jason Wang
2022-04-26  3:46           ` Jason Wang
     [not found]   ` <20220426053856.3325-1-hdanton@sina.com>
2022-04-26  5:59     ` Jason Wang
2022-04-25  2:44 ` [PATCH V3 7/9] virtio: allow to unbreak virtqueue Jason Wang
2022-04-25  2:44   ` Jason Wang
2022-04-25 12:44   ` Cornelia Huck
2022-04-25 12:44     ` Cornelia Huck
2022-04-25 14:04     ` Michael S. Tsirkin
2022-04-25 14:04       ` Michael S. Tsirkin
2022-04-26  3:45       ` Jason Wang
2022-04-26  3:45         ` Jason Wang
2022-04-25  2:44 ` [PATCH V3 8/9] virtio: harden vring IRQ Jason Wang
2022-04-25  2:44   ` Jason Wang
2022-04-25  2:44 ` Jason Wang [this message]
2022-04-25  2:44   ` [PATCH V3 9/9] virtio: use WARN_ON() to warning illegal status value Jason Wang
2022-04-25  2:49 ` [PATCH V3 0/9] rework on the IRQ hardening of virtio Jason Wang
2022-04-25  2:49   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220425024418.8415-10-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=eperezma@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lulu@redhat.com \
    --cc=maz@kernel.org \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.