From: Jason Wang <jasowang@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: mst <mst@redhat.com>, linux-kernel <linux-kernel@vger.kernel.org>,
virtualization <virtualization@lists.linux-foundation.org>,
Stefano Garzarella <sgarzare@redhat.com>,
eperezma <eperezma@redhat.com>, Cindy Lu <lulu@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Marc Zyngier <maz@kernel.org>, Halil Pasic <pasic@linux.ibm.com>
Subject: Re: [PATCH V3 3/9] virtio: introduce config op to synchronize vring callbacks
Date: Thu, 5 May 2022 16:15:50 +0800 [thread overview]
Message-ID: <fe3c54a2-f6eb-96a8-425e-07df6b7b7f95@redhat.com> (raw)
In-Reply-To: <87ilqsl5ba.fsf@redhat.com>
在 2022/4/29 15:25, Cornelia Huck 写道:
> On Fri, Apr 29 2022, Jason Wang <jasowang@redhat.com> wrote:
>
>> On Thu, Apr 28, 2022 at 5:13 PM Cornelia Huck <cohuck@redhat.com> wrote:
>>> On Mon, Apr 25 2022, Jason Wang <jasowang@redhat.com> wrote:
>>>
>>>> This patch introduces new virtio config op to vring
>>>> callbacks. Transport specific method is required to make sure the
>>>> write before this function is visible to the vring_interrupt() that is
>>> Which kind of writes? I.e., what is the scope?
>> Any writes before synchronize_cbs(). Is something like the following better?
>>
>> The function guarantees that all memory operations before it are
>> visible to the vring_interrupt() that is called after it.
> Maybe "all memory operations on the queue"?
That's fine. Will do.
Thanks
>
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: "Paul E. McKenney" <paulmck@kernel.org>,
Cindy Lu <lulu@redhat.com>, mst <mst@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Marc Zyngier <maz@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
virtualization <virtualization@lists.linux-foundation.org>,
Halil Pasic <pasic@linux.ibm.com>, eperezma <eperezma@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH V3 3/9] virtio: introduce config op to synchronize vring callbacks
Date: Thu, 5 May 2022 16:15:50 +0800 [thread overview]
Message-ID: <fe3c54a2-f6eb-96a8-425e-07df6b7b7f95@redhat.com> (raw)
In-Reply-To: <87ilqsl5ba.fsf@redhat.com>
在 2022/4/29 15:25, Cornelia Huck 写道:
> On Fri, Apr 29 2022, Jason Wang <jasowang@redhat.com> wrote:
>
>> On Thu, Apr 28, 2022 at 5:13 PM Cornelia Huck <cohuck@redhat.com> wrote:
>>> On Mon, Apr 25 2022, Jason Wang <jasowang@redhat.com> wrote:
>>>
>>>> This patch introduces new virtio config op to vring
>>>> callbacks. Transport specific method is required to make sure the
>>>> write before this function is visible to the vring_interrupt() that is
>>> Which kind of writes? I.e., what is the scope?
>> Any writes before synchronize_cbs(). Is something like the following better?
>>
>> The function guarantees that all memory operations before it are
>> visible to the vring_interrupt() that is called after it.
> Maybe "all memory operations on the queue"?
That's fine. Will do.
Thanks
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-05-05 8:16 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 2:44 [PATCH V3 0/9] rework on the IRQ hardening of virtio Jason Wang
2022-04-25 2:44 ` Jason Wang
2022-04-25 2:44 ` [PATCH V3 1/9] virtio: use virtio_device_ready() in virtio_device_restore() Jason Wang
2022-04-25 2:44 ` Jason Wang
2022-04-28 9:07 ` Cornelia Huck
2022-04-28 9:07 ` Cornelia Huck
2022-04-25 2:44 ` [PATCH V3 2/9] virtio: use virtio_reset_device() when possible Jason Wang
2022-04-25 2:44 ` Jason Wang
2022-04-28 9:07 ` Cornelia Huck
2022-04-28 9:07 ` Cornelia Huck
2022-04-25 2:44 ` [PATCH V3 3/9] virtio: introduce config op to synchronize vring callbacks Jason Wang
2022-04-25 2:44 ` Jason Wang
2022-04-28 9:13 ` Cornelia Huck
2022-04-28 9:13 ` Cornelia Huck
2022-04-29 2:08 ` Jason Wang
2022-04-29 2:08 ` Jason Wang
2022-04-29 7:25 ` Cornelia Huck
2022-04-29 7:25 ` Cornelia Huck
2022-05-05 8:15 ` Jason Wang [this message]
2022-05-05 8:15 ` Jason Wang
2022-04-25 2:44 ` [PATCH V3 4/9] virtio-pci: implement synchronize_cbs() Jason Wang
2022-04-25 2:44 ` Jason Wang
2022-04-25 2:44 ` [PATCH V3 5/9] virtio-mmio: " Jason Wang
2022-04-25 2:44 ` Jason Wang
2022-04-25 2:44 ` [PATCH V3 6/9] virtio-ccw: " Jason Wang
2022-04-25 2:44 ` Jason Wang
2022-04-25 8:08 ` Michael S. Tsirkin
2022-04-25 8:08 ` Michael S. Tsirkin
2022-04-25 8:54 ` Cornelia Huck
2022-04-25 8:54 ` Cornelia Huck
2022-04-25 13:59 ` Michael S. Tsirkin
2022-04-25 13:59 ` Michael S. Tsirkin
2022-04-26 2:29 ` Halil Pasic
2022-04-26 2:29 ` Halil Pasic
2022-04-26 3:35 ` Michael S. Tsirkin
2022-04-26 3:35 ` Michael S. Tsirkin
2022-04-26 3:38 ` Michael S. Tsirkin
2022-04-26 3:38 ` Michael S. Tsirkin
2022-04-26 3:42 ` Jason Wang
2022-04-26 3:42 ` Jason Wang
2022-04-26 3:53 ` Michael S. Tsirkin
2022-04-26 3:53 ` Michael S. Tsirkin
2022-04-26 3:55 ` Michael S. Tsirkin
2022-04-26 3:55 ` Michael S. Tsirkin
2022-04-26 4:07 ` Jason Wang
2022-04-26 4:07 ` Jason Wang
2022-04-26 6:30 ` Michael S. Tsirkin
2022-04-26 6:30 ` Michael S. Tsirkin
2022-04-27 3:53 ` Jason Wang
2022-04-27 3:53 ` Jason Wang
2022-04-27 6:28 ` Michael S. Tsirkin
2022-04-27 6:28 ` Michael S. Tsirkin
2022-04-27 6:30 ` Michael S. Tsirkin
2022-04-27 6:30 ` Michael S. Tsirkin
2022-04-27 7:57 ` Jason Wang
2022-04-27 7:57 ` Jason Wang
2022-04-27 15:15 ` Michael S. Tsirkin
2022-04-27 15:15 ` Michael S. Tsirkin
2022-04-26 15:47 ` Cornelia Huck
2022-04-26 15:47 ` Cornelia Huck
2022-04-26 16:43 ` Michael S. Tsirkin
2022-04-26 16:43 ` Michael S. Tsirkin
2022-04-27 9:27 ` Cornelia Huck
2022-04-27 9:27 ` Cornelia Huck
2022-04-28 2:43 ` Halil Pasic
2022-04-28 2:43 ` Halil Pasic
2022-04-28 3:04 ` Jason Wang
2022-04-28 3:04 ` Jason Wang
2022-04-28 5:24 ` Michael S. Tsirkin
2022-04-28 5:24 ` Michael S. Tsirkin
2022-04-28 5:51 ` Jason Wang
2022-04-28 5:51 ` Jason Wang
2022-04-28 5:55 ` Michael S. Tsirkin
2022-04-28 5:55 ` Michael S. Tsirkin
2022-04-28 6:02 ` Jason Wang
2022-04-28 6:02 ` Jason Wang
2022-04-28 6:17 ` Michael S. Tsirkin
2022-04-28 6:17 ` Michael S. Tsirkin
2022-04-28 7:42 ` Cornelia Huck
2022-04-28 7:42 ` Cornelia Huck
2022-04-29 2:02 ` Jason Wang
2022-04-29 2:02 ` Jason Wang
2022-04-28 4:12 ` Michael S. Tsirkin
2022-04-28 4:12 ` Michael S. Tsirkin
2022-04-26 2:50 ` Halil Pasic
2022-04-26 2:50 ` Halil Pasic
2022-04-26 3:46 ` Jason Wang
2022-04-26 3:46 ` Jason Wang
[not found] ` <20220426053856.3325-1-hdanton@sina.com>
2022-04-26 5:59 ` Jason Wang
2022-04-25 2:44 ` [PATCH V3 7/9] virtio: allow to unbreak virtqueue Jason Wang
2022-04-25 2:44 ` Jason Wang
2022-04-25 12:44 ` Cornelia Huck
2022-04-25 12:44 ` Cornelia Huck
2022-04-25 14:04 ` Michael S. Tsirkin
2022-04-25 14:04 ` Michael S. Tsirkin
2022-04-26 3:45 ` Jason Wang
2022-04-26 3:45 ` Jason Wang
2022-04-25 2:44 ` [PATCH V3 8/9] virtio: harden vring IRQ Jason Wang
2022-04-25 2:44 ` Jason Wang
2022-04-25 2:44 ` [PATCH V3 9/9] virtio: use WARN_ON() to warning illegal status value Jason Wang
2022-04-25 2:44 ` Jason Wang
2022-04-25 2:49 ` [PATCH V3 0/9] rework on the IRQ hardening of virtio Jason Wang
2022-04-25 2:49 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe3c54a2-f6eb-96a8-425e-07df6b7b7f95@redhat.com \
--to=jasowang@redhat.com \
--cc=cohuck@redhat.com \
--cc=eperezma@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=maz@kernel.org \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=sgarzare@redhat.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.