From: Jason Wang <jasowang@redhat.com> To: jasowang <jasowang@redhat.com>, mst <mst@redhat.com>, linux-kernel <linux-kernel@vger.kernel.org>, virtualization <virtualization@lists.linux-foundation.org> Cc: Stefano Garzarella <sgarzare@redhat.com>, eperezma <eperezma@redhat.com>, Cindy Lu <lulu@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, Peter Zijlstra <peterz@infradead.org>, "Paul E. McKenney" <paulmck@kernel.org>, Marc Zyngier <maz@kernel.org>, Halil Pasic <pasic@linux.ibm.com>, Cornelia Huck <cohuck@redhat.com>, Xuan Zhuo <xuanzhuo@linux.alibaba.com> Subject: Re: [PATCH V3 0/9] rework on the IRQ hardening of virtio Date: Mon, 25 Apr 2022 10:49:26 +0800 [thread overview] Message-ID: <CACGkMEu0qSb2o0HM6R2HE2g_fTbEBwPfXk7pO-QYepe3Unk5aw@mail.gmail.com> (raw) In-Reply-To: <20220425024418.8415-1-jasowang@redhat.com> On Mon, Apr 25, 2022 at 10:44 AM Jason Wang <jasowang@redhat.com> wrote: > > Hi All: > Forgot to add Xuan to the series. Thanks > This is a rework on the IRQ hardening for virtio which is done > previously by the following commits are reverted: > > 9e35276a5344 ("virtio_pci: harden MSI-X interrupts") > 080cd7c3ac87 ("virtio-pci: harden INTX interrupts") > > The reason is that it depends on the IRQF_NO_AUTOEN which may conflict > with the assumption of the affinity managed IRQ that is used by some > virtio drivers. And what's more, it is only done for virtio-pci but > not other transports. > > In this rework, I try to implement a general virtio solution which > borrows the idea of the INTX hardening by re-using per virtqueue > boolean vq->broken and toggle it in virtio_device_ready() and > virtio_reset_device(). Then we can simply reuse the existing checks in > the vring_interrupt() and return early if the driver is not ready. > > Note that, I only did compile test on ccw and MMIO transport. > > Please review. > > Changes since v1: > > - Use transport specific irq synchronization method when possible > - Drop the module parameter and enable the hardening unconditonally > - Tweak the barrier/ordering facilities used in the code > - Reanme irq_soft_enabled to driver_ready > - Avoid unnecssary IRQ synchornization (e.g during boot) > > Changes since V2: > > - add ccw and MMIO support > - rename synchronize_vqs() to synchronize_cbs() > - switch to re-use vq->broken instead of introducing new device > attributes for the future virtqueue reset support > - remove unnecssary READ_ONCE()/WRITE_ONCE() > - a new patch to remove device triggerable BUG_ON() > - more tweaks on the comments > > Jason Wang (8): > virtio: use virtio_reset_device() when possible > virtio: introduce config op to synchronize vring callbacks > virtio-pci: implement synchronize_cbs() > virtio-mmio: implement synchronize_cbs() > virtio-ccw: implement synchronize_cbs() > virtio: allow to unbreak virtqueue > virtio: harden vring IRQ > virtio: use WARN_ON() to warning illegal status value > > Stefano Garzarella (1): > virtio: use virtio_device_ready() in virtio_device_restore() > > drivers/char/virtio_console.c | 2 +- > drivers/crypto/virtio/virtio_crypto_core.c | 2 +- > drivers/s390/virtio/virtio_ccw.c | 31 ++++++++++++++++-- > drivers/virtio/virtio.c | 24 ++++++++++---- > drivers/virtio/virtio_mmio.c | 9 +++++ > drivers/virtio/virtio_pci_common.c | 2 +- > drivers/virtio/virtio_pci_common.h | 2 ++ > drivers/virtio/virtio_pci_legacy.c | 1 + > drivers/virtio/virtio_pci_modern.c | 2 ++ > drivers/virtio/virtio_ring.c | 15 +++++---- > include/linux/virtio.h | 2 +- > include/linux/virtio_config.h | 38 +++++++++++++++++++++- > 12 files changed, 110 insertions(+), 20 deletions(-) > > -- > 2.25.1 > >
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: jasowang <jasowang@redhat.com>, mst <mst@redhat.com>, linux-kernel <linux-kernel@vger.kernel.org>, virtualization <virtualization@lists.linux-foundation.org> Cc: Cindy Lu <lulu@redhat.com>, "Paul E. McKenney" <paulmck@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Marc Zyngier <maz@kernel.org>, Cornelia Huck <cohuck@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, eperezma <eperezma@redhat.com>, Thomas Gleixner <tglx@linutronix.de> Subject: Re: [PATCH V3 0/9] rework on the IRQ hardening of virtio Date: Mon, 25 Apr 2022 10:49:26 +0800 [thread overview] Message-ID: <CACGkMEu0qSb2o0HM6R2HE2g_fTbEBwPfXk7pO-QYepe3Unk5aw@mail.gmail.com> (raw) In-Reply-To: <20220425024418.8415-1-jasowang@redhat.com> On Mon, Apr 25, 2022 at 10:44 AM Jason Wang <jasowang@redhat.com> wrote: > > Hi All: > Forgot to add Xuan to the series. Thanks > This is a rework on the IRQ hardening for virtio which is done > previously by the following commits are reverted: > > 9e35276a5344 ("virtio_pci: harden MSI-X interrupts") > 080cd7c3ac87 ("virtio-pci: harden INTX interrupts") > > The reason is that it depends on the IRQF_NO_AUTOEN which may conflict > with the assumption of the affinity managed IRQ that is used by some > virtio drivers. And what's more, it is only done for virtio-pci but > not other transports. > > In this rework, I try to implement a general virtio solution which > borrows the idea of the INTX hardening by re-using per virtqueue > boolean vq->broken and toggle it in virtio_device_ready() and > virtio_reset_device(). Then we can simply reuse the existing checks in > the vring_interrupt() and return early if the driver is not ready. > > Note that, I only did compile test on ccw and MMIO transport. > > Please review. > > Changes since v1: > > - Use transport specific irq synchronization method when possible > - Drop the module parameter and enable the hardening unconditonally > - Tweak the barrier/ordering facilities used in the code > - Reanme irq_soft_enabled to driver_ready > - Avoid unnecssary IRQ synchornization (e.g during boot) > > Changes since V2: > > - add ccw and MMIO support > - rename synchronize_vqs() to synchronize_cbs() > - switch to re-use vq->broken instead of introducing new device > attributes for the future virtqueue reset support > - remove unnecssary READ_ONCE()/WRITE_ONCE() > - a new patch to remove device triggerable BUG_ON() > - more tweaks on the comments > > Jason Wang (8): > virtio: use virtio_reset_device() when possible > virtio: introduce config op to synchronize vring callbacks > virtio-pci: implement synchronize_cbs() > virtio-mmio: implement synchronize_cbs() > virtio-ccw: implement synchronize_cbs() > virtio: allow to unbreak virtqueue > virtio: harden vring IRQ > virtio: use WARN_ON() to warning illegal status value > > Stefano Garzarella (1): > virtio: use virtio_device_ready() in virtio_device_restore() > > drivers/char/virtio_console.c | 2 +- > drivers/crypto/virtio/virtio_crypto_core.c | 2 +- > drivers/s390/virtio/virtio_ccw.c | 31 ++++++++++++++++-- > drivers/virtio/virtio.c | 24 ++++++++++---- > drivers/virtio/virtio_mmio.c | 9 +++++ > drivers/virtio/virtio_pci_common.c | 2 +- > drivers/virtio/virtio_pci_common.h | 2 ++ > drivers/virtio/virtio_pci_legacy.c | 1 + > drivers/virtio/virtio_pci_modern.c | 2 ++ > drivers/virtio/virtio_ring.c | 15 +++++---- > include/linux/virtio.h | 2 +- > include/linux/virtio_config.h | 38 +++++++++++++++++++++- > 12 files changed, 110 insertions(+), 20 deletions(-) > > -- > 2.25.1 > > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-04-25 2:50 UTC|newest] Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-25 2:44 [PATCH V3 0/9] rework on the IRQ hardening of virtio Jason Wang 2022-04-25 2:44 ` Jason Wang 2022-04-25 2:44 ` [PATCH V3 1/9] virtio: use virtio_device_ready() in virtio_device_restore() Jason Wang 2022-04-25 2:44 ` Jason Wang 2022-04-28 9:07 ` Cornelia Huck 2022-04-28 9:07 ` Cornelia Huck 2022-04-25 2:44 ` [PATCH V3 2/9] virtio: use virtio_reset_device() when possible Jason Wang 2022-04-25 2:44 ` Jason Wang 2022-04-28 9:07 ` Cornelia Huck 2022-04-28 9:07 ` Cornelia Huck 2022-04-25 2:44 ` [PATCH V3 3/9] virtio: introduce config op to synchronize vring callbacks Jason Wang 2022-04-25 2:44 ` Jason Wang 2022-04-28 9:13 ` Cornelia Huck 2022-04-28 9:13 ` Cornelia Huck 2022-04-29 2:08 ` Jason Wang 2022-04-29 2:08 ` Jason Wang 2022-04-29 7:25 ` Cornelia Huck 2022-04-29 7:25 ` Cornelia Huck 2022-05-05 8:15 ` Jason Wang 2022-05-05 8:15 ` Jason Wang 2022-04-25 2:44 ` [PATCH V3 4/9] virtio-pci: implement synchronize_cbs() Jason Wang 2022-04-25 2:44 ` Jason Wang 2022-04-25 2:44 ` [PATCH V3 5/9] virtio-mmio: " Jason Wang 2022-04-25 2:44 ` Jason Wang 2022-04-25 2:44 ` [PATCH V3 6/9] virtio-ccw: " Jason Wang 2022-04-25 2:44 ` Jason Wang 2022-04-25 8:08 ` Michael S. Tsirkin 2022-04-25 8:08 ` Michael S. Tsirkin 2022-04-25 8:54 ` Cornelia Huck 2022-04-25 8:54 ` Cornelia Huck 2022-04-25 13:59 ` Michael S. Tsirkin 2022-04-25 13:59 ` Michael S. Tsirkin 2022-04-26 2:29 ` Halil Pasic 2022-04-26 2:29 ` Halil Pasic 2022-04-26 3:35 ` Michael S. Tsirkin 2022-04-26 3:35 ` Michael S. Tsirkin 2022-04-26 3:38 ` Michael S. Tsirkin 2022-04-26 3:38 ` Michael S. Tsirkin 2022-04-26 3:42 ` Jason Wang 2022-04-26 3:42 ` Jason Wang 2022-04-26 3:53 ` Michael S. Tsirkin 2022-04-26 3:53 ` Michael S. Tsirkin 2022-04-26 3:55 ` Michael S. Tsirkin 2022-04-26 3:55 ` Michael S. Tsirkin 2022-04-26 4:07 ` Jason Wang 2022-04-26 4:07 ` Jason Wang 2022-04-26 6:30 ` Michael S. Tsirkin 2022-04-26 6:30 ` Michael S. Tsirkin 2022-04-27 3:53 ` Jason Wang 2022-04-27 3:53 ` Jason Wang 2022-04-27 6:28 ` Michael S. Tsirkin 2022-04-27 6:28 ` Michael S. Tsirkin 2022-04-27 6:30 ` Michael S. Tsirkin 2022-04-27 6:30 ` Michael S. Tsirkin 2022-04-27 7:57 ` Jason Wang 2022-04-27 7:57 ` Jason Wang 2022-04-27 15:15 ` Michael S. Tsirkin 2022-04-27 15:15 ` Michael S. Tsirkin 2022-04-26 15:47 ` Cornelia Huck 2022-04-26 15:47 ` Cornelia Huck 2022-04-26 16:43 ` Michael S. Tsirkin 2022-04-26 16:43 ` Michael S. Tsirkin 2022-04-27 9:27 ` Cornelia Huck 2022-04-27 9:27 ` Cornelia Huck 2022-04-28 2:43 ` Halil Pasic 2022-04-28 2:43 ` Halil Pasic 2022-04-28 3:04 ` Jason Wang 2022-04-28 3:04 ` Jason Wang 2022-04-28 5:24 ` Michael S. Tsirkin 2022-04-28 5:24 ` Michael S. Tsirkin 2022-04-28 5:51 ` Jason Wang 2022-04-28 5:51 ` Jason Wang 2022-04-28 5:55 ` Michael S. Tsirkin 2022-04-28 5:55 ` Michael S. Tsirkin 2022-04-28 6:02 ` Jason Wang 2022-04-28 6:02 ` Jason Wang 2022-04-28 6:17 ` Michael S. Tsirkin 2022-04-28 6:17 ` Michael S. Tsirkin 2022-04-28 7:42 ` Cornelia Huck 2022-04-28 7:42 ` Cornelia Huck 2022-04-29 2:02 ` Jason Wang 2022-04-29 2:02 ` Jason Wang 2022-04-28 4:12 ` Michael S. Tsirkin 2022-04-28 4:12 ` Michael S. Tsirkin 2022-04-26 2:50 ` Halil Pasic 2022-04-26 2:50 ` Halil Pasic 2022-04-26 3:46 ` Jason Wang 2022-04-26 3:46 ` Jason Wang [not found] ` <20220426053856.3325-1-hdanton@sina.com> 2022-04-26 5:59 ` Jason Wang 2022-04-25 2:44 ` [PATCH V3 7/9] virtio: allow to unbreak virtqueue Jason Wang 2022-04-25 2:44 ` Jason Wang 2022-04-25 12:44 ` Cornelia Huck 2022-04-25 12:44 ` Cornelia Huck 2022-04-25 14:04 ` Michael S. Tsirkin 2022-04-25 14:04 ` Michael S. Tsirkin 2022-04-26 3:45 ` Jason Wang 2022-04-26 3:45 ` Jason Wang 2022-04-25 2:44 ` [PATCH V3 8/9] virtio: harden vring IRQ Jason Wang 2022-04-25 2:44 ` Jason Wang 2022-04-25 2:44 ` [PATCH V3 9/9] virtio: use WARN_ON() to warning illegal status value Jason Wang 2022-04-25 2:44 ` Jason Wang 2022-04-25 2:49 ` Jason Wang [this message] 2022-04-25 2:49 ` [PATCH V3 0/9] rework on the IRQ hardening of virtio Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACGkMEu0qSb2o0HM6R2HE2g_fTbEBwPfXk7pO-QYepe3Unk5aw@mail.gmail.com \ --to=jasowang@redhat.com \ --cc=cohuck@redhat.com \ --cc=eperezma@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lulu@redhat.com \ --cc=maz@kernel.org \ --cc=mst@redhat.com \ --cc=pasic@linux.ibm.com \ --cc=paulmck@kernel.org \ --cc=peterz@infradead.org \ --cc=sgarzare@redhat.com \ --cc=tglx@linutronix.de \ --cc=virtualization@lists.linux-foundation.org \ --cc=xuanzhuo@linux.alibaba.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.