From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com> To: linux-serial@vger.kernel.org, "Greg KH" <gregkh@linuxfoundation.org>, "Jiri Slaby" <jirislaby@kernel.org>, "Manivannan Sadhasivam" <mani@kernel.org>, "Olof Johansson" <olof@lixom.net>, "Andreas Färber" <afaerber@suse.de>, "Arnd Bergmann" <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org, linux-unisoc@lists.infradead.org, linux-kernel@vger.kernel.org Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com> Subject: [PATCH 3/9] serial: rda-uart: Don't allow CS5-6 Date: Tue, 17 May 2022 14:07:31 +0300 [thread overview] Message-ID: <20220517110737.37148-4-ilpo.jarvinen@linux.intel.com> (raw) In-Reply-To: <20220517110737.37148-1-ilpo.jarvinen@linux.intel.com> Only CS7 and CS8 are supported but CSIZE is not sanitized after fallthrough from CS5 or CS6 to CS7. Set CSIZE correctly so that userspace knows the effective value. Incorrect CSIZE also results in miscalculation of the frame bits in tty_get_char_size() or in its predecessor where the roughly the same code is directly within uart_update_timeout(). Cc: Manivannan Sadhasivam <mani@kernel.org> Fixes: c10b13325ced (tty: serial: Add RDA8810PL UART driver) Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> --- drivers/tty/serial/rda-uart.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/rda-uart.c b/drivers/tty/serial/rda-uart.c index e5f1fded423a..f556b4955f59 100644 --- a/drivers/tty/serial/rda-uart.c +++ b/drivers/tty/serial/rda-uart.c @@ -262,6 +262,8 @@ static void rda_uart_set_termios(struct uart_port *port, fallthrough; case CS7: ctrl &= ~RDA_UART_DBITS_8; + termios->c_cflag &= ~CSIZE; + termios->c_cflag |= CS7; break; default: ctrl |= RDA_UART_DBITS_8; -- 2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com> To: linux-serial@vger.kernel.org, "Greg KH" <gregkh@linuxfoundation.org>, "Jiri Slaby" <jirislaby@kernel.org>, "Manivannan Sadhasivam" <mani@kernel.org>, "Olof Johansson" <olof@lixom.net>, "Andreas Färber" <afaerber@suse.de>, "Arnd Bergmann" <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org, linux-unisoc@lists.infradead.org, linux-kernel@vger.kernel.org Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com> Subject: [PATCH 3/9] serial: rda-uart: Don't allow CS5-6 Date: Tue, 17 May 2022 14:07:31 +0300 [thread overview] Message-ID: <20220517110737.37148-4-ilpo.jarvinen@linux.intel.com> (raw) In-Reply-To: <20220517110737.37148-1-ilpo.jarvinen@linux.intel.com> Only CS7 and CS8 are supported but CSIZE is not sanitized after fallthrough from CS5 or CS6 to CS7. Set CSIZE correctly so that userspace knows the effective value. Incorrect CSIZE also results in miscalculation of the frame bits in tty_get_char_size() or in its predecessor where the roughly the same code is directly within uart_update_timeout(). Cc: Manivannan Sadhasivam <mani@kernel.org> Fixes: c10b13325ced (tty: serial: Add RDA8810PL UART driver) Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> --- drivers/tty/serial/rda-uart.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/rda-uart.c b/drivers/tty/serial/rda-uart.c index e5f1fded423a..f556b4955f59 100644 --- a/drivers/tty/serial/rda-uart.c +++ b/drivers/tty/serial/rda-uart.c @@ -262,6 +262,8 @@ static void rda_uart_set_termios(struct uart_port *port, fallthrough; case CS7: ctrl &= ~RDA_UART_DBITS_8; + termios->c_cflag &= ~CSIZE; + termios->c_cflag |= CS7; break; default: ctrl |= RDA_UART_DBITS_8; -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-17 11:08 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-17 11:07 [PATCH 0/9] tty/serial: Termios flag fixes Ilpo Järvinen 2022-05-17 11:07 ` Ilpo Järvinen 2022-05-17 11:07 ` [PATCH 1/9] serial: uartline: Fix BRKINT clearing Ilpo Järvinen 2022-05-17 14:33 ` Sean Anderson 2022-05-18 12:18 ` Shubhrajyoti Datta 2022-05-18 12:25 ` Ilpo Järvinen 2022-05-17 11:07 ` [PATCH 2/9] serial: digicolor-usart: Don't allow CS5-6 Ilpo Järvinen 2022-05-17 11:07 ` Ilpo Järvinen 2022-05-18 4:16 ` Baruch Siach 2022-05-18 4:16 ` Baruch Siach 2022-05-17 11:07 ` Ilpo Järvinen [this message] 2022-05-17 11:07 ` [PATCH 3/9] serial: rda-uart: " Ilpo Järvinen 2022-05-17 11:07 ` [PATCH 4/9] serial: txx9: " Ilpo Järvinen 2022-05-17 11:07 ` [PATCH 5/9] serial: sh-sci: " Ilpo Järvinen 2022-05-17 11:07 ` [PATCH 6/9] serial: sifive: Sanitize CSIZE and c_iflag Ilpo Järvinen 2022-05-17 11:07 ` Ilpo Järvinen 2022-05-17 11:07 ` [PATCH 7/9] serial: st-asc: Sanitize CSIZE and correct PARENB for CS7 Ilpo Järvinen 2022-05-17 11:07 ` Ilpo Järvinen 2022-05-17 11:07 ` [PATCH 8/9] serial: stm32-usart: Correct CSIZE, bits, and parity Ilpo Järvinen 2022-05-17 11:07 ` Ilpo Järvinen 2022-05-17 11:07 ` [PATCH 9/9] pcmcia: synclink_cs: Don't allow CS5-6 Ilpo Järvinen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220517110737.37148-4-ilpo.jarvinen@linux.intel.com \ --to=ilpo.jarvinen@linux.intel.com \ --cc=afaerber@suse.de \ --cc=arnd@arndb.de \ --cc=gregkh@linuxfoundation.org \ --cc=jirislaby@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=linux-unisoc@lists.infradead.org \ --cc=mani@kernel.org \ --cc=olof@lixom.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.